Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92032/?format=api
{ "id": 92032, "url": "http://patches.dpdk.org/api/patches/92032/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210422144030.16746-2-david.hunt@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210422144030.16746-2-david.hunt@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210422144030.16746-2-david.hunt@intel.com", "date": "2021-04-22T14:40:28", "name": "[v1,2/4] test/power: add turbo mode to freq check function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "01cf27cef4114a2ea238c5a9410f3976d8e6aafb", "submitter": { "id": 342, "url": "http://patches.dpdk.org/api/people/342/?format=api", "name": "Hunt, David", "email": "david.hunt@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210422144030.16746-2-david.hunt@intel.com/mbox/", "series": [ { "id": 16610, "url": "http://patches.dpdk.org/api/series/16610/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16610", "date": "2021-04-22T14:40:27", "name": "[v1,1/4] test/power: fix check for cpu frequency", "version": 1, "mbox": "http://patches.dpdk.org/series/16610/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92032/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92032/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D03ADA0548;\n\tThu, 22 Apr 2021 16:40:56 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0A52841DA1;\n\tThu, 22 Apr 2021 16:40:44 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id BA89041D95;\n Thu, 22 Apr 2021 16:40:40 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2021 07:40:36 -0700", "from silpixa00399952.ir.intel.com (HELO\n silpixa00399952.ger.corp.intel.com) ([10.237.222.38])\n by FMSMGA003.fm.intel.com with ESMTP; 22 Apr 2021 07:40:35 -0700" ], "IronPort-SDR": [ "\n i98DdvLhazpalhyDrHRHj2LAQOkOBNNhwGZhfX0N4KZ0FZF3tw2vGa20wRekdepeSinW9mbubg\n H/3a2LHzT3uw==", "\n xL4WC5lJGQifxSY7nUJUZz+eeC/uPoxdAFPgADUazlgTGBrW+4gvozKvYlMlYrPLkBUra5uosz\n Ak1TGjhE5YKA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9962\"; a=\"192709703\"", "E=Sophos;i=\"5.82,242,1613462400\"; d=\"scan'208\";a=\"192709703\"", "E=Sophos;i=\"5.82,242,1613462400\"; d=\"scan'208\";a=\"453273992\"" ], "X-ExtLoop1": "1", "From": "David Hunt <david.hunt@intel.com>", "To": "dev@dpdk.org", "Cc": "david.hunt@intel.com,\n\tstable@dpdk.org", "Date": "Thu, 22 Apr 2021 15:40:28 +0100", "Message-Id": "<20210422144030.16746-2-david.hunt@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210422144030.16746-1-david.hunt@intel.com>", "References": "<20210422144030.16746-1-david.hunt@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 2/4] test/power: add turbo mode to freq check\n function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "With the intel_pstate driver and turbo enabled, the top frequency in\nthe frequency array is the P1+1, i.e. 2300001, whereas the frequency\nshown in scaling_cur_freq could be a lot higher.\n\nThis patch adds a flag to the check_cur_freq function so that we can\nspecify if a frequency is greater than expected (turbo mode), in which\ncase the check should be successful.\n\nFixes: aeaeaf5f2d62 (\"test/power: add cases for turbo feature\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Hunt <david.hunt@intel.com>\n---\n app/test/test_power_cpufreq.c | 27 +++++++++++++++------------\n 1 file changed, 15 insertions(+), 12 deletions(-)", "diff": "diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c\nindex 52f58ef8b2..33a68cf645 100644\n--- a/app/test/test_power_cpufreq.c\n+++ b/app/test/test_power_cpufreq.c\n@@ -48,7 +48,7 @@ static uint32_t total_freq_num;\n static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX];\n \n static int\n-check_cur_freq(unsigned lcore_id, uint32_t idx)\n+check_cur_freq(unsigned int lcore_id, uint32_t idx, int turbo)\n {\n #define TEST_POWER_CONVERT_TO_DECIMAL 10\n #define MAX_LOOP 100\n@@ -90,7 +90,10 @@ check_cur_freq(unsigned lcore_id, uint32_t idx)\n \t\t\t\t\t/ TEST_ROUND_FREQ_TO_N_100000;\n \t\tfreq_conv = freq_conv * TEST_ROUND_FREQ_TO_N_100000;\n \n-\t\tret = (freqs[idx] == freq_conv ? 0 : -1);\n+\t\tif (turbo)\n+\t\t\tret = (freqs[idx] <= freq_conv ? 0 : -1);\n+\t\telse\n+\t\t\tret = (freqs[idx] == freq_conv ? 0 : -1);\n \n \t\tif (ret == 0)\n \t\t\tbreak;\n@@ -183,7 +186,7 @@ check_power_get_freq(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, count);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, count, 0);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -233,7 +236,7 @@ check_power_set_freq(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1, 0);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -269,7 +272,7 @@ check_power_freq_down(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1, 0);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -288,7 +291,7 @@ check_power_freq_down(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, 1);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, 1, 0);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -324,7 +327,7 @@ check_power_freq_up(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 2);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 2, 0);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -343,7 +346,7 @@ check_power_freq_up(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, 0);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, 0, 1);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -371,7 +374,7 @@ check_power_freq_max(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, 0);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, 0, 1);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -399,7 +402,7 @@ check_power_freq_min(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1, 0);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -433,7 +436,7 @@ check_power_turbo(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, 0);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, 0, 1);\n \tif (ret < 0)\n \t\treturn -1;\n \n@@ -452,7 +455,7 @@ check_power_turbo(void)\n \t}\n \n \t/* Check the current frequency */\n-\tret = check_cur_freq(TEST_POWER_LCORE_ID, 1);\n+\tret = check_cur_freq(TEST_POWER_LCORE_ID, 1, 0);\n \tif (ret < 0)\n \t\treturn -1;\n \n", "prefixes": [ "v1", "2/4" ] }