Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91708/?format=api
{ "id": 91708, "url": "http://patches.dpdk.org/api/patches/91708/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1618653299-40380-4-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618653299-40380-4-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618653299-40380-4-git-send-email-humin29@huawei.com", "date": "2021-04-17T09:54:55", "name": "[3/7] net/hns3: remove redundant code about mbx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7d44301f7afd2c70803ca91bc3b30e7159533d0a", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1618653299-40380-4-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16463, "url": "http://patches.dpdk.org/api/series/16463/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16463", "date": "2021-04-17T09:54:52", "name": "features and bugfix for hns3 PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/16463/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91708/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91708/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1F0FDA0562;\n\tSat, 17 Apr 2021 11:55:11 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F1A33161EE1;\n\tSat, 17 Apr 2021 11:54:55 +0200 (CEST)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id 0FEF6161D1B\n for <dev@dpdk.org>; Sat, 17 Apr 2021 11:54:50 +0200 (CEST)", "from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FMpK902Xdz17R8N\n for <dev@dpdk.org>; Sat, 17 Apr 2021 17:52:29 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id\n 14.3.498.0; Sat, 17 Apr 2021 17:54:45 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Sat, 17 Apr 2021 17:54:55 +0800", "Message-ID": "<1618653299-40380-4-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618653299-40380-1-git-send-email-humin29@huawei.com>", "References": "<1618653299-40380-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 3/7] net/hns3: remove redundant code about mbx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nSome mbx messages do not need to reply with data. In this case,\nit is no need to set the response data address and the response\nlength.\n\nThis patch removes these redundant codes from mbx messages that do\nnot need be replied.\n\nFixes: a5475d61fa34 (\"net/hns3: support VF\")\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev_vf.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 5770c47..58809fb 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -1511,7 +1511,6 @@ static void\n hns3vf_request_link_info(struct hns3_hw *hw)\n {\n \tstruct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw);\n-\tuint8_t resp_msg;\n \tbool send_req;\n \tint ret;\n \n@@ -1524,7 +1523,7 @@ hns3vf_request_link_info(struct hns3_hw *hw)\n \t\treturn;\n \n \tret = hns3_send_mbx_msg(hw, HNS3_MBX_GET_LINK_STATUS, 0, NULL, 0, false,\n-\t\t\t\t&resp_msg, sizeof(resp_msg));\n+\t\t\t\tNULL, 0);\n \tif (ret) {\n \t\thns3_err(hw, \"failed to fetch link status, ret = %d\", ret);\n \t\treturn;\n@@ -1756,11 +1755,10 @@ hns3vf_keep_alive_handler(void *param)\n \tstruct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param;\n \tstruct hns3_adapter *hns = eth_dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tuint8_t respmsg;\n \tint ret;\n \n \tret = hns3_send_mbx_msg(hw, HNS3_MBX_KEEP_ALIVE, 0, NULL, 0,\n-\t\t\t\tfalse, &respmsg, sizeof(uint8_t));\n+\t\t\t\tfalse, NULL, 0);\n \tif (ret)\n \t\thns3_err(hw, \"VF sends keeping alive cmd failed(=%d)\",\n \t\t\t ret);\n", "prefixes": [ "3/7" ] }