Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91648/?format=api
{ "id": 91648, "url": "http://patches.dpdk.org/api/patches/91648/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210416170458.50188-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210416170458.50188-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210416170458.50188-6-bruce.richardson@intel.com", "date": "2021-04-16T17:04:49", "name": "[05/14] build: reduce indentation in app build spec", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a30e58dd033575f7c5bc1c15fa7d5dbb27d183b0", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210416170458.50188-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 16449, "url": "http://patches.dpdk.org/api/series/16449/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16449", "date": "2021-04-16T17:04:44", "name": "Build file updates", "version": 1, "mbox": "http://patches.dpdk.org/series/16449/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91648/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91648/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7FA8A0C41;\n\tFri, 16 Apr 2021 19:05:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 95115161A3B;\n\tFri, 16 Apr 2021 19:05:23 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 71C241619E9\n for <dev@dpdk.org>; Fri, 16 Apr 2021 19:05:11 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2021 10:05:11 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.116])\n by orsmga006.jf.intel.com with ESMTP; 16 Apr 2021 10:05:10 -0700" ], "IronPort-SDR": [ "\n PI7U8CWDBcevPvjQkBirqTarjyFOOpTTiLLTxe9kJbVHtldVENU/jPTlxpxZ6mZjju1MdxzzXa\n P6sM6EJTbJPA==", "\n FDBbFIQ86stZfpL6es7rpuqbQybhGUNLjYTwDX6PIWY4VlbsbDm/Bd+3B9Eg5Lx1GmLJCogHwB\n 0zx0hjSjxtkA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9956\"; a=\"280388225\"", "E=Sophos;i=\"5.82,226,1613462400\"; d=\"scan'208\";a=\"280388225\"", "E=Sophos;i=\"5.82,226,1613462400\"; d=\"scan'208\";a=\"384375813\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 16 Apr 2021 18:04:49 +0100", "Message-Id": "<20210416170458.50188-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210416170458.50188-1-bruce.richardson@intel.com>", "References": "<20210401115009.1063844-1-bruce.richardson@intel.com>\n <20210416170458.50188-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 05/14] build: reduce indentation in app build spec", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As with the lib and drivers directories, we can use \"continue\" keyword to\nreduce the indentation level of the majority of the foreach block. At the\nsame time, we can also replace tab indentation with spaces.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/meson.build | 101 ++++++++++++++++++++++++------------------------\n 1 file changed, 51 insertions(+), 50 deletions(-)", "diff": "diff --git a/app/meson.build b/app/meson.build\nindex 50a53dbde..35e53861b 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -2,71 +2,72 @@\n # Copyright(c) 2017-2019 Intel Corporation\n \n if is_windows\n-\tsubdir_done()\n+ subdir_done()\n endif\n \n apps = [\n-\t'pdump',\n-\t'proc-info',\n-\t'test-acl',\n-\t'test-bbdev',\n-\t'test-cmdline',\n-\t'test-compress-perf',\n-\t'test-crypto-perf',\n-\t'test-eventdev',\n-\t'test-fib',\n-\t'test-flow-perf',\n-\t'test-pipeline',\n-\t'test-pmd',\n-\t'test-regex',\n-\t'test-sad']\n+ 'pdump',\n+ 'proc-info',\n+ 'test-acl',\n+ 'test-bbdev',\n+ 'test-cmdline',\n+ 'test-compress-perf',\n+ 'test-crypto-perf',\n+ 'test-eventdev',\n+ 'test-fib',\n+ 'test-flow-perf',\n+ 'test-pipeline',\n+ 'test-pmd',\n+ 'test-regex',\n+ 'test-sad',\n+]\n \n default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']\n default_ldflags = []\n if get_option('default_library') == 'static' and not is_windows\n-\tdefault_ldflags += ['-Wl,--export-dynamic']\n+ default_ldflags += ['-Wl,--export-dynamic']\n endif\n \n foreach app:apps\n-\tbuild = true\n-\tname = app\n-\tsources = []\n-\tincludes = []\n-\tcflags = default_cflags\n-\tldflags = default_ldflags\n-\tobjs = [] # other object files to link against, used e.g. for\n-\t # instruction-set optimized versions of code\n+ build = true\n+ name = app\n+ sources = []\n+ includes = []\n+ cflags = default_cflags\n+ ldflags = default_ldflags\n+ objs = [] # other object files to link against, used e.g. for\n+ # instruction-set optimized versions of code\n \n-\t# use \"deps\" for internal DPDK dependencies, and \"ext_deps\" for\n-\t# external package/library requirements\n-\text_deps = []\n-\tdeps = []\n+ # use \"deps\" for internal DPDK dependencies, and \"ext_deps\" for\n+ # external package/library requirements\n+ ext_deps = []\n+ deps = []\n \n-\tsubdir(name)\n+ subdir(name)\n \n-\tif build\n-\t\tdep_objs = []\n-\t\tforeach d:deps\n-\t\t\tdep_objs += get_variable(get_option('default_library')\n-\t\t\t\t + '_rte_' + d)\n-\t\tendforeach\n+ if not build\n+ continue\n+ endif\n \n-\t\tlink_libs = []\n-\t\tif get_option('default_library') == 'static'\n-\t\t\tlink_libs = dpdk_static_libraries + dpdk_drivers\n-\t\tendif\n+ dep_objs = []\n+ foreach d:deps\n+ dep_objs += get_variable(get_option('default_library') + '_rte_' + d)\n+ endforeach\n \n-\t\texecutable('dpdk-' + name,\n-\t\t\t\tsources,\n-\t\t\t\tc_args: cflags,\n-\t\t\t\tlink_args: ldflags,\n-\t\t\t\tlink_whole: link_libs,\n-\t\t\t\tdependencies: dep_objs,\n-\t\t\t\tinclude_directories: includes,\n-\t\t\t\tinstall_rpath: join_paths(get_option('prefix'),\n-\t\t\t\t\t\t driver_install_path),\n-\t\t\t\tinstall: true)\n-\tendif\n+ link_libs = []\n+ if get_option('default_library') == 'static'\n+ link_libs = dpdk_static_libraries + dpdk_drivers\n+ endif\n+\n+ executable('dpdk-' + name,\n+ sources,\n+ c_args: cflags,\n+ link_args: ldflags,\n+ link_whole: link_libs,\n+ dependencies: dep_objs,\n+ include_directories: includes,\n+ install_rpath: join_paths(get_option('prefix'), driver_install_path),\n+ install: true)\n endforeach\n \n # special case the autotests\n", "prefixes": [ "05/14" ] }