Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91647/?format=api
{ "id": 91647, "url": "http://patches.dpdk.org/api/patches/91647/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210416170458.50188-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210416170458.50188-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210416170458.50188-5-bruce.richardson@intel.com", "date": "2021-04-16T17:04:48", "name": "[04/14] build: clean up driver lists", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b912d6b16da94072f734b921951196015f3497e4", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210416170458.50188-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 16449, "url": "http://patches.dpdk.org/api/series/16449/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16449", "date": "2021-04-16T17:04:44", "name": "Build file updates", "version": 1, "mbox": "http://patches.dpdk.org/series/16449/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91647/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91647/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B6C7A0C41;\n\tFri, 16 Apr 2021 19:05:39 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7C2B0161A36;\n\tFri, 16 Apr 2021 19:05:22 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 7ADA21619E9\n for <dev@dpdk.org>; Fri, 16 Apr 2021 19:05:10 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2021 10:05:10 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.116])\n by orsmga006.jf.intel.com with ESMTP; 16 Apr 2021 10:05:08 -0700" ], "IronPort-SDR": [ "\n pGRYmCUcmxAZpjxyGmNNhPkkOenubtig/qdbta/ICbVvwuseyZ+OO2Bwa2YrZ8tJpOxzUnxDX8\n 3Yc/q0TvmHxg==", "\n 0UCHA+cKryu6Gs/5W6Kiy8rH2udFBmdn3b2d1v0ibOiusg6/iyCRWSyzMQRsFmP7S3PF/ONgzB\n M6T+qzi3NMPw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9956\"; a=\"280388221\"", "E=Sophos;i=\"5.82,226,1613462400\"; d=\"scan'208\";a=\"280388221\"", "E=Sophos;i=\"5.82,226,1613462400\"; d=\"scan'208\";a=\"384375804\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 16 Apr 2021 18:04:48 +0100", "Message-Id": "<20210416170458.50188-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210416170458.50188-1-bruce.richardson@intel.com>", "References": "<20210401115009.1063844-1-bruce.richardson@intel.com>\n <20210416170458.50188-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 04/14] build: clean up driver lists", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Ensure all lists of drivers are standardized:\n* one driver per line\n* lists double-indented with spaces (as they are line continuations)\n* elements in alphabetical order\n* opening and closing list brackets \"[\" & \"]\" on own lines\n* last element has trailing comma\n\nAny code snippets in the list files is adjusted to single-indent using\nwhitespace to correspond to the new style also.\n\nThe lists of standard library dependencies per class, and other short\nlists are not formatted one-per-line as these lists are not expected to\ngrow beyond 2 or 3 entries.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/baseband/meson.build | 10 +++-\n drivers/bus/meson.build | 9 ++-\n drivers/common/meson.build | 9 ++-\n drivers/compress/meson.build | 9 ++-\n drivers/crypto/meson.build | 42 +++++++-------\n drivers/event/meson.build | 18 ++++--\n drivers/mempool/meson.build | 12 +++-\n drivers/meson.build | 38 ++++++------\n drivers/net/meson.build | 108 ++++++++++++++++++-----------------\n drivers/raw/meson.build | 17 ++++--\n drivers/regex/meson.build | 5 +-\n drivers/vdpa/meson.build | 8 ++-\n 12 files changed, 171 insertions(+), 114 deletions(-)", "diff": "diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build\nindex 920e3b02e..c98ebd902 100644\n--- a/drivers/baseband/meson.build\n+++ b/drivers/baseband/meson.build\n@@ -2,7 +2,13 @@\n # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>\n \n if is_windows\n-\tsubdir_done()\n+ subdir_done()\n endif\n \n-drivers = ['null', 'turbo_sw', 'fpga_lte_fec', 'fpga_5gnr_fec', 'acc100']\n+drivers = [\n+ 'acc100',\n+ 'fpga_5gnr_fec',\n+ 'fpga_lte_fec',\n+ 'null',\n+ 'turbo_sw',\n+]\ndiff --git a/drivers/bus/meson.build b/drivers/bus/meson.build\nindex 2e7727af0..c770c6ba1 100644\n--- a/drivers/bus/meson.build\n+++ b/drivers/bus/meson.build\n@@ -1,5 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-drivers = ['dpaa', 'fslmc', 'ifpga', 'pci', 'vdev', 'vmbus']\n+drivers = [\n+ 'dpaa',\n+ 'fslmc',\n+ 'ifpga',\n+ 'pci',\n+ 'vdev',\n+ 'vmbus',\n+]\n std_deps = ['eal']\ndiff --git a/drivers/common/meson.build b/drivers/common/meson.build\nindex 9fdfc2451..4acbad60b 100644\n--- a/drivers/common/meson.build\n+++ b/drivers/common/meson.build\n@@ -2,4 +2,11 @@\n # Copyright(c) 2018 Cavium, Inc\n \n std_deps = ['eal']\n-drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2']\n+drivers = [\n+ 'cpt',\n+ 'dpaax',\n+ 'iavf',\n+ 'mvep',\n+ 'octeontx',\n+ 'octeontx2',\n+]\ndiff --git a/drivers/compress/meson.build b/drivers/compress/meson.build\nindex 49fa02d4c..abe043ab9 100644\n--- a/drivers/compress/meson.build\n+++ b/drivers/compress/meson.build\n@@ -2,9 +2,14 @@\n # Copyright(c) 2018 Intel Corporation\n \n if is_windows\n-\tsubdir_done()\n+ subdir_done()\n endif\n \n-drivers = ['isal', 'mlx5', 'octeontx', 'zlib']\n+drivers = [\n+ 'isal',\n+ 'mlx5',\n+ 'octeontx',\n+ 'zlib',\n+]\n \n std_deps = ['compressdev'] # compressdev pulls in all other needed deps\ndiff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build\nindex c927c5f8d..b9fdf9392 100644\n--- a/drivers/crypto/meson.build\n+++ b/drivers/crypto/meson.build\n@@ -2,27 +2,29 @@\n # Copyright(c) 2017 Intel Corporation\n \n if is_windows\n-\tsubdir_done()\n+ subdir_done()\n endif\n \n-drivers = ['aesni_gcm',\n-\t 'aesni_mb',\n-\t 'armv8',\n-\t 'bcmfs',\n-\t 'caam_jr',\n-\t 'ccp',\n-\t 'dpaa_sec',\n-\t 'dpaa2_sec',\n-\t 'kasumi',\n-\t 'mvsam',\n-\t 'nitrox',\n-\t 'null',\n-\t 'octeontx',\n-\t 'octeontx2',\n-\t 'openssl',\n-\t 'scheduler',\n-\t 'snow3g',\n-\t 'virtio',\n-\t 'zuc']\n+drivers = [\n+ 'aesni_gcm',\n+ 'aesni_mb',\n+ 'armv8',\n+ 'bcmfs',\n+ 'caam_jr',\n+ 'ccp',\n+ 'dpaa_sec',\n+ 'dpaa2_sec',\n+ 'kasumi',\n+ 'mvsam',\n+ 'nitrox',\n+ 'null',\n+ 'octeontx',\n+ 'octeontx2',\n+ 'openssl',\n+ 'scheduler',\n+ 'snow3g',\n+ 'virtio',\n+ 'zuc',\n+]\n \n std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps\ndiff --git a/drivers/event/meson.build b/drivers/event/meson.build\nindex b7f9bf7c6..539c5aeb9 100644\n--- a/drivers/event/meson.build\n+++ b/drivers/event/meson.build\n@@ -2,13 +2,21 @@\n # Copyright(c) 2017 Intel Corporation\n \n if is_windows\n-\tsubdir_done()\n+ subdir_done()\n endif\n \n-drivers = ['dlb2', 'dpaa', 'dpaa2', 'octeontx2', 'opdl', 'skeleton', 'sw',\n-\t 'dsw']\n+drivers = [\n+ 'dlb2',\n+ 'dpaa',\n+ 'dpaa2',\n+ 'dsw',\n+ 'octeontx2',\n+ 'opdl',\n+ 'skeleton',\n+ 'sw',\n+]\n if not (toolchain == 'gcc' and cc.version().version_compare('<4.8.6') and\n-\tdpdk_conf.has('RTE_ARCH_ARM64'))\n-\tdrivers += 'octeontx'\n+ dpdk_conf.has('RTE_ARCH_ARM64'))\n+ drivers += 'octeontx'\n endif\n std_deps = ['eventdev', 'kvargs']\ndiff --git a/drivers/mempool/meson.build b/drivers/mempool/meson.build\nindex a2814c1df..caaffc380 100644\n--- a/drivers/mempool/meson.build\n+++ b/drivers/mempool/meson.build\n@@ -1,6 +1,14 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-drivers = ['bucket', 'cnxk', 'dpaa', 'dpaa2', 'octeontx', 'octeontx2', 'ring',\n-\t 'stack']\n+drivers = [\n+ 'bucket',\n+ 'cnxk',\n+ 'dpaa',\n+ 'dpaa2',\n+ 'octeontx',\n+ 'octeontx2',\n+ 'ring',\n+ 'stack',\n+]\n std_deps = ['mempool']\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex f90330b5a..b78cac389 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -3,26 +3,26 @@\n \n # Defines the order of dependencies evaluation\n subdirs = [\n-\t'common',\n-\t'bus',\n-\t'common/cnxk', # depends on bus.\n-\t'common/mlx5', # depends on bus.\n-\t'common/qat', # depends on bus.\n-\t'common/sfc_efx', # depends on bus.\n-\t'mempool', # depends on common and bus.\n-\t'net', # depends on common, bus, mempool\n-\t'raw', # depends on common, bus and net.\n-\t'crypto', # depends on common, bus and mempool (net in future).\n-\t'compress', # depends on common, bus, mempool.\n-\t'regex', # depends on common, bus, regexdev.\n-\t'vdpa', # depends on common, bus and mempool.\n-\t'event', # depends on common, bus, mempool and net.\n-\t'baseband', # depends on common and bus.\n+ 'common',\n+ 'bus',\n+ 'common/cnxk', # depends on bus.\n+ 'common/mlx5', # depends on bus.\n+ 'common/qat', # depends on bus.\n+ 'common/sfc_efx', # depends on bus.\n+ 'mempool', # depends on common and bus.\n+ 'net', # depends on common, bus, mempool\n+ 'raw', # depends on common, bus and net.\n+ 'crypto', # depends on common, bus and mempool (net in future).\n+ 'compress', # depends on common, bus, mempool.\n+ 'regex', # depends on common, bus, regexdev.\n+ 'vdpa', # depends on common, bus and mempool.\n+ 'event', # depends on common, bus, mempool and net.\n+ 'baseband', # depends on common and bus.\n ]\n \n if meson.is_cross_build()\n-\tdisable_drivers += ',' + meson.get_cross_property('disable_drivers', '')\n-\tenable_drivers += ',' + meson.get_cross_property('enable_drivers', '')\n+ disable_drivers += ',' + meson.get_cross_property('disable_drivers', '')\n+ enable_drivers += ',' + meson.get_cross_property('enable_drivers', '')\n endif\n \n # add cmdline disabled drivers and meson disabled drivers together\n@@ -33,7 +33,7 @@ disable_drivers = run_command(list_dir_globs, disable_drivers).stdout().split()\n enable_drivers = ',' + get_option('enable_drivers')\n enable_drivers = run_command(list_dir_globs, enable_drivers).stdout().split()\n if enable_drivers.length() == 0\n-\tenable_drivers = run_command(list_dir_globs, '*/*').stdout().split()\n+ enable_drivers = run_command(list_dir_globs, '*/*').stdout().split()\n endif\n \n # these drivers must always be enabled, otherwise the build breaks\n@@ -45,7 +45,7 @@ default_cflags += ['-DALLOW_EXPERIMENTAL_API']\n default_cflags += ['-DALLOW_INTERNAL_API']\n \n if cc.has_argument('-Wno-format-truncation')\n-\tdefault_cflags += '-Wno-format-truncation'\n+ default_cflags += '-Wno-format-truncation'\n endif\n \n foreach subpath:subdirs\ndiff --git a/drivers/net/meson.build b/drivers/net/meson.build\nindex fb9ff05a1..c8b5ce298 100644\n--- a/drivers/net/meson.build\n+++ b/drivers/net/meson.build\n@@ -2,58 +2,62 @@\n # Copyright(c) 2017 Intel Corporation\n \n \n-drivers = ['af_packet',\n-\t'af_xdp',\n-\t'ark',\n-\t'atlantic',\n-\t'avp',\n-\t'axgbe', 'bonding',\n-\t'bnx2x',\n-\t'bnxt',\n-\t'cxgbe',\n-\t'dpaa', 'dpaa2',\n-\t'e1000',\n-\t'ena',\n-\t'enetc',\n-\t'enic',\n-\t'failsafe',\n-\t'fm10k', 'i40e',\n-\t'hinic',\n-\t'hns3',\n-\t'iavf',\n-\t'ice',\n-\t'igc',\n-\t'ionic',\n-\t'ipn3ke',\n-\t'ixgbe',\n-\t'kni',\n-\t'liquidio',\n-\t'memif',\n-\t'mlx4',\n-\t'mlx5',\n-\t'mvneta',\n-\t'mvpp2',\n-\t'netvsc',\n-\t'nfb',\n-\t'nfp',\n-\t'null',\n-\t'octeontx',\n-\t'octeontx2',\n-\t'octeontx_ep',\n-\t'pcap',\n-\t'pfe',\n-\t'qede',\n-\t'ring',\n-\t'sfc',\n-\t'softnic',\n-\t'szedata2',\n-\t'tap',\n-\t'thunderx',\n-\t'txgbe',\n-\t'vdev_netvsc',\n-\t'vhost',\n-\t'virtio',\n-\t'vmxnet3',\n+drivers = [\n+ 'af_packet',\n+ 'af_xdp',\n+ 'ark',\n+ 'atlantic',\n+ 'avp',\n+ 'axgbe',\n+ 'bnx2x',\n+ 'bnxt',\n+ 'bonding',\n+ 'cxgbe',\n+ 'dpaa',\n+ 'dpaa2',\n+ 'e1000',\n+ 'ena',\n+ 'enetc',\n+ 'enic',\n+ 'failsafe',\n+ 'fm10k',\n+ 'hinic',\n+ 'hns3',\n+ 'i40e',\n+ 'iavf',\n+ 'ice',\n+ 'igc',\n+ 'ionic',\n+ 'ipn3ke',\n+ 'ixgbe',\n+ 'kni',\n+ 'liquidio',\n+ 'memif',\n+ 'mlx4',\n+ 'mlx5',\n+ 'mvneta',\n+ 'mvpp2',\n+ 'netvsc',\n+ 'nfb',\n+ 'nfp',\n+ 'null',\n+ 'octeontx',\n+ 'octeontx2',\n+ 'octeontx_ep',\n+ 'pcap',\n+ 'pfe',\n+ 'qede',\n+ 'ring',\n+ 'sfc',\n+ 'softnic',\n+ 'szedata2',\n+ 'tap',\n+ 'thunderx',\n+ 'txgbe',\n+ 'vdev_netvsc',\n+ 'vhost',\n+ 'virtio',\n+ 'vmxnet3',\n ]\n std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc\n std_deps += ['bus_pci'] # very many PMDs depend on PCI, so make std\ndiff --git a/drivers/raw/meson.build b/drivers/raw/meson.build\nindex 8c3a036df..c33a7c5f3 100644\n--- a/drivers/raw/meson.build\n+++ b/drivers/raw/meson.build\n@@ -2,12 +2,17 @@\n # Copyright 2018 NXP\n \n if is_windows\n-\tsubdir_done()\n+ subdir_done()\n endif\n \n-drivers = ['dpaa2_cmdif', 'dpaa2_qdma',\n-\t'ifpga', 'ioat', 'ntb',\n-\t'octeontx2_dma',\n-\t'octeontx2_ep',\n-\t'skeleton']\n+drivers = [\n+ 'dpaa2_cmdif',\n+ 'dpaa2_qdma',\n+ 'ifpga',\n+ 'ioat',\n+ 'ntb',\n+ 'octeontx2_dma',\n+ 'octeontx2_ep',\n+ 'skeleton',\n+]\n std_deps = ['rawdev']\ndiff --git a/drivers/regex/meson.build b/drivers/regex/meson.build\nindex 2d05d5af1..94222e55f 100644\n--- a/drivers/regex/meson.build\n+++ b/drivers/regex/meson.build\n@@ -1,5 +1,8 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright 2020 Mellanox Technologies, Ltd\n \n-drivers = ['mlx5', 'octeontx2']\n+drivers = [\n+ 'mlx5',\n+ 'octeontx2',\n+]\n std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc\ndiff --git a/drivers/vdpa/meson.build b/drivers/vdpa/meson.build\nindex 4929be4c0..f765fe398 100644\n--- a/drivers/vdpa/meson.build\n+++ b/drivers/vdpa/meson.build\n@@ -2,10 +2,12 @@\n # Copyright 2019 Mellanox Technologies, Ltd\n \n if is_windows\n-\tsubdir_done()\n+ subdir_done()\n endif\n \n-drivers = ['ifc',\n-\t 'mlx5',]\n+drivers = [\n+ 'ifc',\n+ 'mlx5',\n+]\n std_deps = ['bus_pci', 'kvargs']\n std_deps += ['vhost']\n", "prefixes": [ "04/14" ] }