Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91467/?format=api
{ "id": 91467, "url": "http://patches.dpdk.org/api/patches/91467/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210414174338.657891-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210414174338.657891-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210414174338.657891-1-thomas@monjalon.net", "date": "2021-04-14T17:43:37", "name": "eal: remove useless bus API includes", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b4ac4db06157454f97e0bdc360f15596cb628650", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210414174338.657891-1-thomas@monjalon.net/mbox/", "series": [ { "id": 16376, "url": "http://patches.dpdk.org/api/series/16376/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16376", "date": "2021-04-14T17:43:37", "name": "eal: remove useless bus API includes", "version": 1, "mbox": "http://patches.dpdk.org/series/16376/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91467/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/91467/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6B89A0562;\n\tWed, 14 Apr 2021 19:45:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8FD7B161BFB;\n\tWed, 14 Apr 2021 19:45:16 +0200 (CEST)", "from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com\n [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 6DFFF4013F\n for <dev@dpdk.org>; Wed, 14 Apr 2021 19:45:15 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailnew.nyi.internal (Postfix) with ESMTP id B4F68580819;\n Wed, 14 Apr 2021 13:45:14 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute7.internal (MEProxy); Wed, 14 Apr 2021 13:45:14 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id E276924005A;\n Wed, 14 Apr 2021 13:45:10 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding; s=fm3; bh=jQRCmkOLjTOz9/IeNhGHnqNOt4\n Vt1R74nJA+IlQNivE=; b=YkfPUrprQ2lH4JNPHrz5h7oYJHUGOsslT5WtOw61K7\n VzGA6fpwtrDmLt9xcoLdl3QvzQd/N9J9zPExYixVg80Tpf3DUdORTeDd1fy9IinT\n +z5AnknxpFDNYtTUnA/sJSrgunGEpbfPHjj6/Sz+22IGVPjmt9N/R4R4c2Exh2mx\n luZOrmnwNbF9XpU0WLEquqaGAec/hdMa1c9Ldv/WO/9sXJ/imaVX63odxNJ4BYhi\n xKZdJq3QdyXBAgWzmUMnkOAs5gnvm4yfyrdtBQgiN5CWLfxRrFGw7jDxRDtS5SER\n RrO+TLSwjKSZi4GriICqbAVk6UNsZrOap+aeSH6bXQRw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=jQRCmkOLjTOz9/IeN\n hGHnqNOt4Vt1R74nJA+IlQNivE=; b=PIy8vfks/QjbbCB9EAfgWoTP1cC7ltRYg\n QrN5WRqgr0ygMvLY84eLpfzT7Y8pzg4MXvo2tmt+GqvjT72EO9rv0TIA7rWwXJ5x\n EEK+4zKPgCQScw1YdrCt8/JwzVMxlaLV5zYS17jk6UALEtob8M3zhkm+9T58GRd0\n yQZbloTt6kXprojqZ5B8/g+8R6ehJZLPgO2PuALU410r6mR8QLtFvJePo/IFc91e\n SxVx38y9zIAUguX1o2b7KMyf+xabdMjsF4rei4KE8ac1dFACr0pS0bXpT57dkrcp\n KRr0gof4XVMKQcraYSF84oa8qJNOAgtuS0oyYj9UjZ1pFwjjQ4PoQ==" ], "X-ME-Sender": "<xms:KCp3YGZbljVKT-9BZ_5SAkswtELU5Ep4JNtN3a56EtUBqRb1uMsoSw>\n <xme:KCp3YD-cFAuELVOw0lx0TtDbITVVoBl6Zh54XchRxbLrRWmN_T8Lq07t2CQYhrQfT\n 5w63qlClhrV5rkqNQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrudeluddguddujecutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh\n necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd\n enucfjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedvledvudehvdduudevuedvveehgeduleegiefgjeehudehtddtgedu\n ffejiefhgfenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho\n nhdrnhgvth", "X-ME-Proxy": "<xmx:KCp3YNguW8Ee6LpD9w0lfv2QWYOT2gZGHaOlaT6O82vHm4nbjwYUuA>\n <xmx:KCp3YLc3Smwrb-lwoAzn6t3l-zJsgZPY1uVr3IIF52RFL3YgGHM1iA>\n <xmx:KCp3YMpw8iYJTDcojZ1Lzul12UgKppB5oTx5AccatPieeiJ3cgjkKg>\n <xmx:Kip3YFrETwA4jGRJG1D9DbAeqxzZFtiN5IHfxu3zPfW9QvhjLyxo2w>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@oss.nxp.com>, Rosen Xu <rosen.xu@intel.com>,\n Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>,\n Jay Zhou <jianjay.zhou@huawei.com>, Gaetan Rivet <grive@u256.net>,\n Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>,\n Tianfei zhang <tianfei.zhang@intel.com>,\n Radha Mohan Chintakuntla <radhac@marvell.com>,\n Veerasenareddy Burru <vburru@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>", "Date": "Wed, 14 Apr 2021 19:43:37 +0200", "Message-Id": "<20210414174338.657891-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] eal: remove useless bus API includes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The file rte_bus.h was included in too many files.\n\nThe enum rte_iova_mode is moved from rte_bus.h to rte_eal.h\nbecause it is not specific to the bus layer.\nIt allows to clean-up more includes of rte_bus.h.\n\nSome indirect includes had to be added in few files to compensate.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/test-compress-perf/comp_perf_options.h | 2 ++\n drivers/bus/dpaa/dpaa_bus.c | 1 -\n drivers/bus/fslmc/fslmc_bus.c | 1 -\n drivers/bus/fslmc/fslmc_vfio.c | 1 -\n drivers/bus/ifpga/ifpga_common.c | 1 -\n drivers/bus/ifpga/rte_bus_ifpga.h | 1 -\n drivers/bus/pci/linux/pci.c | 1 -\n drivers/bus/pci/pci_common.c | 1 -\n drivers/bus/vdev/vdev_params.c | 1 -\n drivers/bus/vmbus/linux/vmbus_uio.c | 1 -\n drivers/bus/vmbus/rte_bus_vmbus.h | 1 +\n drivers/bus/vmbus/vmbus_bufring.c | 1 -\n drivers/bus/vmbus/vmbus_channel.c | 1 -\n drivers/bus/vmbus/vmbus_common.c | 1 -\n drivers/bus/vmbus/vmbus_common_uio.c | 1 -\n drivers/crypto/virtio/virtio_pci.c | 1 -\n drivers/net/failsafe/failsafe.c | 1 +\n drivers/net/failsafe/failsafe_eal.c | 1 +\n drivers/net/mlx4/mlx4_ethdev.c | 1 +\n drivers/raw/ifpga/ifpga_rawdev.c | 1 -\n drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 1 -\n drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 1 -\n drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 1 -\n examples/multi_process/hotplug_mp/commands.c | 1 +\n lib/librte_bbdev/rte_bbdev.h | 1 -\n lib/librte_eal/common/hotplug_mp.c | 1 +\n lib/librte_eal/common/hotplug_mp.h | 1 -\n lib/librte_eal/include/rte_bus.h | 14 --------------\n lib/librte_eal/include/rte_devargs.h | 3 ++-\n lib/librte_eal/include/rte_eal.h | 15 ++++++++++++++-\n lib/librte_eal/include/rte_lcore.h | 4 ++++\n lib/librte_ethdev/rte_ethdev.c | 1 +\n lib/librte_pci/rte_pci.c | 1 -\n lib/librte_vhost/vhost_user.c | 1 +\n 34 files changed, 30 insertions(+), 37 deletions(-)", "diff": "diff --git a/app/test-compress-perf/comp_perf_options.h b/app/test-compress-perf/comp_perf_options.h\nindex 0b777521c5..57dd146330 100644\n--- a/app/test-compress-perf/comp_perf_options.h\n+++ b/app/test-compress-perf/comp_perf_options.h\n@@ -5,6 +5,8 @@\n #ifndef _COMP_PERF_OPS_\n #define _COMP_PERF_OPS_\n \n+#include <rte_dev.h>\n+\n #define MAX_LIST\t\t32\n #define MIN_COMPRESSED_BUF_SIZE 8\n #define EXPANSE_RATIO 1.1\ndiff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex 173041c026..98ff68c97c 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -30,7 +30,6 @@\n #include <ethdev_driver.h>\n #include <rte_malloc.h>\n #include <rte_ring.h>\n-#include <rte_bus.h>\n #include <rte_mbuf_pool_ops.h>\n #include <rte_mbuf_dyn.h>\n \ndiff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex 26910ac01f..05967512c8 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -9,7 +9,6 @@\n #include <stdbool.h>\n \n #include <rte_log.h>\n-#include <rte_bus.h>\n #include <rte_malloc.h>\n #include <rte_devargs.h>\n #include <rte_memcpy.h>\ndiff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c\nindex c8373e627a..9fc0e01115 100644\n--- a/drivers/bus/fslmc/fslmc_vfio.c\n+++ b/drivers/bus/fslmc/fslmc_vfio.c\n@@ -29,7 +29,6 @@\n #include <rte_cycles.h>\n #include <rte_kvargs.h>\n #include <rte_dev.h>\n-#include <rte_bus.h>\n #include <rte_eal_memconfig.h>\n \n #include \"rte_fslmc.h\"\ndiff --git a/drivers/bus/ifpga/ifpga_common.c b/drivers/bus/ifpga/ifpga_common.c\nindex 78e2eaee4e..223660d6ff 100644\n--- a/drivers/bus/ifpga/ifpga_common.c\n+++ b/drivers/bus/ifpga/ifpga_common.c\n@@ -14,7 +14,6 @@\n #include <fcntl.h>\n \n #include <rte_errno.h>\n-#include <rte_bus.h>\n #include <rte_per_lcore.h>\n #include <rte_memory.h>\n #include <rte_memzone.h>\ndiff --git a/drivers/bus/ifpga/rte_bus_ifpga.h b/drivers/bus/ifpga/rte_bus_ifpga.h\nindex b43084155a..bb9432a54e 100644\n--- a/drivers/bus/ifpga/rte_bus_ifpga.h\n+++ b/drivers/bus/ifpga/rte_bus_ifpga.h\n@@ -15,7 +15,6 @@\n extern \"C\" {\n #endif /* __cplusplus */\n \n-#include <rte_bus.h>\n #include <rte_pci.h>\n #include <rte_interrupts.h>\n #include <rte_spinlock.h>\ndiff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex 0dc99e9cb2..ff4ca1aa41 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -6,7 +6,6 @@\n #include <dirent.h>\n \n #include <rte_log.h>\n-#include <rte_bus.h>\n #include <rte_pci.h>\n #include <rte_bus_pci.h>\n #include <rte_malloc.h>\ndiff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 30630809bb..74f58c8037 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -13,7 +13,6 @@\n #include <rte_errno.h>\n #include <rte_interrupts.h>\n #include <rte_log.h>\n-#include <rte_bus.h>\n #include <rte_pci.h>\n #include <rte_bus_pci.h>\n #include <rte_per_lcore.h>\ndiff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c\nindex 6f74704d1c..02a6b534bb 100644\n--- a/drivers/bus/vdev/vdev_params.c\n+++ b/drivers/bus/vdev/vdev_params.c\n@@ -5,7 +5,6 @@\n #include <string.h>\n \n #include <rte_dev.h>\n-#include <rte_bus.h>\n #include <rte_kvargs.h>\n #include <rte_errno.h>\n \ndiff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c\nindex b52ca5bf1d..8ce4207374 100644\n--- a/drivers/bus/vmbus/linux/vmbus_uio.c\n+++ b/drivers/bus/vmbus/linux/vmbus_uio.c\n@@ -12,7 +12,6 @@\n #include <sys/mman.h>\n \n #include <rte_log.h>\n-#include <rte_bus.h>\n #include <rte_memory.h>\n #include <rte_common.h>\n #include <rte_malloc.h>\ndiff --git a/drivers/bus/vmbus/rte_bus_vmbus.h b/drivers/bus/vmbus/rte_bus_vmbus.h\nindex 4cf73ce815..00fa357ff6 100644\n--- a/drivers/bus/vmbus/rte_bus_vmbus.h\n+++ b/drivers/bus/vmbus/rte_bus_vmbus.h\n@@ -28,6 +28,7 @@ extern \"C\" {\n #include <rte_uuid.h>\n #include <rte_debug.h>\n #include <rte_interrupts.h>\n+#include <rte_bus.h>\n #include <rte_dev.h>\n #include <rte_vmbus_reg.h>\n \ndiff --git a/drivers/bus/vmbus/vmbus_bufring.c b/drivers/bus/vmbus/vmbus_bufring.c\nindex c4aa07b307..c78619dc44 100644\n--- a/drivers/bus/vmbus/vmbus_bufring.c\n+++ b/drivers/bus/vmbus/vmbus_bufring.c\n@@ -15,7 +15,6 @@\n #include <rte_tailq.h>\n #include <rte_log.h>\n #include <rte_malloc.h>\n-#include <rte_bus.h>\n #include <rte_atomic.h>\n #include <rte_memory.h>\n #include <rte_pause.h>\ndiff --git a/drivers/bus/vmbus/vmbus_channel.c b/drivers/bus/vmbus/vmbus_channel.c\nindex f67f1c438a..508cd955a9 100644\n--- a/drivers/bus/vmbus/vmbus_channel.c\n+++ b/drivers/bus/vmbus/vmbus_channel.c\n@@ -12,7 +12,6 @@\n #include <rte_tailq.h>\n #include <rte_log.h>\n #include <rte_malloc.h>\n-#include <rte_bus.h>\n #include <rte_atomic.h>\n #include <rte_memory.h>\n #include <rte_bus_vmbus.h>\ndiff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c\nindex 39b3308577..1b3be86700 100644\n--- a/drivers/bus/vmbus/vmbus_common.c\n+++ b/drivers/bus/vmbus/vmbus_common.c\n@@ -11,7 +11,6 @@\n #include <sys/mman.h>\n \n #include <rte_log.h>\n-#include <rte_bus.h>\n #include <rte_eal.h>\n #include <rte_tailq.h>\n #include <rte_devargs.h>\ndiff --git a/drivers/bus/vmbus/vmbus_common_uio.c b/drivers/bus/vmbus/vmbus_common_uio.c\nindex 8582e32c1d..d283f286dc 100644\n--- a/drivers/bus/vmbus/vmbus_common_uio.c\n+++ b/drivers/bus/vmbus/vmbus_common_uio.c\n@@ -13,7 +13,6 @@\n #include <rte_tailq.h>\n #include <rte_log.h>\n #include <rte_malloc.h>\n-#include <rte_bus.h>\n #include <rte_bus_vmbus.h>\n \n #include \"private.h\"\ndiff --git a/drivers/crypto/virtio/virtio_pci.c b/drivers/crypto/virtio/virtio_pci.c\nindex ae069794a6..95a43c8801 100644\n--- a/drivers/crypto/virtio/virtio_pci.c\n+++ b/drivers/crypto/virtio/virtio_pci.c\n@@ -10,7 +10,6 @@\n #endif\n \n #include <rte_io.h>\n-#include <rte_bus.h>\n \n #include \"virtio_pci.h\"\n #include \"virtqueue.h\"\ndiff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex e3bda0df2b..57ed41c1b7 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -11,6 +11,7 @@\n #include <ethdev_vdev.h>\n #include <rte_devargs.h>\n #include <rte_kvargs.h>\n+#include <rte_bus.h>\n #include <rte_bus_vdev.h>\n \n #include \"failsafe_private.h\"\ndiff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c\nindex cb4a2abc02..05662f037e 100644\n--- a/drivers/net/failsafe/failsafe_eal.c\n+++ b/drivers/net/failsafe/failsafe_eal.c\n@@ -5,6 +5,7 @@\n \n #include <rte_string_fns.h>\n #include <rte_malloc.h>\n+#include <rte_bus.h>\n \n #include \"failsafe_private.h\"\n \ndiff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c\nindex 783ff94dce..7fd7a91a00 100644\n--- a/drivers/net/mlx4/mlx4_ethdev.c\n+++ b/drivers/net/mlx4/mlx4_ethdev.c\n@@ -32,6 +32,7 @@\n #pragma GCC diagnostic error \"-Wpedantic\"\n #endif\n \n+#include <rte_eal.h>\n #include <rte_bus_pci.h>\n #include <rte_errno.h>\n #include <ethdev_driver.h>\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex d9a46ef915..1b5f57a356 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -11,7 +11,6 @@\n #include <sys/ioctl.h>\n #include <sys/epoll.h>\n #include <rte_log.h>\n-#include <rte_bus.h>\n #include <rte_malloc.h>\n #include <rte_devargs.h>\n #include <rte_memcpy.h>\ndiff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c\nindex efdba2779b..21d98e0d62 100644\n--- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c\n+++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c\n@@ -5,7 +5,6 @@\n #include <string.h>\n #include <unistd.h>\n \n-#include <rte_bus.h>\n #include <rte_bus_pci.h>\n #include <rte_common.h>\n #include <rte_eal.h>\ndiff --git a/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c b/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c\nindex d04e957d82..415c6ab7a8 100644\n--- a/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c\n+++ b/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c\n@@ -7,7 +7,6 @@\n #include <dirent.h>\n #include <fcntl.h>\n \n-#include <rte_bus.h>\n #include <rte_bus_pci.h>\n #include <rte_eal.h>\n #include <rte_lcore.h>\ndiff --git a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\nindex b2ccdda83e..4d0e84907f 100644\n--- a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\n+++ b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\n@@ -4,7 +4,6 @@\n #include <string.h>\n #include <unistd.h>\n \n-#include <rte_bus.h>\n #include <rte_bus_pci.h>\n #include <rte_eal.h>\n #include <rte_lcore.h>\ndiff --git a/examples/multi_process/hotplug_mp/commands.c b/examples/multi_process/hotplug_mp/commands.c\nindex 48fd329583..0e60ac39da 100644\n--- a/examples/multi_process/hotplug_mp/commands.c\n+++ b/examples/multi_process/hotplug_mp/commands.c\n@@ -8,6 +8,7 @@\n #include <cmdline_parse_num.h>\n #include <cmdline_parse_string.h>\n #include <cmdline.h>\n+#include <rte_bus.h>\n #include <rte_ethdev.h>\n \n /**********************************************************/\ndiff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h\nindex 7017124414..7e5d8d2249 100644\n--- a/lib/librte_bbdev/rte_bbdev.h\n+++ b/lib/librte_bbdev/rte_bbdev.h\n@@ -33,7 +33,6 @@ extern \"C\" {\n #include <string.h>\n \n #include <rte_compat.h>\n-#include <rte_bus.h>\n #include <rte_cpuflags.h>\n #include <rte_memory.h>\n \ndiff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/common/hotplug_mp.c\nindex ae6010e8f8..f8fbf358ff 100644\n--- a/lib/librte_eal/common/hotplug_mp.c\n+++ b/lib/librte_eal/common/hotplug_mp.c\n@@ -8,6 +8,7 @@\n #include <rte_alarm.h>\n #include <rte_string_fns.h>\n #include <rte_devargs.h>\n+#include <rte_bus.h>\n \n #include \"hotplug_mp.h\"\n #include \"eal_private.h\"\ndiff --git a/lib/librte_eal/common/hotplug_mp.h b/lib/librte_eal/common/hotplug_mp.h\nindex 8fcf9b52e2..066494ff27 100644\n--- a/lib/librte_eal/common/hotplug_mp.h\n+++ b/lib/librte_eal/common/hotplug_mp.h\n@@ -6,7 +6,6 @@\n #define _HOTPLUG_MP_H_\n \n #include \"rte_dev.h\"\n-#include \"rte_bus.h\"\n \n #define EAL_DEV_MP_ACTION_REQUEST \"eal_dev_mp_request\"\n #define EAL_DEV_MP_ACTION_RESPONSE \"eal_dev_mp_response\"\ndiff --git a/lib/librte_eal/include/rte_bus.h b/lib/librte_eal/include/rte_bus.h\nindex ebacc7adc3..f59a025955 100644\n--- a/lib/librte_eal/include/rte_bus.h\n+++ b/lib/librte_eal/include/rte_bus.h\n@@ -28,20 +28,6 @@ extern \"C\" {\n TAILQ_HEAD(rte_bus_list, rte_bus);\n \n \n-/**\n- * IOVA mapping mode.\n- *\n- * IOVA mapping mode is iommu programming mode of a device.\n- * That device (for example: IOMMU backed DMA device) based\n- * on rte_iova_mode will generate physical or virtual address.\n- *\n- */\n-enum rte_iova_mode {\n-\tRTE_IOVA_DC = 0,\t/* Don't care mode */\n-\tRTE_IOVA_PA = (1 << 0), /* DMA using physical address */\n-\tRTE_IOVA_VA = (1 << 1) /* DMA using virtual address */\n-};\n-\n /**\n * Bus specific scan for devices attached on the bus.\n * For each bus object, the scan would be responsible for finding devices and\ndiff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h\nindex 134b44a887..be850607bc 100644\n--- a/lib/librte_eal/include/rte_devargs.h\n+++ b/lib/librte_eal/include/rte_devargs.h\n@@ -22,8 +22,9 @@ extern \"C\" {\n \n #include <stdio.h>\n #include <sys/queue.h>\n+\n #include <rte_compat.h>\n-#include <rte_bus.h>\n+#include <rte_dev.h>\n \n /**\n * Type of generic device\ndiff --git a/lib/librte_eal/include/rte_eal.h b/lib/librte_eal/include/rte_eal.h\nindex eaf6469e50..530eb74391 100644\n--- a/lib/librte_eal/include/rte_eal.h\n+++ b/lib/librte_eal/include/rte_eal.h\n@@ -18,7 +18,6 @@\n #include <rte_config.h>\n #include <rte_compat.h>\n #include <rte_per_lcore.h>\n-#include <rte_bus.h>\n #include <rte_uuid.h>\n \n #include <rte_pci_dev_feature_defs.h>\n@@ -32,6 +31,20 @@ extern \"C\" {\n /* Maximum thread_name length. */\n #define RTE_MAX_THREAD_NAME_LEN 16\n \n+/**\n+ * IOVA mapping mode.\n+ *\n+ * IOVA mapping mode is IOMMU programming mode of a device.\n+ * That device (for example: IOMMU backed DMA device) based\n+ * on rte_iova_mode will generate physical or virtual address.\n+ *\n+ */\n+enum rte_iova_mode {\n+\tRTE_IOVA_DC = 0, /* Don't care mode */\n+\tRTE_IOVA_PA = (1 << 0), /* DMA using physical address */\n+\tRTE_IOVA_VA = (1 << 1) /* DMA using virtual address */\n+};\n+\n /**\n * The type of process in a linux, multi-process setup\n */\ndiff --git a/lib/librte_eal/include/rte_lcore.h b/lib/librte_eal/include/rte_lcore.h\nindex 1550b75da0..edf3ebd338 100644\n--- a/lib/librte_eal/include/rte_lcore.h\n+++ b/lib/librte_eal/include/rte_lcore.h\n@@ -11,7 +11,11 @@\n * API for lcore and socket manipulation\n *\n */\n+\n+#include <stdio.h>\n+\n #include <rte_config.h>\n+#include <rte_common.h>\n #include <rte_per_lcore.h>\n #include <rte_eal.h>\n #include <rte_launch.h>\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 0419500fc3..b3448527f0 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -35,6 +35,7 @@\n #include <rte_spinlock.h>\n #include <rte_string_fns.h>\n #include <rte_kvargs.h>\n+#include <rte_bus.h>\n #include <rte_class.h>\n #include <rte_ether.h>\n #include <rte_telemetry.h>\ndiff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c\nindex c91be8b167..a304c12fae 100644\n--- a/lib/librte_pci/rte_pci.c\n+++ b/lib/librte_pci/rte_pci.c\n@@ -13,7 +13,6 @@\n #include <rte_errno.h>\n #include <rte_interrupts.h>\n #include <rte_log.h>\n-#include <rte_bus.h>\n #include <rte_eal_paging.h>\n #include <rte_per_lcore.h>\n #include <rte_memory.h>\ndiff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex cdd46a0116..f14c070e60 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -44,6 +44,7 @@\n \n #include <rte_common.h>\n #include <rte_malloc.h>\n+#include <rte_dev.h>\n #include <rte_log.h>\n \n #include \"iotlb.h\"\n", "prefixes": [] }