Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91262/?format=api
{ "id": 91262, "url": "http://patches.dpdk.org/api/patches/91262/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210413143038.2621294-2-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210413143038.2621294-2-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210413143038.2621294-2-qi.z.zhang@intel.com", "date": "2021-04-13T14:30:25", "name": "[v3,01/14] net/ice/base: code cleanup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3c3aac74c2c70217c90ae4c9b1b8d53a49e6b0af", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210413143038.2621294-2-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 16337, "url": "http://patches.dpdk.org/api/series/16337/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16337", "date": "2021-04-13T14:30:24", "name": "ice: base code update batch 2", "version": 3, "mbox": "http://patches.dpdk.org/series/16337/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91262/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91262/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 46425A0524;\n\tTue, 13 Apr 2021 16:27:03 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A070F161040;\n\tTue, 13 Apr 2021 16:26:59 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 2169216102C\n for <dev@dpdk.org>; Tue, 13 Apr 2021 16:26:56 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2021 07:26:56 -0700", "from dpdk51.sh.intel.com ([10.67.111.142])\n by fmsmga008.fm.intel.com with ESMTP; 13 Apr 2021 07:26:55 -0700" ], "IronPort-SDR": [ "\n GK9gTAT9B629Ncd0CADwpoNcF0ISjzNCfnZLLyNf6zF2dRbT+i6K9p/v9O0Ms9LgQ+CNd5YtD3\n 372h2EEgDtUw==", "\n d1ms7hRhJIgXKKo4yaI5ijg/Ixw8BpdDzxLSONx7/ULNd7kyMXbXW4LCNmSPdzQgLGDzOwUAeF\n EJj2cbq1CkYw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9953\"; a=\"214904185\"", "E=Sophos;i=\"5.82,219,1613462400\"; d=\"scan'208\";a=\"214904185\"", "E=Sophos;i=\"5.82,219,1613462400\"; d=\"scan'208\";a=\"417875103\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "dev@dpdk.org, ferruh.yigit@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n Dave Ertman <david.m.ertman@intel.com>", "Date": "Tue, 13 Apr 2021 22:30:25 +0800", "Message-Id": "<20210413143038.2621294-2-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210413143038.2621294-1-qi.z.zhang@intel.com>", "References": "<20210329141411.2395069-1-qi.z.zhang@intel.com>\n <20210413143038.2621294-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 01/14] net/ice/base: code cleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1. There are a lots of function header mismatch its function name.\n2. remove unnecessary header file include.\n3. remove unnecessary macro.\n4. remove unnecessary comment.\n\nSigned-off-by: Dave Ertman <david.m.ertman@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 4 ++--\n drivers/net/ice/base/ice_dcb.c | 2 +-\n drivers/net/ice/base/ice_fdir.c | 2 +-\n drivers/net/ice/base/ice_flex_pipe.c | 1 -\n drivers/net/ice/base/ice_sched.c | 11 +++++------\n drivers/net/ice/base/ice_switch.c | 15 +++++++--------\n drivers/net/ice/base/ice_type.h | 2 --\n drivers/net/ice/base/ice_vlan_mode.c | 3 +--\n drivers/net/ice/base/ice_vlan_mode.h | 1 -\n 9 files changed, 17 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 1546309da1..65018690c2 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -638,7 +638,7 @@ ice_cleanup_fltr_mgmt_single(struct ice_hw *hw, struct ice_switch_info *sw)\n }\n \n /**\n- * ice_cleanup_all_fltr_mgmt - cleanup filter management list and locks\n+ * ice_cleanup_fltr_mgmt_struct - cleanup filter management list and locks\n * @hw: pointer to the HW struct\n */\n void ice_cleanup_fltr_mgmt_struct(struct ice_hw *hw)\n@@ -4903,7 +4903,7 @@ ice_aq_set_lldp_mib(struct ice_hw *hw, u8 mib_type, void *buf, u16 buf_size,\n }\n \n /**\n- * ice_fw_supports_lldp_fltr - check NVM version supports lldp_fltr_ctrl\n+ * ice_fw_supports_lldp_fltr_ctrl - check NVM version supports lldp_fltr_ctrl\n * @hw: pointer to HW struct\n */\n bool ice_fw_supports_lldp_fltr_ctrl(struct ice_hw *hw)\ndiff --git a/drivers/net/ice/base/ice_dcb.c b/drivers/net/ice/base/ice_dcb.c\nindex 7a85e56abf..d5e2cb6e5d 100644\n--- a/drivers/net/ice/base/ice_dcb.c\n+++ b/drivers/net/ice/base/ice_dcb.c\n@@ -857,7 +857,7 @@ ice_cee_to_dcb_cfg(struct ice_aqc_get_cee_dcb_cfg_resp *cee_cfg,\n }\n \n /**\n- * ice_get_ieee_dcb_cfg\n+ * ice_get_ieee_or_cee_dcb_cfg\n * @pi: port information structure\n * @dcbx_mode: mode of DCBX (IEEE or CEE)\n *\ndiff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c\nindex 2b39c13127..8f9c0d346b 100644\n--- a/drivers/net/ice/base/ice_fdir.c\n+++ b/drivers/net/ice/base/ice_fdir.c\n@@ -1845,7 +1845,7 @@ bool ice_fdir_has_frag(enum ice_fltr_ptype flow)\n }\n \n /**\n- * ice_fdir_find_by_idx - find filter with idx\n+ * ice_fdir_find_fltr_by_idx - find filter with idx\n * @hw: pointer to hardware structure\n * @fltr_idx: index to find.\n *\ndiff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex f429bfb0d1..90264240c4 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -357,7 +357,6 @@ ice_marker_ptype_tcam_handler(u32 sect_type, void *section, u32 index,\n \tif (sect_type != ICE_SID_RXPARSER_MARKER_PTYPE)\n \t\treturn NULL;\n \n-\t/* cppcheck-suppress nullPointer */\n \tif (index > ICE_MAX_MARKER_PTYPE_TCAMS_IN_BUF)\n \t\treturn NULL;\n \ndiff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c\nindex 38d1f2cc54..be3f56cdf6 100644\n--- a/drivers/net/ice/base/ice_sched.c\n+++ b/drivers/net/ice/base/ice_sched.c\n@@ -1984,7 +1984,7 @@ ice_sched_cfg_vsi(struct ice_port_info *pi, u16 vsi_handle, u8 tc, u16 maxqs,\n }\n \n /**\n- * ice_sched_rm_agg_vsi_entry - remove aggregator related VSI info entry\n+ * ice_sched_rm_agg_vsi_info - remove aggregator related VSI info entry\n * @pi: port information structure\n * @vsi_handle: software VSI handle\n *\n@@ -3360,7 +3360,7 @@ ice_cfg_vsi_bw_lmt_per_tc(struct ice_port_info *pi, u16 vsi_handle, u8 tc,\n }\n \n /**\n- * ice_cfg_dflt_vsi_bw_lmt_per_tc - configure default VSI BW limit per TC\n+ * ice_cfg_vsi_bw_dflt_lmt_per_tc - configure default VSI BW limit per TC\n * @pi: port information structure\n * @vsi_handle: software VSI handle\n * @tc: traffic class\n@@ -3515,7 +3515,7 @@ ice_cfg_agg_bw_no_shared_lmt(struct ice_port_info *pi, u32 agg_id)\n }\n \n /**\n- * ice_cfg_agg_bw_shared_lmt_per_tc - configure aggregator BW shared limit per tc\n+ * ice_cfg_agg_bw_shared_lmt_per_tc - config aggregator BW shared limit per tc\n * @pi: port information structure\n * @agg_id: aggregator ID\n * @tc: traffic class\n@@ -3535,7 +3535,7 @@ ice_cfg_agg_bw_shared_lmt_per_tc(struct ice_port_info *pi, u32 agg_id, u8 tc,\n }\n \n /**\n- * ice_cfg_agg_bw_shared_lmt_per_tc - configure aggregator BW shared limit per tc\n+ * ice_cfg_agg_bw_no_shared_lmt_per_tc - cfg aggregator BW shared limit per tc\n * @pi: port information structure\n * @agg_id: aggregator ID\n * @tc: traffic class\n@@ -3553,7 +3553,7 @@ ice_cfg_agg_bw_no_shared_lmt_per_tc(struct ice_port_info *pi, u32 agg_id, u8 tc)\n }\n \n /**\n- * ice_config_vsi_queue_priority - config VSI queue priority of node\n+ * ice_cfg_vsi_q_priority - config VSI queue priority of node\n * @pi: port information structure\n * @num_qs: number of VSI queues\n * @q_ids: queue IDs array\n@@ -3649,7 +3649,6 @@ ice_cfg_agg_vsi_priority_per_tc(struct ice_port_info *pi, u32 agg_id,\n \t\tLIST_FOR_EACH_ENTRY(agg_vsi_info, &agg_info->agg_vsi_list,\n \t\t\t\t ice_sched_agg_vsi_info, list_entry)\n \t\t\tif (agg_vsi_info->vsi_handle == vsi_handle) {\n-\t\t\t\t/* cppcheck-suppress unreadVariable */\n \t\t\t\tvsi_handle_valid = true;\n \t\t\t\tbreak;\n \t\t\t}\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 9233c5fd2a..afc51d864d 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -2298,7 +2298,7 @@ enum ice_status ice_alloc_rss_global_lut(struct ice_hw *hw, bool shared_res, u16\n }\n \n /**\n- * ice_free_global_lut - free a RSS global LUT\n+ * ice_free_rss_global_lut - free a RSS global LUT\n * @hw: pointer to the HW struct\n * @global_lut_id: ID of the RSS global LUT to free\n */\n@@ -3174,7 +3174,6 @@ ice_aq_get_recipe(struct ice_hw *hw,\n \tbuf_size = *num_recipes * sizeof(*s_recipe_list);\n \n \tstatus = ice_aq_send_cmd(hw, &desc, s_recipe_list, buf_size, cd);\n-\t/* cppcheck-suppress constArgument */\n \t*num_recipes = LE16_TO_CPU(cmd->num_sub_recipes);\n \n \treturn status;\n@@ -4979,7 +4978,7 @@ enum ice_status ice_add_vlan(struct ice_hw *hw, struct LIST_HEAD_TYPE *v_list)\n }\n \n /**\n- * ice_add_mac_vlan - Add MAC and VLAN pair based filter rule\n+ * ice_add_mac_vlan_rule - Add MAC and VLAN pair based filter rule\n * @hw: pointer to the hardware structure\n * @mv_list: list of MAC and VLAN filters\n * @sw: pointer to switch info struct for which function add rule\n@@ -5671,7 +5670,7 @@ ice_get_vsi_promisc(struct ice_hw *hw, u16 vsi_handle, u8 *promisc_mask,\n }\n \n /**\n- * ice_get_vsi_vlan_promisc - get VLAN promiscuous mode of given VSI\n+ * _ice_get_vsi_vlan_promisc - get VLAN promiscuous mode of given VSI\n * @hw: pointer to the hardware structure\n * @vsi_handle: VSI handle to retrieve info from\n * @promisc_mask: pointer to mask to be filled in\n@@ -6664,7 +6663,7 @@ static bool ice_prot_type_to_id(enum ice_protocol_type type, u8 *id)\n }\n \n /**\n- * ice_find_valid_words - count valid words\n+ * ice_fill_valid_words - count valid words\n * @rule: advanced rule with lookup information\n * @lkup_exts: byte offset extractions of the words that are valid\n *\n@@ -7263,7 +7262,7 @@ ice_get_fv(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n }\n \n /**\n- * ice_tun_type_match_mask - determine if tun type needs a match mask\n+ * ice_tun_type_match_word - determine if tun type needs a match mask\n * @tun_type: tunnel type\n * @mask: mask to be used for the tunnel\n */\n@@ -8860,7 +8859,7 @@ ice_rem_adv_rule_by_id(struct ice_hw *hw,\n }\n \n /**\n- * ice_rem_adv_for_vsi - removes existing advanced switch rules for a\n+ * ice_rem_adv_rule_for_vsi - removes existing advanced switch rules for a\n * given VSI handle\n * @hw: pointer to the hardware structure\n * @vsi_handle: VSI handle for which we are supposed to remove all the rules.\n@@ -9142,7 +9141,7 @@ ice_replay_vsi_all_fltr(struct ice_hw *hw, struct ice_port_info *pi,\n }\n \n /**\n- * ice_rm_all_sw_replay_rule - helper function to delete filter replay rules\n+ * ice_rm_sw_replay_rule_info - helper function to delete filter replay rules\n * @hw: pointer to the HW struct\n * @sw: pointer to switch info struct for which function removes filters\n *\ndiff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h\nindex a6599363f9..3c534a7711 100644\n--- a/drivers/net/ice/base/ice_type.h\n+++ b/drivers/net/ice/base/ice_type.h\n@@ -44,9 +44,7 @@\n #define ice_struct_size(ptr, field, num) \\\n \t(sizeof(*(ptr)) + sizeof(*(ptr)->field) * (num))\n \n-#ifndef FLEX_ARRAY_SIZE\n #define FLEX_ARRAY_SIZE(_ptr, _mem, cnt) ((cnt) * sizeof(_ptr->_mem[0]))\n-#endif /* FLEX_ARRAY_SIZE */\n \n #include \"ice_status.h\"\n #include \"ice_hw_autogen.h\"\ndiff --git a/drivers/net/ice/base/ice_vlan_mode.c b/drivers/net/ice/base/ice_vlan_mode.c\nindex 4ba78ed4cd..ce150009c2 100644\n--- a/drivers/net/ice/base/ice_vlan_mode.c\n+++ b/drivers/net/ice/base/ice_vlan_mode.c\n@@ -2,11 +2,10 @@\n * Copyright(c) 2001-2021 Intel Corporation\n */\n \n-#include \"ice_vlan_mode.h\"\n #include \"ice_common.h\"\n \n /**\n- * ice_pkg_supports_dvm - determine if DDP supports Double VLAN mode (DVM)\n+ * ice_pkg_get_supported_vlan_mode - chk if DDP supports Double VLAN mode (DVM)\n * @hw: pointer to the HW struct\n * @dvm: output variable to determine if DDP supports DVM(true) or SVM(false)\n */\ndiff --git a/drivers/net/ice/base/ice_vlan_mode.h b/drivers/net/ice/base/ice_vlan_mode.h\nindex bcb6ff7134..e9f13e7814 100644\n--- a/drivers/net/ice/base/ice_vlan_mode.h\n+++ b/drivers/net/ice/base/ice_vlan_mode.h\n@@ -6,7 +6,6 @@\n #define _ICE_VLAN_MODE_H_\n \n #include \"ice_osdep.h\"\n-#include \"ice_status.h\"\n \n struct ice_hw;\n \n", "prefixes": [ "v3", "01/14" ] }