Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90992/?format=api
{ "id": 90992, "url": "http://patches.dpdk.org/api/patches/90992/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1618017080-50053-6-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618017080-50053-6-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618017080-50053-6-git-send-email-humin29@huawei.com", "date": "2021-04-10T01:11:18", "name": "[v2,5/7] net/hns3: fix incorrect timing in resetting queues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3ffd5bb700c634841c90f98202c33d985f224412", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1618017080-50053-6-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16255, "url": "http://patches.dpdk.org/api/series/16255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16255", "date": "2021-04-10T01:11:13", "name": "Bugfix for hns3 PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/16255/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90992/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90992/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 47B14A0547;\n\tSat, 10 Apr 2021 03:11:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 83C41141145;\n\tSat, 10 Apr 2021 03:11:12 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 105F1141138\n for <dev@dpdk.org>; Sat, 10 Apr 2021 03:11:08 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FHH1X10xZzNvTV\n for <dev@dpdk.org>; Sat, 10 Apr 2021 09:08:16 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id\n 14.3.498.0; Sat, 10 Apr 2021 09:11:00 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Sat, 10 Apr 2021 09:11:18 +0800", "Message-ID": "<1618017080-50053-6-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618017080-50053-1-git-send-email-humin29@huawei.com>", "References": "<1617963365-41299-1-git-send-email-humin29@huawei.com>\n <1618017080-50053-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v2 5/7] net/hns3: fix incorrect timing in\n resetting queues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nDuring the task queue pairs reset, the getimeofday is used to obtain the\ntimestamp to determine whether the command execution times out. But\ngettimeofday is not monotonous, it can be modified by system\nadministrators, so the timing may not be accurate or even cause the loop\nto wait consistently. And actually, in this scenario, it is not necessary\nto obain the timestamp.\n\nThis patch removes the operation of obtaining the timestamp from the task\nqueue pairs reset function.\n\nFixes: bba636698316 (\"net/hns3: support Rx/Tx and related operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 8c5da44..be93618 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -625,8 +625,8 @@ static int\n hns3pf_reset_tqp(struct hns3_hw *hw, uint16_t queue_id)\n {\n #define HNS3_TQP_RESET_TRY_MS\t200\n+\tuint16_t wait_time = 0;\n \tuint8_t reset_status;\n-\tuint64_t end;\n \tint ret;\n \n \t/*\n@@ -639,17 +639,18 @@ hns3pf_reset_tqp(struct hns3_hw *hw, uint16_t queue_id)\n \t\thns3_err(hw, \"Send reset tqp cmd fail, ret = %d\", ret);\n \t\treturn ret;\n \t}\n-\tend = get_timeofday_ms() + HNS3_TQP_RESET_TRY_MS;\n+\n \tdo {\n \t\t/* Wait for tqp hw reset */\n \t\trte_delay_ms(HNS3_POLL_RESPONE_MS);\n+\t\twait_time += HNS3_POLL_RESPONE_MS;\n \t\tret = hns3_get_tqp_reset_status(hw, queue_id, &reset_status);\n \t\tif (ret)\n \t\t\tgoto tqp_reset_fail;\n \n \t\tif (reset_status)\n \t\t\tbreak;\n-\t} while (get_timeofday_ms() < end);\n+\t} while (wait_time < HNS3_TQP_RESET_TRY_MS);\n \n \tif (!reset_status) {\n \t\tret = -ETIMEDOUT;\n", "prefixes": [ "v2", "5/7" ] }