Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 90821,
    "url": "http://patches.dpdk.org/api/patches/90821/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210407201603.149234-2-lucp.at.work@gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210407201603.149234-2-lucp.at.work@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210407201603.149234-2-lucp.at.work@gmail.com",
    "date": "2021-04-07T20:16:06",
    "name": "[2/2] eal: fix hang in ctrl thread creation error logic",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9db719e54122037be69b4db502ac86321c587e01",
    "submitter": {
        "id": 2151,
        "url": "http://patches.dpdk.org/api/people/2151/?format=api",
        "name": "Luc Pelletier",
        "email": "lucp.at.work@gmail.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210407201603.149234-2-lucp.at.work@gmail.com/mbox/",
    "series": [
        {
            "id": 16178,
            "url": "http://patches.dpdk.org/api/series/16178/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16178",
            "date": "2021-04-07T20:16:04",
            "name": "[1/2] eal: fix race in ctrl thread creation",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/16178/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/90821/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/90821/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6F2D2A0A0F;\n\tWed,  7 Apr 2021 22:28:56 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2710A140F81;\n\tWed,  7 Apr 2021 22:28:56 +0200 (CEST)",
            "from mail-qv1-f47.google.com (mail-qv1-f47.google.com\n [209.85.219.47])\n by mails.dpdk.org (Postfix) with ESMTP id 54EA9140F7F;\n Wed,  7 Apr 2021 22:28:55 +0200 (CEST)",
            "by mail-qv1-f47.google.com with SMTP id t13so3717089qvs.7;\n Wed, 07 Apr 2021 13:28:55 -0700 (PDT)",
            "from localhost.localdomain\n (bras-base-hullpq2034w-grc-18-74-15-213-92.dsl.bell.ca. [74.15.213.92])\n by smtp.gmail.com with ESMTPSA id 7sm19532060qkm.64.2021.04.07.13.28.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 07 Apr 2021 13:28:54 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=VMz1HXOh0o6zKNzAz8TyY9AAt3vcJaxmFlm9CSQviWI=;\n b=jWFn1ve1sKtsEsdEUyqNRwHDgZa7wH4oWGPUPcnkS2yMUaaW/5sb/CWkcbhcjcw0rm\n orGSH+r4BDfFUy9SiGuhgcsJIViF3WI8iF2G7KNLQA1HkVAGqaNSxWRxt4exC6DDJRxH\n u9cTP3uL91v5IbASihId7UWmJJ55FS5agZYDERGuY3aR3LRJ+9ab7VYS17PYkizY1ZEc\n BZ9wCVu3LX65o+6N1xGyXALA3TenqFA5mK2cEDblZ3B0A06gc8Ak4MnrqLnjZfU+eU9U\n MyXTxAnf8Fq3YZVQhDJtOOOqsReTUdrGt9eBTItpg/ieWrd2U5QsPAooJ3jkFnPz3xAn\n aF/g==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=VMz1HXOh0o6zKNzAz8TyY9AAt3vcJaxmFlm9CSQviWI=;\n b=q6qdsTQejQxFVzosd6yt6nD598bGMtrMiiqUTNoeqyurN17roikX4skvSygAnooeZx\n prHPxcokxmdNmNUv6YVet0dqSZjocEDc0gcqm4tsnq5eDB10qtMpVPaYD/z+Lu835Spn\n zqofhEMBMZHb+ZZud+I8qNlzPSjackEqoG5uBSpJFXoVaJ/UjxY8p+Ne1G6pGtGtLlbi\n rJabhCOjSMsxckZJZqHDxHuTpk42wb5V4wzc3EhoAKbwrxklzWbnGBesabjAYl/p5WjJ\n NMvQy9zJNLSSpMHhEM6SC5Re+CU+fAGadQNHsf7NNDnygNad4biu4CCDifN8OqmAQxo8\n uQMA==",
        "X-Gm-Message-State": "AOAM530ROrCxHCHMG+gOi7sCY96NJjemLGX5B7XQpRt+rgc/ar23wj5K\n 85N4HIuJMiM35EVN5iNLs2A=",
        "X-Google-Smtp-Source": "\n ABdhPJway+0jJTXGHvEhXFtGHrSg+GXGtlPTlD6He4td5ajEw4JS3Wp1ZhY1TGDlYjP0DV5gMb1a2Q==",
        "X-Received": "by 2002:a05:6214:f0d:: with SMTP id\n gw13mr5402477qvb.33.1617827334877;\n Wed, 07 Apr 2021 13:28:54 -0700 (PDT)",
        "From": "Luc Pelletier <lucp.at.work@gmail.com>",
        "To": "olivier.matz@6wind.com, jianfeng.tan@intel.com,\n Honnappa.Nagarahalli@arm.com",
        "Cc": "dev@dpdk.org,\n\tLuc Pelletier <lucp.at.work@gmail.com>,\n\tstable@dpdk.org",
        "Date": "Wed,  7 Apr 2021 16:16:06 -0400",
        "Message-Id": "<20210407201603.149234-2-lucp.at.work@gmail.com>",
        "In-Reply-To": "\n <DBAPR08MB581490C7F81791C485E062F698759@DBAPR08MB5814.eurprd08.prod.outlook.com>",
        "References": "\n <DBAPR08MB581490C7F81791C485E062F698759@DBAPR08MB5814.eurprd08.prod.outlook.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error\n logic",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The affinity of a control thread is set after it has been launched. If\nsetting the affinity fails, pthread_cancel is called followed by a call\nto pthread_join, which can hang forever if the thread's start routine\ndoesn't call a pthread cancellation point.\n\nThis patch modifies the logic so that the control thread exits\ngracefully if the affinity cannot be set successfully and removes the\ncall to pthread_cancel.\n\nFixes: 6383d26 (\"eal: set name when creating a control thread\")\nCc: olivier.matz@6wind.com\nCc: stable@dpdk.org\n\nSigned-off-by: Luc Pelletier <lucp.at.work@gmail.com>\n---\n\nHi Olivier,\nHi Honnappa,\n\nAs discussed, I've split the changes into 2 patches. This second commit\nremoves the pthread_cancel call which could result in a hang on join, if\nthe ctrl thread routine didn't call a cancellation point.\n\n lib/librte_eal/common/eal_common_thread.c | 29 +++++++++++++----------\n 1 file changed, 17 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c\nindex 3347e91bf..03dbcd9e8 100644\n--- a/lib/librte_eal/common/eal_common_thread.c\n+++ b/lib/librte_eal/common/eal_common_thread.c\n@@ -187,14 +187,18 @@ static void *ctrl_thread_init(void *arg)\n \t\teal_get_internal_configuration();\n \trte_cpuset_t *cpuset = &internal_conf->ctrl_cpuset;\n \tstruct rte_thread_ctrl_params *params = arg;\n-\tvoid *(*start_routine)(void *) = params->start_routine;\n+\tvoid *(*start_routine)(void *);\n \tvoid *routine_arg = params->arg;\n \n \t__rte_thread_init(rte_lcore_id(), cpuset);\n \n \tpthread_barrier_wait(&params->configured);\n+\tstart_routine = params->start_routine;\n \tctrl_params_free(params);\n \n+\tif (start_routine == NULL)\n+\t\treturn NULL;\n+\n \treturn start_routine(routine_arg);\n }\n \n@@ -218,14 +222,12 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,\n \tparams->refcnt = 2;\n \n \tret = pthread_barrier_init(&params->configured, NULL, 2);\n-\tif (ret != 0) {\n-\t\tfree(params);\n-\t\treturn -ret;\n-\t}\n+\tif (ret != 0)\n+\t\tgoto fail_no_barrier;\n \n \tret = pthread_create(thread, attr, ctrl_thread_init, (void *)params);\n \tif (ret != 0)\n-\t\tgoto fail;\n+\t\tgoto fail_with_barrier;\n \n \tif (name != NULL) {\n \t\tret = rte_thread_setname(*thread, name);\n@@ -236,19 +238,22 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,\n \n \tret = pthread_setaffinity_np(*thread, sizeof(*cpuset), cpuset);\n \tif (ret != 0)\n-\t\tgoto fail_cancel;\n+\t\tparams->start_routine = NULL;\n \n \tpthread_barrier_wait(&params->configured);\n \tctrl_params_free(params);\n \n-\treturn 0;\n+\tif (ret != 0)\n+\t\t/* start_routine has been set to NULL above; */\n+\t\t/* ctrl thread will exit immediately */\n+\t\tpthread_join(*thread, NULL);\n \n-fail_cancel:\n-\tpthread_cancel(*thread);\n-\tpthread_join(*thread, NULL);\n+\treturn -ret;\n \n-fail:\n+fail_with_barrier:\n \tpthread_barrier_destroy(&params->configured);\n+\n+fail_no_barrier:\n \tfree(params);\n \n \treturn -ret;\n",
    "prefixes": [
        "2/2"
    ]
}