Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90556/?format=api
{ "id": 90556, "url": "http://patches.dpdk.org/api/patches/90556/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210405100301.657768-4-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210405100301.657768-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210405100301.657768-4-thomas@monjalon.net", "date": "2021-04-05T10:03:01", "name": "[v2,3/3] drivers: align log names", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "da53da518a9c97e50adcb2e06432894c6c0d23c2", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210405100301.657768-4-thomas@monjalon.net/mbox/", "series": [ { "id": 16101, "url": "http://patches.dpdk.org/api/series/16101/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16101", "date": "2021-04-05T10:02:58", "name": "drivers: align log names", "version": 2, "mbox": "http://patches.dpdk.org/series/16101/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90556/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90556/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4A99A0A0A;\n\tMon, 5 Apr 2021 12:03:25 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0C0B8140E93;\n\tMon, 5 Apr 2021 12:03:15 +0200 (CEST)", "from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com\n [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id ECF4D140E80\n for <dev@dpdk.org>; Mon, 5 Apr 2021 12:03:13 +0200 (CEST)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailnew.nyi.internal (Postfix) with ESMTP id 9269D58039B;\n Mon, 5 Apr 2021 06:03:13 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Mon, 05 Apr 2021 06:03:13 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 514E71080064;\n Mon, 5 Apr 2021 06:03:11 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm3; bh=mz5qiDBLyHQJG\n dmyDzjv8BP6s72Ef5xTHwJSKO1f07M=; b=FJMntpkLbqzJwPoF3JwGucZHsPPQY\n xFWVX1YnIt/rXCnC6dPLU41CbbK1PfYFata1knpcFFXMb3/r4N1aIIjj40rT3OM7\n ps3zJXiJZ1Vhs6hYmvKbhMV77xlyWBYEJQmOaG0qm4OxJfQk3G2cyf3k4StIlI/M\n z/Lb4YFUNnH8URuyE1fXzgXdC1Yv+OVhxGzBUi9Sp+paTssVatMxpsvSpMunrEHf\n VlVmA/c3Ct1DCHu2KTrh67Qk/oOpKbCisMtRtqd5jeSDDkQBJUqpgjdnE67MUKsY\n SkrBZA7SXNHsJDgTg1EAmw5+Br4BhGvVi1BXPb85gP1S0rLyeJ3z/fy3Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=mz5qiDBLyHQJGdmyDzjv8BP6s72Ef5xTHwJSKO1f07M=; b=KKz8mD6d\n DPujeMLPu/AoYMuC2F9SWPfgopJOk+qZ2znDaz2HjEDPs0Bva9PmRy9koSxoewBl\n KQPgjHCd9n9J6XYrp4kmrNbmT2qWux8RPKZSYHUwdzg4bEzOhVgyuRRLPUsvuXgJ\n TFCw8I5mvFBaKRQlOQw/Rd3GCV86X/aNsT3cFk/TPXWvsWp7Ek5W40L6/UBjR8g8\n phNL0duieCJEF7oPaxTlPkK44n+SL+TFcpisyzlfP8BwjsFUxIEJphDIeZtPERrw\n iujFfy+ywn5TqtPqFyVcwNTabr40PVPgO5ejHIraJSf7tgtsFAONgKNRQGuahooF\n ZzJ/ZWmDsMs2Dw==" ], "X-ME-Sender": "<xms:YOBqYD7BlXYFBisHo2wyuuACiBeQJbbpzhoW9hhpICRgQGEvJ91HIw>\n <xme:YOBqYK5mq27FrwuaXSZccYUqvipuG8ig16KcAy42X2eC0tusKx0mo1mXS2khglzpN\n IO8-f8qwIPFqLKLIw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrudejvddgvdegucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepheefieekleefieeljedtvdehgeejvdevfedufeetleejfeethfel\n gfffudektdeunecuffhomhgrihhnpehpmhgurdhnvghtnecukfhppeejjedrudefgedrvd\n dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr\n ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:YOBqYD2NGBKdgTFYvc7qKrBx7U_aUcBfk2OwaB-S-vBo9J9tX4K2-A>\n <xmx:YOBqYGXmuX4jXZiBLCEkvoJs0aV4-IzL1-A3GNLis9c3l-2nLZm1Xw>\n <xmx:YOBqYO7D7LaH_2hSPjRn2IbNDYDCcrPjTKbEHbsMSkCej9cUGSKK1A>\n <xmx:YeBqYCUY5H03XeB19QeFUikC7lD611zhxZDf2lzUtL9XJwSRaFMBhg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Rosen Xu <rosen.xu@intel.com>, Xiao Wang <xiao.w.wang@intel.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n John Griffin <john.griffin@intel.com>, Fiona Trahe <fiona.trahe@intel.com>,\n Deepak Kumar Jain <deepak.k.jain@intel.com>,\n Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,\n Vikas Gupta <vikas.gupta@broadcom.com>,\n \"John W. Linville\" <linville@tuxdriver.com>, Chas Williams <chas3@att.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Tianfei zhang <tianfei.zhang@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>", "Date": "Mon, 5 Apr 2021 12:03:01 +0200", "Message-Id": "<20210405100301.657768-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210405100301.657768-1-thomas@monjalon.net>", "References": "<20210310140107.2730088-1-thomas@monjalon.net>\n <20210405100301.657768-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/3] drivers: align log names", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The log levels are configured by using the name of the logs.\nSome drivers are aligned to follow a common log name standard:\n\tpmd.class.driver[.sub]\nSome \"common\" drivers skip the \"class\" part:\n\tpmd.driver.sub\n\nTwo drivers have exceptions to be clarified:\n\tpmd.vdpa.ifcvf instead of pmd.vdpa.ifc\n\tpmd.afu.ipn3ke instead of pmd.net.ipn3ke\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Rosen Xu <rosen.xu@intel.com>\nAcked-by: Xiao Wang <xiao.w.wang@intel.com>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\nAcked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n doc/guides/cryptodevs/qat.rst | 10 +++++-----\n drivers/common/qat/qat_logs.c | 4 ++--\n drivers/crypto/bcmfs/bcmfs_logs.c | 4 ++--\n drivers/net/af_packet/rte_eth_af_packet.c | 2 +-\n drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-\n drivers/raw/ifpga/ifpga_rawdev.c | 2 +-\n drivers/raw/ioat/ioat_rawdev.c | 2 +-\n drivers/raw/skeleton/skeleton_rawdev.c | 2 +-\n drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-\n 9 files changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst\nindex cf16f03503..224b22b3f7 100644\n--- a/doc/guides/cryptodevs/qat.rst\n+++ b/doc/guides/cryptodevs/qat.rst\n@@ -659,15 +659,15 @@ Debugging\n \n There are 2 sets of trace available via the dynamic logging feature:\n \n-* pmd.qat_dp exposes trace on the data-path.\n-* pmd.qat_general exposes all other trace.\n+* pmd.qat.dp exposes trace on the data-path.\n+* pmd.qat.general exposes all other trace.\n \n pmd.qat exposes both sets of traces.\n They can be enabled using the log-level option (where 8=maximum log level) on\n the process cmdline, e.g. using any of the following::\n \n- --log-level=\"pmd.qat_general,8\"\n- --log-level=\"pmd.qat_dp,8\"\n+ --log-level=\"pmd.qat.general,8\"\n+ --log-level=\"pmd.qat.dp,8\"\n --log-level=\"pmd.qat,8\"\n \n .. Note::\n@@ -678,4 +678,4 @@ the process cmdline, e.g. using any of the following::\n Also the dynamic global log level overrides both sets of trace, so e.g. no\n QAT trace would display in this case::\n \n-\t--log-level=\"7\" --log-level=\"pmd.qat_general,8\"\n+\t--log-level=\"7\" --log-level=\"pmd.qat.general,8\"\ndiff --git a/drivers/common/qat/qat_logs.c b/drivers/common/qat/qat_logs.c\nindex fa48be53c3..adbe163cd9 100644\n--- a/drivers/common/qat/qat_logs.c\n+++ b/drivers/common/qat/qat_logs.c\n@@ -17,5 +17,5 @@ qat_hexdump_log(uint32_t level, uint32_t logtype, const char *title,\n \treturn 0;\n }\n \n-RTE_LOG_REGISTER(qat_gen_logtype, pmd.qat_general, NOTICE);\n-RTE_LOG_REGISTER(qat_dp_logtype, pmd.qat_dp, NOTICE);\n+RTE_LOG_REGISTER(qat_gen_logtype, pmd.qat.general, NOTICE);\n+RTE_LOG_REGISTER(qat_dp_logtype, pmd.qat.dp, NOTICE);\ndiff --git a/drivers/crypto/bcmfs/bcmfs_logs.c b/drivers/crypto/bcmfs/bcmfs_logs.c\nindex 701da9ecf3..9faf12f238 100644\n--- a/drivers/crypto/bcmfs/bcmfs_logs.c\n+++ b/drivers/crypto/bcmfs/bcmfs_logs.c\n@@ -21,5 +21,5 @@ bcmfs_hexdump_log(uint32_t level, uint32_t logtype, const char *title,\n \treturn 0;\n }\n \n-RTE_LOG_REGISTER(bcmfs_conf_logtype, pmd.bcmfs_config, NOTICE)\n-RTE_LOG_REGISTER(bcmfs_dp_logtype, pmd.bcmfs_fp, NOTICE)\n+RTE_LOG_REGISTER(bcmfs_conf_logtype, pmd.crypto.bcmfs.config, NOTICE)\n+RTE_LOG_REGISTER(bcmfs_dp_logtype, pmd.crypto.bcmfs.fp, NOTICE)\ndiff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex bfe5a0a451..a04f7c773a 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -97,7 +97,7 @@ static struct rte_eth_link pmd_link = {\n \t.link_autoneg = ETH_LINK_FIXED,\n };\n \n-RTE_LOG_REGISTER(af_packet_logtype, pmd.net.packet, NOTICE);\n+RTE_LOG_REGISTER(af_packet_logtype, pmd.net.af_packet, NOTICE);\n \n #define PMD_LOG(level, fmt, args...) \\\n \trte_log(RTE_LOG_ ## level, af_packet_logtype, \\\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 24e3cf3c2e..2e9cea5b8e 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -3775,4 +3775,4 @@ RTE_PMD_REGISTER_PARAM_STRING(net_bonding,\n \t\"up_delay=<int> \"\n \t\"down_delay=<int>\");\n \n-RTE_LOG_REGISTER(bond_logtype, pmd.net.bond, NOTICE);\n+RTE_LOG_REGISTER(bond_logtype, pmd.net.bonding, NOTICE);\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex 05d79bfcc2..d9a46ef915 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -1611,7 +1611,7 @@ static struct rte_pci_driver rte_ifpga_rawdev_pmd = {\n RTE_PMD_REGISTER_PCI(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd);\n RTE_PMD_REGISTER_KMOD_DEP(ifpga_rawdev_pci_driver, \"* igb_uio | uio_pci_generic | vfio-pci\");\n-RTE_LOG_REGISTER(ifpga_rawdev_logtype, driver.raw.init, NOTICE);\n+RTE_LOG_REGISTER(ifpga_rawdev_logtype, pmd.raw.ifpga, NOTICE);\n \n static const char * const valid_args[] = {\n #define IFPGA_ARG_NAME \"ifpga\"\ndiff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex a95854d5ac..15af07017c 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -28,7 +28,7 @@ static struct rte_pci_driver ioat_pmd_drv;\n #define IOAT_DEVICE_ID_BDXF\t0x6f2F\n #define IOAT_DEVICE_ID_ICX\t0x0b00\n \n-RTE_LOG_REGISTER(ioat_pmd_logtype, rawdev.ioat, INFO);\n+RTE_LOG_REGISTER(ioat_pmd_logtype, pmd.raw.ioat, INFO);\n \n #define DESC_SZ sizeof(struct rte_ioat_generic_hw_desc)\n #define COMPLETION_SZ sizeof(__m128i)\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c\nindex aa3beaad18..8896f0c9c5 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev.c\n@@ -768,4 +768,4 @@ static struct rte_vdev_driver skeleton_pmd_drv = {\n };\n \n RTE_PMD_REGISTER_VDEV(SKELETON_PMD_RAWDEV_NAME, skeleton_pmd_drv);\n-RTE_LOG_REGISTER(skeleton_pmd_logtype, rawdev.skeleton, INFO);\n+RTE_LOG_REGISTER(skeleton_pmd_logtype, pmd.raw.skeleton, INFO);\ndiff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex 39237aecf7..7a06f97429 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -26,7 +26,7 @@\n \n #include \"base/ifcvf.h\"\n \n-RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.net.ifcvf_vdpa, NOTICE);\n+RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE);\n #define DRV_LOG(level, fmt, args...) \\\n \trte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \\\n \t\t\"IFCVF %s(): \" fmt \"\\n\", __func__, ##args)\n", "prefixes": [ "v2", "3/3" ] }