Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 90364,
    "url": "http://patches.dpdk.org/api/patches/90364/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210401115009.1063844-8-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210401115009.1063844-8-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210401115009.1063844-8-bruce.richardson@intel.com",
    "date": "2021-04-01T11:50:02",
    "name": "[RFC,07/14] build: reduce indentation in examples build spec",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "148feab01d87dafb981d0141c30810ff8c3e7bd9",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210401115009.1063844-8-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 16057,
            "url": "http://patches.dpdk.org/api/series/16057/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16057",
            "date": "2021-04-01T11:49:55",
            "name": "Build file update proposals",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/16057/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/90364/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/90364/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2AB9A0548;\n\tThu,  1 Apr 2021 13:51:17 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 29B301410D8;\n\tThu,  1 Apr 2021 13:50:37 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 1BEE91410ED\n for <dev@dpdk.org>; Thu,  1 Apr 2021 13:50:34 +0200 (CEST)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Apr 2021 04:50:34 -0700",
            "from silpixa00399126.ir.intel.com ([10.237.223.116])\n by FMSMGA003.fm.intel.com with ESMTP; 01 Apr 2021 04:50:33 -0700"
        ],
        "IronPort-SDR": [
            "\n g44gJzYZJVlELcPzQIYrcuU9jYMxhNY2j6HK/p2Q08mOo0kGI187stzJ+a8l2Cb6qzHs44KuxF\n 93tzD54V0APQ==",
            "\n tmH+AKlTgxLkP4gi+wMPyVawyl7vmPwh9p9uX0DhBJEFJTa7bfVeM6WxSaDKLdXq1pDsy4d4F8\n k/gn4VfTn4rw=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9940\"; a=\"179760788\"",
            "E=Sophos;i=\"5.81,296,1610438400\"; d=\"scan'208\";a=\"179760788\"",
            "E=Sophos;i=\"5.81,296,1610438400\"; d=\"scan'208\";a=\"446062660\""
        ],
        "X-ExtLoop1": "1",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "thomas@monjalon.net, david.marchand@redhat.com, bluca@debian.org,\n Bruce Richardson <bruce.richardson@intel.com>",
        "Date": "Thu,  1 Apr 2021 12:50:02 +0100",
        "Message-Id": "<20210401115009.1063844-8-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "In-Reply-To": "<20210401115009.1063844-1-bruce.richardson@intel.com>",
        "References": "<20210401115009.1063844-1-bruce.richardson@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [RFC PATCH 07/14] build: reduce indentation in examples\n build spec",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "As with the lib and drivers directories, we can use \"continue\" keyword to\nreduce the indentation level of the majority of the foreach block. At the\nsame time, we can also replace tab indentation with spaces.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/meson.build | 158 ++++++++++++++++++++++---------------------\n 1 file changed, 80 insertions(+), 78 deletions(-)",
    "diff": "diff --git a/examples/meson.build b/examples/meson.build\nindex d065a6a08b..b9518d687c 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -3,109 +3,111 @@\n \n link_whole_libs = []\n if get_option('default_library') == 'static'\n-\tlink_whole_libs = dpdk_static_libraries + dpdk_drivers\n+    link_whole_libs = dpdk_static_libraries + dpdk_drivers\n endif\n \n # list of all example apps. Keep 1-3 per line, in alphabetical order.\n all_examples = [\n-\t'bbdev_app', 'bond',\n-\t'cmdline',\n-\t'distributor', 'ethtool',\n-\t'eventdev_pipeline',\n-\t'fips_validation', 'flow_classify',\n-\t'flow_filtering', 'helloworld',\n-\t'ioat',\n-\t'ip_fragmentation', 'ip_pipeline',\n-\t'ip_reassembly', 'ipsec-secgw',\n-\t'ipv4_multicast', 'kni',\n-\t'l2fwd', 'l2fwd-cat', 'l2fwd-event',\n-\t'l2fwd-crypto', 'l2fwd-jobstats',\n-\t'l2fwd-keepalive', 'l3fwd',\n-\t'l3fwd-acl', 'l3fwd-power', 'l3fwd-graph',\n-\t'link_status_interrupt',\n-\t'multi_process/client_server_mp/mp_client',\n-\t'multi_process/client_server_mp/mp_server',\n-\t'multi_process/hotplug_mp',\n-\t'multi_process/simple_mp',\n-\t'multi_process/symmetric_mp',\n-\t'ntb', 'packet_ordering',\n-\t'performance-thread/l3fwd-thread',\n-\t'performance-thread/pthread_shim',\n-\t'pipeline',\n-\t'ptpclient',\n-\t'qos_meter', 'qos_sched',\n-\t'rxtx_callbacks',\n-\t'server_node_efd/node',\n-\t'server_node_efd/server',\n-\t'service_cores',\n-\t'skeleton',\n-\t'timer', 'vdpa',\n-\t'vhost', 'vhost_crypto',\n-\t'vhost_blk', 'vm_power_manager',\n-\t'vm_power_manager/guest_cli',\n-\t'vmdq', 'vmdq_dcb',\n+    'bbdev_app', 'bond',\n+    'cmdline',\n+    'distributor', 'ethtool',\n+    'eventdev_pipeline',\n+    'fips_validation', 'flow_classify',\n+    'flow_filtering', 'helloworld',\n+    'ioat',\n+    'ip_fragmentation', 'ip_pipeline',\n+    'ip_reassembly', 'ipsec-secgw',\n+    'ipv4_multicast', 'kni',\n+    'l2fwd', 'l2fwd-cat', 'l2fwd-event',\n+    'l2fwd-crypto', 'l2fwd-jobstats',\n+    'l2fwd-keepalive', 'l3fwd',\n+    'l3fwd-acl', 'l3fwd-power', 'l3fwd-graph',\n+    'link_status_interrupt',\n+    'multi_process/client_server_mp/mp_client',\n+    'multi_process/client_server_mp/mp_server',\n+    'multi_process/hotplug_mp',\n+    'multi_process/simple_mp',\n+    'multi_process/symmetric_mp',\n+    'ntb', 'packet_ordering',\n+    'performance-thread/l3fwd-thread',\n+    'performance-thread/pthread_shim',\n+    'pipeline',\n+    'ptpclient',\n+    'qos_meter', 'qos_sched',\n+    'rxtx_callbacks',\n+    'server_node_efd/node',\n+    'server_node_efd/server',\n+    'service_cores',\n+    'skeleton',\n+    'timer', 'vdpa',\n+    'vhost', 'vhost_crypto',\n+    'vhost_blk', 'vm_power_manager',\n+    'vm_power_manager/guest_cli',\n+    'vmdq', 'vmdq_dcb',\n ]\n \n # on install, skip copying all meson.build files\n ex_file_excludes = ['meson.build']\n foreach ex:all_examples\n-\tex_file_excludes += [ex + '/meson.build']\n+    ex_file_excludes += [ex + '/meson.build']\n endforeach\n \n if get_option('examples') == ''\n-\tsubdir_done()\n+    subdir_done()\n endif\n \n if get_option('examples').to_lower() == 'all'\n-\texamples = all_examples\n-\tallow_skips = true # don't flag an error if we can't build an app\n+    examples = all_examples\n+    allow_skips = true # don't flag an error if we can't build an app\n else\n-\texamples = get_option('examples').split(',')\n-\tallow_skips = false # error out if we can't build a requested app\n+    examples = get_option('examples').split(',')\n+    allow_skips = false # error out if we can't build a requested app\n endif\n default_cflags = machine_args\n if cc.has_argument('-Wno-format-truncation')\n-\tdefault_cflags += '-Wno-format-truncation'\n+    default_cflags += '-Wno-format-truncation'\n endif\n default_ldflags = dpdk_extra_ldflags\n if get_option('default_library') == 'static' and not is_windows\n-\tdefault_ldflags += ['-Wl,--export-dynamic']\n+    default_ldflags += ['-Wl,--export-dynamic']\n endif\n \n foreach example: examples\n-\tname = example.split('/')[-1]\n-\tbuild = true\n-\tsources = []\n-\tallow_experimental_apis = false\n-\tcflags = default_cflags\n-\tldflags = default_ldflags\n+    name = example.split('/')[-1]\n+    build = true\n+    sources = []\n+    allow_experimental_apis = false\n+    cflags = default_cflags\n+    ldflags = default_ldflags\n \n-\text_deps = []\n-\tincludes = [include_directories(example)]\n-\tdeps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']\n-\tsubdir(example)\n+    ext_deps = []\n+    includes = [include_directories(example)]\n+    deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']\n+    subdir(example)\n \n-\tif build\n-\t\tdep_objs = ext_deps\n-\t\tforeach d:deps\n-\t\t\tvar_name = get_option('default_library') + '_rte_' + d\n-\t\t\tif not is_variable(var_name)\n-\t\t\t\terror('Missing dependency \"@0@\" for example \"@1@\"'.format(d, name))\n-\t\t\tendif\n-\t\t\tdep_objs += [get_variable(var_name)]\n-\t\tendforeach\n-\t\tif allow_experimental_apis\n-\t\t\tcflags += '-DALLOW_EXPERIMENTAL_API'\n-\t\tendif\n-\t\texecutable('dpdk-' + name, sources,\n-\t\t\tinclude_directories: includes,\n-\t\t\tlink_whole: link_whole_libs,\n-\t\t\tlink_args: ldflags,\n-\t\t\tc_args: cflags,\n-\t\t\tdependencies: dep_objs)\n-\telif not allow_skips\n-\t\terror('Cannot build requested example \"' + name + '\"')\n-\telse\n-\t\tmessage('Skipping example \"' + name + '\"')\n-\tendif\n+    if not build\n+        if not allow_skips\n+            error('Cannot build requested example \"' + name + '\"')\n+        endif\n+        message('Skipping example \"' + name + '\"')\n+        continue\n+    endif\n+\n+    dep_objs = ext_deps\n+    foreach d:deps\n+        var_name = get_option('default_library') + '_rte_' + d\n+        if not is_variable(var_name)\n+            error('Missing dependency \"@0@\" for example \"@1@\"'.format(d, name))\n+        endif\n+        dep_objs += [get_variable(var_name)]\n+    endforeach\n+    if allow_experimental_apis\n+        cflags += '-DALLOW_EXPERIMENTAL_API'\n+    endif\n+    executable('dpdk-' + name, sources,\n+            include_directories: includes,\n+            link_whole: link_whole_libs,\n+            link_args: ldflags,\n+            c_args: cflags,\n+            dependencies: dep_objs)\n endforeach\n",
    "prefixes": [
        "RFC",
        "07/14"
    ]
}