Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 89360,
    "url": "http://patches.dpdk.org/api/patches/89360/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210317092610.71000-2-salems@nvidia.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210317092610.71000-2-salems@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210317092610.71000-2-salems@nvidia.com",
    "date": "2021-03-17T09:26:02",
    "name": "[v3,1/8] app/testpmd: store VXLAN/NVGRE encap data globally",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "598942ba33b8d96ba8b63934ad035e11d3055adf",
    "submitter": {
        "id": 2138,
        "url": "http://patches.dpdk.org/api/people/2138/?format=api",
        "name": "Salem Sol",
        "email": "salems@nvidia.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210317092610.71000-2-salems@nvidia.com/mbox/",
    "series": [
        {
            "id": 15733,
            "url": "http://patches.dpdk.org/api/series/15733/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15733",
            "date": "2021-03-17T09:26:02",
            "name": "Add support for VXLAN and NVGRE encap as a sample actions",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/15733/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/89360/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/89360/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A182FA00C2;\n\tWed, 17 Mar 2021 10:26:21 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1FC9C140EB2;\n\tWed, 17 Mar 2021 10:26:21 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 66FDF140EB1\n for <dev@dpdk.org>; Wed, 17 Mar 2021 10:26:19 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n salems@nvidia.com) with SMTP; 17 Mar 2021 11:26:16 +0200",
            "from nvidia.com ([10.228.128.224])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 12H9QFx5018989;\n Wed, 17 Mar 2021 11:26:16 +0200"
        ],
        "From": "Salem Sol <salems@nvidia.com>",
        "To": "dev@dpdk.org",
        "Cc": "Jiawei Wang <jiaweiw@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>",
        "Date": "Wed, 17 Mar 2021 11:26:02 +0200",
        "Message-Id": "<20210317092610.71000-2-salems@nvidia.com>",
        "X-Mailer": "git-send-email 2.21.0",
        "In-Reply-To": "<20210317092610.71000-1-salems@nvidia.com>",
        "References": "<20210317092610.71000-1-salems@nvidia.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap data\n globally",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Jiawei Wang <jiaweiw@nvidia.com>\n\nWith the current code the VXLAN/NVGRE parsing routine\nstored the configuration of the header on stack, this\nmight lead to overwriting the data on the stack.\n\nThis patch stores the external data of vxlan and nvgre encap\ninto global data as a pre-step to supporting vxlan and nvgre\nencap as a sample actions.\n\nSigned-off-by: Jiawei Wang <jiaweiw@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 76 ++++++++++++++++++++++++-------------\n 1 file changed, 49 insertions(+), 27 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 49d9f9c043..84676a2e45 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -5244,31 +5244,14 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token,\n \treturn len;\n }\n \n-/** Parse VXLAN encap action. */\n+/** Setup VXLAN encap configuration. */\n static int\n-parse_vc_action_vxlan_encap(struct context *ctx, const struct token *token,\n-\t\t\t    const char *str, unsigned int len,\n-\t\t\t    void *buf, unsigned int size)\n+parse_setup_vxlan_encap_data\n+\t\t(struct action_vxlan_encap_data *action_vxlan_encap_data)\n {\n-\tstruct buffer *out = buf;\n-\tstruct rte_flow_action *action;\n-\tstruct action_vxlan_encap_data *action_vxlan_encap_data;\n-\tint ret;\n-\n-\tret = parse_vc(ctx, token, str, len, buf, size);\n-\tif (ret < 0)\n-\t\treturn ret;\n-\t/* Nothing else to do if there is no buffer. */\n-\tif (!out)\n-\t\treturn ret;\n-\tif (!out->args.vc.actions_n)\n+\tif (!action_vxlan_encap_data)\n \t\treturn -1;\n-\taction = &out->args.vc.actions[out->args.vc.actions_n - 1];\n-\t/* Point to selected object. */\n-\tctx->object = out->args.vc.data;\n-\tctx->objmask = NULL;\n \t/* Set up default configuration. */\n-\taction_vxlan_encap_data = ctx->object;\n \t*action_vxlan_encap_data = (struct action_vxlan_encap_data){\n \t\t.conf = (struct rte_flow_action_vxlan_encap){\n \t\t\t.definition = action_vxlan_encap_data->items,\n@@ -5372,19 +5355,18 @@ parse_vc_action_vxlan_encap(struct context *ctx, const struct token *token,\n \t}\n \tmemcpy(action_vxlan_encap_data->item_vxlan.vni, vxlan_encap_conf.vni,\n \t       RTE_DIM(vxlan_encap_conf.vni));\n-\taction->conf = &action_vxlan_encap_data->conf;\n-\treturn ret;\n+\treturn 0;\n }\n \n-/** Parse NVGRE encap action. */\n+/** Parse VXLAN encap action. */\n static int\n-parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,\n+parse_vc_action_vxlan_encap(struct context *ctx, const struct token *token,\n \t\t\t    const char *str, unsigned int len,\n \t\t\t    void *buf, unsigned int size)\n {\n \tstruct buffer *out = buf;\n \tstruct rte_flow_action *action;\n-\tstruct action_nvgre_encap_data *action_nvgre_encap_data;\n+\tstruct action_vxlan_encap_data *action_vxlan_encap_data;\n \tint ret;\n \n \tret = parse_vc(ctx, token, str, len, buf, size);\n@@ -5399,8 +5381,20 @@ parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,\n \t/* Point to selected object. */\n \tctx->object = out->args.vc.data;\n \tctx->objmask = NULL;\n+\taction_vxlan_encap_data = ctx->object;\n+\tparse_setup_vxlan_encap_data(action_vxlan_encap_data);\n+\taction->conf = &action_vxlan_encap_data->conf;\n+\treturn ret;\n+}\n+\n+/** Setup NVGRE encap configuration. */\n+static int\n+parse_setup_nvgre_encap_data\n+\t\t(struct action_nvgre_encap_data *action_nvgre_encap_data)\n+{\n+\tif (!action_nvgre_encap_data)\n+\t\treturn -1;\n \t/* Set up default configuration. */\n-\taction_nvgre_encap_data = ctx->object;\n \t*action_nvgre_encap_data = (struct action_nvgre_encap_data){\n \t\t.conf = (struct rte_flow_action_nvgre_encap){\n \t\t\t.definition = action_nvgre_encap_data->items,\n@@ -5463,6 +5457,34 @@ parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,\n \t\t\tRTE_FLOW_ITEM_TYPE_VOID;\n \tmemcpy(action_nvgre_encap_data->item_nvgre.tni, nvgre_encap_conf.tni,\n \t       RTE_DIM(nvgre_encap_conf.tni));\n+\treturn 0;\n+}\n+\n+/** Parse NVGRE encap action. */\n+static int\n+parse_vc_action_nvgre_encap(struct context *ctx, const struct token *token,\n+\t\t\t    const char *str, unsigned int len,\n+\t\t\t    void *buf, unsigned int size)\n+{\n+\tstruct buffer *out = buf;\n+\tstruct rte_flow_action *action;\n+\tstruct action_nvgre_encap_data *action_nvgre_encap_data;\n+\tint ret;\n+\n+\tret = parse_vc(ctx, token, str, len, buf, size);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\t/* Nothing else to do if there is no buffer. */\n+\tif (!out)\n+\t\treturn ret;\n+\tif (!out->args.vc.actions_n)\n+\t\treturn -1;\n+\taction = &out->args.vc.actions[out->args.vc.actions_n - 1];\n+\t/* Point to selected object. */\n+\tctx->object = out->args.vc.data;\n+\tctx->objmask = NULL;\n+\taction_nvgre_encap_data = ctx->object;\n+\tparse_setup_nvgre_encap_data(action_nvgre_encap_data);\n \taction->conf = &action_nvgre_encap_data->conf;\n \treturn ret;\n }\n",
    "prefixes": [
        "v3",
        "1/8"
    ]
}