Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88996/?format=api
{ "id": 88996, "url": "http://patches.dpdk.org/api/patches/88996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210312093143.28186-1-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210312093143.28186-1-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210312093143.28186-1-ivan.malov@oktetlabs.ru", "date": "2021-03-12T09:31:34", "name": "[01/10] ethdev: reuse header definition in flow pattern item ETH", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e30f79d1120c17a18da09fe60e2721fb12d26666", "submitter": { "id": 869, "url": "http://patches.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210312093143.28186-1-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 15630, "url": "http://patches.dpdk.org/api/series/15630/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15630", "date": "2021-03-12T09:31:34", "name": "[01/10] ethdev: reuse header definition in flow pattern item ETH", "version": 1, "mbox": "http://patches.dpdk.org/series/15630/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88996/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/88996/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D30D7A0547;\n\tFri, 12 Mar 2021 10:31:50 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5D2A71607ED;\n\tFri, 12 Mar 2021 10:31:50 +0100 (CET)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 340E24067E\n for <dev@dpdk.org>; Fri, 12 Mar 2021 10:31:49 +0100 (CET)", "from localhost.localdomain (unknown [188.242.7.54])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C8BF07F530;\n Fri, 12 Mar 2021 12:31:48 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C8BF07F530", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1615541508;\n bh=lcLB1YnvdclFFkeJB0nSQzYMYyUi/Hj0+//nve4jL3w=;\n h=From:To:Cc:Subject:Date;\n b=WfRzMOu0JzNjcJp2urFGwyv2bH3eRbCxYOcHcQZerpXv4aO8fw4ucHSbplyA0gfC7\n k3dqUbe6jhVYEDNkfhIIlNf6R7zcqYMzDwU6bomW4NckVwg9/PejqTYx1XffV2brYr\n j+mhcRYvKEo4WohhBFXHr5px0Vb2zjydTJ2Meaq4=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>, Ori Kam <orika@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Fri, 12 Mar 2021 12:31:34 +0300", "Message-Id": "<20210312093143.28186-1-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/10] ethdev: reuse header definition in flow\n pattern item ETH", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "One ought to reuse existing header structs in flow items.\nThis particular item contains non-header fields, so it's\nimportant to keep the header fields in a separate struct.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n lib/librte_ethdev/rte_flow.h | 44 ++++++++++++++++++++++--------------\n 1 file changed, 27 insertions(+), 17 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h\nindex 669e677e9..96fd93ee1 100644\n--- a/lib/librte_ethdev/rte_flow.h\n+++ b/lib/librte_ethdev/rte_flow.h\n@@ -728,22 +728,32 @@ static const struct rte_flow_item_raw rte_flow_item_raw_mask = {\n *\n * Matches an Ethernet header.\n *\n- * The @p type field either stands for \"EtherType\" or \"TPID\" when followed\n- * by so-called layer 2.5 pattern items such as RTE_FLOW_ITEM_TYPE_VLAN. In\n- * the latter case, @p type refers to that of the outer header, with the\n- * inner EtherType/TPID provided by the subsequent pattern item. This is the\n- * same order as on the wire.\n- * If the @p type field contains a TPID value, then only tagged packets with the\n- * specified TPID will match the pattern.\n- * The field @p has_vlan can be used to match any type of tagged packets,\n- * instead of using the @p type field.\n- * If the @p type and @p has_vlan fields are not specified, then both tagged\n- * and untagged packets will match the pattern.\n+ * Inside @p hdr field, the sub-field @p ether_type stands either for EtherType\n+ * or TPID, depending on whether the item is followed by a VLAN item or not. If\n+ * two VLAN items follow, the sub-field refers to the outer one, which, in turn,\n+ * contains the inner TPID in the similar header field. The innermost VLAN item\n+ * contains a layer-3 EtherType. All of that follows the order seen on the wire.\n+ *\n+ * If the field in question contains a TPID value, only tagged packets with the\n+ * specified TPID will match the pattern. Alternatively, it's possible to match\n+ * any type of tagged packets by means of the field @p has_vlan rather than use\n+ * the EtherType/TPID field. Also, it's possible to leave the two fields unused.\n+ * If this is the case, both tagged and untagged packets will match the pattern.\n */\n+RTE_STD_C11\n struct rte_flow_item_eth {\n-\tstruct rte_ether_addr dst; /**< Destination MAC. */\n-\tstruct rte_ether_addr src; /**< Source MAC. */\n-\trte_be16_t type; /**< EtherType or TPID. */\n+\tunion {\n+\t\tstruct {\n+\t\t\t/*\n+\t\t\t * These fields are retained for compatibility.\n+\t\t\t * Please switch to the new header field below.\n+\t\t\t */\n+\t\t\tstruct rte_ether_addr dst; /**< Destination MAC. */\n+\t\t\tstruct rte_ether_addr src; /**< Source MAC. */\n+\t\t\trte_be16_t type; /**< EtherType or TPID. */\n+\t\t};\n+\t\tstruct rte_ether_hdr hdr;\n+\t};\n \tuint32_t has_vlan:1; /**< Packet header contains at least one VLAN. */\n \tuint32_t reserved:31; /**< Reserved, must be zero. */\n };\n@@ -751,9 +761,9 @@ struct rte_flow_item_eth {\n /** Default mask for RTE_FLOW_ITEM_TYPE_ETH. */\n #ifndef __cplusplus\n static const struct rte_flow_item_eth rte_flow_item_eth_mask = {\n-\t.dst.addr_bytes = \"\\xff\\xff\\xff\\xff\\xff\\xff\",\n-\t.src.addr_bytes = \"\\xff\\xff\\xff\\xff\\xff\\xff\",\n-\t.type = RTE_BE16(0x0000),\n+\t.hdr.d_addr.addr_bytes = \"\\xff\\xff\\xff\\xff\\xff\\xff\",\n+\t.hdr.s_addr.addr_bytes = \"\\xff\\xff\\xff\\xff\\xff\\xff\",\n+\t.hdr.ether_type = RTE_BE16(0x0000),\n };\n #endif\n \n", "prefixes": [ "01/10" ] }