Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88370/?format=api
{ "id": 88370, "url": "http://patches.dpdk.org/api/patches/88370/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210302114057.706-1-xuemingl@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210302114057.706-1-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210302114057.706-1-xuemingl@nvidia.com", "date": "2021-03-02T11:40:56", "name": "[v7,1/9] ethdev: introduce representor type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "40b02c0fca7bc9b243cf55a737ca62d8d94c6271", "submitter": { "id": 1904, "url": "http://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210302114057.706-1-xuemingl@nvidia.com/mbox/", "series": [ { "id": 15441, "url": "http://patches.dpdk.org/api/series/15441/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15441", "date": "2021-03-02T11:40:56", "name": "[v7,1/9] ethdev: introduce representor type", "version": 7, "mbox": "http://patches.dpdk.org/series/15441/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88370/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/88370/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82F34A054F;\n\tTue, 2 Mar 2021 12:41:13 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 62F4522A2AF;\n\tTue, 2 Mar 2021 12:41:13 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id A0EF222A2AE\n for <dev@dpdk.org>; Tue, 2 Mar 2021 12:41:12 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 2 Mar 2021 13:41:12 +0200", "from nvidia.com ([172.27.8.104])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 122Bf7M3005521;\n Tue, 2 Mar 2021 13:41:08 +0200" ], "From": "Xueming Li <xuemingl@nvidia.com>", "To": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Cc": "dev@dpdk.org, Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Hyong Youb Kim <hyonkim@cisco.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n John Daley <johndale@cisco.com>, Beilei Xing <beilei.xing@intel.com>,\n Jeff Guo <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>,\n Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Tue, 2 Mar 2021 19:40:56 +0800", "Message-Id": "<20210302114057.706-1-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<1608303356-13089-2-git-send-email-xuemingl@nvidia.com>", "References": "<1608303356-13089-2-git-send-email-xuemingl@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 1/9] ethdev: introduce representor type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To support more representor type, this patch introduces representor type\nenum. The enum is subject to be extended to support new representor in\npatches upcoming.\n\nFor each devarg structure, only one type supported.\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\nAcked-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nAcked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nAcked-by: Hyong Youb Kim <hyonkim@cisco.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 7 +++++++\n drivers/net/enic/enic_ethdev.c | 6 ++++++\n drivers/net/i40e/i40e_ethdev.c | 7 +++++++\n drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++++++\n drivers/net/mlx5/linux/mlx5_os.c | 11 +++++++++++\n lib/librte_ethdev/ethdev_driver.h | 7 ++++++-\n lib/librte_ethdev/ethdev_private.c | 5 +++++\n lib/librte_ethdev/rte_ethdev.h | 8 ++++++++\n 8 files changed, 57 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 22c880c5c3..1a276c9b9e 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -5618,6 +5618,13 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,\n \tint i, ret = 0;\n \tstruct rte_kvargs *kvlist = NULL;\n \n+\tif (eth_da->type == RTE_ETH_REPRESENTOR_NONE)\n+\t\treturn 0;\n+\tif (eth_da->type != RTE_ETH_REPRESENTOR_VF) {\n+\t\tPMD_DRV_LOG(ERR, \"unsupported representor type %d\\n\",\n+\t\t\t eth_da->type);\n+\t\treturn -ENOTSUP;\n+\t}\n \tnum_rep = eth_da->nb_representor_ports;\n \tif (num_rep > BNXT_MAX_VF_REPS) {\n \t\tPMD_DRV_LOG(ERR, \"nb_representor_ports = %d > %d MAX VF REPS\\n\",\ndiff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c\nindex b3f441c8f7..def669f411 100644\n--- a/drivers/net/enic/enic_ethdev.c\n+++ b/drivers/net/enic/enic_ethdev.c\n@@ -1312,6 +1312,12 @@ static int eth_enic_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\tif (retval)\n \t\t\treturn retval;\n \t}\n+\tif (eth_da.nb_representor_ports > 0 &&\n+\t eth_da.type != RTE_ETH_REPRESENTOR_VF) {\n+\t\tENICPMD_LOG(ERR, \"unsupported representor type: %s\\n\",\n+\t\t\t pci_dev->device.devargs->args);\n+\t\treturn -ENOTSUP;\n+\t}\n \tretval = rte_eth_dev_create(&pci_dev->device, pci_dev->device.name,\n \t\tsizeof(struct enic),\n \t\teth_dev_pci_specific_init, pci_dev,\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex d7cd049891..9b86bcdc69 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -639,6 +639,13 @@ eth_i40e_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\t\treturn retval;\n \t}\n \n+\tif (eth_da.nb_representor_ports > 0 &&\n+\t eth_da.type != RTE_ETH_REPRESENTOR_VF) {\n+\t\tPMD_DRV_LOG(ERR, \"unsupported representor type: %s\\n\",\n+\t\t\t pci_dev->device.devargs->args);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n \tretval = rte_eth_dev_create(&pci_dev->device, pci_dev->device.name,\n \t\tsizeof(struct i40e_adapter),\n \t\teth_dev_pci_specific_init, pci_dev,\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 761a0f26bb..8a9a21e7c2 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1718,6 +1718,13 @@ eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t} else\n \t\tmemset(ð_da, 0, sizeof(eth_da));\n \n+\tif (eth_da.nb_representor_ports > 0 &&\n+\t eth_da.type != RTE_ETH_REPRESENTOR_VF) {\n+\t\tPMD_DRV_LOG(ERR, \"unsupported representor type: %s\\n\",\n+\t\t\t pci_dev->device.devargs->args);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n \tretval = rte_eth_dev_create(&pci_dev->device, pci_dev->device.name,\n \t\tsizeof(struct ixgbe_adapter),\n \t\teth_dev_pci_specific_init, pci_dev,\ndiff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 2dc079779d..b041e1752d 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -704,6 +704,17 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \t\t\t\tstrerror(rte_errno));\n \t\t\treturn NULL;\n \t\t}\n+\t\tif (eth_da.type == RTE_ETH_REPRESENTOR_NONE) {\n+\t\t\t/* Representor not specified. */\n+\t\t\trte_errno = EBUSY;\n+\t\t\treturn NULL;\n+\t\t}\n+\t\tif (eth_da.type != RTE_ETH_REPRESENTOR_VF) {\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\tDRV_LOG(ERR, \"unsupported representor type: %s\",\n+\t\t\t\tdpdk_dev->devargs->args);\n+\t\t\treturn NULL;\n+\t\t}\n \t\tfor (i = 0; i < eth_da.nb_representor_ports; ++i)\n \t\t\tif (eth_da.representor_ports[i] ==\n \t\t\t (uint16_t)switch_info->port_name)\ndiff --git a/lib/librte_ethdev/ethdev_driver.h b/lib/librte_ethdev/ethdev_driver.h\nindex 57fdedaa1a..d68b8401e7 100644\n--- a/lib/librte_ethdev/ethdev_driver.h\n+++ b/lib/librte_ethdev/ethdev_driver.h\n@@ -1216,7 +1216,11 @@ __rte_internal\n int\n rte_eth_switch_domain_free(uint16_t domain_id);\n \n-/** Generic Ethernet device arguments */\n+/**\n+ * Generic Ethernet device arguments\n+ *\n+ * One type of representor each structure.\n+ */\n struct rte_eth_devargs {\n \tuint16_t ports[RTE_MAX_ETHPORTS];\n \t/** port/s number to enable on a multi-port single function */\n@@ -1226,6 +1230,7 @@ struct rte_eth_devargs {\n \t/** representor port/s identifier to enable on device */\n \tuint16_t nb_representor_ports;\n \t/** number of ports in representor port field */\n+\tenum rte_eth_representor_type type; /* type of representor */\n };\n \n /**\ndiff --git a/lib/librte_ethdev/ethdev_private.c b/lib/librte_ethdev/ethdev_private.c\nindex 5960c75cc5..2d51e3857a 100644\n--- a/lib/librte_ethdev/ethdev_private.c\n+++ b/lib/librte_ethdev/ethdev_private.c\n@@ -111,11 +111,16 @@ rte_eth_devargs_process_range(char *str, uint16_t *list, uint16_t *len_list,\n \treturn 0;\n }\n \n+/*\n+ * representor format:\n+ * #: range or single number of VF representor\n+ */\n int\n rte_eth_devargs_parse_representor_ports(char *str, void *data)\n {\n \tstruct rte_eth_devargs *eth_da = data;\n \n+\teth_da->type = RTE_ETH_REPRESENTOR_VF;\n \treturn rte_eth_devargs_process_range(str, eth_da->representor_ports,\n \t\tð_da->nb_representor_ports, RTE_MAX_ETHPORTS);\n }\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex 059a061072..1f378958ca 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -1506,6 +1506,14 @@ struct rte_eth_rxseg_capa {\n * Ethernet device information\n */\n \n+/**\n+ * Ethernet device representor port type.\n+ */\n+enum rte_eth_representor_type {\n+\tRTE_ETH_REPRESENTOR_NONE, /**< not a representor. */\n+\tRTE_ETH_REPRESENTOR_VF, /**< representor of Virtual Function. */\n+};\n+\n /**\n * A structure used to retrieve the contextual information of\n * an Ethernet device, such as the controlling driver of the\n", "prefixes": [ "v7", "1/9" ] }