Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88362/?format=api
{ "id": 88362, "url": "http://patches.dpdk.org/api/patches/88362/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210302072357.1657556-15-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210302072357.1657556-15-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210302072357.1657556-15-qi.z.zhang@intel.com", "date": "2021-03-02T07:23:57", "name": "[14/14] net/ice/base: cleanup fltr list in case of allocation issues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ac5537d98f89b9fb2651fd5205969307afeeb207", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210302072357.1657556-15-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 15435, "url": "http://patches.dpdk.org/api/series/15435/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15435", "date": "2021-03-02T07:23:43", "name": "ice: base code update", "version": 1, "mbox": "http://patches.dpdk.org/series/15435/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88362/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/88362/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89CBBA054F;\n\tTue, 2 Mar 2021 08:21:52 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EEE0222A28A;\n\tTue, 2 Mar 2021 08:20:51 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id DDEF022A283;\n Tue, 2 Mar 2021 08:20:50 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Mar 2021 23:20:50 -0800", "from dpdk51.sh.intel.com ([10.67.111.142])\n by fmsmga001.fm.intel.com with ESMTP; 01 Mar 2021 23:20:47 -0800" ], "IronPort-SDR": [ "\n l35t4zpy7Ea9gnygqeHa3BIHT8NYzVncM2497AV9XBjCSfGB+apI1eCu2prIhePtdDDCRU5/Y1\n u5X/pqI/OFtw==", "\n NShohdVZcdCZTFNPUVg7bZtUHhsA/WTJPZq68uruQaWusD1QzAZmf7W3oaQh+mPkK/Ckzg22e3\n jO2mPhD66tYQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9910\"; a=\"186775351\"", "E=Sophos;i=\"5.81,216,1610438400\"; d=\"scan'208\";a=\"186775351\"", "E=Sophos;i=\"5.81,216,1610438400\"; d=\"scan'208\";a=\"506230520\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "dev@dpdk.org, haiyue.wang@intel.com, junfeng.guo@intel.com,\n Qi Zhang <qi.z.zhang@intel.com>, stable@dpdk.org,\n Robert Malz <robertx.malz@intel.com>", "Date": "Tue, 2 Mar 2021 15:23:57 +0800", "Message-Id": "<20210302072357.1657556-15-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210302072357.1657556-1-qi.z.zhang@intel.com>", "References": "<20210302072357.1657556-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 14/14] net/ice/base: cleanup fltr list in case of\n allocation issues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When ice_remove_vsi_lkup_fltr is called, by calling\nice_add_to_vsi_fltr_list local copy of vsi filter list\nis created. If any issues during creation of vsi filter\nlist occurs it up for the caller to free already\nallocated memory. This patch ensures proper memory\ndeallocation in these cases.\n\nFixes: c7dd15931183 (\"net/ice/base: add virtual switch code\")\nCc: stable@dpdk.org\n\nSigned-off-by: Robert Malz <robertx.malz@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_switch.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 2d0dd4b28c..3dc764266b 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -6078,7 +6078,7 @@ ice_remove_vsi_lkup_fltr(struct ice_hw *hw, u16 vsi_handle,\n \t\t\t\t\t &remove_list_head);\n \tice_release_lock(rule_lock);\n \tif (status)\n-\t\treturn;\n+\t\tgoto free_fltr_list;\n \n \tswitch (lkup) {\n \tcase ICE_SW_LKUP_MAC:\n@@ -6106,6 +6106,7 @@ ice_remove_vsi_lkup_fltr(struct ice_hw *hw, u16 vsi_handle,\n \t\tbreak;\n \t}\n \n+free_fltr_list:\n \tLIST_FOR_EACH_ENTRY_SAFE(fm_entry, tmp, &remove_list_head,\n \t\t\t\t ice_fltr_list_entry, list_entry) {\n \t\tLIST_DEL(&fm_entry->list_entry);\n", "prefixes": [ "14/14" ] }