Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88313/?format=api
{ "id": 88313, "url": "http://patches.dpdk.org/api/patches/88313/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210301095644.1711-1-nick.connolly@mayadata.io/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210301095644.1711-1-nick.connolly@mayadata.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210301095644.1711-1-nick.connolly@mayadata.io", "date": "2021-03-01T09:56:44", "name": "[v7] bus/pci: nvme on Windows requires class id and bus", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "33c60835b148ba1d976c99352749deea8d062455", "submitter": { "id": 1861, "url": "http://patches.dpdk.org/api/people/1861/?format=api", "name": "Nick Connolly", "email": "nick.connolly@mayadata.io" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210301095644.1711-1-nick.connolly@mayadata.io/mbox/", "series": [ { "id": 15417, "url": "http://patches.dpdk.org/api/series/15417/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15417", "date": "2021-03-01T09:56:44", "name": "[v7] bus/pci: nvme on Windows requires class id and bus", "version": 7, "mbox": "http://patches.dpdk.org/series/15417/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88313/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/88313/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DADFEA054F;\n\tMon, 1 Mar 2021 10:57:01 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 63B3A4067B;\n\tMon, 1 Mar 2021 10:57:01 +0100 (CET)", "from mail-wr1-f50.google.com (mail-wr1-f50.google.com\n [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 033244014E\n for <dev@dpdk.org>; Mon, 1 Mar 2021 10:56:59 +0100 (CET)", "by mail-wr1-f50.google.com with SMTP id v15so15430670wrx.4\n for <dev@dpdk.org>; Mon, 01 Mar 2021 01:56:59 -0800 (PST)", "from FENIX.localdomain\n (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78])\n by smtp.gmail.com with ESMTPSA id c26sm24958659wrb.87.2021.03.01.01.56.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 01 Mar 2021 01:56:59 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=mayadata-io.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=bzfAJDiUn/ye+Hc5hTeebQrRF9B0ul+T6GVuoP3/DuQ=;\n b=UluRXSJTm7f4M/QyG82FYn4cS/fL7M8ZvVKnWmHWvVO+CtUtxwf5rFfMTP9sFiEpg5\n W4oDQ2QGdSpiKxFexnwhh6Jni8YIVIkhqBVdG/LfGWQ/j7COro4R3CFp6uUXk95gaHsB\n yPcSRemQRolhJriRtywdrdrAFATxMWDn15nT93n9P843KAKeSKE8/S2iKl3UlpmfYu1N\n OB/kYvXeLnfheIA3JK24ahAHBeQoQ1E27fGNeVBY7ZmbeS6OcU9HlEsUY6rdsLrl2RBl\n b+4AY5lbD/Nj2cbRHAcEIYHDbhcfREGwjdEvds1m4hqjbVCywkCgoXKm9HBuBSnqD4vC\n ldUw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=bzfAJDiUn/ye+Hc5hTeebQrRF9B0ul+T6GVuoP3/DuQ=;\n b=A4ZKDVILrUjMQmq70rl9gBq+PVVVzYAbKQ0IS2IZjt6tngzQl+6TXqVBGP0d3ZpwQw\n rqifUXNgZsSrwQ3TGZR0wOmc7griX92Rw+tavteaqjZ2di2iaUr9AjidV00TBYgAf1by\n 1L/LJP68eqlmxM35MWwEm/k1lmyNRD5V91ZVKmDrvu4hYIQ15ik5fSMQrfnuUktEH9ar\n P8UCqUTIgW5Jsas4MP3tghg9J+Hv5yKLZwQMpGUw8D96QE+Z0V/Buxxq5SxhAjb2Q1bu\n JnLQJjgr0MmV7uFUAmAVoaqrkYTwfNl3aZp9f2ufrbbC9SImijNFoeKI/D1d6cY6nj1V\n ChlQ==", "X-Gm-Message-State": "AOAM533OCpdg2k6SFNCSwLdMUKW/awE1qqxEKEldfzyFiJpYQ6npOfk0\n HGMnoEWDqdyftvCJPyNXZoUJ2g==", "X-Google-Smtp-Source": "\n ABdhPJx/FXZXapfEg8pb/edJimj3w9a5ltWWnmWkuohbZ78W6N0fspQGBvch6elmOqckp0X+A8rkZA==", "X-Received": "by 2002:adf:a418:: with SMTP id\n d24mr15753011wra.187.1614592619675;\n Mon, 01 Mar 2021 01:56:59 -0800 (PST)", "From": "Nick Connolly <nick.connolly@mayadata.io>", "To": "talshn@nvidia.com, dmitry.kozliuk@gmail.com, pallavi.kadam@intel.com,\n thomas@monjalon.net", "Cc": "dev@dpdk.org,\n\tNick Connolly <nick.connolly@mayadata.io>", "Date": "Mon, 1 Mar 2021 09:56:44 +0000", "Message-Id": "<20210301095644.1711-1-nick.connolly@mayadata.io>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210125170821.11306-1-nick.connolly@mayadata.io>", "References": "<20210125170821.11306-1-nick.connolly@mayadata.io>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7] bus/pci: nvme on Windows requires class id\n and bus", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Attaching to an NVMe disk on Windows using SPDK requires the\nPCI class ID and device.bus fields. Decode the class ID from the PCI\ndevice info strings if it is present and set device.bus.\n\nSigned-off-by: Nick Connolly <nick.connolly@mayadata.io>\nAcked-by: Tal Shnaiderman <talshn@nvidia.com>\nAcked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\nv7:\n* Improve comments as per review by Dmitry Kozlyuk\n\nv6:\n* no changes - resending to resolve spurious iol-testing failure\n\nv5:\n* Add missing version history\n\nv4:\n* Use #define to determine length of Class ID\n\nv3:\n* Put version history at top - v2 mistakenly had it after the diffs\n\nv2:\n* If only a 4-digit class ID is available, convert it to 6-digit format\n\n drivers/bus/pci/windows/pci.c | 24 +++++++++++++++++++++++-\n 1 file changed, 23 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c\nindex f66258452..bc173af2d 100644\n--- a/drivers/bus/pci/windows/pci.c\n+++ b/drivers/bus/pci/windows/pci.c\n@@ -23,6 +23,9 @@ DEFINE_DEVPROPKEY(DEVPKEY_Device_Numa_Node, 0x540b947e, 0x8b40, 0x45bc,\n * the registry hive for PCI devices.\n */\n \n+/* Class ID consists of hexadecimal digits */\n+#define RTE_PCI_DRV_CLASSID_DIGIT\t\"0123456789abcdefABCDEF\"\n+\n /* The functions below are not implemented on Windows,\n * but need to be defined for compilation purposes\n */\n@@ -274,23 +277,41 @@ get_pci_hardware_id(HDEVINFO dev_info, PSP_DEVINFO_DATA device_info_data,\n \n /*\n * parse the SPDRP_HARDWAREID output and assign to rte_pci_id\n+ *\n+ * A list of the device identification string formats can be found at:\n+ * https://docs.microsoft.com/en-us/windows-hardware/drivers/install/identifiers-for-pci-devices\n */\n static int\n parse_pci_hardware_id(const char *buf, struct rte_pci_id *pci_id)\n {\n \tint ids = 0;\n \tuint16_t vendor_id, device_id;\n-\tuint32_t subvendor_id = 0;\n+\tuint32_t subvendor_id = 0, class_id = 0;\n+\tconst char *cp;\n \n \tids = sscanf_s(buf, \"PCI\\\\VEN_%\" PRIx16 \"&DEV_%\" PRIx16 \"&SUBSYS_%\"\n \t\tPRIx32, &vendor_id, &device_id, &subvendor_id);\n \tif (ids != 3)\n \t\treturn -1;\n \n+\t/* Try and find PCI class ID */\n+\tfor (cp = buf; !(cp[0] == 0 && cp[1] == 0); cp++)\n+\t\tif (*cp == '&' && sscanf_s(cp,\n+\t\t\t\t\"&CC_%\" PRIx32, &class_id) == 1) {\n+\t\t\t/*\n+\t\t\t * If the Programming Interface code is not specified,\n+\t\t\t * assume that it is zero.\n+\t\t\t */\n+\t\t\tif (strspn(cp + 4, RTE_PCI_DRV_CLASSID_DIGIT) == 4)\n+\t\t\t\tclass_id <<= 8;\n+\t\t\tbreak;\n+\t\t}\n+\n \tpci_id->vendor_id = vendor_id;\n \tpci_id->device_id = device_id;\n \tpci_id->subsystem_device_id = subvendor_id >> 16;\n \tpci_id->subsystem_vendor_id = subvendor_id & 0xffff;\n+\tpci_id->class_id = class_id;\n \treturn 0;\n }\n \n@@ -339,6 +360,7 @@ pci_scan_one(HDEVINFO dev_info, PSP_DEVINFO_DATA device_info_data)\n \tif (ret != 0)\n \t\tgoto end;\n \n+\tdev->device.bus = &rte_pci_bus.bus;\n \tdev->addr = addr;\n \tdev->id = pci_id;\n \tdev->max_vfs = 0; /* TODO: get max_vfs */\n", "prefixes": [ "v7" ] }