Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88003/?format=api
{ "id": 88003, "url": "http://patches.dpdk.org/api/patches/88003/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210219092803.12756-1-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210219092803.12756-1-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210219092803.12756-1-somnath.kotur@broadcom.com", "date": "2021-02-19T09:28:03", "name": "net/bnxt: refactor HWRM rings allocation routine", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d83adaa2a793394965933ddffb89486c1d1759ac", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210219092803.12756-1-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 15300, "url": "http://patches.dpdk.org/api/series/15300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15300", "date": "2021-02-19T09:28:03", "name": "net/bnxt: refactor HWRM rings allocation routine", "version": 1, "mbox": "http://patches.dpdk.org/series/15300/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88003/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/88003/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2654A054A;\n\tFri, 19 Feb 2021 10:28:12 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5B60240395;\n\tFri, 19 Feb 2021 10:28:12 +0100 (CET)", "from relay.smtp-ext.broadcom.com (lpdvacalvio01.broadcom.com\n [192.19.229.182])\n by mails.dpdk.org (Postfix) with ESMTP id 093F940042\n for <dev@dpdk.org>; Fri, 19 Feb 2021 10:28:10 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id E96C92E5F1;\n Fri, 19 Feb 2021 01:28:07 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com E96C92E5F1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1613726889;\n bh=A4kCuSNIJQcRngSPizw99xSjdY0TD96PJdDTtwYqMNw=;\n h=From:To:Cc:Subject:Date:From;\n b=ayP1dwFfkNRJ55Ck1MCkORksifHMvbkMBSufaUBxxKTXh/PDVRkp7ijuvDb416q93\n dorEwZzE68M3iMJbBqaeX2adWOvDxRXR/5L81upprSnW8R4UhyRp6Os9uoSrleOSJh\n rgN0vHQxFzSSrQKUPznDdYinxImFNwfNoRLFKUvM=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Fri, 19 Feb 2021 14:58:03 +0530", "Message-Id": "<20210219092803.12756-1-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.28.0.450.g3a238e5", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/bnxt: refactor HWRM rings allocation routine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "bnxt_alloc_hwrm_rings() was duplicating a snippet of code that was\nalready present in bnxt_alloc_hwrm_rx_ring() with just one line/function\ninvocation missing. Add that line and replace the snippet of code\nwith a call to bnxt_hwrm_alloc_rx_ring\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ring.c | 59 ++++--------------------------------\n 1 file changed, 6 insertions(+), 53 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex ba23c1fa03..997dcdc28b 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -581,6 +581,7 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index)\n \tstruct bnxt_cp_ring_info *cpr = rxq->cp_ring;\n \tstruct bnxt_ring *cp_ring = cpr->cp_ring_struct;\n \tstruct bnxt_rx_ring_info *rxr = rxq->rx_ring;\n+\tstruct bnxt_coal coal;\n \tint rc;\n \n \t/*\n@@ -603,6 +604,9 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index)\n \t\tbp->grp_info[queue_index].cp_fw_ring_id = cp_ring->fw_ring_id;\n \t}\n \n+\tbnxt_init_dflt_coal(&coal);\n+\tbnxt_hwrm_set_ring_coal(bp, &coal, cp_ring->fw_ring_id);\n+\n \tif (!BNXT_NUM_ASYNC_CPR(bp) && !queue_index) {\n \t\t/*\n \t\t * If a dedicated async event completion ring is not enabled,\n@@ -699,60 +703,9 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp)\n \tbnxt_init_all_rings(bp);\n \n \tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n-\t\tstruct bnxt_rx_queue *rxq = bp->rx_queues[i];\n-\t\tstruct bnxt_cp_ring_info *cpr = rxq->cp_ring;\n-\t\tstruct bnxt_ring *cp_ring = cpr->cp_ring_struct;\n-\t\tstruct bnxt_rx_ring_info *rxr = rxq->rx_ring;\n-\n-\t\t/*\n-\t\t * Storage for the cp ring is allocated based on worst-case\n-\t\t * usage, the actual size to be used by hw is computed here.\n-\t\t */\n-\t\tcp_ring->ring_size = rxr->rx_ring_struct->ring_size * 2;\n-\n-\t\tif (bp->eth_dev->data->scattered_rx)\n-\t\t\tcp_ring->ring_size *= AGG_RING_SIZE_FACTOR;\n-\n-\t\tcp_ring->ring_mask = cp_ring->ring_size - 1;\n-\n-\t\tif (bnxt_alloc_cmpl_ring(bp, i, cpr))\n-\t\t\tgoto err_out;\n-\n-\t\tif (BNXT_HAS_RING_GRPS(bp)) {\n-\t\t\tbp->grp_info[i].fw_stats_ctx = cpr->hw_stats_ctx_id;\n-\t\t\tbp->grp_info[i].cp_fw_ring_id = cp_ring->fw_ring_id;\n-\t\t}\n-\n-\t\tbnxt_hwrm_set_ring_coal(bp, &coal, cp_ring->fw_ring_id);\n-\t\tif (!BNXT_NUM_ASYNC_CPR(bp) && !i) {\n-\t\t\t/*\n-\t\t\t * If a dedicated async event completion ring is not\n-\t\t\t * enabled, use the first completion ring as the default\n-\t\t\t * completion ring for async event handling.\n-\t\t\t */\n-\t\t\tbp->async_cp_ring = cpr;\n-\t\t\trc = bnxt_hwrm_set_async_event_cr(bp);\n-\t\t\tif (rc)\n-\t\t\t\tgoto err_out;\n-\t\t}\n-\n-\t\tif (bnxt_alloc_rx_ring(bp, i))\n-\t\t\tgoto err_out;\n-\n-\t\tif (bnxt_alloc_rx_agg_ring(bp, i))\n+\t\trc = bnxt_alloc_hwrm_rx_ring(bp, i);\n+\t\tif (rc)\n \t\t\tgoto err_out;\n-\n-\t\tif (bnxt_init_one_rx_ring(rxq)) {\n-\t\t\tPMD_DRV_LOG(ERR, \"bnxt_init_one_rx_ring failed!\\n\");\n-\t\t\tbnxt_rx_queue_release_op(rxq);\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\t\tbnxt_db_write(&rxr->rx_db, rxr->rx_raw_prod);\n-\t\tbnxt_db_write(&rxr->ag_db, rxr->ag_raw_prod);\n-\t\trxq->index = i;\n-#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n-\t\tbnxt_rxq_vec_setup(rxq);\n-#endif\n \t}\n \n \tfor (i = 0; i < bp->tx_cp_nr_rings; i++) {\n", "prefixes": [] }