Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 87770,
    "url": "http://patches.dpdk.org/api/patches/87770/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210204203710.34690-1-aboyer@pensando.io/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210204203710.34690-1-aboyer@pensando.io>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210204203710.34690-1-aboyer@pensando.io",
    "date": "2021-02-04T20:37:10",
    "name": "net/ionic: fix Tx fragment limits",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2d0dddb1eaba12a7ee65499b3dc34d1a10c0ced5",
    "submitter": {
        "id": 2036,
        "url": "http://patches.dpdk.org/api/people/2036/?format=api",
        "name": "Andrew Boyer",
        "email": "aboyer@pensando.io"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210204203710.34690-1-aboyer@pensando.io/mbox/",
    "series": [
        {
            "id": 15177,
            "url": "http://patches.dpdk.org/api/series/15177/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15177",
            "date": "2021-02-04T20:37:10",
            "name": "net/ionic: fix Tx fragment limits",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/15177/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/87770/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/87770/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A0838A0524;\n\tThu,  4 Feb 2021 21:37:22 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1696E2407EC;\n\tThu,  4 Feb 2021 21:37:22 +0100 (CET)",
            "from mail-pj1-f54.google.com (mail-pj1-f54.google.com\n [209.85.216.54])\n by mails.dpdk.org (Postfix) with ESMTP id 693032407D2\n for <dev@dpdk.org>; Thu,  4 Feb 2021 21:37:21 +0100 (CET)",
            "by mail-pj1-f54.google.com with SMTP id q72so2377299pjq.2\n for <dev@dpdk.org>; Thu, 04 Feb 2021 12:37:21 -0800 (PST)",
            "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id v23sm5122463pgo.43.2021.02.04.12.37.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 04 Feb 2021 12:37:19 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id;\n bh=6odNgLQH8OqGUY4b5+7Kfa0lvdJRWefguC+jClJuF1o=;\n b=i0ieYfU1mzmLpyvIh0yXak/D02eNHf+kv4yDX6fgqCY2dNy2HGCm4GwZX6eIL55qxg\n Ys8JLbZu/fgpc+u9gETzDEhXUfOmZu3NDq6kGvQ7U5BGBWjTHT8Bh5/6vuQAokFwf2RY\n +N9qeoNC+ElRi/pXquyJx/t2NlgyVcayEnWkSaukb6t9xLY6wrDXftE82VNy4IOLrxQU\n TmBWgd/kWp9eeu9KCHOiPnQnJ1e0fA0arX3rU9sp4OJqSdJdkc51YXLAaQiTjUDgE7aZ\n W5vd9Rt2aNvcE9q6t/nqJvBTXrLAqd6Ve+cFyXackB0ETXORZr8DAIIs4FH9cuQa8xVM\n m1wQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=6odNgLQH8OqGUY4b5+7Kfa0lvdJRWefguC+jClJuF1o=;\n b=nC+GjFd8FXJxt7mlAGSO2Eb8x5Jfk1HEcdeDLAXP5m48E30PtoX6Ch2hQbvnC7wWg1\n AdMEK2oGAvlv6iNHxXaCDIYIoKzSiOLy+7FRZOYLGpCkHkWL5zzHewv1VYHM13s96Nsp\n OVjo1EmbYsRd+Pekz6miaujZ3x50YERlwVXSRtEgflhMI/kudCdkJEYH3hPshi+WaGPu\n 3jKyt+hP2cVl/6mF0IyNu8lLiZdESPyGl8semShx5Y8E3bwdRirKi8eIonApg88jxAY4\n wjx3xoLSP1S+T3/x4AzoE2TNi0ssuPDVPchCQNjq1zq4DhEQpkus+EDhKSHKrnfR5NsX\n IPSA==",
        "X-Gm-Message-State": "AOAM533FuKKLhpQFIky4wAEqU/JfUajzCwYnS7qCT10oAOvcQqWVZnmd\n pUftPyHqR8/dnZ9fnbkJgL8bepKYwhw+BQ==",
        "X-Google-Smtp-Source": "\n ABdhPJwcXUBDqr381MlO3dIEzMjGMd/d5zcgF6TXFX+mSYMr4x3HZvg8o8IEZ0uIA1Lih80CDPra4A==",
        "X-Received": "by 2002:a17:90b:1996:: with SMTP id\n mv22mr712040pjb.121.1612471040414;\n Thu, 04 Feb 2021 12:37:20 -0800 (PST)",
        "From": "Andrew Boyer <aboyer@pensando.io>",
        "To": "dev@dpdk.org",
        "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>",
        "Date": "Thu,  4 Feb 2021 12:37:10 -0800",
        "Message-Id": "<20210204203710.34690-1-aboyer@pensando.io>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] net/ionic: fix Tx fragment limits",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The reported nb_seg_max should include the main fragment in the\ndescriptor and the fragments in the accompanying SGL.\n\nUpdate the Tx prep check as well.\n\nThese were missed when updating to the v1 Tx queue structures.\n\nFixes: 786c64763b50 (\"net/ionic: clean up Tx queue version support\")\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_ethdev.c | 4 ++--\n drivers/net/ionic/ionic_rxtx.c   | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex c9d8493f49..cffe899c07 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -74,8 +74,8 @@ static const struct rte_eth_desc_lim tx_desc_lim_v1 = {\n \t.nb_max = IONIC_MAX_RING_DESC,\n \t.nb_min = IONIC_MIN_RING_DESC,\n \t.nb_align = 1,\n-\t.nb_seg_max = IONIC_TX_MAX_SG_ELEMS_V1,\n-\t.nb_mtu_seg_max = IONIC_TX_MAX_SG_ELEMS_V1,\n+\t.nb_seg_max = IONIC_TX_MAX_SG_ELEMS_V1 + 1,\n+\t.nb_mtu_seg_max = IONIC_TX_MAX_SG_ELEMS_V1 + 1,\n };\n \n static const struct eth_dev_ops ionic_eth_dev_ops = {\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 5ae9ecf400..99920109eb 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -596,7 +596,7 @@ ionic_prep_pkts(void *tx_queue __rte_unused, struct rte_mbuf **tx_pkts,\n \tfor (i = 0; i < nb_pkts; i++) {\n \t\ttxm = tx_pkts[i];\n \n-\t\tif (txm->nb_segs > IONIC_TX_MAX_SG_ELEMS) {\n+\t\tif (txm->nb_segs > IONIC_TX_MAX_SG_ELEMS_V1 + 1) {\n \t\t\trte_errno = -EINVAL;\n \t\t\tbreak;\n \t\t}\n",
    "prefixes": []
}