Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87664/?format=api
{ "id": 87664, "url": "http://patches.dpdk.org/api/patches/87664/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1612338382-3253-8-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1612338382-3253-8-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1612338382-3253-8-git-send-email-oulijun@huawei.com", "date": "2021-02-03T07:46:12", "name": "[07/17] net/hns3: encapsulate a port shaping interface", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "41ee0c77c9239a82e4e6593756c9d1c6f4a9029d", "submitter": { "id": 1675, "url": "http://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1612338382-3253-8-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 15115, "url": "http://patches.dpdk.org/api/series/15115/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15115", "date": "2021-02-03T07:46:05", "name": "bugfixes and small functionality for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/15115/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87664/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87664/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 28786A0A0E;\n\tWed, 3 Feb 2021 08:48:48 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 187D92404A3;\n\tWed, 3 Feb 2021 08:47:09 +0100 (CET)", "from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by mails.dpdk.org (Postfix) with ESMTP id 4F5E5240455\n for <dev@dpdk.org>; Wed, 3 Feb 2021 08:46:57 +0100 (CET)", "from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DVtym0ZwhzjHbP;\n Wed, 3 Feb 2021 15:45:52 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id\n 14.3.498.0; Wed, 3 Feb 2021 15:46:49 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@openeuler.org>", "Date": "Wed, 3 Feb 2021 15:46:12 +0800", "Message-ID": "<1612338382-3253-8-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1612338382-3253-1-git-send-email-oulijun@huawei.com>", "References": "<1612338382-3253-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 07/17] net/hns3: encapsulate a port shaping\n interface", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nWhen rate of port changes, the rate limit of the port needs to\nbe updated. So it is necessary to encapsulate an interface that\nconfigures the rate limit based on the rate.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_dcb.c | 22 +++++++++++++++++-----\n drivers/net/hns3/hns3_dcb.h | 2 +-\n drivers/net/hns3/hns3_ethdev.c | 10 +++-------\n 3 files changed, 21 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3/hns3_dcb.c\nindex 5aa374c..4fe5956 100644\n--- a/drivers/net/hns3/hns3_dcb.c\n+++ b/drivers/net/hns3/hns3_dcb.c\n@@ -330,8 +330,8 @@ hns3_dcb_get_shapping_para(uint8_t ir_b, uint8_t ir_u, uint8_t ir_s,\n \treturn shapping_para;\n }\n \n-int\n-hns3_dcb_port_shaper_cfg(struct hns3_hw *hw)\n+static int\n+hns3_dcb_port_shaper_cfg(struct hns3_hw *hw, uint32_t speed)\n {\n \tstruct hns3_port_shapping_cmd *shap_cfg_cmd;\n \tstruct hns3_shaper_parameter shaper_parameter;\n@@ -340,7 +340,7 @@ hns3_dcb_port_shaper_cfg(struct hns3_hw *hw)\n \tstruct hns3_cmd_desc desc;\n \tint ret;\n \n-\tret = hns3_shaper_para_calc(hw, hw->mac.link_speed,\n+\tret = hns3_shaper_para_calc(hw, speed,\n \t\t\t\t HNS3_SHAPER_LVL_PORT, &shaper_parameter);\n \tif (ret) {\n \t\thns3_err(hw, \"calculate shaper parameter failed: %d\", ret);\n@@ -366,12 +366,24 @@ hns3_dcb_port_shaper_cfg(struct hns3_hw *hw)\n \t * depends on the firmware version. But driver still needs to\n \t * calculate it and configure to firmware for better compatibility.\n \t */\n-\tshap_cfg_cmd->port_rate = rte_cpu_to_le_32(hw->mac.link_speed);\n+\tshap_cfg_cmd->port_rate = rte_cpu_to_le_32(speed);\n \thns3_set_bit(shap_cfg_cmd->flag, HNS3_TM_RATE_VLD_B, 1);\n \n \treturn hns3_cmd_send(hw, &desc, 1);\n }\n \n+int\n+hns3_port_shaper_update(struct hns3_hw *hw, uint32_t speed)\n+{\n+\tint ret;\n+\n+\tret = hns3_dcb_port_shaper_cfg(hw, speed);\n+\tif (ret)\n+\t\thns3_err(hw, \"configure port shappering failed: ret = %d\", ret);\n+\n+\treturn ret;\n+}\n+\n static int\n hns3_dcb_pg_shapping_cfg(struct hns3_hw *hw, enum hns3_shap_bucket bucket,\n \t\t\t uint8_t pg_id, uint32_t shapping_para, uint32_t rate)\n@@ -961,7 +973,7 @@ hns3_dcb_shaper_cfg(struct hns3_hw *hw)\n {\n \tint ret;\n \n-\tret = hns3_dcb_port_shaper_cfg(hw);\n+\tret = hns3_dcb_port_shaper_cfg(hw, hw->mac.link_speed);\n \tif (ret) {\n \t\thns3_err(hw, \"config port shaper failed: %d\", ret);\n \t\treturn ret;\ndiff --git a/drivers/net/hns3/hns3_dcb.h b/drivers/net/hns3/hns3_dcb.h\nindex 8248434..0d25d3b 100644\n--- a/drivers/net/hns3/hns3_dcb.h\n+++ b/drivers/net/hns3/hns3_dcb.h\n@@ -208,7 +208,7 @@ int hns3_queue_to_tc_mapping(struct hns3_hw *hw, uint16_t nb_rx_q,\n \t\t\t uint16_t nb_tx_q);\n \n int hns3_dcb_cfg_update(struct hns3_adapter *hns);\n-int hns3_dcb_port_shaper_cfg(struct hns3_hw *hw);\n+int hns3_port_shaper_update(struct hns3_hw *hw, uint32_t speed);\n int hns3_pg_shaper_rate_cfg(struct hns3_hw *hw, uint8_t pg_id, uint32_t rate);\n int hns3_pri_shaper_rate_cfg(struct hns3_hw *hw, uint8_t tc_no, uint32_t rate);\n uint8_t hns3_txq_mapped_tc_get(struct hns3_hw *hw, uint16_t txq_no);\ndiff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 3706e05..cf7d0aa 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -4363,7 +4363,6 @@ static int\n hns3_cfg_mac_speed_dup(struct hns3_hw *hw, uint32_t speed, uint8_t duplex)\n {\n \tstruct hns3_mac *mac = &hw->mac;\n-\tuint32_t cur_speed = mac->link_speed;\n \tint ret;\n \n \tduplex = hns3_check_speed_dup(duplex, speed);\n@@ -4374,14 +4373,11 @@ hns3_cfg_mac_speed_dup(struct hns3_hw *hw, uint32_t speed, uint8_t duplex)\n \tif (ret)\n \t\treturn ret;\n \n-\tmac->link_speed = speed;\n-\tret = hns3_dcb_port_shaper_cfg(hw);\n-\tif (ret) {\n-\t\thns3_err(hw, \"failed to configure port shaper, ret = %d.\", ret);\n-\t\tmac->link_speed = cur_speed;\n+\tret = hns3_port_shaper_update(hw, speed);\n+\tif (ret)\n \t\treturn ret;\n-\t}\n \n+\tmac->link_speed = speed;\n \tmac->link_duplex = duplex;\n \n \treturn 0;\n", "prefixes": [ "07/17" ] }