Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87555/?format=api
{ "id": 87555, "url": "http://patches.dpdk.org/api/patches/87555/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210129164823.3205861-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210129164823.3205861-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210129164823.3205861-3-bruce.richardson@intel.com", "date": "2021-01-29T16:48:16", "name": "[v7,02/10] eal: fix error attribute use for clang", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ff70b43602ad7d4d23fc6f0da5ea5006cf41361e", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210129164823.3205861-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 15035, "url": "http://patches.dpdk.org/api/series/15035/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15035", "date": "2021-01-29T16:48:14", "name": "add checking of header includes", "version": 7, "mbox": "http://patches.dpdk.org/series/15035/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87555/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/87555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 29503A09E4;\n\tFri, 29 Jan 2021 17:48:54 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 56DD640696;\n\tFri, 29 Jan 2021 17:48:42 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 5B18C4068C;\n Fri, 29 Jan 2021 17:48:36 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Jan 2021 08:48:35 -0800", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by orsmga002.jf.intel.com with ESMTP; 29 Jan 2021 08:48:34 -0800" ], "IronPort-SDR": [ "\n QUgC1FMs/qsxecJtfhNlWJLDEkNlafpK/H3NB47pcsuIhwOfhH3wsFIwtQpZCHq8geMW1lYIQq\n M+VGk0G4pNlA==", "\n G7bQRLykbyFAlbLFKYfGGCBLUA7dRxVISRkkwhwm4Uqcwpl+oNGTRhBPHbrM1UH2snBMT682VZ\n vbu0f5h3yryw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9879\"; a=\"179671264\"", "E=Sophos;i=\"5.79,386,1602572400\"; d=\"scan'208\";a=\"179671264\"", "E=Sophos;i=\"5.79,386,1602572400\"; d=\"scan'208\";a=\"370431288\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>,\n stable@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>, Haiyue Wang <haiyue.wang@intel.com>", "Date": "Fri, 29 Jan 2021 16:48:16 +0000", "Message-Id": "<20210129164823.3205861-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210129164823.3205861-1-bruce.richardson@intel.com>", "References": "<20210114110606.21142-1-bruce.richardson@intel.com>\n <20210129164823.3205861-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 02/10] eal: fix error attribute use for clang", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Clang does not have an \"error\" attribute for functions, so for marking\ninternal functions we need to check for the error attribute, and provide\na fallback if it is not present. For clang, we can use \"diagnose_if\"\nattribute, similarly checking for its presence before use.\n\nFixes: fba5af82adc8 (\"eal: add internal ABI tag definition\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_eal/include/rte_compat.h | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)\n\n--\n2.27.0", "diff": "diff --git a/lib/librte_eal/include/rte_compat.h b/lib/librte_eal/include/rte_compat.h\nindex 4cd8f68d68..2718612cce 100644\n--- a/lib/librte_eal/include/rte_compat.h\n+++ b/lib/librte_eal/include/rte_compat.h\n@@ -19,12 +19,23 @@ __attribute__((section(\".text.experimental\")))\n\n #endif\n\n-#ifndef ALLOW_INTERNAL_API\n+#ifndef __has_attribute\n+/* if no has_attribute assume no support for attribute too */\n+#define __has_attribute(x) 0\n+#endif\n+\n+#if !defined ALLOW_INTERNAL_API && __has_attribute(error) /* For GCC */\n\n #define __rte_internal \\\n __attribute__((error(\"Symbol is not public ABI\"), \\\n section(\".text.internal\")))\n\n+#elif !defined ALLOW_INTERNAL_API && __has_attribute(diagnose_if) /* For clang */\n+\n+#define __rte_internal \\\n+__attribute__((diagnose_if(1, \"Symbol is not public ABI\", \"error\"), \\\n+section(\".text.internal\")))\n+\n #else\n\n #define __rte_internal \\\n", "prefixes": [ "v7", "02/10" ] }