Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85479/?format=api
{ "id": 85479, "url": "http://patches.dpdk.org/api/patches/85479/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1608304614-13908-4-git-send-email-xuemingl@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1608304614-13908-4-git-send-email-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1608304614-13908-4-git-send-email-xuemingl@nvidia.com", "date": "2020-12-18T15:16:48", "name": "[RFC,3/9] devargs: fix memory leak in legacy parser", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "481cc96855b19857eb9e8fba167271875626980c", "submitter": { "id": 1904, "url": "http://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1608304614-13908-4-git-send-email-xuemingl@nvidia.com/mbox/", "series": [ { "id": 14378, "url": "http://patches.dpdk.org/api/series/14378/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14378", "date": "2020-12-18T15:16:52", "name": "support global syntax", "version": 1, "mbox": "http://patches.dpdk.org/series/14378/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/85479/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/85479/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F1AFCA09FD;\n\tFri, 18 Dec 2020 16:20:16 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3EF40CC43;\n\tFri, 18 Dec 2020 16:17:25 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 5D7BFCB12\n for <dev@dpdk.org>; Fri, 18 Dec 2020 16:17:10 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 18 Dec 2020 17:17:04 +0200", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BIFH4qb010856;\n Fri, 18 Dec 2020 17:17:04 +0200" ], "From": "Xueming Li <xuemingl@nvidia.com>", "To": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Olivier Matz <olivier.matz@6wind.com>, Matan Azrad <matan@nvidia.com>", "Cc": "dev@dpdk.org, xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>,\n gaetan.rivet@6wind.com, stable@dpdk.org", "Date": "Fri, 18 Dec 2020 15:16:48 +0000", "Message-Id": "<1608304614-13908-4-git-send-email-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1608304614-13908-1-git-send-email-xuemingl@nvidia.com>", "References": "<1608304614-13908-1-git-send-email-xuemingl@nvidia.com>", "Subject": "[dpdk-dev] [RFC 3/9] devargs: fix memory leak in legacy parser", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Data field was designed as parser buffer, will be released once in\nreleasing struct memory. The duplicated device arguments was not saved\nto data and this caused memory leak.\n\nThis patch fixes this leak by saving to new allocated memory to data\nfield.\n\nFixes: 4969f5914c9e (\"devargs: introduce new parsing helper\")\nCc: gaetan.rivet@6wind.com\nCc: stable@dpdk.org\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n lib/librte_eal/common/eal_common_devargs.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex f36f71fbce..3c4774c88a 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -224,13 +224,14 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)\n \tda->bus = bus;\n \t/* Parse eventual device arguments */\n \tif (devname[i] == ',')\n-\t\tda->args = strdup(&devname[i + 1]);\n+\t\tda->data = strdup(&devname[i + 1]);\n \telse\n-\t\tda->args = strdup(\"\");\n-\tif (da->args == NULL) {\n+\t\tda->data = strdup(\"\");\n+\tif (da->data == NULL) {\n \t\tRTE_LOG(ERR, EAL, \"not enough memory to parse arguments\\n\");\n \t\treturn -ENOMEM;\n \t}\n+\tda->args = da->data;\n \treturn 0;\n }\n \n", "prefixes": [ "RFC", "3/9" ] }