Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85173/?format=api
{ "id": 85173, "url": "http://patches.dpdk.org/api/patches/85173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201215060519.302145-17-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201215060519.302145-17-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201215060519.302145-17-qi.z.zhang@intel.com", "date": "2020-12-15T06:05:08", "name": "[16/27] net/ice/base: fix incorrect tunnel destroy", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c0e515ff9cd0e0e02722f86a4cb549476b30cd78", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201215060519.302145-17-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 14300, "url": "http://patches.dpdk.org/api/series/14300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14300", "date": "2020-12-15T06:04:52", "name": "ice base code update", "version": 1, "mbox": "http://patches.dpdk.org/series/14300/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/85173/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/85173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B134DA09E9;\n\tTue, 15 Dec 2020 07:07:19 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 237D4CA4E;\n\tTue, 15 Dec 2020 07:01:56 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 50AADCA36\n for <dev@dpdk.org>; Tue, 15 Dec 2020 07:01:52 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Dec 2020 22:01:51 -0800", "from dpdk51.sh.intel.com ([10.67.111.142])\n by orsmga002.jf.intel.com with ESMTP; 14 Dec 2020 22:01:50 -0800" ], "IronPort-SDR": [ "\n 1iNdYhwtsds5MME9rApG0O9Vota1BPoT4RuYT1tkzkQN7fYj3USviuszb0qLX+aDAW5CYJ8257\n lYCYhzr++ixQ==", "\n HqxTYMm5D7DIdlHiYSdJPcDW5Aw0PkyPiPxKiKaZJoYF0+J+jeMerCyFC1B/0IimmctTjesNpU\n CH4/aZEWhG/Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9835\"; a=\"193200283\"", "E=Sophos;i=\"5.78,420,1599548400\"; d=\"scan'208\";a=\"193200283\"", "E=Sophos;i=\"5.78,420,1599548400\"; d=\"scan'208\";a=\"351723598\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>, stable@dpdkr.org,\n Xiao Zhang <xiao.zhang@intel.com>", "Date": "Tue, 15 Dec 2020 14:05:08 +0800", "Message-Id": "<20201215060519.302145-17-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20201215060519.302145-1-qi.z.zhang@intel.com>", "References": "<20201215060519.302145-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 16/27] net/ice/base: fix incorrect tunnel destroy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The tcam information in AQ command buffer is not correct when destroy\ntunnel entries. The tcam count was always ONE even destroy multiple\nentries, and the offset of tcam memory was also incorrect. This patch is\nto fix this issue.\n\nFixes: 884efe3ca1f3 (\"net/ice/base: add VXLAN/generic tunnel management\")\nCc: stable@dpdkr.org\n\nSigned-off-by: Xiao Zhang <xiao.zhang@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 0812135cf5..6c7f83899d 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -2163,7 +2163,7 @@ enum ice_status ice_destroy_tunnel(struct ice_hw *hw, u16 port, bool all)\n \tu16 count = 0;\n \tu16 index;\n \tu16 size;\n-\tu16 i;\n+\tu16 i, j;\n \n \tice_acquire_lock(&hw->tnl_lock);\n \n@@ -2203,30 +2203,31 @@ enum ice_status ice_destroy_tunnel(struct ice_hw *hw, u16 port, bool all)\n \t\t\t\t\t size);\n \tif (!sect_rx)\n \t\tgoto ice_destroy_tunnel_err;\n-\tsect_rx->count = CPU_TO_LE16(1);\n+\tsect_rx->count = CPU_TO_LE16(count);\n \n \tsect_tx = (struct ice_boost_tcam_section *)\n \t\tice_pkg_buf_alloc_section(bld, ICE_SID_TXPARSER_BOOST_TCAM,\n \t\t\t\t\t size);\n \tif (!sect_tx)\n \t\tgoto ice_destroy_tunnel_err;\n-\tsect_tx->count = CPU_TO_LE16(1);\n+\tsect_tx->count = CPU_TO_LE16(count);\n \n \t/* copy original boost entry to update package buffer, one copy to Rx\n \t * section, another copy to the Tx section\n \t */\n-\tfor (i = 0; i < hw->tnl.count && i < ICE_TUNNEL_MAX_ENTRIES; i++)\n+\tfor (i = 0, j = 0; i < hw->tnl.count && i < ICE_TUNNEL_MAX_ENTRIES; i++)\n \t\tif (hw->tnl.tbl[i].valid && hw->tnl.tbl[i].in_use &&\n \t\t (all || hw->tnl.tbl[i].port == port)) {\n-\t\t\tice_memcpy(sect_rx->tcam + i,\n+\t\t\tice_memcpy(sect_rx->tcam + j,\n \t\t\t\t hw->tnl.tbl[i].boost_entry,\n \t\t\t\t sizeof(*sect_rx->tcam),\n \t\t\t\t ICE_NONDMA_TO_NONDMA);\n-\t\t\tice_memcpy(sect_tx->tcam + i,\n+\t\t\tice_memcpy(sect_tx->tcam + j,\n \t\t\t\t hw->tnl.tbl[i].boost_entry,\n \t\t\t\t sizeof(*sect_tx->tcam),\n \t\t\t\t ICE_NONDMA_TO_NONDMA);\n \t\t\thw->tnl.tbl[i].marked = true;\n+\t\t\tj++;\n \t\t}\n \n \tstatus = ice_update_pkg(hw, ice_pkg_buf(bld), 1);\n", "prefixes": [ "16/27" ] }