Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84908/?format=api
{ "id": 84908, "url": "http://patches.dpdk.org/api/patches/84908/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201209235347.16180-15-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201209235347.16180-15-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201209235347.16180-15-ajit.khaparde@broadcom.com", "date": "2020-12-09T23:53:44", "name": "[v3,14/17] net/bnxt: fix PF resource query", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7b9afbf052a815d556c179bc18b059be9df33b66", "submitter": { "id": 2064, "url": "http://patches.dpdk.org/api/people/2064/?format=api", "name": "Ajit Khaparde", "email": "ajitkhaparde@gmail.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201209235347.16180-15-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14226, "url": "http://patches.dpdk.org/api/series/14226/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14226", "date": "2020-12-09T23:53:30", "name": "fixes and refactoring changes for bnxt", "version": 3, "mbox": "http://patches.dpdk.org/series/14226/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84908/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84908/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D49D8A04DB;\n\tThu, 10 Dec 2020 00:58:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B72F8CA4C;\n\tThu, 10 Dec 2020 00:54:20 +0100 (CET)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 2B869C97A;\n Thu, 10 Dec 2020 00:54:14 +0100 (CET)", "by mail-pg1-f195.google.com with SMTP id o4so2477992pgj.0;\n Wed, 09 Dec 2020 15:54:14 -0800 (PST)", "from localhost.localdomain ([192.19.228.250])\n by smtp.gmail.com with ESMTPSA id s7sm4047693pfh.207.2020.12.09.15.54.10\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 09 Dec 2020 15:54:11 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=NIgyByExLkf8JyPQhV3IrW/GfQFNvU7+7U9tVph/vJE=;\n b=oCRUXDV2TFf+osqwFTF60E3FhembxQ2viSpLzzcGH2TnBCqD4yHRcjV8tuoqJpmLI4\n Ai8pusCqX53TjnFIVCFuA6F+16d2DWrHbyBnbifp4Nx5LeFaWxPMvfwKlCoaz0t6PWc4\n 22C8Kxg/aj/KldZV6JnRpqxUrk3YXAoBu1fLmvaevd7ROaXpTTaYME8iXUBfToDcy4P2\n y4oebm+J2R0Cwp/4Sg7p1XdEx1KiSOuTZSv7L0DK9J0OVgChjltSOttAesSIO6tVpck9\n XxgqNBmDHfdZ+IY753ybggZBxx6CKvnhlaiqFLAJALt9v7qGAqcj/uP0g/NP4XZEZXKV\n fjNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=NIgyByExLkf8JyPQhV3IrW/GfQFNvU7+7U9tVph/vJE=;\n b=XzbwvqDyJlxjq+OoPT/yTSi4VNpujzr6RgsA9orWOUbACxZDwYpUu5UJ0gUEVaqizp\n hqZmXX/WzIYlskeyYM6agZjpU5qVNob9K77LohcU0Rvcp9eL5AJt5/9CnxECLvcPT2MJ\n QC7EemQQnmKkAlo6SSe+BolV8JQAu5XEifwMD5Psk/hJG3aPAvPDtbHAKdVcOu7Oa7Ms\n bEjBb1gEfIZwPgx3wlSUzFtBDYqhGuMV7Y0E3WzWFD5H4BGpFCIoZ9Lb1wTGDKvSC2DS\n hb8j/odUgT1eIVKCcSRO3cVQNQuFONr3ZY84Y6rI3Ita57pLDafmFEPJ10DFfqFPnbel\n 5qDw==", "X-Gm-Message-State": "AOAM530afRZsgNIQqBP2ZXkTkueQ4lq+KKVU4CdPWTwNoKPFjyeaCGlr\n U8fk6fLWJViCeuRP6Y7cPPpSx0+oc4LQG/Xr", "X-Google-Smtp-Source": "\n ABdhPJyFEatOh5OtwvDDrWGQMTSRkHIV3E9LLOSt7q56RvNO0vcVHYuru1iL9Mfg7pLG+yev/CpfJg==", "X-Received": "by 2002:a17:90b:8d5:: with SMTP id\n ds21mr4344896pjb.5.1607558052131;\n Wed, 09 Dec 2020 15:54:12 -0800 (PST)", "From": "Ajit Khaparde <ajitkhaparde@gmail.com>", "X-Google-Original-From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>, stable@dpdk.org,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Date": "Wed, 9 Dec 2020 15:53:44 -0800", "Message-Id": "<20201209235347.16180-15-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201209235347.16180-1-ajit.khaparde@broadcom.com>", "References": "<20201209192233.6518-1-ajit.khaparde@broadcom.com>\n <20201209235347.16180-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 14/17] net/bnxt: fix PF resource query", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nThis cmd should be called by every driver after 'hwrm_func_cfg'\nto get the actual number of resources allocated by the HWRM.\nThe values returned in the cmd are the max values for that PF.\n\nAlso, now that the max values for the PF are computed in probe itself,\nno need to invoke FUNC_QCAPs or any other cmd in dev_configure_op()\nas that would just override the actual max values obtained above.\n\nFixes: f8168ca0e690 (\"net/bnxt: support thor controller\")\nCc: stable@dpdk.org\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 7 -------\n drivers/net/bnxt/bnxt_hwrm.c | 36 +++++++++++++++++++++++++++++++++-\n 2 files changed, 35 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex bf8963577..21d9e26ca 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1071,13 +1071,6 @@ static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev)\n \t\t}\n \n \t\tpthread_mutex_unlock(&bp->def_cp_lock);\n-\t} else {\n-\t\t/* legacy driver needs to get updated values */\n-\t\trc = bnxt_hwrm_func_qcaps(bp);\n-\t\tif (rc) {\n-\t\t\tPMD_DRV_LOG(ERR, \"hwrm func qcaps fail:%d\\n\", rc);\n-\t\t\treturn rc;\n-\t\t}\n \t}\n \n \t/* Inherit new configurations */\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex cee2656c1..a3eb133c0 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -3456,6 +3456,35 @@ static int bnxt_update_max_resources(struct bnxt *bp,\n \treturn 0;\n }\n \n+/* Update the PF resource values based on how many resources\n+ * got allocated to it.\n+ */\n+static int bnxt_update_max_resources_pf_only(struct bnxt *bp)\n+{\n+\tstruct hwrm_func_qcfg_input req = {0};\n+\tstruct hwrm_func_qcfg_output *resp = bp->hwrm_cmd_resp_addr;\n+\tint rc;\n+\n+\t/* Get the actual allocated values now */\n+\tHWRM_PREP(&req, HWRM_FUNC_QCFG, BNXT_USE_CHIMP_MB);\n+\treq.fid = rte_cpu_to_le_16(0xffff);\n+\trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n+\tHWRM_CHECK_RESULT();\n+\n+\tbp->max_rsscos_ctx = rte_le_to_cpu_16(resp->alloc_rsscos_ctx);\n+\tbp->max_stat_ctx = rte_le_to_cpu_16(resp->alloc_stat_ctx);\n+\tbp->max_cp_rings = rte_le_to_cpu_16(resp->alloc_cmpl_rings);\n+\tbp->max_tx_rings = rte_le_to_cpu_16(resp->alloc_tx_rings);\n+\tbp->max_rx_rings = rte_le_to_cpu_16(resp->alloc_rx_rings);\n+\tbp->max_l2_ctx = rte_le_to_cpu_16(resp->alloc_l2_ctx);\n+\tbp->max_ring_grps = rte_le_to_cpu_16(resp->alloc_hw_ring_grps);\n+\tbp->max_vnics = rte_le_to_cpu_16(resp->alloc_vnics);\n+\n+\tHWRM_UNLOCK();\n+\n+\treturn 0;\n+}\n+\n int bnxt_hwrm_func_qcfg_current_vf_vlan(struct bnxt *bp, int vf)\n {\n \tstruct hwrm_func_qcfg_input req = {0};\n@@ -3555,8 +3584,13 @@ int bnxt_hwrm_allocate_pf_only(struct bnxt *bp)\n \t\t HWRM_FUNC_CFG_INPUT_FLAGS_STD_TX_RING_MODE_DISABLE);\n \tbp->pf->func_cfg_flags |=\n \t\tHWRM_FUNC_CFG_INPUT_FLAGS_STD_TX_RING_MODE_DISABLE;\n+\n \trc = bnxt_hwrm_pf_func_cfg(bp, &pf_resc);\n-\trc = __bnxt_hwrm_func_qcaps(bp);\n+\tif (rc)\n+\t\treturn rc;\n+\n+\trc = bnxt_update_max_resources_pf_only(bp);\n+\n \treturn rc;\n }\n \n", "prefixes": [ "v3", "14/17" ] }