Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84783/?format=api
{ "id": 84783, "url": "http://patches.dpdk.org/api/patches/84783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201207173319.1397740-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201207173319.1397740-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201207173319.1397740-1-thomas@monjalon.net", "date": "2020-12-07T17:33:19", "name": "[1/1] devtools: avoid installing static binaries", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a81de128112aca2de46b6f81365f5a3809b98136", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201207173319.1397740-1-thomas@monjalon.net/mbox/", "series": [ { "id": 14202, "url": "http://patches.dpdk.org/api/series/14202/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14202", "date": "2020-12-07T17:33:19", "name": "[1/1] devtools: avoid installing static binaries", "version": 1, "mbox": "http://patches.dpdk.org/series/14202/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84783/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/84783/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 093C9A04E6;\n\tMon, 7 Dec 2020 18:33:42 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A913CC8CC;\n\tMon, 7 Dec 2020 18:33:37 +0100 (CET)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 33449CF3\n for <dev@dpdk.org>; Mon, 7 Dec 2020 18:33:36 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id DA7A15C0246;\n Mon, 7 Dec 2020 12:33:34 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Mon, 07 Dec 2020 12:33:34 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 4E23B240065;\n Mon, 7 Dec 2020 12:33:34 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding; s=fm2; bh=xdTprw8kxN00kKO46rnVtsIavd\n IEKRErcLhiHGqnS3g=; b=QgrrEt3IXw0m41AjbCqYLn4E3ydaTPq9UC9F6rjH+u\n bL4mW+85Xl1R24YyyEFzrRHFwpho1ZPkzHjNxFuciAkgHcf2DdidjV2PSS7CUlCq\n x3dJEn9CqlkmWi4vSuBaqxM6YLl0/k6G8dl6wyY9d3o4L5Wm88zOpL3h/a6Ldh+p\n zRty5BDjdj34+Bf3lHrXcRadJcaJaADkwyytIFmv2A2fTVWiGz9hrmIE6MfMhceo\n cdl4yLoINQKjqb/7kkjWU3bZoIWlIMJwN1PLljEljx4VTVQpB6qH/FWKB5WReStW\n LJcu6apH6Q/PRIrCdp9pm5zIc1UukwLwh8W3XhmHI2sw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=xdTprw8kxN00kKO46\n rnVtsIavdIEKRErcLhiHGqnS3g=; b=WbthiQ7sKAFGdMG7VaMq5BtRyDr5eBndP\n NdPygiEW4WSoKd47su/ucvl5hlNYRSwggXRJxEIna5ykpJKiwrmN5qg0CcZlL5+P\n bb0UfgPrFMoRO+1NMFXc9yhy9kbnK99nsZfa2QsflMjaFa1KpR2R8mFt4stw048d\n xWwRNsugMDsnmzgGjEOBhQ1Q5zLoMvaZjB/oM2hzH1EbW6g/kiRQoH9dRB9u/vCo\n euGN5zGdkm2lNoJhBGk8E5o6XPtKiaLCjKjFZ6QWO6WJe0Sqg2efsAK23CuzXUs4\n y2KHHoUZCZwTe71Ph04ckn+SzDCAhTcL5PNQYb1IJoKVXOxbNISGA==" ], "X-ME-Sender": "<xms:bmfOX-gREhA0rzw9etSsAWuB4VPi20DKSGdoc73B0UL8rkn11EKZzw>\n <xme:bmfOX_Arng3dKaVvlTC43qIQNSKAiCtWTv0382Frxo78t264TgX5hO2vCBmz7I5Bb\n DXTSd5APMtmN207Dw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrudejgedguddtudcutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh\n necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd\n ertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm\n ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdelvdduhedvudduveeuvd\n evheegudelgeeigfejheduhedttdegudffjeeihffgnecukfhppeejjedrudefgedrvddt\n fedrudekgeenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhroh\n hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:bmfOX2GtcoABmSKTBmchp40Bhf-UXniivhLyPkQON-FUyVFZlq_Zow>\n <xmx:bmfOX3Rk6PAbrxzt-wnJqEflY2GH5fWXH0J8DBv6XBDhu7MvUyextw>\n <xmx:bmfOX7zBZsxkDNzSDMu-lYNU6OWwpXC1efEaP2znVXFTU0ILdcjDoA>\n <xmx:bmfOX5a1yT59qROClnW1mTThQ9HAc_A3oFTfh9OVD-hHZ6jBmbozbg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com,\n\tbruce.richardson@intel.com", "Date": "Mon, 7 Dec 2020 18:33:19 +0100", "Message-Id": "<20201207173319.1397740-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/1] devtools: avoid installing static binaries", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When testing compilation and checking ABI compatibility,\nthere is no real need of static binaries eating disks.\nThe static linkage of applications are tested with GCC and Clang,\nplus some examples are statically linked.\nThe after-installation build test is limited to \"helloworld\" example.\nNote the meson static build test was already limited to \"l3fwd\" example.\n\nThe ABI compatibility is checked on shared libraries, so no need\nrunning this test a second time on builds intended for static linking.\nHowever, limiting ABI check to \"shared builds\" means all test cases\nmust have a \"shared build\" occurence.\nAs a consequence the 32-bit build test is switched to shared linking.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n devtools/test-meson-builds.sh | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex 7280b7a93d..ed44d4ffb1 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -166,6 +166,9 @@ build () # <directory> <target compiler | cross file> <meson options>\n \tconfig $srcdir $builds_dir/$targetdir $cross --werror $*\n \tcompile $builds_dir/$targetdir\n \tif [ -n \"$DPDK_ABI_REF_VERSION\" ]; then\n+\t\tif echo $* | grep -qw -- '--default-library=static' ; then\n+\t\t\treturn # skip ABI check for static build\n+\t\tfi\n \t\tabirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION\n \t\tif [ ! -d $abirefdir/$targetdir ]; then\n \t\t\t# clone current sources\n@@ -230,7 +233,7 @@ if check_cc_flags '-m32' ; then\n \t\texport PKG_CONFIG_LIBDIR='/usr/lib/pkgconfig'\n \tfi\n \ttarget_override='i386-pc-linux-gnu'\n-\tbuild build-32b cc -Dc_args='-m32' -Dc_link_args='-m32'\n+\tbuild build-32b cc -Dc_args='-m32' -Dc_link_args='-m32' $use_shared\n \ttarget_override=\n \tunset PKG_CONFIG_LIBDIR\n fi\n@@ -274,7 +277,8 @@ if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then\n \texport PKGCONF=\"pkg-config --define-prefix\"\n \tfor example in $examples; do\n \t\techo \"## Building $example\"\n+\t\t[ $example = helloworld ] && static=static || static= # save disk space\n \t\t$MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example \\\n-\t\t\tclean shared static >&$veryverbose\n+\t\t\tclean shared $static >&$veryverbose\n \tdone\n fi\n", "prefixes": [ "1/1" ] }