Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84430/?format=api
{ "id": 84430, "url": "http://patches.dpdk.org/api/patches/84430/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1605874101-30893-10-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1605874101-30893-10-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/1605874101-30893-10-git-send-email-juraj.linkes@pantheon.tech", "date": "2020-11-20T12:08:18", "name": "[v13,09/12] build: disable drivers in Arm builds", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3894a1330e500c74c5566049b6855fbcee4c1b80", "submitter": { "id": 1626, "url": "http://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1605874101-30893-10-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 14004, "url": "http://patches.dpdk.org/api/series/14004/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14004", "date": "2020-11-20T12:08:09", "name": "Arm build options rework", "version": 13, "mbox": "http://patches.dpdk.org/series/14004/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84430/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D507BA04DD;\n\tFri, 20 Nov 2020 13:11:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 958F0C95C;\n\tFri, 20 Nov 2020 13:08:57 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by dpdk.org (Postfix) with ESMTP id 8B32BC910\n for <dev@dpdk.org>; Fri, 20 Nov 2020 13:08:41 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 5C926B9B5C;\n Fri, 20 Nov 2020 13:08:39 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id paY3fYa9h3QH; Fri, 20 Nov 2020 13:08:38 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 9F5AFBA257;\n Fri, 20 Nov 2020 13:08:33 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "bruce.richardson@intel.com, Ruifeng.Wang@arm.com,\n Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com,\n Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com,\n ajit.khaparde@broadcom.com, ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Date": "Fri, 20 Nov 2020 13:08:18 +0100", "Message-Id": "<1605874101-30893-10-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech>", "References": "<1605277875-13625-1-git-send-email-juraj.linkes@pantheon.tech>\n <1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v13 09/12] build: disable drivers in Arm builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A few options that disabled drivers in the old makefiles were improperly\nported to the meson build system. Fix this by adding a to the list of\ndisabled drivers, similarly how the command line option works and remove\nunneeded driver options ported from the old makefile system, since they\ndon't work in the current Meson build system.\nAdd support for removing drivers for cross builds so that we can disable\nthem in cross files.\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n config/arm/arm64_armada_linux_gcc | 1 +\n config/arm/meson.build | 7 +++----\n doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++\n drivers/meson.build | 6 +++++-\n meson.build | 1 +\n 5 files changed, 14 insertions(+), 5 deletions(-)", "diff": "diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc\nindex 2ecc4604c..e365f61d0 100644\n--- a/config/arm/arm64_armada_linux_gcc\n+++ b/config/arm/arm64_armada_linux_gcc\n@@ -18,3 +18,4 @@ implementer_id = '0x56'\n part_number = '0xd08'\n max_lcores = 16\n max_numa_nodes = 1\n+disabled_drivers = ['bus/dpaa', 'bus/fslmc', 'common/dpaax']\ndiff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 375a804ac..7db343b8a 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -2,6 +2,9 @@\n # Copyright(c) 2017 Intel Corporation.\n # Copyright(c) 2017 Cavium, Inc\n \n+# disable Arm drivers for all builds\n+disabled_drivers += ['net/avp', 'net/fm10k']\n+\n # common flags to all aarch64 builds, with lowest priority\n flags_common = [\n \t# Accelerate rte_memcpy. Be sure to run unit test (memcpy_perf_autotest)\n@@ -16,9 +19,6 @@ flags_common = [\n \t#\t['RTE_ARM64_MEMCPY_ALIGN_MASK', 0xF],\n \t#\t['RTE_ARM64_MEMCPY_STRICT_ALIGN', false],\n \n-\t['RTE_NET_FM10K', false],\n-\t['RTE_NET_AVP', false],\n-\n \t['RTE_SCHED_VECTOR', false],\n \t['RTE_ARM_USE_WFE', false],\n \t['RTE_ARCH_ARM64', true],\n@@ -126,7 +126,6 @@ implementer_cavium = {\n \t\t\t\t['RTE_MACHINE', '\"octeontx2\"'],\n \t\t\t\t['RTE_ARM_FEATURE_ATOMICS', true],\n \t\t\t\t['RTE_USE_C11_MEM_MODEL', true],\n-\t\t\t\t['RTE_EAL_IGB_UIO', false],\n \t\t\t\t['RTE_MAX_LCORE', 36],\n \t\t\t\t['RTE_MAX_NUMA_NODES', 1]\n \t\t\t]\ndiff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\nindex 4e65b271c..210ad4508 100644\n--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\n+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\n@@ -143,3 +143,7 @@ There are other options you may specify in a cross file to tailor the build::\n Supported extra configuration\n max_numa_nodes = n # will set RTE_MAX_NUMA_NODES\n max_lcores = n # will set RTE_MAX_LCORE\n+\n+ disabled_drivers = ['bus/dpaa', 'crypto'] # add disabled drivers\n+ # valid values are directories (optionally with their subdirs)\n+ # in the drivers directory\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex 6b50f7238..21a296b55 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -18,9 +18,13 @@ subdirs = [\n \t'baseband', # depends on common and bus.\n ]\n \n-disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'),\n+disabled_drivers += run_command(list_dir_globs, get_option('disable_drivers'),\n \t\t).stdout().split()\n \n+if meson.is_cross_build()\n+\tdisabled_drivers += meson.get_cross_property('disabled_drivers', [])\n+endif\n+\n default_cflags = machine_args\n default_cflags += ['-DALLOW_EXPERIMENTAL_API']\n default_cflags += ['-DALLOW_INTERNAL_API']\ndiff --git a/meson.build b/meson.build\nindex 45d974cd2..fcc8931f0 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -21,6 +21,7 @@ dpdk_drivers = []\n dpdk_extra_ldflags = []\n dpdk_libs_disabled = []\n dpdk_drvs_disabled = []\n+disabled_drivers = []\n abi_version_file = files('ABI_VERSION')\n \n if host_machine.cpu_family().startswith('x86')\n", "prefixes": [ "v13", "09/12" ] }