Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84050/?format=api
{ "id": 84050, "url": "http://patches.dpdk.org/api/patches/84050/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201112094142.1781861-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201112094142.1781861-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201112094142.1781861-2-bruce.richardson@intel.com", "date": "2020-11-12T09:41:39", "name": "[v4,1/4] examples: fix flattening directory layout on install", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d1d055537390506a78105faf3dabd1dc982e8659", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201112094142.1781861-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 13835, "url": "http://patches.dpdk.org/api/series/13835/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13835", "date": "2020-11-12T09:41:38", "name": "improve examples installation", "version": 4, "mbox": "http://patches.dpdk.org/series/13835/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84050/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/84050/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8425EA09D3;\n\tThu, 12 Nov 2020 10:42:26 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E7E766CAC;\n\tThu, 12 Nov 2020 10:42:15 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 68EF46CAB;\n Thu, 12 Nov 2020 10:42:13 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Nov 2020 01:42:11 -0800", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by orsmga002.jf.intel.com with ESMTP; 12 Nov 2020 01:42:10 -0800" ], "IronPort-SDR": [ "\n ixMmjn0U/XorgZ5pqTstT+wcO/ADh1mzCU0izvVdzBCLjD4NfaFxvMp7zectfkEBtmgX2Wyn6W\n RzeaLD66s2iw==", "\n j/7D3l9ikTbrGzPGmcUsYCltY/hFKWvWqZCxA+ujdAAd+mgqrJ0q6zgLTNNHXGuq0LoKTYNY/Y\n 2YpVqmiOKd7g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9802\"; a=\"231903628\"", "E=Sophos;i=\"5.77,471,1596524400\"; d=\"scan'208\";a=\"231903628\"", "E=Sophos;i=\"5.77,471,1596524400\"; d=\"scan'208\";a=\"339347892\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>,\n stable@dpdk.org", "Date": "Thu, 12 Nov 2020 09:41:39 +0000", "Message-Id": "<20201112094142.1781861-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201112094142.1781861-1-bruce.richardson@intel.com>", "References": "<20201110170809.1309043-1-bruce.richardson@intel.com>\n <20201112094142.1781861-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 1/4] examples: fix flattening directory layout\n\ton install", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "By installing the examples one-by-one in a loop in the examples\nmeson.build file we effectively flattened out the structure of the examples\nfolder and omitted some common and shared subfolders that were never\ndirectly built. Instead, we can remove the loop and just have the whole\n\"examples\" folder installed as-is in a single statement, preserving its\ndirectory structure, and thereby fixing the build of a number of the\nexamples.\n\nFixes: 2daf565f91b5 (\"examples: install as part of ninja install\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/meson.build | 7 -------\n meson.build | 3 +++\n 2 files changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/meson.build b/examples/meson.build\nindex f17995532..46ec80919 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -47,13 +47,6 @@ all_examples = [\n \t'vm_power_manager/guest_cli',\n \t'vmdq', 'vmdq_dcb',\n ]\n-# install all example code on install - irrespective of whether the example in\n-# question is to be built as part of this build or not.\n-foreach ex:all_examples\n-\tinstall_subdir(ex,\n-\t\t\tinstall_dir: get_option('datadir') + '/dpdk/examples',\n-\t\t\texclude_files: 'meson.build')\n-endforeach\n \n if get_option('examples') == ''\n \tsubdir_done()\ndiff --git a/meson.build b/meson.build\nindex 61d9a4f5f..45d974cd2 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -59,6 +59,9 @@ subdir('doc')\n # build any examples explicitly requested - useful for developers - and\n # install any example code into the appropriate install path\n subdir('examples')\n+install_subdir('examples',\n+\tinstall_dir: get_option('datadir') + '/dpdk',\n+\texclude_files: 'meson.build')\n \n # build kernel modules if enabled\n if get_option('enable_kmods')\n", "prefixes": [ "v4", "1/4" ] }