Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84028/?format=api
{ "id": 84028, "url": "http://patches.dpdk.org/api/patches/84028/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111174845.1768044-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111174845.1768044-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111174845.1768044-3-bruce.richardson@intel.com", "date": "2020-11-11T17:48:44", "name": "[v3,3/4] examples: stop processing build file if build is impossible", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8fbad9c2d44edffcd5482d403dcbfd61196611c8", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111174845.1768044-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 13781, "url": "http://patches.dpdk.org/api/series/13781/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13781", "date": "2020-11-10T17:08:09", "name": "install: fix flattening of examples directory", "version": 1, "mbox": "http://patches.dpdk.org/series/13781/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84028/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84028/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2CE2A09D9;\n\tWed, 11 Nov 2020 18:49:21 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 34C0156A3;\n\tWed, 11 Nov 2020 18:49:02 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id CD890F90\n for <dev@dpdk.org>; Wed, 11 Nov 2020 18:48:58 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2020 09:48:56 -0800", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by fmsmga005.fm.intel.com with ESMTP; 11 Nov 2020 09:48:55 -0800" ], "IronPort-SDR": [ "\n 4ObJuDMrB8tkMUDL+o7u4DTvXJAF5NBLyAyfGOb5CX/YsOCdhEO2zsirq5H0tQwsXnw14+wqC4\n EYfDnPE8q4bQ==", "\n 6wHnl3UJztjA9qyz5c67bwd4aogy0ChPdCIh/9QISmKq2E3FG7FiRZtDdnx3ckecw8nEcbzjik\n oQSFxVH1SEaw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9802\"; a=\"157200303\"", "E=Sophos;i=\"5.77,470,1596524400\"; d=\"scan'208\";a=\"157200303\"", "E=Sophos;i=\"5.77,470,1596524400\"; d=\"scan'208\";a=\"531793536\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 11 Nov 2020 17:48:44 +0000", "Message-Id": "<20201111174845.1768044-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201111174845.1768044-1-bruce.richardson@intel.com>", "References": "<20201110170809.1309043-1-bruce.richardson@intel.com>\n <20201111174845.1768044-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 3/4] examples: stop processing build file if\n\tbuild is impossible", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Once it has been determined that an example cannot be built, there is\nlittle point in continuing to process the meson.build file for that\nexample, so we can use subdir_done() to return to the calling file.\nThis can potentially prevent problems where later statement in the file\nmay cause an error on systems where the app cannot be built, e.g. on\nWindows or FreeBSD.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/distributor/meson.build | 3 +++\n examples/ethtool/meson.build | 4 ++++\n examples/ioat/meson.build | 3 +++\n examples/ip_pipeline/meson.build | 4 ++++\n examples/kni/meson.build | 4 ++++\n examples/l2fwd-cat/meson.build | 4 ++++\n examples/ntb/meson.build | 2 ++\n examples/performance-thread/l3fwd-thread/meson.build | 4 ++++\n examples/performance-thread/pthread_shim/meson.build | 4 ++++\n examples/pipeline/meson.build | 4 ++++\n examples/vdpa/meson.build | 2 ++\n examples/vhost/meson.build | 2 ++\n examples/vhost_blk/meson.build | 2 ++\n examples/vhost_crypto/meson.build | 4 ++++\n 14 files changed, 46 insertions(+)", "diff": "diff --git a/examples/distributor/meson.build b/examples/distributor/meson.build\nindex 5244cd4ff..d8dbc235f 100644\n--- a/examples/distributor/meson.build\n+++ b/examples/distributor/meson.build\n@@ -8,6 +8,9 @@\n \n # require the power library\n build = dpdk_conf.has('RTE_LIB_POWER')\n+if not build\n+\tsubdir_done()\n+endif\n \n allow_experimental_apis = true\n deps += ['distributor', 'power']\ndiff --git a/examples/ethtool/meson.build b/examples/ethtool/meson.build\nindex cc8edac3d..4d08bc4c5 100644\n--- a/examples/ethtool/meson.build\n+++ b/examples/ethtool/meson.build\n@@ -7,6 +7,10 @@\n # DPDK instance, use 'make'\n \n build = is_linux\n+if not build\n+\tsubdir_done()\n+endif\n+\n sources = files('lib/rte_ethtool.c',\n \t'ethtool-app/ethapp.c',\n \t'ethtool-app/main.c')\ndiff --git a/examples/ioat/meson.build b/examples/ioat/meson.build\nindex 6afbaa680..e348196ba 100644\n--- a/examples/ioat/meson.build\n+++ b/examples/ioat/meson.build\n@@ -8,6 +8,9 @@\n \n allow_experimental_apis = true\n build = dpdk_conf.has('RTE_RAW_IOAT')\n+if not build\n+\tsubdir_done()\n+endif\n \n deps += ['raw_ioat']\n \ndiff --git a/examples/ip_pipeline/meson.build b/examples/ip_pipeline/meson.build\nindex 664223c97..945e28b58 100644\n--- a/examples/ip_pipeline/meson.build\n+++ b/examples/ip_pipeline/meson.build\n@@ -7,6 +7,10 @@\n # DPDK instance, use 'make'\n \n build = cc.has_header('sys/epoll.h')\n+if not build\n+\tsubdir_done()\n+endif\n+\n deps += ['pipeline', 'bus_pci']\n allow_experimental_apis = true\n sources = files(\ndiff --git a/examples/kni/meson.build b/examples/kni/meson.build\nindex 58639b139..e119eebab 100644\n--- a/examples/kni/meson.build\n+++ b/examples/kni/meson.build\n@@ -8,6 +8,10 @@\n \n # this app can be built if-and-only-if KNI library is buildable\n build = dpdk_conf.has('RTE_LIB_KNI')\n+if not build\n+\tsubdir_done()\n+endif\n+\n deps += ['kni', 'bus_pci']\n sources = files(\n \t'main.c'\ndiff --git a/examples/l2fwd-cat/meson.build b/examples/l2fwd-cat/meson.build\nindex 2bed18e74..60169bcbd 100644\n--- a/examples/l2fwd-cat/meson.build\n+++ b/examples/l2fwd-cat/meson.build\n@@ -8,6 +8,10 @@\n \n pqos = cc.find_library('pqos', required: false)\n build = pqos.found()\n+if not build\n+\tsubdir_done()\n+endif\n+\n ext_deps += pqos\n allow_experimental_apis = true\n cflags += '-I/usr/local/include' # assume pqos lib installed in /usr/local\ndiff --git a/examples/ntb/meson.build b/examples/ntb/meson.build\nindex b0201f68b..02be9fc80 100644\n--- a/examples/ntb/meson.build\n+++ b/examples/ntb/meson.build\n@@ -9,7 +9,9 @@\n allow_experimental_apis = true\n if not is_linux\n \tbuild = false\n+\tsubdir_done()\n endif\n+\n deps += 'rawdev'\n cflags += ['-D_FILE_OFFSET_BITS=64']\n sources = files(\ndiff --git a/examples/performance-thread/l3fwd-thread/meson.build b/examples/performance-thread/l3fwd-thread/meson.build\nindex 99de24be7..4858b201e 100644\n--- a/examples/performance-thread/l3fwd-thread/meson.build\n+++ b/examples/performance-thread/l3fwd-thread/meson.build\n@@ -7,6 +7,10 @@\n # DPDK instance, use 'make'\n \n build = dpdk_conf.has('RTE_ARCH_X86_64')\n+if not build\n+\tsubdir_done()\n+endif\n+\n deps += ['timer', 'lpm']\n allow_experimental_apis = true\n \ndiff --git a/examples/performance-thread/pthread_shim/meson.build b/examples/performance-thread/pthread_shim/meson.build\nindex 26ef78635..d49979930 100644\n--- a/examples/performance-thread/pthread_shim/meson.build\n+++ b/examples/performance-thread/pthread_shim/meson.build\n@@ -7,6 +7,10 @@\n # DPDK instance, use 'make'\n \n build = dpdk_conf.has('RTE_ARCH_X86_64') or dpdk_conf.has('RTE_ARCH_ARM64')\n+if not build\n+\tsubdir_done()\n+endif\n+\n deps += ['timer']\n allow_experimental_apis = true\n \ndiff --git a/examples/pipeline/meson.build b/examples/pipeline/meson.build\nindex e47d483de..4f5925d7c 100644\n--- a/examples/pipeline/meson.build\n+++ b/examples/pipeline/meson.build\n@@ -7,6 +7,10 @@\n # DPDK instance, use 'make'\n \n build = cc.has_header('sys/epoll.h')\n+if not build\n+\tsubdir_done()\n+endif\n+\n deps += ['pipeline', 'bus_pci']\n allow_experimental_apis = true\n sources = files(\ndiff --git a/examples/vdpa/meson.build b/examples/vdpa/meson.build\nindex 73f129cd9..26f6089c9 100644\n--- a/examples/vdpa/meson.build\n+++ b/examples/vdpa/meson.build\n@@ -8,7 +8,9 @@\n \n if not is_linux\n \tbuild = false\n+\tsubdir_done()\n endif\n+\n deps += 'vhost'\n allow_experimental_apis = true\n sources = files(\ndiff --git a/examples/vhost/meson.build b/examples/vhost/meson.build\nindex 24f1f7131..7e5b9d938 100644\n--- a/examples/vhost/meson.build\n+++ b/examples/vhost/meson.build\n@@ -8,7 +8,9 @@\n \n if not is_linux\n \tbuild = false\n+\tsubdir_done()\n endif\n+\n deps += 'vhost'\n allow_experimental_apis = true\n sources = files(\ndiff --git a/examples/vhost_blk/meson.build b/examples/vhost_blk/meson.build\nindex 857367192..354ba0584 100644\n--- a/examples/vhost_blk/meson.build\n+++ b/examples/vhost_blk/meson.build\n@@ -8,10 +8,12 @@\n \n if not is_linux\n \tbuild = false\n+\tsubdir_done()\n endif\n \n if not cc.has_header('linux/virtio_blk.h')\n \tbuild = false\n+\tsubdir_done()\n endif\n \n deps += 'vhost'\ndiff --git a/examples/vhost_crypto/meson.build b/examples/vhost_crypto/meson.build\nindex b2c125e2f..403f21098 100644\n--- a/examples/vhost_crypto/meson.build\n+++ b/examples/vhost_crypto/meson.build\n@@ -7,6 +7,10 @@\n # DPDK instance, use 'make'\n \n build = dpdk_conf.has('RTE_LIB_VHOST')\n+if not build\n+\tsubdir_done()\n+endif\n+\n allow_experimental_apis = true\n deps += ['vhost', 'cryptodev']\n sources = files(\n", "prefixes": [ "v3", "3/4" ] }