Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83997/?format=api
{ "id": 83997, "url": "http://patches.dpdk.org/api/patches/83997/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111081507.19913-7-ibtisam.tariq@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111081507.19913-7-ibtisam.tariq@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111081507.19913-7-ibtisam.tariq@emumba.com", "date": "2020-11-11T08:15:07", "name": "[7/7] examples/vhost_crypto: enhance getopt_long usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7b4cae9f56070408e3693c1821d69b8ec307e195", "submitter": { "id": 1680, "url": "http://patches.dpdk.org/api/people/1680/?format=api", "name": "Ibtisam Tariq", "email": "ibtisam.tariq@emumba.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111081507.19913-7-ibtisam.tariq@emumba.com/mbox/", "series": [ { "id": 13801, "url": "http://patches.dpdk.org/api/series/13801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13801", "date": "2020-11-11T08:15:01", "name": "[1/7] examples/fips_validation: enhance getopt_long usage", "version": 1, "mbox": "http://patches.dpdk.org/series/13801/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83997/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/83997/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F019AA09D2;\n\tWed, 11 Nov 2020 09:17:38 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EE165B3A;\n\tWed, 11 Nov 2020 09:16:07 +0100 (CET)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id E50785AB3\n for <dev@dpdk.org>; Wed, 11 Nov 2020 09:16:04 +0100 (CET)", "by mail-wr1-f67.google.com with SMTP id d12so1585038wrr.13\n for <dev@dpdk.org>; Wed, 11 Nov 2020 00:16:04 -0800 (PST)", "from localhost.localdomain ([39.33.227.210])\n by smtp.gmail.com with ESMTPSA id z3sm909539wrw.87.2020.11.11.00.16.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Nov 2020 00:16:03 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=F4hIvNjOel+GquIQtnawbHV5oREb1Om8o4ct0BH2KXM=;\n b=jIULhxXQgaf1WD9NocWHH1lFmMqDVPu5RXhn8X9hUAOrXRrO9ZZZxnHlQeSQSVsKmE\n Q1XkxPv0YeZUewe5M7xj81a795tas8mHdqxOxigViDwT8OXCHk2QGgQeDoFBOkkqkPC8\n JWF7gBci08JyHIPGFi3IJeF2T/SQjH5sj76vLF+INONniEIXzkUzC7UiltAwEbxtAr/E\n ig1xIX6erV6X/XUIO1EO7XGw7N2+vITjN6xjp62K5wYICowK1VMxlPN+8h/rs0MqXoH2\n xkvEclriOIrd3uflzb7f+72KHQiZIj/BFhD4XI8hdcr/j4+w7q/90jcKnYAvOnvXK20U\n EGXw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=F4hIvNjOel+GquIQtnawbHV5oREb1Om8o4ct0BH2KXM=;\n b=cphIjMYyyyszNFl4IiEmqC1fheA4gzeaXXPb80wsSvIfyhbYJ+v1b4fH21VXVU2c19\n 1caLhgEXx4gk4buD8UgWwhufYIJeh2gv15sfQyXxzXFppONppBhZq0u8YpZkiouqiOjE\n 8LFlwbCAxU6N9CvJqDlKzZoYU3p5gjQeUjhAB1brx2zBJXWE1ARjs52FT3/yv4DCSkt7\n bcLRgzFnAwnEkApzM6WLrCfpHZK6+gnNPji8IPKSzg2fRsFS4+LzQMOYbIe3y/vjnj28\n b/9fdv1fFancF+4LCRHPJSd0XCPu/mWtN7eqy77SlFm5mesjixkc68RcCWA0qJA6g/R0\n Uhlw==", "X-Gm-Message-State": "AOAM531ye0FXuhJrK8iu+4pUMOpKwFMDP3DgQ3u8YgdT8hqv2K51wDOH\n s2kM2lZzof4vrXBQjuITNpQaAw==", "X-Google-Smtp-Source": "\n ABdhPJzq/iZ399dtjZYysZtoZOLXeazm1VN0kEzW9XSDsJDjSoCNJ1fT/WqjSsZieFORLQom6SPzIw==", "X-Received": "by 2002:adf:c847:: with SMTP id e7mr28604628wrh.346.1605082563634;\n Wed, 11 Nov 2020 00:16:03 -0800 (PST)", "From": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n cristian.dumitrescu@intel.com, jasvinder.singh@intel.com,\n john.mcnamara@intel.com, reshma.pattan@intel.com,\n konstantin.ananyev@intel.com, marko.kovacevic@intel.com", "Cc": "dev@dpdk.org, Ibtisam Tariq <ibtisam.tariq@emumba.com>,\n roy.fan.zhang@intel.com", "Date": "Wed, 11 Nov 2020 08:15:07 +0000", "Message-Id": "<20201111081507.19913-7-ibtisam.tariq@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201111081507.19913-1-ibtisam.tariq@emumba.com>", "References": "<20201111081507.19913-1-ibtisam.tariq@emumba.com>", "Subject": "[dpdk-dev] [PATCH 7/7] examples/vhost_crypto: enhance getopt_long\n\tusage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of using getopt_long return value, strcmp was used to\ncompare the input parameters with the struct option array. This\npatch get rid of all those strcmp by directly binding each longopt\nwith an int enum. This is to improve readability and consistency in\nall examples.\n\nBugzilla ID: 238\nCc: roy.fan.zhang@intel.com\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n---\nv2\n* Remove extra indentations.\n* Remove extra block brackets in switch statement.\n* Change enum names to start with OPT_ and remove KEYWORD from enum names.\n* Remove unused short options\n\nv1\n* enhance getopt_long usage\n---\n examples/vhost_crypto/main.c | 88 +++++++++++++++++++++---------------\n 1 file changed, 51 insertions(+), 37 deletions(-)", "diff": "diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c\nindex 11ad49159..d731751eb 100644\n--- a/examples/vhost_crypto/main.c\n+++ b/examples/vhost_crypto/main.c\n@@ -62,10 +62,16 @@ struct vhost_crypto_options {\n \tuint32_t guest_polling;\n } options;\n \n-#define CONFIG_KEYWORD\t\t\"config\"\n-#define SOCKET_FILE_KEYWORD\t\"socket-file\"\n-#define ZERO_COPY_KEYWORD\t\"zero-copy\"\n-#define POLLING_KEYWORD\t\t\"guest-polling\"\n+enum {\n+#define OPT_CONFIG\t\t\"config\"\n+\tOPT_CONFIG_NUM = 256,\n+#define OPT_SOCKET_FILE\t\"socket-file\"\n+\tOPT_SOCKET_FILE_NUM,\n+#define OPT_ZERO_COPY\t\"zero-copy\"\n+\tOPT_ZERO_COPY_NUM,\n+#define OPT_POLLING\t\t\"guest-polling\"\n+\tOPT_POLLING_NUM,\n+};\n \n #define NB_SOCKET_FIELDS\t(2)\n \n@@ -198,8 +204,8 @@ vhost_crypto_usage(const char *prgname)\n \t\t\" --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]\"\n \t\t\" --%s: zero copy\\n\"\n \t\t\" --%s: guest polling\\n\",\n-\t\tprgname, SOCKET_FILE_KEYWORD, CONFIG_KEYWORD,\n-\t\tZERO_COPY_KEYWORD, POLLING_KEYWORD);\n+\t\tprgname, OPT_SOCKET_FILE, OPT_CONFIG,\n+\t\tOPT_ZERO_COPY, OPT_POLLING);\n }\n \n static int\n@@ -210,48 +216,56 @@ vhost_crypto_parse_args(int argc, char **argv)\n \tchar **argvopt;\n \tint option_index;\n \tstruct option lgopts[] = {\n-\t\t\t{SOCKET_FILE_KEYWORD, required_argument, 0, 0},\n-\t\t\t{CONFIG_KEYWORD, required_argument, 0, 0},\n-\t\t\t{ZERO_COPY_KEYWORD, no_argument, 0, 0},\n-\t\t\t{POLLING_KEYWORD, no_argument, 0, 0},\n-\t\t\t{NULL, 0, 0, 0}\n+\t\t{OPT_SOCKET_FILE, required_argument,\n+\t\t\t\tNULL, OPT_SOCKET_FILE_NUM},\n+\t\t{OPT_CONFIG, required_argument,\n+\t\t\t\tNULL, OPT_CONFIG_NUM},\n+\t\t{OPT_ZERO_COPY, no_argument,\n+\t\t\t\tNULL, OPT_ZERO_COPY_NUM},\n+\t\t{OPT_POLLING, no_argument,\n+\t\t\t\tNULL, OPT_POLLING_NUM},\n+\t\t{NULL, 0, 0, 0}\n \t};\n \n \targvopt = argv;\n \n-\twhile ((opt = getopt_long(argc, argvopt, \"s:\",\n+\twhile ((opt = getopt_long(argc, argvopt, \"\",\n \t\t\t\t lgopts, &option_index)) != EOF) {\n \n+\t\tif (opt == '?') {\n+\t\t\tvhost_crypto_usage(prgname);\n+\t\t\treturn -1;\n+\t\t}\n+\n \t\tswitch (opt) {\n-\t\tcase 0:\n-\t\t\tif (strcmp(lgopts[option_index].name,\n-\t\t\t\t\tSOCKET_FILE_KEYWORD) == 0) {\n-\t\t\t\tret = parse_socket_arg(optarg);\n-\t\t\t\tif (ret < 0) {\n-\t\t\t\t\tvhost_crypto_usage(prgname);\n-\t\t\t\t\treturn ret;\n-\t\t\t\t}\n-\t\t\t} else if (strcmp(lgopts[option_index].name,\n-\t\t\t\t\tCONFIG_KEYWORD) == 0) {\n-\t\t\t\tret = parse_config(optarg);\n-\t\t\t\tif (ret < 0) {\n-\t\t\t\t\tvhost_crypto_usage(prgname);\n-\t\t\t\t\treturn ret;\n-\t\t\t\t}\n-\t\t\t} else if (strcmp(lgopts[option_index].name,\n-\t\t\t\t\tZERO_COPY_KEYWORD) == 0) {\n-\t\t\t\toptions.zero_copy =\n-\t\t\t\t\tRTE_VHOST_CRYPTO_ZERO_COPY_ENABLE;\n-\t\t\t} else if (strcmp(lgopts[option_index].name,\n-\t\t\t\t\tPOLLING_KEYWORD) == 0) {\n-\t\t\t\toptions.guest_polling = 1;\n-\t\t\t} else {\n+\t\tcase OPT_SOCKET_FILE_NUM:\n+\t\t\tret = parse_socket_arg(optarg);\n+\t\t\tif (ret < 0) {\n \t\t\t\tvhost_crypto_usage(prgname);\n-\t\t\t\treturn -EINVAL;\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t\tbreak;\n+\n+\t\tcase OPT_CONFIG_NUM:\n+\t\t\tret = parse_config(optarg);\n+\t\t\tif (ret < 0) {\n+\t\t\t\tvhost_crypto_usage(prgname);\n+\t\t\t\treturn ret;\n \t\t\t}\n \t\t\tbreak;\n+\n+\t\tcase OPT_ZERO_COPY_NUM:\n+\t\t\toptions.zero_copy =\n+\t\t\t\tRTE_VHOST_CRYPTO_ZERO_COPY_ENABLE;\n+\t\t\tbreak;\n+\n+\t\tcase OPT_POLLING_NUM:\n+\t\t\toptions.guest_polling = 1;\n+\t\t\tbreak;\n+\n \t\tdefault:\n-\t\t\treturn -1;\n+\t\t\tvhost_crypto_usage(prgname);\n+\t\t\treturn -EINVAL;\n \t\t}\n \t}\n \n", "prefixes": [ "7/7" ] }