Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83994/?format=api
{ "id": 83994, "url": "http://patches.dpdk.org/api/patches/83994/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111081507.19913-4-ibtisam.tariq@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111081507.19913-4-ibtisam.tariq@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111081507.19913-4-ibtisam.tariq@emumba.com", "date": "2020-11-11T08:15:04", "name": "[4/7] examples/performance-thread/l3fwd-thread: enhance getopt_long usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "da8af40c8d28ad21b8cd14fa0d96a494a6d3ad02", "submitter": { "id": 1680, "url": "http://patches.dpdk.org/api/people/1680/?format=api", "name": "Ibtisam Tariq", "email": "ibtisam.tariq@emumba.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111081507.19913-4-ibtisam.tariq@emumba.com/mbox/", "series": [ { "id": 13801, "url": "http://patches.dpdk.org/api/series/13801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13801", "date": "2020-11-11T08:15:01", "name": "[1/7] examples/fips_validation: enhance getopt_long usage", "version": 1, "mbox": "http://patches.dpdk.org/series/13801/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83994/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/83994/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C92EA09D2;\n\tWed, 11 Nov 2020 09:16:33 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 25E975937;\n\tWed, 11 Nov 2020 09:15:53 +0100 (CET)", "from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 549A8DED\n for <dev@dpdk.org>; Wed, 11 Nov 2020 09:15:51 +0100 (CET)", "by mail-wr1-f65.google.com with SMTP id k2so1650762wrx.2\n for <dev@dpdk.org>; Wed, 11 Nov 2020 00:15:51 -0800 (PST)", "from localhost.localdomain ([39.33.227.210])\n by smtp.gmail.com with ESMTPSA id z3sm909539wrw.87.2020.11.11.00.15.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Nov 2020 00:15:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=67/hPuPOrIMwfrb5cwvWLxAILqwcvuZTYJvgWFpLXB0=;\n b=j55vak1QkROGqpw8U9Npxk1xzK5z+42VjB3MbLVIYhAQjjUTkKAqJq9inpAtm9xvJN\n G1cVGXmpfDuthNhgFjRBK2BkIkLozEedl/+ZbS20xNpN7qp8wwum4kqrdFtrAfhLMLNz\n ElPAKyjeATWcJkfIU9OLLXRonTFRnYK8KzslEf6XgMbHqPSKAVZYSXrGkAfxgxgy+1xO\n S8xM01EjasvvgMmNaBUyLUBCv2nr2R/L5emZFVIKs7Gyj2SLqJs03usGUQ/3wTYsFHDB\n i9CiDg/ruTaDfvrAWsOvFgbkuIJYYKBvdWQf+rbZQYvbj2BCkI2c1ee24mtnMrn6DaF9\n cqpw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=67/hPuPOrIMwfrb5cwvWLxAILqwcvuZTYJvgWFpLXB0=;\n b=oJjNLohJmiLZJxOT9ChdVxd5w2BgRU8DAyL3zefRWTG5d3QtG5DShHLgICAHPTbfCZ\n fiFSUpqa8PXWmVgWlMOaujaZdNzPtCx78je40BhzaztheSNdZx1R0lDaxLcCuESZ7nTM\n wjv+qjkvsgvkMCTrf0ken1/pnpFHkbUZXA6n1S/HHPtl3Ha9nzXO2vHGQr3L1VKSIupM\n L+3k2FoR9gpwDzmFXYbCvFfToh1cKOnCFtmcL2sm2f8f1ITakiBFmsvmKbsqvR/1CHY7\n oZgJKNQ3pRa7TKCWRGFE9oQuNUTxVPjebFV143vCXB+/Ri51zQpArA8a1ZUej7lzomYq\n q+Dg==", "X-Gm-Message-State": "AOAM5332iycDZ2tT102AgpXkuUT27NeQo7mZY6RbINCMN3LskCCvSgIM\n +2dXX/gn0nqwHH1RdfjUihS0Pw==", "X-Google-Smtp-Source": "\n ABdhPJyQKqR+jul32he71iZLcVVjFud5XWEFkP40G78xR3sqa4Z3fDTUkGGvY9mhTgD6QIquS/dY1w==", "X-Received": "by 2002:a5d:5450:: with SMTP id w16mr2663490wrv.425.1605082550090;\n Wed, 11 Nov 2020 00:15:50 -0800 (PST)", "From": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n cristian.dumitrescu@intel.com, jasvinder.singh@intel.com,\n john.mcnamara@intel.com, reshma.pattan@intel.com,\n konstantin.ananyev@intel.com, marko.kovacevic@intel.com", "Cc": "dev@dpdk.org, Ibtisam Tariq <ibtisam.tariq@emumba.com>,\n ian.betts@intel.com", "Date": "Wed, 11 Nov 2020 08:15:04 +0000", "Message-Id": "<20201111081507.19913-4-ibtisam.tariq@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201111081507.19913-1-ibtisam.tariq@emumba.com>", "References": "<20201111081507.19913-1-ibtisam.tariq@emumba.com>", "Subject": "[dpdk-dev] [PATCH 4/7] examples/performance-thread/l3fwd-thread:\n\tenhance getopt_long usage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of using getopt_long return value, strcmp was used to\ncompare the input parameters with the struct option array. This\npatch get rid of all those strcmp by directly binding each longopt\nwith an int enum. This is to improve readability and consistency in\nall examples.\n\nBugzilla ID: 238\nCc: ian.betts@intel.com\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n---\nv2\n* Remove extra indentations.\n* Remove extra block brackets in switch statement.\n* Change enum names to start with OPT_ and remove KEYWORD from enum names.\n\nv1\n* enhance getopt_long usage\n---\n .../performance-thread/l3fwd-thread/main.c | 210 +++++++++---------\n 1 file changed, 106 insertions(+), 104 deletions(-)", "diff": "diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c\nindex 7bf61db6b..c75d2a4a3 100644\n--- a/examples/performance-thread/l3fwd-thread/main.c\n+++ b/examples/performance-thread/l3fwd-thread/main.c\n@@ -2858,18 +2858,28 @@ parse_eth_dest(const char *optarg)\n \t\tdest[c] = peer_addr[c];\n \t*(uint64_t *)(val_eth + portid) = dest_eth_addr[portid];\n }\n-\n-#define CMD_LINE_OPT_RX_CONFIG \"rx\"\n-#define CMD_LINE_OPT_TX_CONFIG \"tx\"\n-#define CMD_LINE_OPT_STAT_LCORE \"stat-lcore\"\n-#define CMD_LINE_OPT_ETH_DEST \"eth-dest\"\n-#define CMD_LINE_OPT_NO_NUMA \"no-numa\"\n-#define CMD_LINE_OPT_IPV6 \"ipv6\"\n-#define CMD_LINE_OPT_ENABLE_JUMBO \"enable-jumbo\"\n-#define CMD_LINE_OPT_HASH_ENTRY_NUM \"hash-entry-num\"\n-#define CMD_LINE_OPT_NO_LTHREADS \"no-lthreads\"\n-#define CMD_LINE_OPT_PARSE_PTYPE \"parse-ptype\"\n-\n+enum {\n+#define OPT_RX_CONFIG \"rx\"\n+\tOPT_RX_CONFIG_NUM = 256,\n+#define OPT_TX_CONFIG \"tx\"\n+\tOPT_TX_CONFIG_NUM,\n+#define OPT_STAT_LCORE \"stat-lcore\"\n+\tOPT_STAT_LCORE_NUM,\n+#define OPT_ETH_DEST \"eth-dest\"\n+\tOPT_ETH_DEST_NUM,\n+#define OPT_NO_NUMA \"no-numa\"\n+\tOPT_NO_NUMA_NUM,\n+#define OPT_IPV6 \"ipv6\"\n+\tOPT_IPV6_NUM,\n+#define OPT_ENABLE_JUMBO \"enable-jumbo\"\n+\tOPT_ENABLE_JUMBO_NUM,\n+#define OPT_HASH_ENTRY_NUM \"hash-entry-num\"\n+\tOPT_HASH_ENTRY_NUM_NUM,\n+#define OPT_NO_LTHREADS \"no-lthreads\"\n+\tOPT_NO_LTHREADS_NUM,\n+#define OPT_PARSE_PTYPE \"parse-ptype\"\n+\tOPT_PARSE_PTYPE_NUM,\n+};\n /* Parse the argument given in the command line of the application */\n static int\n parse_args(int argc, char **argv)\n@@ -2879,17 +2889,17 @@ parse_args(int argc, char **argv)\n \tint option_index;\n \tchar *prgname = argv[0];\n \tstatic struct option lgopts[] = {\n-\t\t{CMD_LINE_OPT_RX_CONFIG, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_TX_CONFIG, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_STAT_LCORE, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_ETH_DEST, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_NO_NUMA, 0, 0, 0},\n-\t\t{CMD_LINE_OPT_IPV6, 0, 0, 0},\n-\t\t{CMD_LINE_OPT_ENABLE_JUMBO, 0, 0, 0},\n-\t\t{CMD_LINE_OPT_HASH_ENTRY_NUM, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_NO_LTHREADS, 0, 0, 0},\n-\t\t{CMD_LINE_OPT_PARSE_PTYPE, 0, 0, 0},\n-\t\t{NULL, 0, 0, 0}\n+\t\t{OPT_RX_CONFIG, 1, NULL, OPT_RX_CONFIG_NUM },\n+\t\t{OPT_TX_CONFIG, 1, NULL, OPT_TX_CONFIG_NUM },\n+\t\t{OPT_STAT_LCORE, 1, NULL, OPT_STAT_LCORE_NUM },\n+\t\t{OPT_ETH_DEST, 1, NULL, OPT_ETH_DEST_NUM },\n+\t\t{OPT_NO_NUMA, 0, NULL, OPT_NO_NUMA_NUM },\n+\t\t{OPT_IPV6, 0, NULL, OPT_IPV6_NUM },\n+\t\t{OPT_ENABLE_JUMBO, 0, NULL, OPT_ENABLE_JUMBO_NUM },\n+\t\t{OPT_HASH_ENTRY_NUM, 1, NULL, OPT_HASH_ENTRY_NUM_NUM },\n+\t\t{OPT_NO_LTHREADS, 0, NULL, OPT_NO_LTHREADS_NUM },\n+\t\t{OPT_PARSE_PTYPE, 0, NULL, OPT_PARSE_PTYPE_NUM },\n+\t\t{NULL, 0, 0, 0 }\n \t};\n \n \targvopt = argv;\n@@ -2907,112 +2917,104 @@ parse_args(int argc, char **argv)\n \t\t\t\treturn -1;\n \t\t\t}\n \t\t\tbreak;\n+\n \t\tcase 'P':\n \t\t\tprintf(\"Promiscuous mode selected\\n\");\n \t\t\tpromiscuous_on = 1;\n \t\t\tbreak;\n \n \t\t/* long options */\n-\t\tcase 0:\n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_RX_CONFIG,\n-\t\t\t\tsizeof(CMD_LINE_OPT_RX_CONFIG))) {\n-\t\t\t\tret = parse_rx_config(optarg);\n-\t\t\t\tif (ret) {\n-\t\t\t\t\tprintf(\"invalid rx-config\\n\");\n-\t\t\t\t\tprint_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t}\n+\t\tcase OPT_RX_CONFIG_NUM:\n+\t\t\tret = parse_rx_config(optarg);\n+\t\t\tif (ret) {\n+\t\t\t\tprintf(\"invalid rx-config\\n\");\n+\t\t\t\tprint_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_TX_CONFIG,\n-\t\t\t\tsizeof(CMD_LINE_OPT_TX_CONFIG))) {\n-\t\t\t\tret = parse_tx_config(optarg);\n-\t\t\t\tif (ret) {\n-\t\t\t\t\tprintf(\"invalid tx-config\\n\");\n-\t\t\t\t\tprint_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t}\n+\t\tcase OPT_TX_CONFIG_NUM:\n+\t\t\tret = parse_tx_config(optarg);\n+\t\t\tif (ret) {\n+\t\t\t\tprintf(\"invalid tx-config\\n\");\n+\t\t\t\tprint_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tbreak;\n \n #if (APP_CPU_LOAD > 0)\n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_STAT_LCORE,\n-\t\t\t\t\tsizeof(CMD_LINE_OPT_STAT_LCORE))) {\n-\t\t\t\tcpu_load_lcore_id = parse_stat_lcore(optarg);\n-\t\t\t}\n+\t\tcase OPT_STAT_LCORE_NUM:\n+\t\t\tcpu_load_lcore_id = parse_stat_lcore(optarg);\n+\t\t\tbreak;\n #endif\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_ETH_DEST,\n-\t\t\t\tsizeof(CMD_LINE_OPT_ETH_DEST)))\n-\t\t\t\t\tparse_eth_dest(optarg);\n+\t\tcase OPT_ETH_DEST_NUM:\n+\t\t\tparse_eth_dest(optarg);\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_NO_NUMA,\n-\t\t\t\tsizeof(CMD_LINE_OPT_NO_NUMA))) {\n-\t\t\t\tprintf(\"numa is disabled\\n\");\n-\t\t\t\tnuma_on = 0;\n-\t\t\t}\n+\t\tcase OPT_NO_NUMA_NUM:\n+\t\t\tprintf(\"numa is disabled\\n\");\n+\t\t\tnuma_on = 0;\n+\t\t\tbreak;\n \n #if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_IPV6,\n-\t\t\t\tsizeof(CMD_LINE_OPT_IPV6))) {\n-\t\t\t\tprintf(\"ipv6 is specified\\n\");\n-\t\t\t\tipv6 = 1;\n-\t\t\t}\n+\t\tcase OPT_IPV6_NUM:\n+\t\t\tprintf(\"ipv6 is specified\\n\");\n+\t\t\tipv6 = 1;\n+\t\t\tbreak;\n #endif\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_NO_LTHREADS,\n-\t\t\t\t\tsizeof(CMD_LINE_OPT_NO_LTHREADS))) {\n-\t\t\t\tprintf(\"l-threads model is disabled\\n\");\n-\t\t\t\tlthreads_on = 0;\n-\t\t\t}\n+\t\tcase OPT_NO_LTHREADS_NUM:\n+\t\t\tprintf(\"l-threads model is disabled\\n\");\n+\t\t\tlthreads_on = 0;\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_PARSE_PTYPE,\n-\t\t\t\t\tsizeof(CMD_LINE_OPT_PARSE_PTYPE))) {\n-\t\t\t\tprintf(\"software packet type parsing enabled\\n\");\n-\t\t\t\tparse_ptype_on = 1;\n-\t\t\t}\n+\t\tcase OPT_PARSE_PTYPE_NUM:\n+\t\t\tprintf(\"software packet type parsing enabled\\n\");\n+\t\t\tparse_ptype_on = 1;\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_ENABLE_JUMBO,\n-\t\t\t\tsizeof(CMD_LINE_OPT_ENABLE_JUMBO))) {\n-\t\t\t\tstruct option lenopts = {\"max-pkt-len\", required_argument, 0,\n-\t\t\t\t\t\t0};\n-\n-\t\t\t\tprintf(\"jumbo frame is enabled - disabling simple TX path\\n\");\n-\t\t\t\tport_conf.rxmode.offloads |=\n-\t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n-\t\t\t\tport_conf.txmode.offloads |=\n-\t\t\t\t\t\tDEV_TX_OFFLOAD_MULTI_SEGS;\n-\n-\t\t\t\t/* if no max-pkt-len set, use the default value\n-\t\t\t\t * RTE_ETHER_MAX_LEN\n-\t\t\t\t */\n-\t\t\t\tif (0 == getopt_long(argc, argvopt, \"\", &lenopts,\n-\t\t\t\t\t\t&option_index)) {\n-\n-\t\t\t\t\tret = parse_max_pkt_len(optarg);\n-\t\t\t\t\tif ((ret < 64) || (ret > MAX_JUMBO_PKT_LEN)) {\n-\t\t\t\t\t\tprintf(\"invalid packet length\\n\");\n-\t\t\t\t\t\tprint_usage(prgname);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tport_conf.rxmode.max_rx_pkt_len = ret;\n-\t\t\t\t}\n-\t\t\t\tprintf(\"set jumbo frame max packet length to %u\\n\",\n-\t\t\t\t\t\t(unsigned int)port_conf.rxmode.max_rx_pkt_len);\n-\t\t\t}\n-#if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_HASH_ENTRY_NUM,\n-\t\t\t\tsizeof(CMD_LINE_OPT_HASH_ENTRY_NUM))) {\n-\t\t\t\tret = parse_hash_entry_number(optarg);\n-\t\t\t\tif ((ret > 0) && (ret <= L3FWD_HASH_ENTRIES)) {\n-\t\t\t\t\thash_entry_number = ret;\n-\t\t\t\t} else {\n-\t\t\t\t\tprintf(\"invalid hash entry number\\n\");\n+\t\tcase OPT_ENABLE_JUMBO_NUM:\n+\t\t{\n+\t\t\tstruct option lenopts = {\"max-pkt-len\",\n+\t\t\t\t\trequired_argument, 0, 0};\n+\n+\t\t\tprintf(\"jumbo frame is enabled - disabling simple TX path\\n\");\n+\t\t\tport_conf.rxmode.offloads |=\n+\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t\t\tport_conf.txmode.offloads |=\n+\t\t\t\t\tDEV_TX_OFFLOAD_MULTI_SEGS;\n+\n+\t\t\t/* if no max-pkt-len set, use the default value\n+\t\t\t * RTE_ETHER_MAX_LEN\n+\t\t\t */\n+\t\t\tif (0 == getopt_long(argc, argvopt, \"\", &lenopts,\n+\t\t\t\t\t&option_index)) {\n+\n+\t\t\t\tret = parse_max_pkt_len(optarg);\n+\t\t\t\tif ((ret < 64) || (ret > MAX_JUMBO_PKT_LEN)) {\n+\t\t\t\t\tprintf(\"invalid packet length\\n\");\n \t\t\t\t\tprint_usage(prgname);\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n+\t\t\t\tport_conf.rxmode.max_rx_pkt_len = ret;\n \t\t\t}\n-#endif\n+\t\t\tprintf(\"set jumbo frame max packet length to %u\\n\",\n+\t\t\t\t(unsigned int)port_conf.rxmode.max_rx_pkt_len);\n \t\t\tbreak;\n+\t\t}\n+#if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\n+\t\tcase OPT_HASH_ENTRY_NUM_NUM:\n+\t\t\tret = parse_hash_entry_number(optarg);\n+\t\t\tif ((ret > 0) && (ret <= L3FWD_HASH_ENTRIES)) {\n+\t\t\t\thash_entry_number = ret;\n+\t\t\t} else {\n+\t\t\t\tprintf(\"invalid hash entry number\\n\");\n+\t\t\t\tprint_usage(prgname);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tbreak;\n+#endif\n \n \t\tdefault:\n \t\t\tprint_usage(prgname);\n", "prefixes": [ "4/7" ] }