Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83980/?format=api
{ "id": 83980, "url": "http://patches.dpdk.org/api/patches/83980/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-25-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-25-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-25-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:23", "name": "[v2,24/37] net/txgbe: add flow API destroy function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ec49fc73b2adba46b3f69adbee50f70996c49b98", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-25-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83980/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83980/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A645A09D2;\n\tWed, 11 Nov 2020 08:00:54 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B9CEA592B;\n\tWed, 11 Nov 2020 07:48:42 +0100 (CET)", "from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130])\n by dpdk.org (Postfix) with ESMTP id B881B592C\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:48:39 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:51 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077271t0el2oij", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "ZW0iyQuFPjkQYCxBXU/MrtK2AdNTOZzc2l8mzqRIz21NzmwU76xp+V+SUYs5+\n 3nT7o6k0eVrxQaJUtDTC145V1i1j2p09ohX9M8QjYAYGfrwL8DhGY/bx43gXHJXO3c484Ns\n bMG22NY9/74iSLkGOen6qlgYUQdYZABFUI0jt0WHETKV0aN1iEu+YchDVMc+5O21u63yKyn\n Q5hugKBcndm4yrjRtDJ7i4L4e/J5U/zTpg35ljYlbFkSOOZm7xZwX2yyyWhXw0B8pAJKuZe\n S1fb1BOGaSYwN4S0gr+7N6GT+brgNFkOc6Qu7P83vCcOmnTd5zF9Niy95Qx0y+nJe6kDa6h\n dqjoZYQFDC+jIb+xyg=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:23 +0800", "Message-Id": "<20201111064936.768604-25-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 24/37] net/txgbe: add flow API destroy function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support to destroy operation for flow API.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_flow.c | 128 +++++++++++++++++++++++++++++++++\n 1 file changed, 128 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex 4141352bf..8d5362175 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -2942,8 +2942,136 @@ txgbe_flow_validate(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n+/* Destroy a flow rule on txgbe. */\n+static int\n+txgbe_flow_destroy(struct rte_eth_dev *dev,\n+\t\tstruct rte_flow *flow,\n+\t\tstruct rte_flow_error *error)\n+{\n+\tint ret;\n+\tstruct rte_flow *pmd_flow = flow;\n+\tenum rte_filter_type filter_type = pmd_flow->filter_type;\n+\tstruct rte_eth_ntuple_filter ntuple_filter;\n+\tstruct rte_eth_ethertype_filter ethertype_filter;\n+\tstruct rte_eth_syn_filter syn_filter;\n+\tstruct txgbe_fdir_rule fdir_rule;\n+\tstruct txgbe_l2_tunnel_conf l2_tn_filter;\n+\tstruct txgbe_ntuple_filter_ele *ntuple_filter_ptr;\n+\tstruct txgbe_ethertype_filter_ele *ethertype_filter_ptr;\n+\tstruct txgbe_eth_syn_filter_ele *syn_filter_ptr;\n+\tstruct txgbe_eth_l2_tunnel_conf_ele *l2_tn_filter_ptr;\n+\tstruct txgbe_fdir_rule_ele *fdir_rule_ptr;\n+\tstruct txgbe_flow_mem *txgbe_flow_mem_ptr;\n+\tstruct txgbe_hw_fdir_info *fdir_info = TXGBE_DEV_FDIR(dev);\n+\tstruct txgbe_rss_conf_ele *rss_filter_ptr;\n+\n+\tswitch (filter_type) {\n+\tcase RTE_ETH_FILTER_NTUPLE:\n+\t\tntuple_filter_ptr = (struct txgbe_ntuple_filter_ele *)\n+\t\t\t\t\tpmd_flow->rule;\n+\t\trte_memcpy(&ntuple_filter,\n+\t\t\t&ntuple_filter_ptr->filter_info,\n+\t\t\tsizeof(struct rte_eth_ntuple_filter));\n+\t\tret = txgbe_add_del_ntuple_filter(dev, &ntuple_filter, FALSE);\n+\t\tif (!ret) {\n+\t\t\tTAILQ_REMOVE(&filter_ntuple_list,\n+\t\t\tntuple_filter_ptr, entries);\n+\t\t\trte_free(ntuple_filter_ptr);\n+\t\t}\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_ETHERTYPE:\n+\t\tethertype_filter_ptr = (struct txgbe_ethertype_filter_ele *)\n+\t\t\t\t\tpmd_flow->rule;\n+\t\trte_memcpy(ðertype_filter,\n+\t\t\tðertype_filter_ptr->filter_info,\n+\t\t\tsizeof(struct rte_eth_ethertype_filter));\n+\t\tret = txgbe_add_del_ethertype_filter(dev,\n+\t\t\t\tðertype_filter, FALSE);\n+\t\tif (!ret) {\n+\t\t\tTAILQ_REMOVE(&filter_ethertype_list,\n+\t\t\t\tethertype_filter_ptr, entries);\n+\t\t\trte_free(ethertype_filter_ptr);\n+\t\t}\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_SYN:\n+\t\tsyn_filter_ptr = (struct txgbe_eth_syn_filter_ele *)\n+\t\t\t\tpmd_flow->rule;\n+\t\trte_memcpy(&syn_filter,\n+\t\t\t&syn_filter_ptr->filter_info,\n+\t\t\tsizeof(struct rte_eth_syn_filter));\n+\t\tret = txgbe_syn_filter_set(dev, &syn_filter, FALSE);\n+\t\tif (!ret) {\n+\t\t\tTAILQ_REMOVE(&filter_syn_list,\n+\t\t\t\tsyn_filter_ptr, entries);\n+\t\t\trte_free(syn_filter_ptr);\n+\t\t}\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_FDIR:\n+\t\tfdir_rule_ptr = (struct txgbe_fdir_rule_ele *)pmd_flow->rule;\n+\t\trte_memcpy(&fdir_rule,\n+\t\t\t&fdir_rule_ptr->filter_info,\n+\t\t\tsizeof(struct txgbe_fdir_rule));\n+\t\tret = txgbe_fdir_filter_program(dev, &fdir_rule, TRUE, FALSE);\n+\t\tif (!ret) {\n+\t\t\tTAILQ_REMOVE(&filter_fdir_list,\n+\t\t\t\tfdir_rule_ptr, entries);\n+\t\t\trte_free(fdir_rule_ptr);\n+\t\t\tif (TAILQ_EMPTY(&filter_fdir_list))\n+\t\t\t\tfdir_info->mask_added = false;\n+\t\t}\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_L2_TUNNEL:\n+\t\tl2_tn_filter_ptr = (struct txgbe_eth_l2_tunnel_conf_ele *)\n+\t\t\t\tpmd_flow->rule;\n+\t\trte_memcpy(&l2_tn_filter, &l2_tn_filter_ptr->filter_info,\n+\t\t\tsizeof(struct txgbe_l2_tunnel_conf));\n+\t\tret = txgbe_dev_l2_tunnel_filter_del(dev, &l2_tn_filter);\n+\t\tif (!ret) {\n+\t\t\tTAILQ_REMOVE(&filter_l2_tunnel_list,\n+\t\t\t\tl2_tn_filter_ptr, entries);\n+\t\t\trte_free(l2_tn_filter_ptr);\n+\t\t}\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_HASH:\n+\t\trss_filter_ptr = (struct txgbe_rss_conf_ele *)\n+\t\t\t\tpmd_flow->rule;\n+\t\tret = txgbe_config_rss_filter(dev,\n+\t\t\t\t\t&rss_filter_ptr->filter_info, FALSE);\n+\t\tif (!ret) {\n+\t\t\tTAILQ_REMOVE(&filter_rss_list,\n+\t\t\t\trss_filter_ptr, entries);\n+\t\t\trte_free(rss_filter_ptr);\n+\t\t}\n+\t\tbreak;\n+\tdefault:\n+\t\tPMD_DRV_LOG(WARNING, \"Filter type (%d) not supported\",\n+\t\t\t filter_type);\n+\t\tret = -EINVAL;\n+\t\tbreak;\n+\t}\n+\n+\tif (ret) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_HANDLE,\n+\t\t\t\tNULL, \"Failed to destroy flow\");\n+\t\treturn ret;\n+\t}\n+\n+\tTAILQ_FOREACH(txgbe_flow_mem_ptr, &txgbe_flow_list, entries) {\n+\t\tif (txgbe_flow_mem_ptr->flow == pmd_flow) {\n+\t\t\tTAILQ_REMOVE(&txgbe_flow_list,\n+\t\t\t\ttxgbe_flow_mem_ptr, entries);\n+\t\t\trte_free(txgbe_flow_mem_ptr);\n+\t\t}\n+\t}\n+\trte_free(flow);\n+\n+\treturn ret;\n+}\n+\n const struct rte_flow_ops txgbe_flow_ops = {\n \t.validate = txgbe_flow_validate,\n \t.create = txgbe_flow_create,\n+\t.destroy = txgbe_flow_destroy,\n };\n \n", "prefixes": [ "v2", "24/37" ] }