Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83978/?format=api
{ "id": 83978, "url": "http://patches.dpdk.org/api/patches/83978/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-36-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-36-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-36-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:34", "name": "[v2,35/37] net/txgbe: support security session destroy", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d8c7f640cafe222ed88cf507fb8e7fe8d313d86f", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-36-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83978/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/83978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 63330A09D2;\n\tWed, 11 Nov 2020 08:00:14 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A2560C8B0;\n\tWed, 11 Nov 2020 07:48:32 +0100 (CET)", "from smtpbguseast1.qq.com (smtpbguseast1.qq.com [54.204.34.129])\n by dpdk.org (Postfix) with ESMTP id 1B436C804\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:48:16 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:48:05 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077286ta5jllu9", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "f0dVAzX4zglC+UAAWOmVsnsDa+twMcVtfB7WuvTlkp5xrshj1h4Vi6NL1fH+D\n WIkZrG2gfTzPANCKMPpSZ91Sl//9rR0UkHZyABDPbVMqpjI2Vf26zJxybcODwcGFx+3IMih\n tbU54cGUeZsjAxnZRumgJX7NuzmaakTHKmCBdvlzoVA8JpvNugEBDNES+dJwYodaFb6ZSQD\n a3W3n4XmqFi7AU6zjls+BGe2qXz6DteNxg/wTZIRZZu4dt4v5umueHKmAgydVDS6+ER4pKf\n H6iFbJF0Cou/xc67L7Jxfml74HbFq867aXWzhZh7gEhJOIjxjycdVXdqRkcP30sbQA1thdA\n jMMG99BfWKdji9ZGLlE7UdkZO4jGA==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:34 +0800", "Message-Id": "<20201111064936.768604-36-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 35/37] net/txgbe: support security session\n\tdestroy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support to clear a security session's private data,\nget the size of a security session,\nadd update the mbuf with provided metadata.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ipsec.c | 167 ++++++++++++++++++++++++++++++++\n drivers/net/txgbe/txgbe_ipsec.h | 15 +++\n 2 files changed, 182 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c\nindex 7501e25af..0bdd1c061 100644\n--- a/drivers/net/txgbe/txgbe_ipsec.c\n+++ b/drivers/net/txgbe/txgbe_ipsec.c\n@@ -199,6 +199,106 @@ txgbe_crypto_add_sa(struct txgbe_crypto_session *ic_session)\n \treturn 0;\n }\n \n+static int\n+txgbe_crypto_remove_sa(struct rte_eth_dev *dev,\n+\t\t struct txgbe_crypto_session *ic_session)\n+{\n+\tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n+\tstruct txgbe_ipsec *priv = TXGBE_DEV_IPSEC(dev);\n+\tuint32_t reg_val;\n+\tint sa_index = -1;\n+\n+\tif (ic_session->op == TXGBE_OP_AUTHENTICATED_DECRYPTION) {\n+\t\tint i, ip_index = -1;\n+\n+\t\t/* Find a match in the IP table*/\n+\t\tfor (i = 0; i < IPSEC_MAX_RX_IP_COUNT; i++) {\n+\t\t\tif (CMP_IP(priv->rx_ip_tbl[i].ip, ic_session->dst_ip)) {\n+\t\t\t\tip_index = i;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t}\n+\n+\t\t/* Fail if no match*/\n+\t\tif (ip_index < 0) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Entry not found in the Rx IP table\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\t/* Find a free entry in the SA table*/\n+\t\tfor (i = 0; i < IPSEC_MAX_SA_COUNT; i++) {\n+\t\t\tif (priv->rx_sa_tbl[i].spi ==\n+\t\t\t\t rte_cpu_to_be_32(ic_session->spi)) {\n+\t\t\t\tsa_index = i;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t}\n+\t\t/* Fail if no match*/\n+\t\tif (sa_index < 0) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Entry not found in the Rx SA table\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\t/* Disable and clear Rx SPI and key table table entryes*/\n+\t\treg_val = TXGBE_IPSRXIDX_WRITE |\n+\t\t\tTXGBE_IPSRXIDX_TB_SPI | (sa_index << 3);\n+\t\twr32(hw, TXGBE_IPSRXSPI, 0);\n+\t\twr32(hw, TXGBE_IPSRXADDRIDX, 0);\n+\t\twr32w(hw, TXGBE_IPSRXIDX, reg_val, TXGBE_IPSRXIDX_WRITE, 1000);\n+\t\treg_val = TXGBE_IPSRXIDX_WRITE |\n+\t\t\tTXGBE_IPSRXIDX_TB_KEY | (sa_index << 3);\n+\t\twr32(hw, TXGBE_IPSRXKEY(0), 0);\n+\t\twr32(hw, TXGBE_IPSRXKEY(1), 0);\n+\t\twr32(hw, TXGBE_IPSRXKEY(2), 0);\n+\t\twr32(hw, TXGBE_IPSRXKEY(3), 0);\n+\t\twr32(hw, TXGBE_IPSRXSALT, 0);\n+\t\twr32(hw, TXGBE_IPSRXMODE, 0);\n+\t\twr32w(hw, TXGBE_IPSRXIDX, reg_val, TXGBE_IPSRXIDX_WRITE, 1000);\n+\t\tpriv->rx_sa_tbl[sa_index].used = 0;\n+\n+\t\t/* If last used then clear the IP table entry*/\n+\t\tpriv->rx_ip_tbl[ip_index].ref_count--;\n+\t\tif (priv->rx_ip_tbl[ip_index].ref_count == 0) {\n+\t\t\treg_val = TXGBE_IPSRXIDX_WRITE | TXGBE_IPSRXIDX_TB_IP |\n+\t\t\t\t\t(ip_index << 3);\n+\t\t\twr32(hw, TXGBE_IPSRXADDR(0), 0);\n+\t\t\twr32(hw, TXGBE_IPSRXADDR(1), 0);\n+\t\t\twr32(hw, TXGBE_IPSRXADDR(2), 0);\n+\t\t\twr32(hw, TXGBE_IPSRXADDR(3), 0);\n+\t\t}\n+\t} else { /* session->dir == RTE_CRYPTO_OUTBOUND */\n+\t\tint i;\n+\n+\t\t/* Find a match in the SA table*/\n+\t\tfor (i = 0; i < IPSEC_MAX_SA_COUNT; i++) {\n+\t\t\tif (priv->tx_sa_tbl[i].spi ==\n+\t\t\t\t rte_cpu_to_be_32(ic_session->spi)) {\n+\t\t\t\tsa_index = i;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t}\n+\t\t/* Fail if no match entries*/\n+\t\tif (sa_index < 0) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Entry not found in the Tx SA table\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\treg_val = TXGBE_IPSRXIDX_WRITE | (sa_index << 3);\n+\t\twr32(hw, TXGBE_IPSTXKEY(0), 0);\n+\t\twr32(hw, TXGBE_IPSTXKEY(1), 0);\n+\t\twr32(hw, TXGBE_IPSTXKEY(2), 0);\n+\t\twr32(hw, TXGBE_IPSTXKEY(3), 0);\n+\t\twr32(hw, TXGBE_IPSTXSALT, 0);\n+\t\twr32w(hw, TXGBE_IPSTXIDX, reg_val, TXGBE_IPSTXIDX_WRITE, 1000);\n+\n+\t\tpriv->tx_sa_tbl[sa_index].used = 0;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n txgbe_crypto_create_session(void *device,\n \t\tstruct rte_security_session_conf *conf,\n@@ -262,6 +362,70 @@ txgbe_crypto_create_session(void *device,\n \treturn 0;\n }\n \n+static unsigned int\n+txgbe_crypto_session_get_size(__rte_unused void *device)\n+{\n+\treturn sizeof(struct txgbe_crypto_session);\n+}\n+\n+static int\n+txgbe_crypto_remove_session(void *device,\n+\t\tstruct rte_security_session *session)\n+{\n+\tstruct rte_eth_dev *eth_dev = device;\n+\tstruct txgbe_crypto_session *ic_session =\n+\t\t(struct txgbe_crypto_session *)\n+\t\tget_sec_session_private_data(session);\n+\tstruct rte_mempool *mempool = rte_mempool_from_obj(ic_session);\n+\n+\tif (eth_dev != ic_session->dev) {\n+\t\tPMD_DRV_LOG(ERR, \"Session not bound to this device\\n\");\n+\t\treturn -ENODEV;\n+\t}\n+\n+\tif (txgbe_crypto_remove_sa(eth_dev, ic_session)) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to remove session\\n\");\n+\t\treturn -EFAULT;\n+\t}\n+\n+\trte_mempool_put(mempool, (void *)ic_session);\n+\n+\treturn 0;\n+}\n+\n+static inline uint8_t\n+txgbe_crypto_compute_pad_len(struct rte_mbuf *m)\n+{\n+\tif (m->nb_segs == 1) {\n+\t\t/* 16 bytes ICV + 2 bytes ESP trailer + payload padding size\n+\t\t * payload padding size is stored at <pkt_len - 18>\n+\t\t */\n+\t\tuint8_t *esp_pad_len = rte_pktmbuf_mtod_offset(m, uint8_t *,\n+\t\t\t\t\trte_pktmbuf_pkt_len(m) -\n+\t\t\t\t\t(ESP_TRAILER_SIZE + ESP_ICV_SIZE));\n+\t\treturn *esp_pad_len + ESP_TRAILER_SIZE + ESP_ICV_SIZE;\n+\t}\n+\treturn 0;\n+}\n+\n+static int\n+txgbe_crypto_update_mb(void *device __rte_unused,\n+\t\tstruct rte_security_session *session,\n+\t\t struct rte_mbuf *m, void *params __rte_unused)\n+{\n+\tstruct txgbe_crypto_session *ic_session =\n+\t\t\tget_sec_session_private_data(session);\n+\tif (ic_session->op == TXGBE_OP_AUTHENTICATED_ENCRYPTION) {\n+\t\tunion txgbe_crypto_tx_desc_md *mdata =\n+\t\t\t(union txgbe_crypto_tx_desc_md *)\n+\t\t\t\trte_security_dynfield(m);\n+\t\tmdata->enc = 1;\n+\t\tmdata->sa_idx = ic_session->sa_index;\n+\t\tmdata->pad_len = txgbe_crypto_compute_pad_len(m);\n+\t}\n+\treturn 0;\n+}\n+\n static const struct rte_security_capability *\n txgbe_crypto_capabilities_get(void *device __rte_unused)\n {\n@@ -390,6 +554,9 @@ txgbe_crypto_capabilities_get(void *device __rte_unused)\n \n static struct rte_security_ops txgbe_security_ops = {\n \t.session_create = txgbe_crypto_create_session,\n+\t.session_get_size = txgbe_crypto_session_get_size,\n+\t.session_destroy = txgbe_crypto_remove_session,\n+\t.set_pkt_metadata = txgbe_crypto_update_mb,\n \t.capabilities_get = txgbe_crypto_capabilities_get\n };\n \ndiff --git a/drivers/net/txgbe/txgbe_ipsec.h b/drivers/net/txgbe/txgbe_ipsec.h\nindex c94775636..d022a255f 100644\n--- a/drivers/net/txgbe/txgbe_ipsec.h\n+++ b/drivers/net/txgbe/txgbe_ipsec.h\n@@ -17,6 +17,9 @@\n #define IPSEC_MAX_RX_IP_COUNT 128\n #define IPSEC_MAX_SA_COUNT 1024\n \n+#define ESP_ICV_SIZE 16\n+#define ESP_TRAILER_SIZE 2\n+\n enum txgbe_operation {\n \tTXGBE_OP_AUTHENTICATED_ENCRYPTION,\n \tTXGBE_OP_AUTHENTICATED_DECRYPTION\n@@ -68,6 +71,18 @@ struct txgbe_crypto_tx_sa_table {\n \tuint8_t used;\n };\n \n+union txgbe_crypto_tx_desc_md {\n+\tuint64_t data;\n+\tstruct {\n+\t\t/**< SA table index */\n+\t\tuint32_t sa_idx;\n+\t\t/**< ICV and ESP trailer length */\n+\t\tuint8_t pad_len;\n+\t\t/**< enable encryption */\n+\t\tuint8_t enc;\n+\t};\n+};\n+\n struct txgbe_ipsec {\n \tstruct txgbe_crypto_rx_ip_table rx_ip_tbl[IPSEC_MAX_RX_IP_COUNT];\n \tstruct txgbe_crypto_rx_sa_table rx_sa_tbl[IPSEC_MAX_SA_COUNT];\n", "prefixes": [ "v2", "35/37" ] }