Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83977/?format=api
{ "id": 83977, "url": "http://patches.dpdk.org/api/patches/83977/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-38-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-38-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-38-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:36", "name": "[v2,37/37] net/txgbe: add security type in flow action", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "dba0577f0ef97a48d3604f1d6d9531d472f24c4b", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-38-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83977/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/83977/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86A8AA09D2;\n\tWed, 11 Nov 2020 07:59:51 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 048BDC86E;\n\tWed, 11 Nov 2020 07:48:31 +0100 (CET)", "from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22])\n by dpdk.org (Postfix) with ESMTP id C7926C7EA\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:48:12 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:48:08 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077288t7aj339r", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "lRUSrEWtKQDfnvSBSMR44JGt31YkfSPUSPRJ5CGrs6PV1uaRmTyKOrd05KPIN\n VlT3sfU6uFjgPt3fu+DSjpywXeTTt4h5eX7fS31nhFb6fyNJw0OBaJmgfzhFWxrqmszV5gv\n ENoJBd6J5txmByJLx65x+8e0+mj5P7eY4bc2d5dYzqtus6ivFB0AcGC/64/1NiJvsXHlNWb\n US0yj6dzKwuxXlrxz/paE2xNrnaDJxF0sN/s9SSz6R0yr43hiaTDCSEJishkcos/l1HfvFw\n CREA//Ydj4W6GpPjSNV1UixDqSiCXbacXyuCoCvkDNt9ikIcgKunPjboJZOQzO4VIjsSEes\n Q23u/EkGEP/BzHf2G1HoM9i5eS28g==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:36 +0800", "Message-Id": "<20201111064936.768604-38-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 37/37] net/txgbe: add security type in flow\n\taction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add security type in flow action.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_flow.c | 52 +++++++++++++++++++++++++++++++++\n drivers/net/txgbe/txgbe_ipsec.c | 30 +++++++++++++++++++\n drivers/net/txgbe/txgbe_ipsec.h | 3 ++\n 3 files changed, 85 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex b5f4073e2..5ca89d619 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -145,6 +145,9 @@ const struct rte_flow_action *next_no_void_action(\n * END\n * other members in mask and spec should set to 0x00.\n * item->last should be NULL.\n+ *\n+ * Special case for flow action type RTE_FLOW_ACTION_TYPE_SECURITY.\n+ *\n */\n static int\n cons_parse_ntuple_filter(const struct rte_flow_attr *attr,\n@@ -193,6 +196,43 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr,\n \tmemset(ð_null, 0, sizeof(struct rte_flow_item_eth));\n \tmemset(&vlan_null, 0, sizeof(struct rte_flow_item_vlan));\n \n+#ifdef RTE_LIB_SECURITY\n+\t/**\n+\t * Special case for flow action type RTE_FLOW_ACTION_TYPE_SECURITY\n+\t */\n+\tact = next_no_void_action(actions, NULL);\n+\tif (act->type == RTE_FLOW_ACTION_TYPE_SECURITY) {\n+\t\tconst void *conf = act->conf;\n+\t\t/* check if the next not void item is END */\n+\t\tact = next_no_void_action(actions, act);\n+\t\tif (act->type != RTE_FLOW_ACTION_TYPE_END) {\n+\t\t\tmemset(filter, 0, sizeof(struct rte_eth_ntuple_filter));\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact, \"Not supported action.\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\n+\t\t/* get the IP pattern*/\n+\t\titem = next_no_void_pattern(pattern, NULL);\n+\t\twhile (item->type != RTE_FLOW_ITEM_TYPE_IPV4 &&\n+\t\t\t\titem->type != RTE_FLOW_ITEM_TYPE_IPV6) {\n+\t\t\tif (item->last ||\n+\t\t\t\t\titem->type == RTE_FLOW_ITEM_TYPE_END) {\n+\t\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\titem, \"IP pattern missing.\");\n+\t\t\t\treturn -rte_errno;\n+\t\t\t}\n+\t\t\titem = next_no_void_pattern(pattern, item);\n+\t\t}\n+\n+\t\tfilter->proto = IPPROTO_ESP;\n+\t\treturn txgbe_crypto_add_ingress_sa_from_flow(conf, item->spec,\n+\t\t\t\t\titem->type == RTE_FLOW_ITEM_TYPE_IPV6);\n+\t}\n+#endif\n+\n \t/* the first not void item can be MAC or IPv4 */\n \titem = next_no_void_pattern(pattern, NULL);\n \n@@ -563,6 +603,12 @@ txgbe_parse_ntuple_filter(struct rte_eth_dev *dev,\n \tif (ret)\n \t\treturn ret;\n \n+#ifdef RTE_LIB_SECURITY\n+\t/* ESP flow not really a flow */\n+\tif (filter->proto == IPPROTO_ESP)\n+\t\treturn 0;\n+#endif\n+\n \t/* txgbe doesn't support tcp flags */\n \tif (filter->flags & RTE_NTUPLE_FLAGS_TCP_FLAG) {\n \t\tmemset(filter, 0, sizeof(struct rte_eth_ntuple_filter));\n@@ -2690,6 +2736,12 @@ txgbe_flow_create(struct rte_eth_dev *dev,\n \tret = txgbe_parse_ntuple_filter(dev, attr, pattern,\n \t\t\tactions, &ntuple_filter, error);\n \n+#ifdef RTE_LIB_SECURITY\n+\t/* ESP flow not really a flow*/\n+\tif (ntuple_filter.proto == IPPROTO_ESP)\n+\t\treturn flow;\n+#endif\n+\n \tif (!ret) {\n \t\tret = txgbe_add_del_ntuple_filter(dev, &ntuple_filter, TRUE);\n \t\tif (!ret) {\ndiff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c\nindex f8c54f3d4..d0543ce0b 100644\n--- a/drivers/net/txgbe/txgbe_ipsec.c\n+++ b/drivers/net/txgbe/txgbe_ipsec.c\n@@ -658,6 +658,36 @@ txgbe_crypto_enable_ipsec(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+int\n+txgbe_crypto_add_ingress_sa_from_flow(const void *sess,\n+\t\t\t\t const void *ip_spec,\n+\t\t\t\t uint8_t is_ipv6)\n+{\n+\tstruct txgbe_crypto_session *ic_session =\n+\t\t\tget_sec_session_private_data(sess);\n+\n+\tif (ic_session->op == TXGBE_OP_AUTHENTICATED_DECRYPTION) {\n+\t\tif (is_ipv6) {\n+\t\t\tconst struct rte_flow_item_ipv6 *ipv6 = ip_spec;\n+\t\t\tic_session->src_ip.type = IPv6;\n+\t\t\tic_session->dst_ip.type = IPv6;\n+\t\t\trte_memcpy(ic_session->src_ip.ipv6,\n+\t\t\t\t ipv6->hdr.src_addr, 16);\n+\t\t\trte_memcpy(ic_session->dst_ip.ipv6,\n+\t\t\t\t ipv6->hdr.dst_addr, 16);\n+\t\t} else {\n+\t\t\tconst struct rte_flow_item_ipv4 *ipv4 = ip_spec;\n+\t\t\tic_session->src_ip.type = IPv4;\n+\t\t\tic_session->dst_ip.type = IPv4;\n+\t\t\tic_session->src_ip.ipv4 = ipv4->hdr.src_addr;\n+\t\t\tic_session->dst_ip.ipv4 = ipv4->hdr.dst_addr;\n+\t\t}\n+\t\treturn txgbe_crypto_add_sa(ic_session);\n+\t}\n+\n+\treturn 0;\n+}\n+\n static struct rte_security_ops txgbe_security_ops = {\n \t.session_create = txgbe_crypto_create_session,\n \t.session_get_size = txgbe_crypto_session_get_size,\ndiff --git a/drivers/net/txgbe/txgbe_ipsec.h b/drivers/net/txgbe/txgbe_ipsec.h\nindex 54c27d8ce..1e5678437 100644\n--- a/drivers/net/txgbe/txgbe_ipsec.h\n+++ b/drivers/net/txgbe/txgbe_ipsec.h\n@@ -91,5 +91,8 @@ struct txgbe_ipsec {\n \n int txgbe_ipsec_ctx_create(struct rte_eth_dev *dev);\n int txgbe_crypto_enable_ipsec(struct rte_eth_dev *dev);\n+int txgbe_crypto_add_ingress_sa_from_flow(const void *sess,\n+\t\t\t\t\t const void *ip_spec,\n+\t\t\t\t\t uint8_t is_ipv6);\n \n #endif /*TXGBE_IPSEC_H_*/\n", "prefixes": [ "v2", "37/37" ] }