Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83970/?format=api
{ "id": 83970, "url": "http://patches.dpdk.org/api/patches/83970/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-23-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-23-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-23-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:21", "name": "[v2,22/37] net/txgbe: add generic flow API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fa067ceca01e1c560c167e0cfaaa911b92518da4", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-23-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83970/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/83970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6DFEDA09D2;\n\tWed, 11 Nov 2020 07:57:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D9A4C814;\n\tWed, 11 Nov 2020 07:48:20 +0100 (CET)", "from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56])\n by dpdk.org (Postfix) with ESMTP id 3CEC2BE49\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:48:04 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:48 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077269t37qemiu", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "FjvBusSIvfigX5K5fWTr8nicIR4AxWZKQt4xIqR0a5IHyzWxoD46obKmt5TWN\n hQlMgHIjnHaMeBG2dzJnXhMDZINs/YxprALUTAg3f0cJydi6gtHgSnx1HCplUraiX5MzUKU\n DQVgqyeWRE4rdyQHhkv9Rb71/nSEJ/rO77dERno7IWFiAHGjEIwWs42adVwwfvk94nxujvn\n OMRdtybwCrnAnHJZj7QCR+VmOq9l7Wt7y/RR2yMC3VW8uWyjDjMdhJMd0poD7rh+LkkHvsO\n w4Aolr1oggv43cxJEGoeqtfTLyznFO0Q1cnTOz8IEDJwsML9421MNMDv/2IDORl/j5qYQ20\n dRGCV3weKO5i5gY6YTkS0GGJltfDA==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:21 +0800", "Message-Id": "<20201111064936.768604-23-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 22/37] net/txgbe: add generic flow API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add flow API with generic flow operaions, validate first.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n doc/guides/nics/features/txgbe.ini | 1 +\n doc/guides/nics/txgbe.rst | 1 +\n drivers/net/txgbe/txgbe_ethdev.c | 25 ++++++++++++\n drivers/net/txgbe/txgbe_ethdev.h | 2 +\n drivers/net/txgbe/txgbe_flow.c | 61 ++++++++++++++++++++++++++++++\n 5 files changed, 90 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/txgbe.ini b/doc/guides/nics/features/txgbe.ini\nindex 573bf1604..ffeecfd20 100644\n--- a/doc/guides/nics/features/txgbe.ini\n+++ b/doc/guides/nics/features/txgbe.ini\n@@ -26,6 +26,7 @@ SR-IOV = Y\n DCB = Y\n VLAN filter = Y\n Flow control = Y\n+Flow API = Y\n Rate limitation = Y\n CRC offload = P\n VLAN offload = P\ndiff --git a/doc/guides/nics/txgbe.rst b/doc/guides/nics/txgbe.rst\nindex cd293698b..5a7299964 100644\n--- a/doc/guides/nics/txgbe.rst\n+++ b/doc/guides/nics/txgbe.rst\n@@ -29,6 +29,7 @@ Features\n - IEEE 1588\n - FW version\n - LRO\n+- Generic flow API\n \n Prerequisites\n -------------\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex bffccb822..9a68e266f 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -4050,6 +4050,30 @@ txgbe_add_del_ethertype_filter(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+static int\n+txgbe_dev_filter_ctrl(__rte_unused struct rte_eth_dev *dev,\n+\t\t enum rte_filter_type filter_type,\n+\t\t enum rte_filter_op filter_op,\n+\t\t void *arg)\n+{\n+\tint ret = 0;\n+\n+\tswitch (filter_type) {\n+\tcase RTE_ETH_FILTER_GENERIC:\n+\t\tif (filter_op != RTE_ETH_FILTER_GET)\n+\t\t\treturn -EINVAL;\n+\t\t*(const void **)arg = &txgbe_flow_ops;\n+\t\tbreak;\n+\tdefault:\n+\t\tPMD_DRV_LOG(WARNING, \"Filter type (%d) not supported\",\n+\t\t\t\t\t\t\tfilter_type);\n+\t\tret = -EINVAL;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+\n static u8 *\n txgbe_dev_addr_list_itr(__rte_unused struct txgbe_hw *hw,\n \t\t\tu8 **mc_addr_ptr, u32 *vmdq)\n@@ -5032,6 +5056,7 @@ static const struct eth_dev_ops txgbe_eth_dev_ops = {\n \t.reta_query = txgbe_dev_rss_reta_query,\n \t.rss_hash_update = txgbe_dev_rss_hash_update,\n \t.rss_hash_conf_get = txgbe_dev_rss_hash_conf_get,\n+\t.filter_ctrl = txgbe_dev_filter_ctrl,\n \t.set_mc_addr_list = txgbe_dev_set_mc_addr_list,\n \t.rxq_info_get = txgbe_rxq_info_get,\n \t.txq_info_get = txgbe_txq_info_get,\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex ceecb746f..a0a452c1a 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -487,6 +487,8 @@ uint32_t txgbe_convert_vm_rx_mask_to_val(uint16_t rx_mask, uint32_t orig_val);\n \n void txgbe_fdir_filter_restore(struct rte_eth_dev *dev);\n \n+extern const struct rte_flow_ops txgbe_flow_ops;\n+\n void txgbe_clear_all_ethertype_filter(struct rte_eth_dev *dev);\n void txgbe_clear_all_ntuple_filter(struct rte_eth_dev *dev);\n void txgbe_clear_syn_filter(struct rte_eth_dev *dev);\ndiff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex 77e025863..884a8545f 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -2629,3 +2629,64 @@ txgbe_filterlist_flush(void)\n \t}\n }\n \n+/**\n+ * Check if the flow rule is supported by txgbe.\n+ * It only checkes the format. Don't guarantee the rule can be programmed into\n+ * the HW. Because there can be no enough room for the rule.\n+ */\n+static int\n+txgbe_flow_validate(struct rte_eth_dev *dev,\n+\t\tconst struct rte_flow_attr *attr,\n+\t\tconst struct rte_flow_item pattern[],\n+\t\tconst struct rte_flow_action actions[],\n+\t\tstruct rte_flow_error *error)\n+{\n+\tstruct rte_eth_ntuple_filter ntuple_filter;\n+\tstruct rte_eth_ethertype_filter ethertype_filter;\n+\tstruct rte_eth_syn_filter syn_filter;\n+\tstruct txgbe_l2_tunnel_conf l2_tn_filter;\n+\tstruct txgbe_fdir_rule fdir_rule;\n+\tstruct txgbe_rte_flow_rss_conf rss_conf;\n+\tint ret;\n+\n+\tmemset(&ntuple_filter, 0, sizeof(struct rte_eth_ntuple_filter));\n+\tret = txgbe_parse_ntuple_filter(dev, attr, pattern,\n+\t\t\t\tactions, &ntuple_filter, error);\n+\tif (!ret)\n+\t\treturn 0;\n+\n+\tmemset(ðertype_filter, 0, sizeof(struct rte_eth_ethertype_filter));\n+\tret = txgbe_parse_ethertype_filter(dev, attr, pattern,\n+\t\t\t\tactions, ðertype_filter, error);\n+\tif (!ret)\n+\t\treturn 0;\n+\n+\tmemset(&syn_filter, 0, sizeof(struct rte_eth_syn_filter));\n+\tret = txgbe_parse_syn_filter(dev, attr, pattern,\n+\t\t\t\tactions, &syn_filter, error);\n+\tif (!ret)\n+\t\treturn 0;\n+\n+\tmemset(&fdir_rule, 0, sizeof(struct txgbe_fdir_rule));\n+\tret = txgbe_parse_fdir_filter(dev, attr, pattern,\n+\t\t\t\tactions, &fdir_rule, error);\n+\tif (!ret)\n+\t\treturn 0;\n+\n+\tmemset(&l2_tn_filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\tret = txgbe_parse_l2_tn_filter(dev, attr, pattern,\n+\t\t\t\tactions, &l2_tn_filter, error);\n+\tif (!ret)\n+\t\treturn 0;\n+\n+\tmemset(&rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\tret = txgbe_parse_rss_filter(dev, attr,\n+\t\t\t\t\tactions, &rss_conf, error);\n+\n+\treturn ret;\n+}\n+\n+const struct rte_flow_ops txgbe_flow_ops = {\n+\t.validate = txgbe_flow_validate,\n+};\n+\n", "prefixes": [ "v2", "22/37" ] }