Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 83963,
    "url": "http://patches.dpdk.org/api/patches/83963/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-21-jiawenwu@trustnetic.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201111064936.768604-21-jiawenwu@trustnetic.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-21-jiawenwu@trustnetic.com",
    "date": "2020-11-11T06:49:19",
    "name": "[v2,20/37] net/txgbe: add RSS filter restore operation",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "8eaf394cecddc3263e3a74e68136cfc3147401bd",
    "submitter": {
        "id": 1932,
        "url": "http://patches.dpdk.org/api/people/1932/?format=api",
        "name": "Jiawen Wu",
        "email": "jiawenwu@trustnetic.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-21-jiawenwu@trustnetic.com/mbox/",
    "series": [
        {
            "id": 13798,
            "url": "http://patches.dpdk.org/api/series/13798/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798",
            "date": "2020-11-11T06:49:00",
            "name": "net: add txgbe PMD part 2",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/13798/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/83963/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/83963/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BFE95A09D2;\n\tWed, 11 Nov 2020 07:55:00 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E8566BE95;\n\tWed, 11 Nov 2020 07:48:08 +0100 (CET)",
            "from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216])\n by dpdk.org (Postfix) with ESMTP id D6568AC90\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:47:52 +0100 (CET)",
            "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:46 +0800 (CST)"
        ],
        "X-QQ-mid": "bizesmtp27t1605077266tg5arqij",
        "X-QQ-SSF": "01400000000000C0C000B00A0000000",
        "X-QQ-FEAT": "mrYqqQu6MtG1GLO6ogqo1uHA3bVqwK2SkXpsuYNjb0mt7TVdbBNLC3Up6Fg4y\n ZNNM1QudnAI63T+WDwZpInTpjFQy/jH64F5nIEGhRIYBha2sWtIGYb8JompM14x3P3Q/wbh\n CflPvu8aB36PeymR5RMBjVoLOffpERFsOElutSFouwX2957JFtBUr6LL7hPd9hM4ExEvcR3\n OoSXu7C+LOeGL/tCooFgAlgJ5/fjAHi5lr3MJ2TxDYVkhQ9jSz1yqxyHAyLLUbU4pav2+PH\n c4MHqYfjL6eKYw8PoBLokPQV2ol0zPi8fQ87h3xigh4ndQwSZnlrVb3VoUV+0U1C766coAc\n McEatgj7cR2lbPOVdlY5OSWOCC3Cw==",
        "X-QQ-GoodBg": "2",
        "From": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "To": "dev@dpdk.org",
        "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "Date": "Wed, 11 Nov 2020 14:49:19 +0800",
        "Message-Id": "<20201111064936.768604-21-jiawenwu@trustnetic.com>",
        "X-Mailer": "git-send-email 2.18.4",
        "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>",
        "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>",
        "X-QQ-SENDSIZE": "520",
        "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6",
        "X-QQ-Bgrelay": "1",
        "Subject": "[dpdk-dev] [PATCH v2 20/37] net/txgbe: add RSS filter restore\n\toperation",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add restore operation on RSS filter.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 12 +++++\n drivers/net/txgbe/txgbe_ethdev.h |  7 +++\n drivers/net/txgbe/txgbe_rxtx.c   | 76 ++++++++++++++++++++++++++++++++\n 3 files changed, 95 insertions(+)",
    "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex 32c4b15c1..2983b63a2 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -4887,6 +4887,17 @@ txgbe_l2_tn_filter_restore(struct rte_eth_dev *dev)\n \t}\n }\n \n+/* restore rss filter */\n+static inline void\n+txgbe_rss_filter_restore(struct rte_eth_dev *dev)\n+{\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(dev);\n+\n+\tif (filter_info->rss_info.conf.queue_num)\n+\t\ttxgbe_config_rss_filter(dev,\n+\t\t\t&filter_info->rss_info, TRUE);\n+}\n+\n static int\n txgbe_filter_restore(struct rte_eth_dev *dev)\n {\n@@ -4895,6 +4906,7 @@ txgbe_filter_restore(struct rte_eth_dev *dev)\n \ttxgbe_syn_filter_restore(dev);\n \ttxgbe_fdir_filter_restore(dev);\n \ttxgbe_l2_tn_filter_restore(dev);\n+\ttxgbe_rss_filter_restore(dev);\n \n \treturn 0;\n }\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex 80587b245..b8fc605a7 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -237,6 +237,8 @@ struct txgbe_filter_info {\n \tstruct txgbe_5tuple_filter_list fivetuple_list;\n \t/* store the SYN filter info */\n \tuint32_t syn_info;\n+\t/* store the rss filter info */\n+\tstruct txgbe_rte_flow_rss_conf rss_info;\n };\n \n struct txgbe_l2_tn_key {\n@@ -487,6 +489,11 @@ int txgbe_set_queue_rate_limit(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t       uint16_t tx_rate);\n int txgbe_rss_conf_init(struct txgbe_rte_flow_rss_conf *out,\n \t\t\tconst struct rte_flow_action_rss *in);\n+int txgbe_action_rss_same(const struct rte_flow_action_rss *comp,\n+\t\t\t  const struct rte_flow_action_rss *with);\n+int txgbe_config_rss_filter(struct rte_eth_dev *dev,\n+\t\tstruct txgbe_rte_flow_rss_conf *conf, bool add);\n+\n static inline int\n txgbe_ethertype_filter_lookup(struct txgbe_filter_info *filter_info,\n \t\t\t      uint16_t ethertype)\ndiff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c\nindex 5f212ffc3..209660656 100644\n--- a/drivers/net/txgbe/txgbe_rxtx.c\n+++ b/drivers/net/txgbe/txgbe_rxtx.c\n@@ -4653,3 +4653,79 @@ txgbe_rss_conf_init(struct txgbe_rte_flow_rss_conf *out,\n \treturn 0;\n }\n \n+int\n+txgbe_action_rss_same(const struct rte_flow_action_rss *comp,\n+\t\t      const struct rte_flow_action_rss *with)\n+{\n+\treturn (comp->func == with->func &&\n+\t\tcomp->level == with->level &&\n+\t\tcomp->types == with->types &&\n+\t\tcomp->key_len == with->key_len &&\n+\t\tcomp->queue_num == with->queue_num &&\n+\t\t!memcmp(comp->key, with->key, with->key_len) &&\n+\t\t!memcmp(comp->queue, with->queue,\n+\t\t\tsizeof(*with->queue) * with->queue_num));\n+}\n+\n+int\n+txgbe_config_rss_filter(struct rte_eth_dev *dev,\n+\t\tstruct txgbe_rte_flow_rss_conf *conf, bool add)\n+{\n+\tstruct txgbe_hw *hw;\n+\tuint32_t reta;\n+\tuint16_t i;\n+\tuint16_t j;\n+\tstruct rte_eth_rss_conf rss_conf = {\n+\t\t.rss_key = conf->conf.key_len ?\n+\t\t\t(void *)(uintptr_t)conf->conf.key : NULL,\n+\t\t.rss_key_len = conf->conf.key_len,\n+\t\t.rss_hf = conf->conf.types,\n+\t};\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(dev);\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\thw = TXGBE_DEV_HW(dev);\n+\n+\tif (!add) {\n+\t\tif (txgbe_action_rss_same(&filter_info->rss_info.conf,\n+\t\t\t\t\t  &conf->conf)) {\n+\t\t\ttxgbe_rss_disable(dev);\n+\t\t\tmemset(&filter_info->rss_info, 0,\n+\t\t\t\tsizeof(struct txgbe_rte_flow_rss_conf));\n+\t\t\treturn 0;\n+\t\t}\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (filter_info->rss_info.conf.queue_num)\n+\t\treturn -EINVAL;\n+\t/* Fill in redirection table\n+\t * The byte-swap is needed because NIC registers are in\n+\t * little-endian order.\n+\t */\n+\treta = 0;\n+\tfor (i = 0, j = 0; i < ETH_RSS_RETA_SIZE_128; i++, j++) {\n+\t\tif (j == conf->conf.queue_num)\n+\t\t\tj = 0;\n+\t\treta = (reta >> 8) | LS32(conf->conf.queue[j], 24, 0xFF);\n+\t\tif ((i & 3) == 3)\n+\t\t\twr32a(hw, TXGBE_REG_RSSTBL, i >> 2, reta);\n+\t}\n+\n+\t/* Configure the RSS key and the RSS protocols used to compute\n+\t * the RSS hash of input packets.\n+\t */\n+\tif ((rss_conf.rss_hf & TXGBE_RSS_OFFLOAD_ALL) == 0) {\n+\t\ttxgbe_rss_disable(dev);\n+\t\treturn 0;\n+\t}\n+\tif (rss_conf.rss_key == NULL)\n+\t\trss_conf.rss_key = rss_intel_key; /* Default hash key */\n+\ttxgbe_dev_rss_hash_update(dev, &rss_conf);\n+\n+\tif (txgbe_rss_conf_init(&filter_info->rss_info, &conf->conf))\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n",
    "prefixes": [
        "v2",
        "20/37"
    ]
}