Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83954/?format=api
{ "id": 83954, "url": "http://patches.dpdk.org/api/patches/83954/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-13-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-13-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-13-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:11", "name": "[v2,12/37] net/txgbe: add L2 tunnel filter parse rule", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e43b723e339045419aa936f4b039f3314c296fb4", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-13-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83954/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83954/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87085A09D2;\n\tWed, 11 Nov 2020 07:51:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5D724A9A0;\n\tWed, 11 Nov 2020 07:47:51 +0100 (CET)", "from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])\n by dpdk.org (Postfix) with ESMTP id EF8624CA6\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:47:40 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:35 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077255tqry1ey6", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "O9RHVi+JMbJ8r4n0i20oSfvPmwK9VuK9/qnz7WTrQpMwenrYeJHA9VOHv5I34\n J/qH53hmPNoUsiF+zvuI/+H5+QdRZ4++vmgGjXLAY10g4n3yTDZHKwXYRYUeAMw9vsEET+F\n muq5DnWq4z1+Yz1Ojn25Uz4gcigmcFoQ9cg0ufwNI1aXEDV3TN36NCvvZ4hbC2HVpg1zECp\n 9V+ojN2G+cMmLLfIVJfmGvVy2QMCSjlj023VTNkkBIyDfG3JMl33zP+7rY1EGsM+5gov2rh\n qVGtpZ+asntsQJaTMIIGljR6vHL2r3pMNb9bMa0slPhUCwMH0G59pmYmarg/xfj/fld++N9\n PLt/Rwc5H9VJt7Z1jbURdnGRzpcvA==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:11 +0800", "Message-Id": "<20201111064936.768604-13-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 12/37] net/txgbe: add L2 tunnel filter parse\n\trule", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support to parse flow for L2 tunnel filter.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_flow.c | 202 +++++++++++++++++++++++++++++++++\n 1 file changed, 202 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex 7110e594b..8589e3328 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -15,6 +15,8 @@\n #include <rte_common.h>\n #include <rte_cycles.h>\n \n+#include <rte_bus_pci.h>\n+#include <rte_hash_crc.h>\n #include <rte_flow.h>\n #include <rte_flow_driver.h>\n \n@@ -1040,3 +1042,203 @@ txgbe_parse_syn_filter(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+/**\n+ * Parse the rule to see if it is a L2 tunnel rule.\n+ * And get the L2 tunnel filter info BTW.\n+ * Only support E-tag now.\n+ * pattern:\n+ * The first not void item can be E_TAG.\n+ * The next not void item must be END.\n+ * action:\n+ * The first not void action should be VF or PF.\n+ * The next not void action should be END.\n+ * pattern example:\n+ * ITEM\t\tSpec\t\t\tMask\n+ * E_TAG\tgrp\t\t0x1\t0x3\n+\t\te_cid_base\t0x309\t0xFFF\n+ * END\n+ * other members in mask and spec should set to 0x00.\n+ * item->last should be NULL.\n+ */\n+static int\n+cons_parse_l2_tn_filter(struct rte_eth_dev *dev,\n+\t\t\tconst struct rte_flow_attr *attr,\n+\t\t\tconst struct rte_flow_item pattern[],\n+\t\t\tconst struct rte_flow_action actions[],\n+\t\t\tstruct txgbe_l2_tunnel_conf *filter,\n+\t\t\tstruct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_item *item;\n+\tconst struct rte_flow_item_e_tag *e_tag_spec;\n+\tconst struct rte_flow_item_e_tag *e_tag_mask;\n+\tconst struct rte_flow_action *act;\n+\tconst struct rte_flow_action_vf *act_vf;\n+\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n+\n+\tif (!pattern) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM_NUM,\n+\t\t\tNULL, \"NULL pattern.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!actions) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_NUM,\n+\t\t\t\t NULL, \"NULL action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!attr) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR,\n+\t\t\t\t NULL, \"NULL attribute.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* The first not void item should be e-tag. */\n+\titem = next_no_void_pattern(pattern, NULL);\n+\tif (item->type != RTE_FLOW_ITEM_TYPE_E_TAG) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\titem, \"Not supported by L2 tunnel filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!item->spec || !item->mask) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\titem, \"Not supported by L2 tunnel filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/*Not supported last point for range*/\n+\tif (item->last) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\titem, \"Not supported last point for range\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\te_tag_spec = item->spec;\n+\te_tag_mask = item->mask;\n+\n+\t/* Only care about GRP and E cid base. */\n+\tif (e_tag_mask->epcp_edei_in_ecid_b ||\n+\t e_tag_mask->in_ecid_e ||\n+\t e_tag_mask->ecid_e ||\n+\t e_tag_mask->rsvd_grp_ecid_b != rte_cpu_to_be_16(0x3FFF)) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\titem, \"Not supported by L2 tunnel filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tfilter->l2_tunnel_type = RTE_L2_TUNNEL_TYPE_E_TAG;\n+\t/**\n+\t * grp and e_cid_base are bit fields and only use 14 bits.\n+\t * e-tag id is taken as little endian by HW.\n+\t */\n+\tfilter->tunnel_id = rte_be_to_cpu_16(e_tag_spec->rsvd_grp_ecid_b);\n+\n+\t/* check if the next not void item is END */\n+\titem = next_no_void_pattern(pattern, item);\n+\tif (item->type != RTE_FLOW_ITEM_TYPE_END) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\titem, \"Not supported by L2 tunnel filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* parse attr */\n+\t/* must be input direction */\n+\tif (!attr->ingress) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\tattr, \"Only support ingress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->egress) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\tattr, \"Not support egress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->transfer) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,\n+\t\t\tattr, \"No support for transfer.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->priority) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n+\t\t\tattr, \"Not support priority.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* check if the first not void action is VF or PF. */\n+\tact = next_no_void_action(actions, NULL);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_VF &&\n+\t\t\tact->type != RTE_FLOW_ACTION_TYPE_PF) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (act->type == RTE_FLOW_ACTION_TYPE_VF) {\n+\t\tact_vf = (const struct rte_flow_action_vf *)act->conf;\n+\t\tfilter->pool = act_vf->id;\n+\t} else {\n+\t\tfilter->pool = pci_dev->max_vfs;\n+\t}\n+\n+\t/* check if the next not void item is END */\n+\tact = next_no_void_action(actions, act);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_END) {\n+\t\tmemset(filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+txgbe_parse_l2_tn_filter(struct rte_eth_dev *dev,\n+\t\t\tconst struct rte_flow_attr *attr,\n+\t\t\tconst struct rte_flow_item pattern[],\n+\t\t\tconst struct rte_flow_action actions[],\n+\t\t\tstruct txgbe_l2_tunnel_conf *l2_tn_filter,\n+\t\t\tstruct rte_flow_error *error)\n+{\n+\tint ret = 0;\n+\n+\tret = cons_parse_l2_tn_filter(dev, attr, pattern,\n+\t\t\t\tactions, l2_tn_filter, error);\n+\n+\tmemset(l2_tn_filter, 0, sizeof(struct txgbe_l2_tunnel_conf));\n+\trte_flow_error_set(error, EINVAL,\n+\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\tNULL, \"Not supported by L2 tunnel filter\");\n+\tret = -rte_errno;\n+\treturn ret;\n+}\n+\n", "prefixes": [ "v2", "12/37" ] }