Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83937/?format=api
{ "id": 83937, "url": "http://patches.dpdk.org/api/patches/83937/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/8c79503838d1abb953ce209e5a619476f4c66c96.1605015133.git.zhouguoyang@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<8c79503838d1abb953ce209e5a619476f4c66c96.1605015133.git.zhouguoyang@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/8c79503838d1abb953ce209e5a619476f4c66c96.1605015133.git.zhouguoyang@huawei.com", "date": "2020-11-11T06:33:37", "name": "[v1,1/1] net/hinic/base: add message check for command channel", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "396c75d0ece80a94cf4053e44abf3c7112753cca", "submitter": { "id": 2039, "url": "http://patches.dpdk.org/api/people/2039/?format=api", "name": "Guoyang Zhou", "email": "zhouguoyang@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/8c79503838d1abb953ce209e5a619476f4c66c96.1605015133.git.zhouguoyang@huawei.com/mbox/", "series": [ { "id": 13795, "url": "http://patches.dpdk.org/api/series/13795/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13795", "date": "2020-11-11T06:33:36", "name": "add message id check for command channel", "version": 1, "mbox": "http://patches.dpdk.org/series/13795/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83937/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83937/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CBD0FA09D2;\n\tWed, 11 Nov 2020 07:29:52 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D87D7493D;\n\tWed, 11 Nov 2020 07:29:42 +0100 (CET)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by dpdk.org (Postfix) with ESMTP id BFC3837B4;\n Wed, 11 Nov 2020 07:29:38 +0100 (CET)", "from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CWFFJ4jz5zkj8d;\n Wed, 11 Nov 2020 14:29:24 +0800 (CST)", "from tester.localdomain (10.175.119.39) by\n DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id\n 14.3.487.0; Wed, 11 Nov 2020 14:29:29 +0800" ], "From": "Guoyang Zhou <zhouguoyang@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <bluca@debian.org>,\n <cloud.wangxiaoyun@huawei.com>, <luoxianjun@huawei.com>,\n <yin.yinshi@huawei.com>, <luojiachen@huawei.com>, <zhouguoyang@huawei.com>,\n <chenlizhong@huawei.com>, <zhaohui8@huawei.com>, <chenchanghu@huawei.com>,\n <stable@dpdk.org>", "Date": "Wed, 11 Nov 2020 14:33:37 +0800", "Message-ID": "\n <8c79503838d1abb953ce209e5a619476f4c66c96.1605015133.git.zhouguoyang@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<cover.1605015133.git.zhouguoyang@huawei.com>", "References": "<cover.1605015133.git.zhouguoyang@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.175.119.39]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v1 1/1] net/hinic/base: add message check for\n\tcommand channel", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In the command channel, a message may has several fragments,\nand the several fragments should have same message id. To\nprevent problems, this check is added.\n\nFixes: 1e4593db1d58 (\"net/hinic/base: fix log info for PF command channel\")\nCc: stable@dpdk.org\nSigned-off-by: Guoyang Zhou <zhouguoyang@huawei.com>\n---\n drivers/net/hinic/base/hinic_pmd_mbox.c | 28 +++++++++++++++++++---------\n drivers/net/hinic/base/hinic_pmd_mbox.h | 2 +-\n drivers/net/hinic/base/hinic_pmd_mgmt.c | 23 ++++++++++++++---------\n drivers/net/hinic/base/hinic_pmd_mgmt.h | 2 +-\n 4 files changed, 35 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/hinic/base/hinic_pmd_mbox.c b/drivers/net/hinic/base/hinic_pmd_mbox.c\nindex ff44c25..92a7cc1 100644\n--- a/drivers/net/hinic/base/hinic_pmd_mbox.c\n+++ b/drivers/net/hinic/base/hinic_pmd_mbox.c\n@@ -240,20 +240,22 @@ static void recv_func_mbox_handler(struct hinic_mbox_func_to_func *func_to_func,\n }\n \n static bool check_mbox_seq_id_and_seg_len(struct hinic_recv_mbox *recv_mbox,\n-\t\t\t\t\t u8 seq_id, u8 seg_len)\n+\t\t\t\t\t u8 seq_id, u8 seg_len, u8 msg_id)\n {\n \tif (seq_id > HINIC_SEQ_ID_MAX_VAL || seg_len > HINIC_MSG_SEG_LEN)\n \t\treturn false;\n \n \tif (seq_id == 0) {\n-\t\trecv_mbox->sed_id = seq_id;\n+\t\trecv_mbox->seq_id = seq_id;\n+\t\trecv_mbox->msg_info.msg_id = msg_id;\n \t} else {\n-\t\tif (seq_id != recv_mbox->sed_id + 1) {\n-\t\t\trecv_mbox->sed_id = 0;\n+\t\tif ((seq_id != recv_mbox->seq_id + 1) ||\n+\t\t\tmsg_id != recv_mbox->msg_info.msg_id) {\n+\t\t\trecv_mbox->seq_id = 0;\n \t\t\treturn false;\n \t\t}\n \n-\t\trecv_mbox->sed_id = seq_id;\n+\t\trecv_mbox->seq_id = seq_id;\n \t}\n \n \treturn true;\n@@ -477,16 +479,24 @@ static int recv_mbox_handler(struct hinic_mbox_func_to_func *func_to_func,\n \tu16 src_func_idx;\n \tenum hinic_hwif_direction_type direction;\n \tu8 seq_id, seg_len;\n+\tu8 msg_id;\n+\tu8 front_id;\n \n \tseq_id = HINIC_MBOX_HEADER_GET(mbox_header, SEQID);\n \tseg_len = HINIC_MBOX_HEADER_GET(mbox_header, SEG_LEN);\n \tdirection = HINIC_MBOX_HEADER_GET(mbox_header, DIRECTION);\n \tsrc_func_idx = HINIC_MBOX_HEADER_GET(mbox_header, SRC_GLB_FUNC_IDX);\n+\tmsg_id = HINIC_MBOX_HEADER_GET(mbox_header, MSG_ID);\n+\tfront_id = recv_mbox->seq_id;\n \n-\tif (!check_mbox_seq_id_and_seg_len(recv_mbox, seq_id, seg_len)) {\n+\tif (!check_mbox_seq_id_and_seg_len(recv_mbox, seq_id, seg_len,\n+\t\tmsg_id)) {\n \t\tPMD_DRV_LOG(ERR,\n-\t\t\t\"Mailbox sequence and segment check failed, src func id: 0x%x, front id: 0x%x, current id: 0x%x, seg len: 0x%x\\n\",\n-\t\t\tsrc_func_idx, recv_mbox->sed_id, seq_id, seg_len);\n+\t\t\t\"Mailbox sequence and segment check failed, src func id: 0x%x, \"\n+\t\t\t\"front id: 0x%x, current id: 0x%x, seg len: 0x%x \"\n+\t\t\t\"front msg_id: %d, cur msg_id: %d\",\n+\t\t\tsrc_func_idx, front_id, seq_id, seg_len,\n+\t\t\trecv_mbox->msg_info.msg_id, msg_id);\n \t\treturn HINIC_ERROR;\n \t}\n \n@@ -496,7 +506,7 @@ static int recv_mbox_handler(struct hinic_mbox_func_to_func *func_to_func,\n \tif (!HINIC_MBOX_HEADER_GET(mbox_header, LAST))\n \t\treturn HINIC_ERROR;\n \n-\trecv_mbox->sed_id = 0;\n+\trecv_mbox->seq_id = 0;\n \trecv_mbox->cmd = HINIC_MBOX_HEADER_GET(mbox_header, CMD);\n \trecv_mbox->mod = HINIC_MBOX_HEADER_GET(mbox_header, MODULE);\n \trecv_mbox->mbox_len = HINIC_MBOX_HEADER_GET(mbox_header, MSG_LEN);\ndiff --git a/drivers/net/hinic/base/hinic_pmd_mbox.h b/drivers/net/hinic/base/hinic_pmd_mbox.h\nindex dc08b99..b17f0df 100644\n--- a/drivers/net/hinic/base/hinic_pmd_mbox.h\n+++ b/drivers/net/hinic/base/hinic_pmd_mbox.h\n@@ -39,7 +39,7 @@ struct hinic_recv_mbox {\n \tvoid *buf_out;\n \tenum hinic_mbox_ack_type ack_type;\n \tstruct mbox_msg_info msg_info;\n-\tu8 sed_id;\n+\tu8 seq_id;\n };\n \n struct hinic_send_mbox {\ndiff --git a/drivers/net/hinic/base/hinic_pmd_mgmt.c b/drivers/net/hinic/base/hinic_pmd_mgmt.c\nindex fb31bc8..9b39950 100644\n--- a/drivers/net/hinic/base/hinic_pmd_mgmt.c\n+++ b/drivers/net/hinic/base/hinic_pmd_mgmt.c\n@@ -529,19 +529,21 @@ int hinic_msg_to_mgmt_no_ack(void *hwdev, enum hinic_mod_type mod, u8 cmd,\n }\n \n static bool check_mgmt_seq_id_and_seg_len(struct hinic_recv_msg *recv_msg,\n-\t\t\t\t\t u8 seq_id, u8 seg_len)\n+\t\t\t\t\t u8 seq_id, u8 seg_len, u16 msg_id)\n {\n \tif (seq_id > HINIC_SEQ_ID_MAX_VAL || seg_len > HINIC_MSG_SEG_LEN)\n \t\treturn false;\n \n \tif (seq_id == 0) {\n-\t\trecv_msg->sed_id = seq_id;\n+\t\trecv_msg->seq_id = seq_id;\n+\t\trecv_msg->msg_id = msg_id;\n \t} else {\n-\t\tif (seq_id != recv_msg->sed_id + 1) {\n-\t\t\trecv_msg->sed_id = 0;\n+\t\tif ((seq_id != recv_msg->seq_id + 1) ||\n+\t\t\tmsg_id != recv_msg->msg_id) {\n+\t\t\trecv_msg->seq_id = 0;\n \t\t\treturn false;\n \t\t}\n-\t\trecv_msg->sed_id = seq_id;\n+\t\trecv_msg->seq_id = seq_id;\n \t}\n \n \treturn true;\n@@ -615,17 +617,20 @@ static int recv_mgmt_msg_handler(struct hinic_msg_pf_to_mgmt *pf_to_mgmt,\n \tu8 seq_id, seq_len;\n \tu32 msg_buf_max = MAX_PF_MGMT_BUF_SIZE;\n \tu8 front_id;\n+\tu16 msg_id;\n \n \tseq_id = HINIC_MSG_HEADER_GET(msg_header, SEQID);\n \tseq_len = HINIC_MSG_HEADER_GET(msg_header, SEG_LEN);\n-\tfront_id = recv_msg->sed_id;\n+\tfront_id = recv_msg->seq_id;\n+\tmsg_id = HINIC_MSG_HEADER_GET(msg_header, MSG_ID);\n \n-\tif (!check_mgmt_seq_id_and_seg_len(recv_msg, seq_id, seq_len)) {\n+\tif (!check_mgmt_seq_id_and_seg_len(recv_msg, seq_id, seq_len, msg_id)) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"Mgmt msg sequence and segment check failed, \"\n-\t\t\t\"func id: 0x%x, front id: 0x%x, current id: 0x%x, seg len: 0x%x\",\n+\t\t\t\"func id: 0x%x, front id: 0x%x, current id: 0x%x, seg len: 0x%x \"\n+\t\t\t\"front msg_id: %d, cur msg_id: %d\",\n \t\t\thinic_global_func_id(pf_to_mgmt->hwdev),\n-\t\t\tfront_id, seq_id, seq_len);\n+\t\t\tfront_id, seq_id, seq_len, recv_msg->msg_id, msg_id);\n \t\treturn HINIC_ERROR;\n \t}\n \ndiff --git a/drivers/net/hinic/base/hinic_pmd_mgmt.h b/drivers/net/hinic/base/hinic_pmd_mgmt.h\nindex 0f32865..5099a3a 100644\n--- a/drivers/net/hinic/base/hinic_pmd_mgmt.h\n+++ b/drivers/net/hinic/base/hinic_pmd_mgmt.h\n@@ -69,7 +69,7 @@ struct hinic_recv_msg {\n \tu8\t\t\tcmd;\n \tu16\t\t\tmsg_id;\n \tint\t\t\tasync_mgmt_to_pf;\n-\tu8\t\t\tsed_id;\n+\tu8\t\t\tseq_id;\n };\n \n #define HINIC_COMM_SELF_CMD_MAX 8\n", "prefixes": [ "v1", "1/1" ] }