Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83926/?format=api
{ "id": 83926, "url": "http://patches.dpdk.org/api/patches/83926/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201110225544.1876-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201110225544.1876-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20201110225544.1876-6-stephen@networkplumber.org", "date": "2020-11-10T22:55:42", "name": "[v10,5/7] app/test: use new allowlist and blocklist", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0f9906fd47ecc12c7b8d9eeec0b07823b9bf4c0b", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201110225544.1876-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 13788, "url": "http://patches.dpdk.org/api/series/13788/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13788", "date": "2020-11-10T22:55:37", "name": "replace blacklist/whitelist with allow/block", "version": 10, "mbox": "http://patches.dpdk.org/series/13788/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83926/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83926/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 531B2A04E7;\n\tTue, 10 Nov 2020 23:57:13 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 763085AA7;\n\tTue, 10 Nov 2020 23:55:59 +0100 (CET)", "from mail-pl1-f170.google.com (mail-pl1-f170.google.com\n [209.85.214.170]) by dpdk.org (Postfix) with ESMTP id D179D594B\n for <dev@dpdk.org>; Tue, 10 Nov 2020 23:55:56 +0100 (CET)", "by mail-pl1-f170.google.com with SMTP id g11so7237815pll.13\n for <dev@dpdk.org>; Tue, 10 Nov 2020 14:55:56 -0800 (PST)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id t9sm52934pjo.4.2020.11.10.14.55.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 10 Nov 2020 14:55:53 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=7/vUIgucrhO4cgNM0FcEoUmH8m5U9dKq0pD6xeMhbzM=;\n b=mEIoBDYA3MGVEFwe84LsVPGxciDskbZ0cGd6TmTVVDBGfHPagKelAHSKMpS9fapXJD\n nrymaXqlCpOCijuj30XDGRcBTdGmbdsNGndKX8XyLi/mT5HBawoFvVOwKgBvwCjHBbkz\n eVi81HQgNE0eg4LVENvL8JoziexY9KNsU3N5IcmW3g8Srt+Wt7OxuhxkJ/KXpKt7Pizf\n FfEHtpyhnbA4GHpZDvknQjeXmpE/9BkkzaOvf9Ep/VusTDGlO5qnPf74+MMXiZrYmu2S\n ZNArUoVuNU00OpeSxUUGdyZHOCyta+8KdbJS3buYPonTS2YkEIEffMYq+ez4mr5nt/6Q\n jGlQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=7/vUIgucrhO4cgNM0FcEoUmH8m5U9dKq0pD6xeMhbzM=;\n b=Y5AEmeAk131DuOha3eKsjhnIyMnrBFKjlaXqk2MMrfFbR5F830eMDeqouyosr/a86B\n 8ayHjhtl69tRVwI3bcG0MpEvo3ia6S1K6wqB5CQ6lxTL0uYY7l4FTiED0rF1SE3oUxEC\n 7Ilppvk2I7P6OtKdSpe0RMQAbcmbeYbRRS32Yi/kjBlW/v65Q0tHTN3PkziDjilD+tnw\n tzACvWgnaCCjmbk4bWGm31Y9nVM/HGkDwVk6a2Xsl+Uu/Sqf1/WvygF2vFgeNOixgq72\n zJkE2AXVbMqt4KTNTfyGiVSxcI2u/45vLVP6ncOEtyBlAwaAN029OeuUqNBhrs6GGs8V\n CAxA==", "X-Gm-Message-State": "AOAM533jSt5MxcVvQOsreTIrX0t4BVO/bOXT24wI7swffqBI7zMTAghA\n G+81q5opKXGRLHjqjWG/O6E22RKJfEJj05Ac", "X-Google-Smtp-Source": "\n ABdhPJyzXNM4CbGvjXtDKpvJnkhU65m+3jE+3k+lSPTzr9ViuanMxo4SVYKIVZH/DTFx8LWUGbXkMw==", "X-Received": "by 2002:a17:902:d34c:b029:d7:ca4a:3d83 with SMTP id\n l12-20020a170902d34cb02900d7ca4a3d83mr16170091plk.55.1605048954571;\n Tue, 10 Nov 2020 14:55:54 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Luca Boccassi <bluca@debian.org>", "Date": "Tue, 10 Nov 2020 14:55:42 -0800", "Message-Id": "<20201110225544.1876-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201110225544.1876-1-stephen@networkplumber.org>", "References": "<20200922143202.8755-1-stephen@networkplumber.org>\n <20201110225544.1876-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v10 5/7] app/test: use new allowlist and blocklist", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Test the renamed blocklist and allowlist arguments.\nUse new terms in test variable names as well.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\n app/test/autotest.py | 16 +++++------\n app/test/autotest_runner.py | 18 ++++++-------\n app/test/test.c | 2 +-\n app/test/test_eal_flags.c | 53 +++++++++++++++++++------------------\n 4 files changed, 45 insertions(+), 44 deletions(-)", "diff": "diff --git a/app/test/autotest.py b/app/test/autotest.py\nindex 9eef1efbe565..6ff2e71475a1 100644\n--- a/app/test/autotest.py\n+++ b/app/test/autotest.py\n@@ -10,7 +10,7 @@\n \n def usage():\n print(\"Usage: autotest.py [test app|test iso image] \",\n- \"[target] [whitelist|-blacklist]\")\n+ \"[target] [allow|-block]\")\n \n if len(sys.argv) < 3:\n usage()\n@@ -18,18 +18,18 @@ def usage():\n \n target = sys.argv[2]\n \n-test_whitelist = None\n-test_blacklist = None\n+test_allowlist = None\n+test_blocklist = None\n \n-# get blacklist/whitelist\n+# get blocklist/allowlist\n if len(sys.argv) > 3:\n testlist = sys.argv[3].split(',')\n testlist = [test.lower() for test in testlist]\n if testlist[0].startswith('-'):\n testlist[0] = testlist[0].lstrip('-')\n- test_blacklist = testlist\n+ test_blocklist = testlist\n else:\n- test_whitelist = testlist\n+ test_allowlist = testlist\n \n cmdline = \"%s -c f\" % (sys.argv[1])\n \n@@ -39,8 +39,8 @@ def usage():\n # processes, so make it 1, otherwise make it 4. ignored for non-parallel tests\n n_processes = 1 if \"bsd\" in target else 4\n \n-runner = autotest_runner.AutotestRunner(cmdline, target, test_blacklist,\n- test_whitelist, n_processes)\n+runner = autotest_runner.AutotestRunner(cmdline, target, test_blocklist,\n+ test_allowlist, n_processes)\n \n runner.parallel_tests = autotest_data.parallel_test_list[:]\n runner.non_parallel_tests = autotest_data.non_parallel_test_list[:]\ndiff --git a/app/test/autotest_runner.py b/app/test/autotest_runner.py\nindex 998fe57a55d1..72c40e85fdd2 100644\n--- a/app/test/autotest_runner.py\n+++ b/app/test/autotest_runner.py\n@@ -188,14 +188,14 @@ class AutotestRunner:\n n_tests = 0\n fails = 0\n log_buffers = []\n- blacklist = []\n- whitelist = []\n+ blocklist = []\n+ allowlist = []\n \n- def __init__(self, cmdline, target, blacklist, whitelist, n_processes):\n+ def __init__(self, cmdline, target, blocklist, allowlist, n_processes):\n self.cmdline = cmdline\n self.target = target\n- self.blacklist = blacklist\n- self.whitelist = whitelist\n+ self.blocklist = blocklist\n+ self.allowlist = allowlist\n self.skipped = []\n self.parallel_tests = []\n self.non_parallel_tests = []\n@@ -269,7 +269,7 @@ def __process_result(self, result):\n self.csvwriter.writerow([test_name, test_result, result_str])\n \n # this function checks individual test and decides if this test should be in\n- # the group by comparing it against whitelist/blacklist. it also checks if\n+ # the group by comparing it against allowlist/blocklist. it also checks if\n # the test is compiled into the binary, and marks it as skipped if necessary\n def __filter_test(self, test):\n test_cmd = test[\"Command\"]\n@@ -279,10 +279,10 @@ def __filter_test(self, test):\n if \"_autotest\" in test_id:\n test_id = test_id[:-len(\"_autotest\")]\n \n- # filter out blacklisted/whitelisted tests\n- if self.blacklist and test_id in self.blacklist:\n+ # filter out blocklisted/allowlisted tests\n+ if self.blocklist and test_id in self.blocklist:\n return False\n- if self.whitelist and test_id not in self.whitelist:\n+ if self.allowlist and test_id not in self.allowlist:\n return False\n \n # if test wasn't compiled in, remove it as well\ndiff --git a/app/test/test.c b/app/test/test.c\nindex f27a56e03390..ba0b0309b561 100644\n--- a/app/test/test.c\n+++ b/app/test/test.c\n@@ -61,7 +61,7 @@ do_recursive_call(void)\n \t\t\t{ \"test_main_lcore_flag\", no_action },\n \t\t\t{ \"test_invalid_n_flag\", no_action },\n \t\t\t{ \"test_no_hpet_flag\", no_action },\n-\t\t\t{ \"test_whitelist_flag\", no_action },\n+\t\t\t{ \"test_allow_flag\", no_action },\n \t\t\t{ \"test_invalid_b_flag\", no_action },\n \t\t\t{ \"test_invalid_vdev_flag\", no_action },\n \t\t\t{ \"test_invalid_r_flag\", no_action },\ndiff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c\nindex da119d4e4a92..85b6c6d7c7f9 100644\n--- a/app/test/test_eal_flags.c\n+++ b/app/test/test_eal_flags.c\n@@ -30,7 +30,7 @@\n #define no_hpet \"--no-hpet\"\n #define no_huge \"--no-huge\"\n #define no_shconf \"--no-shconf\"\n-#define pci_whitelist \"--pci-whitelist\"\n+#define allow \"--allow\"\n #define vdev \"--vdev\"\n #define memtest \"memtest\"\n #define memtest1 \"memtest1\"\n@@ -223,12 +223,12 @@ get_number_of_sockets(void)\n #endif\n \n /*\n- * Test that the app doesn't run with invalid whitelist option.\n+ * Test that the app doesn't run with invalid allow option.\n * Final tests ensures it does run with valid options as sanity check (one\n * test for with Domain+BDF, second for just with BDF)\n */\n static int\n-test_whitelist_flag(void)\n+test_allow_flag(void)\n {\n \tunsigned i;\n #ifdef RTE_EXEC_ENV_FREEBSD\n@@ -245,45 +245,45 @@ test_whitelist_flag(void)\n \n \tconst char *wlinval[][7] = {\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"error\", \"\", \"\"},\n+\t\t\t\tallow, \"error\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"0:0:0\", \"\", \"\"},\n+\t\t\t\tallow, \"0:0:0\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"0:error:0.1\", \"\", \"\"},\n+\t\t\t\tallow, \"0:error:0.1\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"0:0:0.1error\", \"\", \"\"},\n+\t\t\t\tallow, \"0:0:0.1error\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"error0:0:0.1\", \"\", \"\"},\n+\t\t\t\tallow, \"error0:0:0.1\", \"\", \"\"},\n \t\t{prgname, prefix, mp_flag,\n-\t\t\t\tpci_whitelist, \"0:0:0.1.2\", \"\", \"\"},\n+\t\t\t\tallow, \"0:0:0.1.2\", \"\", \"\"},\n \t};\n-\t/* Test with valid whitelist option */\n+\t/* Test with valid allow option */\n \tconst char *wlval1[] = {prgname, prefix, mp_flag,\n-\t\t\tpci_whitelist, \"00FF:09:0B.3\"};\n+\t\t\tallow, \"00FF:09:0B.3\"};\n \tconst char *wlval2[] = {prgname, prefix, mp_flag,\n-\t\t\tpci_whitelist, \"09:0B.3\", pci_whitelist, \"0a:0b.1\"};\n+\t\t\tallow, \"09:0B.3\", allow, \"0a:0b.1\"};\n \tconst char *wlval3[] = {prgname, prefix, mp_flag,\n-\t\t\tpci_whitelist, \"09:0B.3,type=test\",\n-\t\t\tpci_whitelist, \"08:00.1,type=normal\",\n+\t\t\tallow, \"09:0B.3,type=test\",\n+\t\t\tallow, \"08:00.1,type=normal\",\n \t};\n \n \tfor (i = 0; i < RTE_DIM(wlinval); i++) {\n \t\tif (launch_proc(wlinval[i]) == 0) {\n \t\t\tprintf(\"Error - process did run ok with invalid \"\n-\t\t\t \"whitelist parameter\\n\");\n+\t\t\t \"allow parameter\\n\");\n \t\t\treturn -1;\n \t\t}\n \t}\n \tif (launch_proc(wlval1) != 0 ) {\n-\t\tprintf(\"Error - process did not run ok with valid whitelist\\n\");\n+\t\tprintf(\"Error - process did not run ok with valid allow\\n\");\n \t\treturn -1;\n \t}\n \tif (launch_proc(wlval2) != 0 ) {\n-\t\tprintf(\"Error - process did not run ok with valid whitelist value set\\n\");\n+\t\tprintf(\"Error - process did not run ok with valid allow value set\\n\");\n \t\treturn -1;\n \t}\n \tif (launch_proc(wlval3) != 0 ) {\n-\t\tprintf(\"Error - process did not run ok with valid whitelist + args\\n\");\n+\t\tprintf(\"Error - process did not run ok with valid allow + args\\n\");\n \t\treturn -1;\n \t}\n \n@@ -291,7 +291,7 @@ test_whitelist_flag(void)\n }\n \n /*\n- * Test that the app doesn't run with invalid blacklist option.\n+ * Test that the app doesn't run with invalid blocklist option.\n * Final test ensures it does run with valid options as sanity check\n */\n static int\n@@ -317,7 +317,7 @@ test_invalid_b_flag(void)\n \t\t{prgname, prefix, mp_flag, \"-b\", \"error0:0:0.1\"},\n \t\t{prgname, prefix, mp_flag, \"-b\", \"0:0:0.1.2\"},\n \t};\n-\t/* Test with valid blacklist option */\n+\t/* Test with valid blocklist option */\n \tconst char *blval[] = {prgname, prefix, mp_flag,\n \t\t\t \"-b\", \"FF:09:0B.3\"};\n \n@@ -326,12 +326,12 @@ test_invalid_b_flag(void)\n \tfor (i = 0; i != RTE_DIM(blinval); i++) {\n \t\tif (launch_proc(blinval[i]) == 0) {\n \t\t\tprintf(\"Error - process did run ok with invalid \"\n-\t\t\t \"blacklist parameter\\n\");\n+\t\t\t \"blocklist parameter\\n\");\n \t\t\treturn -1;\n \t\t}\n \t}\n \tif (launch_proc(blval) != 0) {\n-\t\tprintf(\"Error - process did not run ok with valid blacklist value\\n\");\n+\t\tprintf(\"Error - process did not run ok with valid blocklist value\\n\");\n \t\treturn -1;\n \t}\n \treturn 0;\n@@ -419,7 +419,7 @@ test_invalid_r_flag(void)\n \t\t\t{prgname, prefix, mp_flag, \"-r\", \"-1\"},\n \t\t\t{prgname, prefix, mp_flag, \"-r\", \"17\"},\n \t};\n-\t/* Test with valid blacklist option */\n+\t/* Test with valid blocklist option */\n \tconst char *rval[] = {prgname, prefix, mp_flag, \"-r\", \"16\"};\n \n \tint i;\n@@ -1492,9 +1492,9 @@ test_eal_flags(void)\n \t\treturn ret;\n \t}\n \n-\tret = test_whitelist_flag();\n+\tret = test_allow_flag();\n \tif (ret < 0) {\n-\t\tprintf(\"Error in test_invalid_whitelist_flag()\\n\");\n+\t\tprintf(\"Error in test_allow_flag()\\n\");\n \t\treturn ret;\n \t}\n \n@@ -1546,7 +1546,8 @@ REGISTER_TEST_COMMAND(eal_flags_main_opt_autotest, test_main_lcore_flag);\n REGISTER_TEST_COMMAND(eal_flags_n_opt_autotest, test_invalid_n_flag);\n REGISTER_TEST_COMMAND(eal_flags_hpet_autotest, test_no_hpet_flag);\n REGISTER_TEST_COMMAND(eal_flags_no_huge_autotest, test_no_huge_flag);\n-REGISTER_TEST_COMMAND(eal_flags_w_opt_autotest, test_whitelist_flag);\n+REGISTER_TEST_COMMAND(eal_flags_w_opt_autotest, test_allow_flag); /* for legacy CI */\n+REGISTER_TEST_COMMAND(eal_flags_a_opt_autotest, test_allow_flag);\n REGISTER_TEST_COMMAND(eal_flags_b_opt_autotest, test_invalid_b_flag);\n REGISTER_TEST_COMMAND(eal_flags_vdev_opt_autotest, test_invalid_vdev_flag);\n REGISTER_TEST_COMMAND(eal_flags_r_opt_autotest, test_invalid_r_flag);\n", "prefixes": [ "v10", "5/7" ] }