Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83924/?format=api
{ "id": 83924, "url": "http://patches.dpdk.org/api/patches/83924/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201110225544.1876-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201110225544.1876-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20201110225544.1876-3-stephen@networkplumber.org", "date": "2020-11-10T22:55:39", "name": "[v10,2/7] drivers: replace references to blacklist", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fe57f5190a363e8fb12ab553217be71aef0e0967", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201110225544.1876-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 13788, "url": "http://patches.dpdk.org/api/series/13788/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13788", "date": "2020-11-10T22:55:37", "name": "replace blacklist/whitelist with allow/block", "version": 10, "mbox": "http://patches.dpdk.org/series/13788/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83924/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/83924/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 146A6A04E7;\n\tTue, 10 Nov 2020 23:56:30 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 67C73569B;\n\tTue, 10 Nov 2020 23:55:55 +0100 (CET)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id A54DB2E8D\n for <dev@dpdk.org>; Tue, 10 Nov 2020 23:55:52 +0100 (CET)", "by mail-pf1-f195.google.com with SMTP id a18so250794pfl.3\n for <dev@dpdk.org>; Tue, 10 Nov 2020 14:55:52 -0800 (PST)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id t9sm52934pjo.4.2020.11.10.14.55.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 10 Nov 2020 14:55:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=6zvhW4iYuAuST18wPXtuSUGAjTgl52SbDfnG8ZapurE=;\n b=DN64XD0jJshUNX7jdpuHldHfHyO6ZQWzq2K09ORaNCzJBqQIrF0UgvFCUqUfldqtva\n k0QHUQUYVbmcwYUgzHKN/lcth2I6ivDkjOHjCopFGWYGZKe7l/OLWiPJheGMhMB7d/Ik\n v2MY+eu2cctMPGD8FVvVfjP2cwS6Rip4R241D9I4i1m0yF2aD4hGU95oe4IoEcRTosGe\n J7QU0PICsCvEOFOw4c/MYfWSgsq6CqCSOhj9ltDFsTmHZ4Yx87LXFjfhu+Btt9jlZfRI\n p0dRzY95isARCrSryAIyl7Zy40bXygiU/fhUeB6O6kLgCUSH9RpvV7XRj+NeOdO70ZlK\n KTtw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=6zvhW4iYuAuST18wPXtuSUGAjTgl52SbDfnG8ZapurE=;\n b=oUGYL3tR2grYrotb5FQdQLkgumXVec5BBWZmY4gtJpHMJBZhM+n1hQ5WTHDII16yIL\n SwrbRQnqGCTllZFadlKLJu3mmmbPhFc9MjgUlKi4t2DG2jJwiX8gLo+9+VbeBZlmSPjB\n vZL9+rviSDV1KzWNTtSEqbLeh3DLctU+crPbJJ5FREPuYGanPVO2VGmyAXc9I8pl8rXh\n kygYLhuhLuSJm5vemZpvWjIyts6U1D+7SpoQDZTULGyOKrc5qHGh/7zuOrIngIwqb+80\n Kfgi9GR/SsQfgb4BmXPGSI9va/GFvB7MH6MuTZ0ZFPEKC4qQdZddXUAdmpmV3PFOYcYZ\n IXQw==", "X-Gm-Message-State": "AOAM5305BkpmZU+k16rKsSaN7C6f+YxAas94PUrlBfClTD3JsDYHxdrL\n 0HqWnKtRV2gGamclddmVwVRL7lOTmfOFqrrx", "X-Google-Smtp-Source": "\n ABdhPJydmtntSKadr7kqCgz/d1J3FQ+sDtRl/brAd/umbWXBvMlfw0cQFoqsklVs1NywV13CQNE0ow==", "X-Received": "by 2002:aa7:824d:0:b029:18b:ad77:1a2b with SMTP id\n e13-20020aa7824d0000b029018bad771a2bmr20555817pfn.25.1605048950278;\n Tue, 10 Nov 2020 14:55:50 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Luca Boccassi <bluca@debian.org>, Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Tue, 10 Nov 2020 14:55:39 -0800", "Message-Id": "<20201110225544.1876-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201110225544.1876-1-stephen@networkplumber.org>", "References": "<20200922143202.8755-1-stephen@networkplumber.org>\n <20201110225544.1876-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v10 2/7] drivers: replace references to blacklist", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use the new terminology blocked to describe when devices\nare excluded from being used.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Luca Boccassi <bluca@debian.org>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/dpaa/dpaa_bus.c | 7 +++----\n drivers/bus/fslmc/fslmc_bus.c | 9 ++++-----\n drivers/bus/fslmc/fslmc_vfio.c | 12 ++++++------\n drivers/bus/pci/pci_common.c | 24 ++++++++++--------------\n drivers/bus/vmbus/vmbus_common.c | 4 ++--\n drivers/crypto/virtio/virtio_pci.c | 2 +-\n drivers/net/virtio/virtio_pci.c | 2 +-\n 7 files changed, 27 insertions(+), 33 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex ece6a4c4243a..3098e230933c 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -584,7 +584,7 @@ rte_dpaa_bus_probe(void)\n \tstruct rte_dpaa_driver *drv;\n \tFILE *svr_file = NULL;\n \tunsigned int svr_ver;\n-\tint probe_all = rte_dpaa_bus.bus.conf.scan_mode != RTE_BUS_SCAN_WHITELIST;\n+\tint probe_all = rte_dpaa_bus.bus.conf.scan_mode != RTE_BUS_SCAN_ALLOWLIST;\n \tstatic int process_once;\n \n \t/* If DPAA bus is not present nothing needs to be done */\n@@ -646,13 +646,12 @@ rte_dpaa_bus_probe(void)\n \n \t\t\tif (!drv->probe ||\n \t\t\t (dev->device.devargs &&\n-\t\t\t dev->device.devargs->policy == RTE_DEV_BLACKLISTED))\n+\t\t\t dev->device.devargs->policy == RTE_DEV_BLOCKED))\n \t\t\t\tcontinue;\n \n \t\t\tif (probe_all ||\n \t\t\t (dev->device.devargs &&\n-\t\t\t dev->device.devargs->policy ==\n-\t\t\t RTE_DEV_WHITELISTED)) {\n+\t\t\t dev->device.devargs->policy == RTE_DEV_ALLOWED)) {\n \t\t\t\tret = drv->probe(drv, dev);\n \t\t\t\tif (ret) {\n \t\t\t\t\tDPAA_BUS_ERR(\"unable to probe:%s\",\ndiff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex db936696282e..58435589b21d 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -420,7 +420,7 @@ rte_fslmc_probe(void)\n \t\treturn 0;\n \t}\n \n-\tprobe_all = rte_fslmc_bus.bus.conf.scan_mode != RTE_BUS_SCAN_WHITELIST;\n+\tprobe_all = rte_fslmc_bus.bus.conf.scan_mode != RTE_BUS_SCAN_ALLOWLIST;\n \n \t/* In case of PA, the FD addresses returned by qbman APIs are physical\n \t * addresses, which need conversion into equivalent VA address for\n@@ -451,16 +451,15 @@ rte_fslmc_probe(void)\n \t\t\t\tcontinue;\n \n \t\t\tif (dev->device.devargs &&\n-\t\t\t dev->device.devargs->policy == RTE_DEV_BLACKLISTED) {\n-\t\t\t\tDPAA2_BUS_LOG(DEBUG, \"%s Blacklisted, skipping\",\n+\t\t\t dev->device.devargs->policy == RTE_DEV_BLOCKED) {\n+\t\t\t\tDPAA2_BUS_LOG(DEBUG, \"%s Blocked, skipping\",\n \t\t\t\t\t dev->device.name);\n \t\t\t\tcontinue;\n \t\t\t}\n \n \t\t\tif (probe_all ||\n \t\t\t (dev->device.devargs &&\n-\t\t\t dev->device.devargs->policy ==\n-\t\t\t RTE_DEV_WHITELISTED)) {\n+\t\t\t dev->device.devargs->policy == RTE_DEV_ALLOWED)) {\n \t\t\t\tret = drv->probe(drv, dev);\n \t\t\t\tif (ret) {\n \t\t\t\t\tDPAA2_BUS_ERR(\"Unable to probe\");\ndiff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c\nindex aba55b46d8da..b52f36c33e4f 100644\n--- a/drivers/bus/fslmc/fslmc_vfio.c\n+++ b/drivers/bus/fslmc/fslmc_vfio.c\n@@ -812,13 +812,13 @@ fslmc_vfio_process_group(void)\n \t\tif (dev->dev_type == DPAA2_MPORTAL) {\n \t\t\tdpmcp_count++;\n \t\t\tif (dev->device.devargs &&\n-\t\t\t dev->device.devargs->policy == RTE_DEV_BLACKLISTED)\n+\t\t\t dev->device.devargs->policy == RTE_DEV_BLOCKED)\n \t\t\t\tis_dpmcp_in_blocklist = true;\n \t\t}\n \t\tif (dev->dev_type == DPAA2_IO) {\n \t\t\tdpio_count++;\n \t\t\tif (dev->device.devargs &&\n-\t\t\t dev->device.devargs->policy == RTE_DEV_BLACKLISTED)\n+\t\t\t dev->device.devargs->policy == RTE_DEV_BLOCKED)\n \t\t\t\tis_dpio_in_blocklist = true;\n \t\t}\n \t}\n@@ -829,8 +829,8 @@ fslmc_vfio_process_group(void)\n \t\tif (dev->dev_type == DPAA2_MPORTAL) {\n \t\t\tcurrent_device++;\n \t\t\tif (dev->device.devargs &&\n-\t\t\t dev->device.devargs->policy == RTE_DEV_BLACKLISTED) {\n-\t\t\t\tDPAA2_BUS_LOG(DEBUG, \"%s Blacklisted, skipping\",\n+\t\t\t dev->device.devargs->policy == RTE_DEV_BLOCKED) {\n+\t\t\t\tDPAA2_BUS_LOG(DEBUG, \"%s Blocked, skipping\",\n \t\t\t\t\t dev->device.name);\n \t\t\t\tTAILQ_REMOVE(&rte_fslmc_bus.device_list,\n \t\t\t\t\t\tdev, next);\n@@ -876,8 +876,8 @@ fslmc_vfio_process_group(void)\n \t\tif (dev->dev_type == DPAA2_IO)\n \t\t\tcurrent_device++;\n \t\tif (dev->device.devargs &&\n-\t\t dev->device.devargs->policy == RTE_DEV_BLACKLISTED) {\n-\t\t\tDPAA2_BUS_LOG(DEBUG, \"%s Blacklisted, skipping\",\n+\t\t dev->device.devargs->policy == RTE_DEV_BLOCKED) {\n+\t\t\tDPAA2_BUS_LOG(DEBUG, \"%s Blocked, skipping\",\n \t\t\t\t dev->device.name);\n \t\t\tTAILQ_REMOVE(&rte_fslmc_bus.device_list, dev, next);\n \t\t\tcontinue;\ndiff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 39eea464b4c0..b24c0697130e 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -67,9 +67,8 @@ pci_name_set(struct rte_pci_device *dev)\n \t\t\tdev->name, sizeof(dev->name));\n \tdevargs = pci_devargs_lookup(&dev->addr);\n \tdev->device.devargs = devargs;\n-\t/* In blacklist mode, if the device is not blacklisted, no\n-\t * rte_devargs exists for it.\n-\t */\n+\n+\t/* If the device is blocked, no rte_devargs exists for it. */\n \tif (devargs != NULL)\n \t\t/* If an rte_devargs exists, the generic rte_device uses the\n \t\t * given name as its name.\n@@ -172,7 +171,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,\n \n \tloc = &dev->addr;\n \n-\t/* The device is not blacklisted; Check if driver supports it */\n+\t/* The device is not blocked; Check if driver supports it */\n \tif (!rte_pci_match(dr, dev))\n \t\t/* Match of device and driver failed */\n \t\treturn 1;\n@@ -181,12 +180,10 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,\n \t\t\tloc->domain, loc->bus, loc->devid, loc->function,\n \t\t\tdev->device.numa_node);\n \n-\t/* no initialization when blacklisted, return without error */\n+\t/* no initialization when marked as blocked, return without error */\n \tif (dev->device.devargs != NULL &&\n-\t\tdev->device.devargs->policy ==\n-\t\t\tRTE_DEV_BLACKLISTED) {\n-\t\tRTE_LOG(INFO, EAL, \" Device is blacklisted, not\"\n-\t\t\t\" initializing\\n\");\n+\t\tdev->device.devargs->policy == RTE_DEV_BLOCKED) {\n+\t\tRTE_LOG(INFO, EAL, \" Device is blocked, not initializing\\n\");\n \t\treturn 1;\n \t}\n \n@@ -629,14 +626,13 @@ rte_pci_ignore_device(const struct rte_pci_addr *pci_addr)\n \tstruct rte_devargs *devargs = pci_devargs_lookup(pci_addr);\n \n \tswitch (rte_pci_bus.bus.conf.scan_mode) {\n-\tcase RTE_BUS_SCAN_WHITELIST:\n-\t\tif (devargs && devargs->policy == RTE_DEV_WHITELISTED)\n+\tcase RTE_BUS_SCAN_ALLOWLIST:\n+\t\tif (devargs && devargs->policy == RTE_DEV_ALLOWED)\n \t\t\treturn false;\n \t\tbreak;\n \tcase RTE_BUS_SCAN_UNDEFINED:\n-\tcase RTE_BUS_SCAN_BLACKLIST:\n-\t\tif (devargs == NULL ||\n-\t\t devargs->policy != RTE_DEV_BLACKLISTED)\n+\tcase RTE_BUS_SCAN_BLOCKLIST:\n+\t\tif (devargs == NULL || devargs->policy != RTE_DEV_BLOCKED)\n \t\t\treturn false;\n \t\tbreak;\n \t}\ndiff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c\nindex 4c9ac33ac6e4..b31678ad0564 100644\n--- a/drivers/bus/vmbus/vmbus_common.c\n+++ b/drivers/bus/vmbus/vmbus_common.c\n@@ -101,7 +101,7 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr,\n \tVMBUS_LOG(INFO, \"VMBUS device %s on NUMA socket %i\",\n \t\t guid, dev->device.numa_node);\n \n-\t/* TODO add blacklisted */\n+\t/* TODO add block/allow logic */\n \n \t/* map resources for device */\n \tret = rte_vmbus_map_device(dev);\n@@ -177,7 +177,7 @@ rte_vmbus_probe(void)\n \n \t\trte_uuid_unparse(dev->device_id, ubuf, sizeof(ubuf));\n \n-\t\t/* TODO: add whitelist/blacklist */\n+\t\t/* TODO: add allowlist/blocklist */\n \n \t\tif (vmbus_probe_all_drivers(dev) < 0) {\n \t\t\tVMBUS_LOG(NOTICE,\ndiff --git a/drivers/crypto/virtio/virtio_pci.c b/drivers/crypto/virtio/virtio_pci.c\nindex f490f6e28960..ae069794a683 100644\n--- a/drivers/crypto/virtio/virtio_pci.c\n+++ b/drivers/crypto/virtio/virtio_pci.c\n@@ -438,7 +438,7 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_crypto_hw *hw)\n * Return -1:\n * if there is error mapping with VFIO/UIO.\n * if port map error when driver type is KDRV_NONE.\n- * if whitelisted but driver type is KDRV_UNKNOWN.\n+ * if marked as allowed but driver type is KDRV_UNKNOWN.\n * Return 1 if kernel driver is managing the device.\n * Return 0 on success.\n */\ndiff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex 9915eabf68b0..d6b950ee6925 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -682,7 +682,7 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n * Return -1:\n * if there is error mapping with VFIO/UIO.\n * if port map error when driver type is KDRV_NONE.\n- * if whitelisted but driver type is KDRV_UNKNOWN.\n+ * if marked as allowed but driver type is KDRV_UNKNOWN.\n * Return 1 if kernel driver is managing the device.\n * Return 0 on success.\n */\n", "prefixes": [ "v10", "2/7" ] }