Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83847/?format=api
{ "id": 83847, "url": "http://patches.dpdk.org/api/patches/83847/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201109133005.67035-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201109133005.67035-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201109133005.67035-1-ferruh.yigit@intel.com", "date": "2020-11-09T13:30:05", "name": "net/af_xdp: do not use fixed size storage for pointer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1d6a6a9ca44ffbc738b175524b0c2ad48978ac58", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201109133005.67035-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 13745, "url": "http://patches.dpdk.org/api/series/13745/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13745", "date": "2020-11-09T13:30:05", "name": "net/af_xdp: do not use fixed size storage for pointer", "version": 1, "mbox": "http://patches.dpdk.org/series/13745/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83847/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83847/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 92FCBA0527;\n\tMon, 9 Nov 2020 14:30:14 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0EE9F5AB8;\n\tMon, 9 Nov 2020 14:30:13 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 5DB4E5AA7;\n Mon, 9 Nov 2020 14:30:10 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Nov 2020 05:30:09 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by fmsmga005.fm.intel.com with ESMTP; 09 Nov 2020 05:30:07 -0800" ], "IronPort-SDR": [ "\n bhcs1918VEB18gEF6aK+CXEhrDBeYmNXs/cwxxh5lgyVR99Yrs/sv5GZLfYjkdJsJMYP7CBvrG\n jz1SM5je91fg==", "\n 35QNGowU8EiRRjkoRs/AZhzOxjBQacPWHLW9lRx3GfXEKyuxS2kjxfcidLz6/4uvS3dfYzuDUQ\n 5UiAq/v5Gtsw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9799\"; a=\"157582457\"", "E=Sophos;i=\"5.77,463,1596524400\"; d=\"scan'208\";a=\"157582457\"", "E=Sophos;i=\"5.77,463,1596524400\"; d=\"scan'208\";a=\"530736518\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Ciara Loftus <ciara.loftus@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Xiaolong Ye <xiaolong.ye@intel.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tdev@dpdk.org,\n\tstable@dpdk.org", "Date": "Mon, 9 Nov 2020 13:30:05 +0000", "Message-Id": "<20201109133005.67035-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/af_xdp: do not use fixed size storage for\n\tpointer", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'uint64_t' is used to hold the pointer, for 32-bits build this\nassumption is wrong and giving following build error:\n\nrte_eth_af_xdp.c: In function ‘xdp_umem_configure’:\nrte_eth_af_xdp.c:970:15:\n error: cast to pointer from integer of different size\n [-Werror=int-to-pointer-cast]\n 970 | base_addr = (void *)get_base_addr(mb_pool, &align);\n | ^\n\nReplacing the 'uint64_t' return type of the 'get_base_addr()' to the\n'uintptr_t'.\nAlthough not sure if the overall logic supports the 32-bits, using\n'uintptr_t' should be safe both for 64/32 bits.\n\nFixes: d8a210774e1d (\"net/af_xdp: support unaligned umem chunks\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n\n---\n\nHi Ciara,\n\nI am not sure if 32-bit is supported for the af_xdp, but even not does\nthis change make sense for the 64-bits?\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex 4076ff797c..2c7892bd7e 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -910,13 +910,13 @@ eth_link_update(struct rte_eth_dev *dev __rte_unused,\n }\n \n #if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG)\n-static inline uint64_t get_base_addr(struct rte_mempool *mp, uint64_t *align)\n+static inline uintptr_t get_base_addr(struct rte_mempool *mp, uint64_t *align)\n {\n \tstruct rte_mempool_memhdr *memhdr;\n-\tuint64_t memhdr_addr, aligned_addr;\n+\tuintptr_t memhdr_addr, aligned_addr;\n \n \tmemhdr = STAILQ_FIRST(&mp->mem_list);\n-\tmemhdr_addr = (uint64_t)memhdr->addr;\n+\tmemhdr_addr = (uintptr_t)memhdr->addr;\n \taligned_addr = memhdr_addr & ~(getpagesize() - 1);\n \t*align = memhdr_addr - aligned_addr;\n \n", "prefixes": [] }