Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83827/?format=api
{ "id": 83827, "url": "http://patches.dpdk.org/api/patches/83827/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201108075330.1502-1-liweifeng96@126.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201108075330.1502-1-liweifeng96@126.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201108075330.1502-1-liweifeng96@126.com", "date": "2020-11-08T07:53:30", "name": "[v2] net/mlx5: make flow operation thread safe", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "0a3b00fe4818eb8b10222aed905d2f6d057bd6ad", "submitter": { "id": 1800, "url": "http://patches.dpdk.org/api/people/1800/?format=api", "name": "Weifeng Li", "email": "liweifeng96@126.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201108075330.1502-1-liweifeng96@126.com/mbox/", "series": [ { "id": 13734, "url": "http://patches.dpdk.org/api/series/13734/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13734", "date": "2020-11-08T07:53:30", "name": "[v2] net/mlx5: make flow operation thread safe", "version": 2, "mbox": "http://patches.dpdk.org/series/13734/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83827/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83827/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A0F83A04E6;\n\tSun, 8 Nov 2020 08:57:08 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E0CE51E2B;\n\tSun, 8 Nov 2020 08:57:06 +0100 (CET)", "from m15113.mail.126.com (m15113.mail.126.com [220.181.15.113])\n by dpdk.org (Postfix) with ESMTP id 3D172F90\n for <dev@dpdk.org>; Sun, 8 Nov 2020 08:57:04 +0100 (CET)", "from localhost.localdomain (unknown [125.120.172.145])\n by smtp3 (Coremail) with SMTP id DcmowAC3v8OtpKdfoiy9LQ--.21757S2;\n Sun, 08 Nov 2020 15:56:37 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com;\n s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=jIL8X\n mv4XApJ4AXD7SmYBU4A/LO7gxcDfefiArqe1Lk=; b=jxlheB78Gj6WeZD5xU6u7\n s9xmtCtFwFQRje7Mmrt/LqLRiONLDNjDRUOeUld8yJbpEUUDt6Fj5p30E2G0YGSn\n 9PfM8KAXjzT+uwyByVdMKXZEBq6I1c4ZRsdjgDuOeOpprzD+yOZ1CfNMHBOGc2po\n U3jMNe5wRbrSUt+9OPcATc=", "From": "Weifeng Li <liweifeng96@126.com>", "To": "matan@nvidia.com", "Cc": "dev@dpdk.org,\n\tWeifeng Li <liweifeng96@126.com>", "Date": "Sun, 8 Nov 2020 15:53:30 +0800", "Message-Id": "<20201108075330.1502-1-liweifeng96@126.com>", "X-Mailer": "git-send-email 2.27.0.windows.1", "In-Reply-To": "<20201108073714.1448-1-liweifeng96@126.com>", "References": "<20201108073714.1448-1-liweifeng96@126.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "DcmowAC3v8OtpKdfoiy9LQ--.21757S2", "X-Coremail-Antispam": "1Uf129KBjvJXoWxCryDKF4DCw18WF18XFyrWFg_yoWrWF45pa\n 13tF1ayrW8XFyIgw45Aa13ZF45Ww4I9r4YkF9xuwn5ZrWDZrykGr1kG3yUZrWkKrW3AFZx\n tF4UK3WDCF43WrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UsAwsUUUUU=", "X-Originating-IP": "[125.120.172.145]", "X-CM-SenderInfo": "5olzvx5ihqwmaw6rjloofrz/1tbimR3W-l9E1QeucQABs7", "Subject": "[dpdk-dev] [PATCH v2] net/mlx5: make flow operation thread safe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Does it need a lock for flow about below scene.\nThread1: flow_list_destroy----flow_list_create\nThread2: ---------flow_list_destroy----\nMaybe the same flow can be operate at the same time.\n\nWhen i start mlx5 bond and trigger LSC at the same time.\nIt is possible to assert in mlx5_rx_queue_release func and\nprint \"port 4 Rx queue 0 is still used by a flow and cannot\nbe removed\". I use dpdk-testpmd to simulate the test.\n\nSigned-off-by: Weifeng Li <liweifeng96@126.com>\n---\nv2: adjust coding style issue.\n---\n drivers/net/mlx5/linux/mlx5_os.c | 1 +\n drivers/net/mlx5/mlx5.h | 1 +\n drivers/net/mlx5/mlx5_flow.c | 13 +++++++++++--\n 3 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex c78d56f..59c074e 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -1426,6 +1426,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \t\t\t\t MLX5_MAX_MAC_ADDRESSES);\n \tpriv->flows = 0;\n \tpriv->ctrl_flows = 0;\n+\trte_spinlock_init(&priv->flow_lock);\n \trte_spinlock_init(&priv->flow_list_lock);\n \tTAILQ_INIT(&priv->flow_meters);\n \tTAILQ_INIT(&priv->flow_meter_profiles);\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex b43a8c9..860bf2f 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -963,6 +963,7 @@ struct mlx5_priv {\n \tunsigned int reta_idx_n; /* RETA index size. */\n \tstruct mlx5_drop drop_queue; /* Flow drop queues. */\n \tuint32_t flows; /* RTE Flow rules. */\n+\trte_spinlock_t flow_lock;\n \tuint32_t ctrl_flows; /* Control flow rules. */\n \trte_spinlock_t flow_list_lock;\n \tstruct mlx5_obj_ops obj_ops; /* HW objects operations. */\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex e9c0ddd..69d8159 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -5577,6 +5577,7 @@ flow_list_create(struct rte_eth_dev *dev, uint32_t *list,\n \t\t\t\texternal, hairpin_flow, error);\n \tif (ret < 0)\n \t\tgoto error_before_hairpin_split;\n+\trte_spinlock_lock(&priv->flow_lock);\n \tflow = mlx5_ipool_zmalloc(priv->sh->ipool[MLX5_IPOOL_RTE_FLOW], &idx);\n \tif (!flow) {\n \t\trte_errno = ENOMEM;\n@@ -5598,8 +5599,10 @@ flow_list_create(struct rte_eth_dev *dev, uint32_t *list,\n \tmemset(rss_desc, 0, offsetof(struct mlx5_flow_rss_desc, queue));\n \trss = flow_get_rss_action(p_actions_rx);\n \tif (rss) {\n-\t\tif (flow_rss_workspace_adjust(wks, rss_desc, rss->queue_num))\n+\t\tif (flow_rss_workspace_adjust(wks, rss_desc, rss->queue_num)) {\n+\t\t\trte_spinlock_unlock(&priv->flow_lock);\n \t\t\treturn 0;\n+\t\t}\n \t\t/*\n \t\t * The following information is required by\n \t\t * mlx5_flow_hashfields_adjust() in advance.\n@@ -5723,6 +5726,7 @@ flow_list_create(struct rte_eth_dev *dev, uint32_t *list,\n \t\t__atomic_add_fetch(&tunnel->refctn, 1, __ATOMIC_RELAXED);\n \t\tmlx5_free(default_miss_ctx.queue);\n \t}\n+\trte_spinlock_unlock(&priv->flow_lock);\n \treturn idx;\n error:\n \tMLX5_ASSERT(flow);\n@@ -5738,6 +5742,7 @@ flow_list_create(struct rte_eth_dev *dev, uint32_t *list,\n \t\twks->flow_nested_idx = 0;\n error_before_hairpin_split:\n \trte_free(translated_actions);\n+\trte_spinlock_unlock(&priv->flow_lock);\n \treturn 0;\n }\n \n@@ -5877,11 +5882,14 @@ flow_list_destroy(struct rte_eth_dev *dev, uint32_t *list,\n \t\t uint32_t flow_idx)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n+\trte_spinlock_lock(&priv->flow_lock);\n \tstruct rte_flow *flow = mlx5_ipool_get(priv->sh->ipool\n \t\t\t\t\t [MLX5_IPOOL_RTE_FLOW], flow_idx);\n \n-\tif (!flow)\n+\tif (!flow) {\n+\t\trte_spinlock_unlock(&priv->flow_lock);\n \t\treturn;\n+\t}\n \t/*\n \t * Update RX queue flags only if port is started, otherwise it is\n \t * already clean.\n@@ -5908,6 +5916,7 @@ flow_list_destroy(struct rte_eth_dev *dev, uint32_t *list,\n \t}\n \tflow_mreg_del_copy_action(dev, flow);\n \tmlx5_ipool_free(priv->sh->ipool[MLX5_IPOOL_RTE_FLOW], flow_idx);\n+\trte_spinlock_unlock(&priv->flow_lock);\n }\n \n /**\n", "prefixes": [ "v2" ] }