Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82387/?format=api
{ "id": 82387, "url": "http://patches.dpdk.org/api/patches/82387/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201027221343.28551-7-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201027221343.28551-7-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201027221343.28551-7-david.marchand@redhat.com", "date": "2020-10-27T22:13:41", "name": "[6/8] fslmc: switch sequence number to dynamic field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "933361ed1a6c9dd9c46d6fc0b0c52470c213d8f9", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201027221343.28551-7-david.marchand@redhat.com/mbox/", "series": [ { "id": 13394, "url": "http://patches.dpdk.org/api/series/13394/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13394", "date": "2020-10-27T22:13:35", "name": "remove mbuf seqn", "version": 1, "mbox": "http://patches.dpdk.org/series/13394/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82387/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/82387/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3BDC6A04B5;\n\tTue, 27 Oct 2020 23:16:00 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1FC593976;\n\tTue, 27 Oct 2020 23:14:14 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [63.128.21.124])\n by dpdk.org (Postfix) with ESMTP id 62EB134EE\n for <dev@dpdk.org>; Tue, 27 Oct 2020 23:14:10 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-4-VIDqo2v4P6-dsyR_P219bQ-1; Tue, 27 Oct 2020 18:14:04 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 62518803F4E;\n Tue, 27 Oct 2020 22:14:03 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.40])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 641D85C1BB;\n Tue, 27 Oct 2020 22:14:01 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1603836849;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QZfHAVLbbdgf9AJwo84s0vs6ah+POWIEO8cbKl8ZHco=;\n b=ZhTvJbut+6y4F5G8c5wQKKvgRyCoRcUVHWD6mH6k6Q4CzdxiWyY+m7CxXv/CDbBxA2/aj/\n e0R+C/tEHm6ysnnrd+m59N6b85gMpT9uLwWnaKEf1olRf5CNp8tsh501csEtdPJt0+f0cw\n jT8ZQBlgriNlUBmanRBkoLJMS5TjhXg=", "X-MC-Unique": "VIDqo2v4P6-dsyR_P219bQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@oss.nxp.com>, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>, Akhil Goyal <akhil.goyal@nxp.com>,\n Nipun Gupta <nipun.gupta@nxp.com>", "Date": "Tue, 27 Oct 2020 23:13:41 +0100", "Message-Id": "<20201027221343.28551-7-david.marchand@redhat.com>", "In-Reply-To": "<20201027221343.28551-1-david.marchand@redhat.com>", "References": "<20201027221343.28551-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 6/8] fslmc: switch sequence number to dynamic\n\tfield", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The dpaa2 drivers have been hacking the deprecated field seqn for\ninternal features.\nIt is moved to a dynamic mbuf field in order to allow removal of seqn.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/bus/fslmc/fslmc_bus.c | 17 +++++++++++\n drivers/bus/fslmc/rte_fslmc.h | 23 +++++++++++++++\n drivers/bus/fslmc/version.map | 1 +\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 18 ++++++------\n drivers/event/dpaa2/dpaa2_eventdev.c | 9 +++---\n drivers/event/dpaa2/dpaa2_eventdev_selftest.c | 4 ++-\n drivers/mempool/dpaa2/dpaa2_hw_mempool.h | 2 --\n drivers/net/dpaa2/dpaa2_rxtx.c | 28 +++++++++----------\n 8 files changed, 73 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex beb3dd008f..db93669628 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -14,6 +14,7 @@\n #include <rte_devargs.h>\n #include <rte_memcpy.h>\n #include <rte_ethdev_driver.h>\n+#include <rte_mbuf_dyn.h>\n \n #include <rte_fslmc.h>\n #include <fslmc_vfio.h>\n@@ -27,6 +28,9 @@\n struct rte_fslmc_bus rte_fslmc_bus;\n uint8_t dpaa2_virt_mode;\n \n+#define DPAA2_SEQN_DYNFIELD_NAME \"dpaa2_seqn_dynfield\"\n+int dpaa2_seqn_dynfield_offset = -1;\n+\n uint32_t\n rte_fslmc_get_device_count(enum rte_dpaa2_dev_type device_type)\n {\n@@ -374,9 +378,22 @@ rte_fslmc_probe(void)\n \tstruct rte_dpaa2_device *dev;\n \tstruct rte_dpaa2_driver *drv;\n \n+\tstatic const struct rte_mbuf_dynfield dpaa2_seqn_dynfield_desc = {\n+\t\t.name = DPAA2_SEQN_DYNFIELD_NAME,\n+\t\t.size = sizeof(dpaa2_seqn_t),\n+\t\t.align = __alignof__(dpaa2_seqn_t),\n+\t};\n+\n \tif (TAILQ_EMPTY(&rte_fslmc_bus.device_list))\n \t\treturn 0;\n \n+\tdpaa2_seqn_dynfield_offset =\n+\t\trte_mbuf_dynfield_register(&dpaa2_seqn_dynfield_desc);\n+\tif (dpaa2_seqn_dynfield_offset < 0) {\n+\t\tDPAA2_BUS_ERR(\"Failed to register mbuf field for dpaa sequence number\");\n+\t\treturn 0;\n+\t}\n+\n \tret = fslmc_vfio_setup_group();\n \tif (ret) {\n \t\tDPAA2_BUS_ERR(\"Unable to setup VFIO %d\", ret);\ndiff --git a/drivers/bus/fslmc/rte_fslmc.h b/drivers/bus/fslmc/rte_fslmc.h\nindex 80873fffc9..37ca6886f2 100644\n--- a/drivers/bus/fslmc/rte_fslmc.h\n+++ b/drivers/bus/fslmc/rte_fslmc.h\n@@ -32,11 +32,34 @@ extern \"C\" {\n #include <rte_bus.h>\n #include <rte_tailq.h>\n #include <rte_devargs.h>\n+#include <rte_mbuf.h>\n+#include <rte_mbuf_dyn.h>\n \n #include <fslmc_vfio.h>\n \n #define FSLMC_OBJECT_MAX_LEN 32 /**< Length of each device on bus */\n \n+#define DPAA2_INVALID_MBUF_SEQN 0\n+\n+typedef uint32_t dpaa2_seqn_t;\n+extern int dpaa2_seqn_dynfield_offset;\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n+ * Read dpaa2 sequence number from mbuf.\n+ *\n+ * @param mbuf Structure to read from.\n+ * @return pointer to dpaa2 sequence number.\n+ */\n+__rte_experimental\n+static inline dpaa2_seqn_t *\n+dpaa2_seqn(const struct rte_mbuf *mbuf)\n+{\n+\treturn RTE_MBUF_DYNFIELD(mbuf, dpaa2_seqn_dynfield_offset,\n+\t\tdpaa2_seqn_t *);\n+}\n \n /** Device driver supports link state interrupt */\n #define RTE_DPAA2_DRV_INTR_LSC\t0x0008\ndiff --git a/drivers/bus/fslmc/version.map b/drivers/bus/fslmc/version.map\nindex b169f5228a..f44c1a7988 100644\n--- a/drivers/bus/fslmc/version.map\n+++ b/drivers/bus/fslmc/version.map\n@@ -19,6 +19,7 @@ INTERNAL {\n \tdpaa2_free_eq_descriptors;\n \tdpaa2_get_mcp_ptr;\n \tdpaa2_io_portal;\n+\tdpaa2_seqn_dynfield_offset;\n \tdpaa2_svr_family;\n \tdpaa2_virt_mode;\n \tdpbp_disable;\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex afcd6bd063..ce1d50ce77 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -1472,13 +1472,15 @@ dpaa2_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops,\n \t\t\tdpaa2_eqcr_size : nb_ops;\n \n \t\tfor (loop = 0; loop < frames_to_send; loop++) {\n-\t\t\tif ((*ops)->sym->m_src->seqn) {\n-\t\t\t uint8_t dqrr_index = (*ops)->sym->m_src->seqn - 1;\n-\n-\t\t\t flags[loop] = QBMAN_ENQUEUE_FLAG_DCA | dqrr_index;\n-\t\t\t DPAA2_PER_LCORE_DQRR_SIZE--;\n-\t\t\t DPAA2_PER_LCORE_DQRR_HELD &= ~(1 << dqrr_index);\n-\t\t\t (*ops)->sym->m_src->seqn = DPAA2_INVALID_MBUF_SEQN;\n+\t\t\tif (*dpaa2_seqn((*ops)->sym->m_src)) {\n+\t\t\t\tuint8_t dqrr_index =\n+\t\t\t\t\t*dpaa2_seqn((*ops)->sym->m_src) - 1;\n+\n+\t\t\t\tflags[loop] = QBMAN_ENQUEUE_FLAG_DCA | dqrr_index;\n+\t\t\t\tDPAA2_PER_LCORE_DQRR_SIZE--;\n+\t\t\t\tDPAA2_PER_LCORE_DQRR_HELD &= ~(1 << dqrr_index);\n+\t\t\t\t*dpaa2_seqn((*ops)->sym->m_src) =\n+\t\t\t\t\tDPAA2_INVALID_MBUF_SEQN;\n \t\t\t}\n \n \t\t\t/*Clear the unused FD fields before sending*/\n@@ -3714,7 +3716,7 @@ dpaa2_sec_process_atomic_event(struct qbman_swp *swp __rte_unused,\n \n \tev->event_ptr = sec_fd_to_mbuf(fd);\n \tdqrr_index = qbman_get_dqrr_idx(dq);\n-\tcrypto_op->sym->m_src->seqn = dqrr_index + 1;\n+\t*dpaa2_seqn(crypto_op->sym->m_src) = dqrr_index + 1;\n \tDPAA2_PER_LCORE_DQRR_SIZE++;\n \tDPAA2_PER_LCORE_DQRR_HELD |= 1 << dqrr_index;\n \tDPAA2_PER_LCORE_DQRR_MBUF(dqrr_index) = crypto_op->sym->m_src;\ndiff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c\nindex 95f03c8b9e..eeb2494bd0 100644\n--- a/drivers/event/dpaa2/dpaa2_eventdev.c\n+++ b/drivers/event/dpaa2/dpaa2_eventdev.c\n@@ -131,8 +131,9 @@ dpaa2_eventdev_enqueue_burst(void *port, const struct rte_event ev[],\n \t\t\tqbman_eq_desc_set_response(&eqdesc[loop], 0, 0);\n \n \t\t\tif (event->sched_type == RTE_SCHED_TYPE_ATOMIC\n-\t\t\t\t&& event->mbuf->seqn) {\n-\t\t\t\tuint8_t dqrr_index = event->mbuf->seqn - 1;\n+\t\t\t\t&& *dpaa2_seqn(event->mbuf)) {\n+\t\t\t\tuint8_t dqrr_index =\n+\t\t\t\t\t*dpaa2_seqn(event->mbuf) - 1;\n \n \t\t\t\tqbman_eq_desc_set_dca(&eqdesc[loop], 1,\n \t\t\t\t\t\t dqrr_index, 0);\n@@ -249,7 +250,7 @@ static void dpaa2_eventdev_process_atomic(struct qbman_swp *swp,\n \n \trte_memcpy(ev, ev_temp, sizeof(struct rte_event));\n \trte_free(ev_temp);\n-\tev->mbuf->seqn = dqrr_index + 1;\n+\t*dpaa2_seqn(ev->mbuf) = dqrr_index + 1;\n \tDPAA2_PER_LCORE_DQRR_SIZE++;\n \tDPAA2_PER_LCORE_DQRR_HELD |= 1 << dqrr_index;\n \tDPAA2_PER_LCORE_DQRR_MBUF(dqrr_index) = ev->mbuf;\n@@ -314,7 +315,7 @@ dpaa2_eventdev_dequeue_burst(void *port, struct rte_event ev[],\n \t\tif (DPAA2_PER_LCORE_DQRR_HELD & (1 << i)) {\n \t\t\tqbman_swp_dqrr_idx_consume(swp, i);\n \t\t\tDPAA2_PER_LCORE_DQRR_SIZE--;\n-\t\t\tDPAA2_PER_LCORE_DQRR_MBUF(i)->seqn =\n+\t\t\t*dpaa2_seqn(DPAA2_PER_LCORE_DQRR_MBUF(i)) =\n \t\t\t\tDPAA2_INVALID_MBUF_SEQN;\n \t\t}\n \t\ti++;\ndiff --git a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c\nindex 5447db8a8a..cd7311a94d 100644\n--- a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c\n+++ b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c\n@@ -19,6 +19,7 @@\n #include <rte_random.h>\n #include <rte_bus_vdev.h>\n #include <rte_test.h>\n+#include <rte_fslmc.h>\n \n #include \"dpaa2_eventdev.h\"\n #include \"dpaa2_eventdev_logs.h\"\n@@ -274,7 +275,8 @@ check_excess_events(uint8_t port)\n \t\tvalid_event = rte_event_dequeue_burst(evdev, port, &ev, 1, 0);\n \n \t\tRTE_TEST_ASSERT_SUCCESS(valid_event,\n-\t\t\t\t\"Unexpected valid event=%d\", ev.mbuf->seqn);\n+\t\t\t\t\"Unexpected valid event=%d\",\n+\t\t\t\t*dpaa2_seqn(ev.mbuf));\n \t}\n \treturn 0;\n }\ndiff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.h b/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\nindex 53fa1552d1..7c493b28e7 100644\n--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\n+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\n@@ -10,8 +10,6 @@\n \n #define DPAA2_MAX_BUF_POOLS\t8\n \n-#define DPAA2_INVALID_MBUF_SEQN\t0\n-\n struct buf_pool_cfg {\n \tvoid *addr;\n \t/**< The address from where DPAA2 will carve out the buffers */\ndiff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c\nindex 4dd1d5f578..6201de4606 100644\n--- a/drivers/net/dpaa2/dpaa2_rxtx.c\n+++ b/drivers/net/dpaa2/dpaa2_rxtx.c\n@@ -710,7 +710,7 @@ dpaa2_dev_process_atomic_event(struct qbman_swp *swp __rte_unused,\n \tev->mbuf = eth_fd_to_mbuf(fd, rxq->eth_data->port_id);\n \n \tdqrr_index = qbman_get_dqrr_idx(dq);\n-\tev->mbuf->seqn = dqrr_index + 1;\n+\t*dpaa2_seqn(ev->mbuf) = dqrr_index + 1;\n \tDPAA2_PER_LCORE_DQRR_SIZE++;\n \tDPAA2_PER_LCORE_DQRR_HELD |= 1 << dqrr_index;\n \tDPAA2_PER_LCORE_DQRR_MBUF(dqrr_index) = ev->mbuf;\n@@ -736,9 +736,9 @@ dpaa2_dev_process_ordered_event(struct qbman_swp *swp,\n \n \tev->mbuf = eth_fd_to_mbuf(fd, rxq->eth_data->port_id);\n \n-\tev->mbuf->seqn = DPAA2_ENQUEUE_FLAG_ORP;\n-\tev->mbuf->seqn |= qbman_result_DQ_odpid(dq) << DPAA2_EQCR_OPRID_SHIFT;\n-\tev->mbuf->seqn |= qbman_result_DQ_seqnum(dq) << DPAA2_EQCR_SEQNUM_SHIFT;\n+\t*dpaa2_seqn(ev->mbuf) = DPAA2_ENQUEUE_FLAG_ORP;\n+\t*dpaa2_seqn(ev->mbuf) |= qbman_result_DQ_odpid(dq) << DPAA2_EQCR_OPRID_SHIFT;\n+\t*dpaa2_seqn(ev->mbuf) |= qbman_result_DQ_seqnum(dq) << DPAA2_EQCR_SEQNUM_SHIFT;\n \n \tqbman_swp_dqrr_consume(swp, dq);\n }\n@@ -1063,14 +1063,14 @@ dpaa2_dev_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tdpaa2_eqcr_size : nb_pkts;\n \n \t\tfor (loop = 0; loop < frames_to_send; loop++) {\n-\t\t\tif ((*bufs)->seqn) {\n-\t\t\t\tuint8_t dqrr_index = (*bufs)->seqn - 1;\n+\t\t\tif (*dpaa2_seqn(*bufs)) {\n+\t\t\t\tuint8_t dqrr_index = *dpaa2_seqn(*bufs) - 1;\n \n \t\t\t\tflags[loop] = QBMAN_ENQUEUE_FLAG_DCA |\n \t\t\t\t\t\tdqrr_index;\n \t\t\t\tDPAA2_PER_LCORE_DQRR_SIZE--;\n \t\t\t\tDPAA2_PER_LCORE_DQRR_HELD &= ~(1 << dqrr_index);\n-\t\t\t\t(*bufs)->seqn = DPAA2_INVALID_MBUF_SEQN;\n+\t\t\t\t*dpaa2_seqn(*bufs) = DPAA2_INVALID_MBUF_SEQN;\n \t\t\t}\n \n \t\t\tif (likely(RTE_MBUF_DIRECT(*bufs))) {\n@@ -1230,10 +1230,10 @@ dpaa2_set_enqueue_descriptor(struct dpaa2_queue *dpaa2_q,\n \n \tqbman_eq_desc_set_fq(eqdesc, dpaa2_q->fqid);\n \n-\tif (m->seqn & DPAA2_ENQUEUE_FLAG_ORP) {\n-\t\torpid = (m->seqn & DPAA2_EQCR_OPRID_MASK) >>\n+\tif (*dpaa2_seqn(m) & DPAA2_ENQUEUE_FLAG_ORP) {\n+\t\torpid = (*dpaa2_seqn(m) & DPAA2_EQCR_OPRID_MASK) >>\n \t\t\tDPAA2_EQCR_OPRID_SHIFT;\n-\t\tseqnum = (m->seqn & DPAA2_EQCR_SEQNUM_MASK) >>\n+\t\tseqnum = (*dpaa2_seqn(m) & DPAA2_EQCR_SEQNUM_MASK) >>\n \t\t\tDPAA2_EQCR_SEQNUM_SHIFT;\n \n \t\tif (!priv->en_loose_ordered) {\n@@ -1255,12 +1255,12 @@ dpaa2_set_enqueue_descriptor(struct dpaa2_queue *dpaa2_q,\n \t\t\tqbman_eq_desc_set_orp(eqdesc, 0, orpid, seqnum, 0);\n \t\t}\n \t} else {\n-\t\tdq_idx = m->seqn - 1;\n+\t\tdq_idx = *dpaa2_seqn(m) - 1;\n \t\tqbman_eq_desc_set_dca(eqdesc, 1, dq_idx, 0);\n \t\tDPAA2_PER_LCORE_DQRR_SIZE--;\n \t\tDPAA2_PER_LCORE_DQRR_HELD &= ~(1 << dq_idx);\n \t}\n-\tm->seqn = DPAA2_INVALID_MBUF_SEQN;\n+\t*dpaa2_seqn(m) = DPAA2_INVALID_MBUF_SEQN;\n }\n \n /* Callback to handle sending ordered packets through WRIOP based interface */\n@@ -1314,7 +1314,7 @@ dpaa2_dev_tx_ordered(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tdpaa2_eqcr_size : nb_pkts;\n \n \t\tif (!priv->en_loose_ordered) {\n-\t\t\tif ((*bufs)->seqn & DPAA2_ENQUEUE_FLAG_ORP) {\n+\t\t\tif (*dpaa2_seqn(*bufs) & DPAA2_ENQUEUE_FLAG_ORP) {\n \t\t\t\tnum_free_eq_desc = dpaa2_free_eq_descriptors();\n \t\t\t\tif (num_free_eq_desc < frames_to_send)\n \t\t\t\t\tframes_to_send = num_free_eq_desc;\n@@ -1325,7 +1325,7 @@ dpaa2_dev_tx_ordered(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t/*Prepare enqueue descriptor*/\n \t\t\tqbman_eq_desc_clear(&eqdesc[loop]);\n \n-\t\t\tif ((*bufs)->seqn) {\n+\t\t\tif (*dpaa2_seqn(*bufs)) {\n \t\t\t\t/* Use only queue 0 for Tx in case of atomic/\n \t\t\t\t * ordered packets as packets can get unordered\n \t\t\t\t * when being tranmitted out from the interface\n", "prefixes": [ "6/8" ] }