Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81815/?format=api
{ "id": 81815, "url": "http://patches.dpdk.org/api/patches/81815/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603381885-88819-4-git-send-email-huawei.xhw@alibaba-inc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603381885-88819-4-git-send-email-huawei.xhw@alibaba-inc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603381885-88819-4-git-send-email-huawei.xhw@alibaba-inc.com", "date": "2020-10-22T15:51:25", "name": "[v5,3/3] PCI: don't use vfio ioctl call to access PIO resource", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "908f83230060124cd8516f22384a6f56833ce7f6", "submitter": { "id": 1977, "url": "http://patches.dpdk.org/api/people/1977/?format=api", "name": "谢华伟(此时此刻）", "email": "huawei.xhw@alibaba-inc.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603381885-88819-4-git-send-email-huawei.xhw@alibaba-inc.com/mbox/", "series": [ { "id": 13220, "url": "http://patches.dpdk.org/api/series/13220/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13220", "date": "2020-10-22T15:51:22", "name": "support both PIO and MMIO BAR for virtio PMD", "version": 5, "mbox": "http://patches.dpdk.org/series/13220/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81815/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/81815/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE6BDA04DD;\n\tThu, 22 Oct 2020 17:52:19 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 830ADAC61;\n\tThu, 22 Oct 2020 17:51:44 +0200 (CEST)", "from out0-145.mail.aliyun.com (out0-145.mail.aliyun.com\n [140.205.0.145]) by dpdk.org (Postfix) with ESMTP id 5A016AC48\n for <dev@dpdk.org>; Thu, 22 Oct 2020 17:51:36 +0200 (CEST)", "from\n rs3a10040.et2sqa.z1.et2sqa.tbsite.net(mailfrom:huawei.xhw@alibaba-inc.com\n fp:SMTPD_---.In.51nB_1603381889) by smtp.aliyun-inc.com(127.0.0.1);\n Thu, 22 Oct 2020 23:51:33 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=alibaba-inc.com; s=default;\n t=1603381894; h=From:To:Subject:Date:Message-Id;\n bh=0LrVduElJIgm1/oCAgsnOBUUTvaUgQr5wfFP4MqhV7A=;\n b=Mmo8HLckWk5PEclJIeaO2Pv0bW+GOyqzrHiUjzQclijP7jzmoJs7v0e73jdRfAcOuswfBPUMy0z1akLqozbHMlFGrgqoba/GyInGSOxiXHnYxWmKx7GCn/x4tqJeYHOyCTjj2H4bBK41bZ+XREqdWAvW7urJcKsHtJgpeqhrFnE=", "X-Alimail-AntiSpam": "AC=PASS; BC=-1|-1; BR=01201311R131e4; CH=green;\n DM=||false|;\n DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018047213;\n MF=huawei.xhw@alibaba-inc.com; NM=1; PH=DS; RN=9; SR=0;\n TI=SMTPD_---.In.51nB_1603381889;", "From": "\" =?utf-8?b?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?= \"\n <huawei.xhw@alibaba-inc.com>", "To": "ferruh.yigit@intel.com", "Cc": "<dev@dpdk.org>, <maxime.coquelin@redhat.com>, <anatoly.burakov@intel.com>,\n <david.marchand@redhat.com>, <zhihong.wang@intel.com>,\n <chenbo.xia@intel.com>, <grive@u256.net>, \" =?utf-8?b?6LCi5Y2O5LyfKOatpA==?=\n\t=?utf-8?b?5pe25q2k5Yi777yJ?= \" <huawei.xhw@alibaba-inc.com>", "Date": "Thu, 22 Oct 2020 23:51:25 +0800", "Message-Id": "<1603381885-88819-4-git-send-email-huawei.xhw@alibaba-inc.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603381885-88819-1-git-send-email-huawei.xhw@alibaba-inc.com>", "References": "<68ecd941-9c56-4de7-fae2-2ad15bdfd81a@alibaba-inc.com>\n <1603381885-88819-1-git-send-email-huawei.xhw@alibaba-inc.com>", "Subject": "[dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access\n\tPIO resource", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"huawei.xhw\" <huawei.xhw@alibaba-inc.com>\n\nVFIO should use the same way to map/read/write PORT IO as UIO, for\nvirtio PMD.\n\nSigned-off-by: huawei.xhw <huawei.xhw@alibaba-inc.com>\n---\n drivers/bus/pci/linux/pci.c | 8 ++++----\n drivers/bus/pci/linux/pci_uio.c | 4 +++-\n 2 files changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex 0dc99e9..2ed9f2b 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -687,7 +687,7 @@ int rte_pci_write_config(const struct rte_pci_device *device,\n #ifdef VFIO_PRESENT\n \tcase RTE_PCI_KDRV_VFIO:\n \t\tif (pci_vfio_is_enabled())\n-\t\t\tret = pci_vfio_ioport_map(dev, bar, p);\n+\t\t\tret = pci_uio_ioport_map(dev, bar, p);\n \t\tbreak;\n #endif\n \tcase RTE_PCI_KDRV_IGB_UIO:\n@@ -711,7 +711,7 @@ int rte_pci_write_config(const struct rte_pci_device *device,\n \tswitch (p->dev->kdrv) {\n #ifdef VFIO_PRESENT\n \tcase RTE_PCI_KDRV_VFIO:\n-\t\tpci_vfio_ioport_read(p, data, len, offset);\n+\t\tpci_uio_ioport_read(p, data, len, offset);\n \t\tbreak;\n #endif\n \tcase RTE_PCI_KDRV_IGB_UIO:\n@@ -730,7 +730,7 @@ int rte_pci_write_config(const struct rte_pci_device *device,\n \tswitch (p->dev->kdrv) {\n #ifdef VFIO_PRESENT\n \tcase RTE_PCI_KDRV_VFIO:\n-\t\tpci_vfio_ioport_write(p, data, len, offset);\n+\t\tpci_uio_ioport_write(p, data, len, offset);\n \t\tbreak;\n #endif\n \tcase RTE_PCI_KDRV_IGB_UIO:\n@@ -751,7 +751,7 @@ int rte_pci_write_config(const struct rte_pci_device *device,\n #ifdef VFIO_PRESENT\n \tcase RTE_PCI_KDRV_VFIO:\n \t\tif (pci_vfio_is_enabled())\n-\t\t\tret = pci_vfio_ioport_unmap(p);\n+\t\t\tret = pci_uio_ioport_unmap(p);\n \t\tbreak;\n #endif\n \tcase RTE_PCI_KDRV_IGB_UIO:\ndiff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c\nindex c19382f..463792b 100644\n--- a/drivers/bus/pci/linux/pci_uio.c\n+++ b/drivers/bus/pci/linux/pci_uio.c\n@@ -429,7 +429,9 @@\n \t}\n \n \t/* FIXME only for primary process ? */\n-\tif (dev->intr_handle.type == RTE_INTR_HANDLE_UNKNOWN) {\n+\tif (dev->intr_handle.type == RTE_INTR_HANDLE_UNKNOWN &&\n+\t\t(dev->kdrv == RTE_PCI_KDRV_IGB_UIO ||\n+\t\t dev->kdrv == RTE_PCI_KDRV_UIO_GENERIC)) {\n \t\tint uio_num = pci_get_uio_dev(dev, dirname, sizeof(dirname), 0);\n \t\tif (uio_num < 0) {\n \t\t\tRTE_LOG(ERR, EAL, \"cannot open %s: %s\\n\",\n", "prefixes": [ "v5", "3/3" ] }