Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81806/?format=api
{ "id": 81806, "url": "http://patches.dpdk.org/api/patches/81806/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201022145944.470054-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201022145944.470054-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201022145944.470054-4-bruce.richardson@intel.com", "date": "2020-10-22T14:59:44", "name": "[RFC,3/3] build: write messages to dpdk build log file", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "760393d18e7d9db970629e59ad39575f58c31a91", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201022145944.470054-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 13218, "url": "http://patches.dpdk.org/api/series/13218/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13218", "date": "2020-10-22T14:59:42", "name": "add custom logging to DPDK meson runs", "version": 1, "mbox": "http://patches.dpdk.org/series/13218/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81806/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81806/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 40995A04DD;\n\tThu, 22 Oct 2020 17:01:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 55EF7AC43;\n\tThu, 22 Oct 2020 17:00:10 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id EC527AA23\n for <dev@dpdk.org>; Thu, 22 Oct 2020 17:00:05 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Oct 2020 08:00:03 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by orsmga005.jf.intel.com with ESMTP; 22 Oct 2020 08:00:02 -0700" ], "IronPort-SDR": [ "\n 8rhzfepe5Gl2LUzBe2NgslAzcHFPqDat0HXfJD0Ww5TFqRcGmrVbtTMqnnnMADqZOJwYPNjfDM\n uMyP4yATriGQ==", "\n HyvnjX4d5dvcwxxxBXa0Bvq8cfAbZqLmDPzR65xfAuXAYBa7K4J4gDTT4QEXVyqazRW77OYquC\n +iQi+r9WooMg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9781\"; a=\"185219014\"", "E=Sophos;i=\"5.77,404,1596524400\"; d=\"scan'208\";a=\"185219014\"", "E=Sophos;i=\"5.77,404,1596524400\"; d=\"scan'208\";a=\"533997630\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 22 Oct 2020 15:59:44 +0100", "Message-Id": "<20201022145944.470054-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201022145944.470054-1-bruce.richardson@intel.com>", "References": "<20201022145944.470054-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH 3/3] build: write messages to dpdk build log\n\tfile", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add additional info into the DPDK-specific logs by copying or replacing all\n\"message()\" calls with writes to the log file, making the build\nconfiguration, including lists of enabled/disabled drivers etc. available\nafter the meson run has completed.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/meson.build | 2 +-\n config/arm/meson.build | 2 ++\n config/x86/meson.build | 2 ++\n drivers/meson.build | 6 ++++--\n examples/meson.build | 1 +\n lib/meson.build | 5 +++--\n meson.build | 6 ++++++\n 7 files changed, 19 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 8bfb02890..b2d90cfd8 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -439,7 +439,7 @@ dpdk_test = executable('dpdk-test',\n \tinstall: true)\n \n has_hugepage = run_command('has-hugepage.sh').stdout().strip() != '0'\n-message('hugepage availability: @0@'.format(has_hugepage))\n+run_command(log, 'hugepage availability: @0@'.format(has_hugepage))\n \n # some perf tests (eg: memcpy perf autotest)take very long\n # to complete, so timeout to 10 minutes\ndiff --git a/config/arm/meson.build b/config/arm/meson.build\nindex b49203fa8..31ac79480 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -182,6 +182,7 @@ else\n \tendforeach\n \n \tmessage('Implementer : ' + machine[0])\n+\trun_command(log, 'config/arm/meson.build: Implementer = ' + machine[0])\n \tforeach flag: machine[1]\n \t\tif flag.length() > 0\n \t\t\tdpdk_conf.set(flag[0], flag[1])\n@@ -205,6 +206,7 @@ else\n \tendforeach\n endif\n message(machine_args)\n+run_command(log, 'config/arm/meson.build: machine_args = ', machine_args)\n \n if (cc.get_define('__ARM_NEON', args: machine_args) != '' or\n cc.get_define('__aarch64__', args: machine_args) != '')\ndiff --git a/config/x86/meson.build b/config/x86/meson.build\nindex 31bfa63b1..0008717b8 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -13,6 +13,8 @@ endif\n # we require SSE4.2 for DPDK\n if cc.get_define('__SSE4_2__', args: machine_args) == ''\n \tmessage('SSE 4.2 not enabled by default, explicitly enabling')\n+\trun_command(log, 'config/x86/meson.build:',\n+\t\t\t'SSE 4.2 not enabled by default, explicitly enabling')\n \tmachine_args += '-msse4'\n endif\n \ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex c008abd4a..fd925114e 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -90,8 +90,10 @@ foreach subpath:subdirs\n \t\t\t\tif not is_variable('shared_rte_' + d)\n \t\t\t\t\tbuild = false\n \t\t\t\t\treason = 'Missing internal dependency, \"@0@\"'.format(d)\n-\t\t\t\t\tmessage('Disabling @1@ [@2@]: missing internal dependency \"@0@\"'\n-\t\t\t\t\t\t\t.format(d, name, 'drivers/' + drv_path))\n+\t\t\t\t\tlog_msg = 'Disabling @1@ [@2@]: missing internal dependency \"@0@\"'.format(\n+\t\t\t\t\t\td, name, 'drivers/' + drv_path)\n+\t\t\t\t\tmessage(log_msg)\n+\t\t\t\t\trun_command(log, log_msg)\n \t\t\t\telse\n \t\t\t\t\tshared_deps += [get_variable('shared_rte_' + d)]\n \t\t\t\t\tstatic_deps += [get_variable('static_rte_' + d)]\ndiff --git a/examples/meson.build b/examples/meson.build\nindex 414ec55cc..8f9922cad 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -105,5 +105,6 @@ foreach example: examples\n \t\terror('Cannot build requested example \"' + name + '\"')\n \telse\n \t\tmessage('Skipping example \"' + name + '\"')\n+\t\trun_command(log, 'Skipping example \"' + name + '\"')\n \tendif\n endforeach\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 2715c0f66..aac07eb50 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -112,8 +112,9 @@ foreach l:libraries\n \t\t\tstatic_dep = shared_dep\n \t\telse\n \t\t\tif is_windows and use_function_versioning\n-\t\t\t\tmessage('@0@: Function versioning is not supported by Windows.'\n-\t\t\t\t.format(name))\n+\t\t\t\tlog_msg = '@0@: Function versioning is not supported by Windows.'.format(name)\n+\t\t\t\tmessage(log_msg)\n+\t\t\t\trun_command(log, log_msg)\n \t\t\tendif\n \n \t\t\tif use_function_versioning\ndiff --git a/meson.build b/meson.build\nindex 8333d264f..a587579f3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -15,6 +15,8 @@ project('DPDK', 'C',\n subdir('buildtools')\n \n run_command(log, '======= Starting meson =======')\n+run_command(log, 'Meson version', meson.version())\n+run_command(log, 'DPDK version', meson.project_version())\n \n # set up some global vars for compiler, platform, configuration, etc.\n cc = meson.get_compiler('c')\n@@ -76,6 +78,7 @@ foreach lib:enabled_libs\n \tendif\n endforeach\n message(output_message + '\\n')\n+run_command(log, output_message)\n \n output_message = '\\n===============\\nDrivers Enabled\\n===============\\n'\n foreach class:dpdk_driver_classes\n@@ -92,6 +95,7 @@ foreach class:dpdk_driver_classes\n \tendforeach\n endforeach\n message(output_message + '\\n')\n+run_command(log, output_message)\n \n output_message = '\\n=================\\nContent Skipped\\n=================\\n'\n output_message += '\\nlibs:\\n\\t'\n@@ -105,3 +109,5 @@ foreach drv:dpdk_drvs_disabled\n \toutput_message += drv + ':\\t' + reason + '\\n\\t'\n endforeach\n message(output_message + '\\n')\n+run_command(log, output_message)\n+run_command(log, 'Meson done\\n')\n", "prefixes": [ "RFC", "3/3" ] }