Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81769/?format=api
{ "id": 81769, "url": "http://patches.dpdk.org/api/patches/81769/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603359758-13297-11-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603359758-13297-11-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603359758-13297-11-git-send-email-arybchenko@solarflare.com", "date": "2020-10-22T09:42:33", "name": "[v2,10/14] ethdev: remove legacy L2_TUNNEL filter type support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1f575bff9a58313e7b3bff290bde8e4873259cb8", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603359758-13297-11-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13207, "url": "http://patches.dpdk.org/api/series/13207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13207", "date": "2020-10-22T09:42:23", "name": "ethdev: remove legacy filter API", "version": 2, "mbox": "http://patches.dpdk.org/series/13207/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81769/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81769/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E93AA04DD;\n\tThu, 22 Oct 2020 11:46:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 74B77A9BA;\n\tThu, 22 Oct 2020 11:43:33 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 0075FA968\n for <dev@dpdk.org>; Thu, 22 Oct 2020 11:43:11 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.137])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 9F29F20059; Thu, 22 Oct 2020 09:43:09 +0000 (UTC)", "from us4-mdac16-62.at1.mdlocal (unknown [10.110.50.155])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 9E32C6009B;\n Thu, 22 Oct 2020 09:43:09 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.48.59])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 07D0222004D;\n Thu, 22 Oct 2020 09:43:09 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n BE794380055;\n Thu, 22 Oct 2020 09:43:08 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 22 Oct 2020 10:43:03 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 22 Oct 2020 10:43:03 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09M9h3eM023378;\n Thu, 22 Oct 2020 10:43:03 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id C4F1A1613A9;\n Thu, 22 Oct 2020 10:43:03 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>, Ray Kinsella\n <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Jeff Guo\n <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>, Rasesh Mody\n <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>", "CC": "<dev@dpdk.org>", "Date": "Thu, 22 Oct 2020 10:42:33 +0100", "Message-ID": "<1603359758-13297-11-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603359758-13297-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603030152-13451-1-git-send-email-arybchenko@solarflare.com>\n <1603359758-13297-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25740.003", "X-TM-AS-Result": "No-1.147700-8.000000-10", "X-TMASE-MatchedRID": "1INWUdRqZzfXhaZsZZP8sKiUivh0j2PvF03B4pKYOlpG7aLtT3oj+yXD\n Fxgit6TpPVa/URzklI8chiY3DrTHPa0iin8P0KjVPwKTD1v8YV5MkOX0UoduuVVkJxysad/Istf\n L6WfCYzE2GpeDLY7WfOIGtqyMn3xGJIp5MhAnVvPnZxuPj9aY+w+jS+LRpl81HqeNNK3aTgsF2S\n 1V5QxD3UEcqa8/c+Vr5pceXwRZ3AUn5dt8H65jTi9cBNSlgvYqszQhMHsSILvi7ECA5q90uYkII\n OqbR5F7CmviniliH8pD3/OEVqXP9DbcsMCH+ZLFntN+u6tbkNQ2nLo2hN48ITnZfxjBVQRb836g\n DighvV0wys77l3JfzfCBM3mGxg7AhIf8oP/tBGBlpwNsTvdlKeqhuTPUDQDtdBaEtWosUzUy+1W\n M4JyCSeLzNWBegCW2wgn7iDBesS1YF3qW3Je6+36gxD/yR1NWhEIZI6l491/E+bFuoCmYK+U2OJ\n 2c3iYQgdPI2KoOozRHsRVbEa4sum4A0vBPCkXquhg3Bb63pnh1Z5ayiQbBv71NuKS30BZnQIFIZ\n LtsgG0DUH+nVLNyiCsqIP9TxvtJhyLR7CBmZbR+3BndfXUhXQ==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.147700-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25740.003", "X-MDID": "1603359789-x-6i91WVdY_2", "X-PPE-DISP": "1603359789;x-6i91WVdY_2", "Subject": "[dpdk-dev] [PATCH v2 10/14] ethdev: remove legacy L2_TUNNEL filter\n\ttype support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of L2 tunnel filter RTE flow API should be used.\n\nPreserve RTE_ETH_FILTER_L2_TUNNEL since it is used in drivers\ninternally in RTE flow API support.\n\nrte_eth_l2_tunnel_conf structure is used in other ethdev API\nfunctions.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nAcked-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n app/test-pmd/cmdline.c | 123 --------------------\n doc/guides/rel_notes/deprecation.rst | 3 +-\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 --\n drivers/net/ixgbe/ixgbe_ethdev.c | 48 --------\n drivers/net/qede/qede_filter.c | 1 -\n 5 files changed, 1 insertion(+), 181 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 61bc840f71..27b7086da8 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -664,13 +664,6 @@ static void cmd_help_long_parsed(void *parsed_result,\n \t\t\t\" Enable/disable E-tag based forwarding\"\n \t\t\t\" on a port\\n\\n\"\n \n-\t\t\t\"E-tag set filter add e-tag-id (value) dst-pool\"\n-\t\t\t\" (pool_id) port (port_id)\\n\"\n-\t\t\t\" Add an E-tag forwarding filter on a port\\n\\n\"\n-\n-\t\t\t\"E-tag set filter del e-tag-id (value) port (port_id)\\n\"\n-\t\t\t\" Delete an E-tag forwarding filter on a port\\n\\n\"\n-\n \t\t\t\"ddp add (port_id) (profile_path[,backup_profile_path])\\n\"\n \t\t\t\" Load a profile package on a port\\n\\n\"\n \n@@ -12199,120 +12192,6 @@ cmdline_parse_inst_t cmd_config_e_tag_forwarding_en_dis = {\n \t},\n };\n \n-/* E-tag filter configuration */\n-static void\n-cmd_config_e_tag_filter_add_parsed(\n-\tvoid *parsed_result,\n-\t__rte_unused struct cmdline *cl,\n-\t__rte_unused void *data)\n-{\n-\tstruct cmd_config_e_tag_result *res = parsed_result;\n-\tstruct rte_eth_l2_tunnel_conf entry;\n-\tint ret = 0;\n-\n-\tif (port_id_is_invalid(res->port_id, ENABLED_WARN))\n-\t\treturn;\n-\n-\tif (res->e_tag_id_val > 0x3fff) {\n-\t\tprintf(\"e-tag-id must be equal or less than 0x3fff.\\n\");\n-\t\treturn;\n-\t}\n-\n-\tret = rte_eth_dev_filter_supported(res->port_id,\n-\t\t\t\t\t RTE_ETH_FILTER_L2_TUNNEL);\n-\tif (ret < 0) {\n-\t\tprintf(\"E-tag filter is not supported on port %u.\\n\",\n-\t\t res->port_id);\n-\t\treturn;\n-\t}\n-\n-\tentry.l2_tunnel_type = RTE_L2_TUNNEL_TYPE_E_TAG;\n-\tentry.tunnel_id = res->e_tag_id_val;\n-\tentry.pool = res->dst_pool_val;\n-\n-\tret = rte_eth_dev_filter_ctrl(res->port_id,\n-\t\t\t\t RTE_ETH_FILTER_L2_TUNNEL,\n-\t\t\t\t RTE_ETH_FILTER_ADD,\n-\t\t\t\t &entry);\n-\tif (ret < 0)\n-\t\tprintf(\"E-tag filter programming error: (%s)\\n\",\n-\t\t strerror(-ret));\n-}\n-\n-cmdline_parse_inst_t cmd_config_e_tag_filter_add = {\n-\t.f = cmd_config_e_tag_filter_add_parsed,\n-\t.data = NULL,\n-\t.help_str = \"E-tag ... : E-tag filter add\",\n-\t.tokens = {\n-\t\t(void *)&cmd_config_e_tag_e_tag,\n-\t\t(void *)&cmd_config_e_tag_set,\n-\t\t(void *)&cmd_config_e_tag_filter,\n-\t\t(void *)&cmd_config_e_tag_add,\n-\t\t(void *)&cmd_config_e_tag_e_tag_id,\n-\t\t(void *)&cmd_config_e_tag_e_tag_id_val,\n-\t\t(void *)&cmd_config_e_tag_dst_pool,\n-\t\t(void *)&cmd_config_e_tag_dst_pool_val,\n-\t\t(void *)&cmd_config_e_tag_port,\n-\t\t(void *)&cmd_config_e_tag_port_id,\n-\t\tNULL,\n-\t},\n-};\n-\n-static void\n-cmd_config_e_tag_filter_del_parsed(\n-\tvoid *parsed_result,\n-\t__rte_unused struct cmdline *cl,\n-\t__rte_unused void *data)\n-{\n-\tstruct cmd_config_e_tag_result *res = parsed_result;\n-\tstruct rte_eth_l2_tunnel_conf entry;\n-\tint ret = 0;\n-\n-\tif (port_id_is_invalid(res->port_id, ENABLED_WARN))\n-\t\treturn;\n-\n-\tif (res->e_tag_id_val > 0x3fff) {\n-\t\tprintf(\"e-tag-id must be less than 0x3fff.\\n\");\n-\t\treturn;\n-\t}\n-\n-\tret = rte_eth_dev_filter_supported(res->port_id,\n-\t\t\t\t\t RTE_ETH_FILTER_L2_TUNNEL);\n-\tif (ret < 0) {\n-\t\tprintf(\"E-tag filter is not supported on port %u.\\n\",\n-\t\t res->port_id);\n-\t\treturn;\n-\t}\n-\n-\tentry.l2_tunnel_type = RTE_L2_TUNNEL_TYPE_E_TAG;\n-\tentry.tunnel_id = res->e_tag_id_val;\n-\n-\tret = rte_eth_dev_filter_ctrl(res->port_id,\n-\t\t\t\t RTE_ETH_FILTER_L2_TUNNEL,\n-\t\t\t\t RTE_ETH_FILTER_DELETE,\n-\t\t\t\t &entry);\n-\tif (ret < 0)\n-\t\tprintf(\"E-tag filter programming error: (%s)\\n\",\n-\t\t strerror(-ret));\n-}\n-\n-cmdline_parse_inst_t cmd_config_e_tag_filter_del = {\n-\t.f = cmd_config_e_tag_filter_del_parsed,\n-\t.data = NULL,\n-\t.help_str = \"E-tag ... : E-tag filter delete\",\n-\t.tokens = {\n-\t\t(void *)&cmd_config_e_tag_e_tag,\n-\t\t(void *)&cmd_config_e_tag_set,\n-\t\t(void *)&cmd_config_e_tag_filter,\n-\t\t(void *)&cmd_config_e_tag_del,\n-\t\t(void *)&cmd_config_e_tag_e_tag_id,\n-\t\t(void *)&cmd_config_e_tag_e_tag_id_val,\n-\t\t(void *)&cmd_config_e_tag_port,\n-\t\t(void *)&cmd_config_e_tag_port_id,\n-\t\tNULL,\n-\t},\n-};\n-\n /* vf vlan anti spoof configuration */\n \n /* Common result structure for vf vlan anti spoof */\n@@ -18621,8 +18500,6 @@ cmdline_parse_ctx_t main_ctx[] = {\n \t(cmdline_parse_inst_t *)&cmd_config_e_tag_insertion_dis,\n \t(cmdline_parse_inst_t *)&cmd_config_e_tag_stripping_en_dis,\n \t(cmdline_parse_inst_t *)&cmd_config_e_tag_forwarding_en_dis,\n-\t(cmdline_parse_inst_t *)&cmd_config_e_tag_filter_add,\n-\t(cmdline_parse_inst_t *)&cmd_config_e_tag_filter_del,\n \t(cmdline_parse_inst_t *)&cmd_set_vf_vlan_anti_spoof,\n \t(cmdline_parse_inst_t *)&cmd_set_vf_mac_anti_spoof,\n \t(cmdline_parse_inst_t *)&cmd_set_vf_vlan_stripq,\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 48b5bfd3cb..af46728da1 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -97,8 +97,7 @@ Deprecation Notices\n \n * ethdev: the legacy filter API, including\n ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well\n- as filter types FDIR\n- and L2_TUNNEL, is superseded by the generic flow API (rte_flow) in\n+ as filter types FDIR, is superseded by the generic flow API (rte_flow) in\n PMDs that implement the latter.\n The legacy API will be removed in DPDK 20.11.\n \ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex 25d048a011..1440b0f692 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -1714,13 +1714,6 @@ Enable/disable E-tag based forwarding on a port::\n \n testpmd> E-tag set forwarding (on|off) port (port_id)\n \n-Add an E-tag forwarding filter on a port::\n-\n- testpmd> E-tag set filter add e-tag-id (value) dst-pool (pool_id) port (port_id)\n-\n-Delete an E-tag forwarding filter on a port::\n- testpmd> E-tag set filter del e-tag-id (value) port (port_id)\n-\n ddp add\n ~~~~~~~\n \ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 922d415000..255d2bf078 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -355,9 +355,6 @@ static int ixgbe_dev_l2_tunnel_offload_set\n \t struct rte_eth_l2_tunnel_conf *l2_tunnel,\n \t uint32_t mask,\n \t uint8_t en);\n-static int ixgbe_dev_l2_tunnel_filter_handle(struct rte_eth_dev *dev,\n-\t\t\t\t\t enum rte_filter_op filter_op,\n-\t\t\t\t\t void *arg);\n \n static int ixgbe_dev_udp_tunnel_port_add(struct rte_eth_dev *dev,\n \t\t\t\t\t struct rte_eth_udp_tunnel *udp_tunnel);\n@@ -6813,9 +6810,6 @@ ixgbe_dev_filter_ctrl(struct rte_eth_dev *dev,\n \tcase RTE_ETH_FILTER_FDIR:\n \t\tret = ixgbe_fdir_ctrl_func(dev, filter_op, arg);\n \t\tbreak;\n-\tcase RTE_ETH_FILTER_L2_TUNNEL:\n-\t\tret = ixgbe_dev_l2_tunnel_filter_handle(dev, filter_op, arg);\n-\t\tbreak;\n \tcase RTE_ETH_FILTER_GENERIC:\n \t\tif (filter_op != RTE_ETH_FILTER_GET)\n \t\t\treturn -EINVAL;\n@@ -7887,48 +7881,6 @@ ixgbe_dev_l2_tunnel_filter_del(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n-/**\n- * ixgbe_dev_l2_tunnel_filter_handle - Handle operations for l2 tunnel filter.\n- * @dev: pointer to rte_eth_dev structure\n- * @filter_op:operation will be taken.\n- * @arg: a pointer to specific structure corresponding to the filter_op\n- */\n-static int\n-ixgbe_dev_l2_tunnel_filter_handle(struct rte_eth_dev *dev,\n-\t\t\t\t enum rte_filter_op filter_op,\n-\t\t\t\t void *arg)\n-{\n-\tint ret;\n-\n-\tif (filter_op == RTE_ETH_FILTER_NOP)\n-\t\treturn 0;\n-\n-\tif (arg == NULL) {\n-\t\tPMD_DRV_LOG(ERR, \"arg shouldn't be NULL for operation %u.\",\n-\t\t\t filter_op);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tswitch (filter_op) {\n-\tcase RTE_ETH_FILTER_ADD:\n-\t\tret = ixgbe_dev_l2_tunnel_filter_add\n-\t\t\t(dev,\n-\t\t\t (struct rte_eth_l2_tunnel_conf *)arg,\n-\t\t\t FALSE);\n-\t\tbreak;\n-\tcase RTE_ETH_FILTER_DELETE:\n-\t\tret = ixgbe_dev_l2_tunnel_filter_del\n-\t\t\t(dev,\n-\t\t\t (struct rte_eth_l2_tunnel_conf *)arg);\n-\t\tbreak;\n-\tdefault:\n-\t\tPMD_DRV_LOG(ERR, \"unsupported operation %u.\", filter_op);\n-\t\tret = -EINVAL;\n-\t\tbreak;\n-\t}\n-\treturn ret;\n-}\n-\n static int\n ixgbe_e_tag_forwarding_en_dis(struct rte_eth_dev *dev, bool en)\n {\ndiff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c\nindex 283e7322cb..a9870338aa 100644\n--- a/drivers/net/qede/qede_filter.c\n+++ b/drivers/net/qede/qede_filter.c\n@@ -1241,7 +1241,6 @@ int qede_dev_filter_ctrl(struct rte_eth_dev *eth_dev,\n \n \t\t*(const void **)arg = &qede_flow_ops;\n \t\treturn 0;\n-\tcase RTE_ETH_FILTER_L2_TUNNEL:\n \tcase RTE_ETH_FILTER_MAX:\n \tdefault:\n \t\tDP_ERR(edev, \"Unsupported filter type %d\\n\",\n", "prefixes": [ "v2", "10/14" ] }