Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81601/?format=api
{ "id": 81601, "url": "http://patches.dpdk.org/api/patches/81601/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201020152052.389446-3-amorenoz@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201020152052.389446-3-amorenoz@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201020152052.389446-3-amorenoz@redhat.com", "date": "2020-10-20T15:20:51", "name": "[v2,2/3] virtio_user: don't set/get_status until FEATURES_OK", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "365a0bda896f2a8925670e3fd944745cc1d0308b", "submitter": { "id": 1397, "url": "http://patches.dpdk.org/api/people/1397/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201020152052.389446-3-amorenoz@redhat.com/mbox/", "series": [ { "id": 13150, "url": "http://patches.dpdk.org/api/series/13150/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13150", "date": "2020-10-20T15:20:49", "name": "virtio-user: fix virtio-user server mode", "version": 2, "mbox": "http://patches.dpdk.org/series/13150/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81601/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81601/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 13ACAA04DC;\n\tTue, 20 Oct 2020 17:21:53 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E2CB7BCF9;\n\tTue, 20 Oct 2020 17:21:12 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by dpdk.org (Postfix) with ESMTP id 7A6B5BCF1\n for <dev@dpdk.org>; Tue, 20 Oct 2020 17:21:10 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-69-1esTdA2lNmizRNSFfqkKdA-1; Tue, 20 Oct 2020 11:21:05 -0400", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BBF3B18BE163;\n Tue, 20 Oct 2020 15:21:03 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (ovpn-112-202.ams2.redhat.com\n [10.36.112.202])\n by smtp.corp.redhat.com (Postfix) with ESMTP id EAE6B55763;\n Tue, 20 Oct 2020 15:21:01 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1603207268;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ixGc/T2lTLUgB9FGSpAtW3F+2uLWJHEaX8805BcvInY=;\n b=UUoLgpJnXlnpNOK4xBavSgr18cC7eHrtEVk9gH0cDy6v7IT+8dCdQj2NVFrbCdlqfPQiAQ\n nywAya2Z8oSKnklRyPotllUNtn18pNB3Rc5TWmmex4HsfHF2I+JK8qMBy6yaTTeK1+XfRG\n wLFy3ZgtMxNPk8I1ObtmN5MFBGuYKWI=", "X-MC-Unique": "1esTdA2lNmizRNSFfqkKdA-1", "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@dpdk.org", "Cc": "yinan.wang@intel.com, patrick.fu@intel.com, amorenoz@redhat.com,\n maxime.coquelin@redhat.com, stable@dpdk.org,\n Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "Date": "Tue, 20 Oct 2020 17:20:51 +0200", "Message-Id": "<20201020152052.389446-3-amorenoz@redhat.com>", "In-Reply-To": "<20201020152052.389446-1-amorenoz@redhat.com>", "References": "<20201020152052.389446-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v2 2/3] virtio_user: don't set/get_status until\n\tFEATURES_OK", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "According to the virtio spec, ACK and DRIVER status bits should be set\nbefore feature negotiation.\n\nHowever, until the protocol features are negotiated, the driver does not\nknow if the device actually supports the those vhost-user messages.\nTherefore, until FEATURES_OK is set, the GET/SET_STATUS messages should\nnot be sent.\n\nFixes: 57912824615f (\"net/virtio-user: support vhost status setting\")\nCc: maxime.coquelin@redhat.com\nCc: stable@dpdk.org\n\nSigned-off-by: Adrian Moreno <amorenoz@redhat.com>\n---\n drivers/net/virtio/virtio_user/vhost_user.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex ef290c357..450d77e92 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -278,8 +278,9 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \n \tswitch (req) {\n \tcase VHOST_USER_GET_STATUS:\n-\t\tif (!(dev->protocol_features &\n-\t\t\t\t(1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n+\t\tif (!(dev->status & VIRTIO_CONFIG_STATUS_FEATURES_OK) ||\n+\t\t (!(dev->protocol_features &\n+\t\t\t\t(1ULL << VHOST_USER_PROTOCOL_F_STATUS))))\n \t\t\treturn 0;\n \t\t/* Fallthrough */\n \tcase VHOST_USER_GET_FEATURES:\n@@ -288,8 +289,9 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \t\tbreak;\n \n \tcase VHOST_USER_SET_STATUS:\n-\t\tif (!(dev->protocol_features &\n-\t\t\t\t(1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n+\t\tif (!(dev->status & VIRTIO_CONFIG_STATUS_FEATURES_OK) ||\n+\t\t (!(dev->protocol_features &\n+\t\t\t\t(1ULL << VHOST_USER_PROTOCOL_F_STATUS))))\n \t\t\treturn 0;\n \n \t\tif (has_reply_ack)\n", "prefixes": [ "v2", "2/3" ] }