Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81515/?format=api
{ "id": 81515, "url": "http://patches.dpdk.org/api/patches/81515/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603185222-14831-8-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603185222-14831-8-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603185222-14831-8-git-send-email-arybchenko@solarflare.com", "date": "2020-10-20T09:12:47", "name": "[v2,07/62] net/sfc: add the concept of MAE (transfer) rules", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "656c963a516fb260cd54604521e7d39fb099224c", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603185222-14831-8-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13137, "url": "http://patches.dpdk.org/api/series/13137/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13137", "date": "2020-10-20T09:12:44", "name": "net/sfc: support flow API transfer rules", "version": 2, "mbox": "http://patches.dpdk.org/series/13137/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81515/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81515/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 99436A04DD;\n\tTue, 20 Oct 2020 11:21:06 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EB117C844;\n\tTue, 20 Oct 2020 11:14:23 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 16373C778\n for <dev@dpdk.org>; Tue, 20 Oct 2020 11:14:07 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.60])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 9CB4C60050 for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:05 +0000 (UTC)", "from us4-mdac16-63.ut7.mdlocal (unknown [10.7.66.62])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 9BD4F2009A\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:05 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.66.41])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 1FB971C0051\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:05 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n C77DF4C0060\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:04 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 20 Oct 2020 10:13:59 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 20 Oct 2020 10:13:59 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09K9DxLq028336;\n Tue, 20 Oct 2020 10:13:59 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 336EF1613AB;\n Tue, 20 Oct 2020 10:13:59 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Tue, 20 Oct 2020 10:12:47 +0100", "Message-ID": "<1603185222-14831-8-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603185222-14831-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>\n <1603185222-14831-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-TM-AS-Result": "No-0.590700-8.000000-10", "X-TMASE-MatchedRID": "9+vAdSePT9pcN4Yc45F7ZR5dqSUtZTxbvvkzqYJBDFaRoQLwUmtov4TZ\n RPOp2cAoFfpc/lC98DwWsp6eJb7A26H2g9syPs88nFVnNmvv47tLXPA26IG0hN9RlPzeVuQQJPU\n KiLeLtT/lbE1XrIJXPbQHaFNPaJ+oRRCzDlgXi1gaPMGCcVm9DoLsLasl5ROh9gQ08tNoyG8VLG\n IPVP4OQVSMP30ASix4Gh0ehw7l3kJdwbDa/5b0bWLiVenyedyja01mhnn7t6Tm5xVqTV9QwQQJG\n m5M0WiV4vM1YF6AJbbCCfuIMF6xLSdET58jp62SfdYTdp1V+i9UivibKL7SI2//TI5vKwiIrx33\n PIFfjPlodGG5NBGWSEOrH4K/J8rNoyb+4oySoDv2ev7TpEjkITwyQw+LBwEfvU24pLfQFmdAgUh\n ku2yAbQNQf6dUs3KIKyog/1PG+0kxvqnnvSKWdw==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--0.590700-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-MDID": "1603185245-KiBlVxpUSVRN", "X-PPE-DISP": "1603185245;KiBlVxpUSVRN", "Subject": "[dpdk-dev] [PATCH v2 07/62] net/sfc: add the concept of MAE\n\t(transfer) rules", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nDefine the corresponding specification structure and\nmake the code identify MAE rules by testing transfer\nattribute presence. Also, add a priority level check.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n doc/guides/nics/sfc_efx.rst | 5 +++--\n drivers/net/sfc/sfc_flow.c | 26 ++++++++++++++++++++------\n drivers/net/sfc/sfc_flow.h | 9 +++++++++\n drivers/net/sfc/sfc_mae.c | 11 +++++++++++\n drivers/net/sfc/sfc_mae.h | 2 ++\n 5 files changed, 45 insertions(+), 8 deletions(-)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 959b52c1c3..7a5aff79f9 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -144,8 +144,9 @@ Flow API support\n Supported attributes:\n \n - Ingress\n+- Transfer\n \n-Supported pattern items:\n+Supported pattern items (***non-transfer*** rules):\n \n - VOID\n \n@@ -173,7 +174,7 @@ Supported pattern items:\n \n - NVGRE (exact match of virtual subnet ID)\n \n-Supported actions:\n+Supported actions (***non-transfer*** rules):\n \n - VOID\n \ndiff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex cb802d7991..86082208d0 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -1124,12 +1124,15 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n * Protocol-independent flow API support\n */\n static int\n-sfc_flow_parse_attr(const struct rte_flow_attr *attr,\n+sfc_flow_parse_attr(struct sfc_adapter *sa,\n+\t\t const struct rte_flow_attr *attr,\n \t\t struct rte_flow *flow,\n \t\t struct rte_flow_error *error)\n {\n \tstruct sfc_flow_spec *spec = &flow->spec;\n \tstruct sfc_flow_spec_filter *spec_filter = &spec->filter;\n+\tstruct sfc_flow_spec_mae *spec_mae = &spec->mae;\n+\tstruct sfc_mae *mae = &sa->mae;\n \n \tif (attr == NULL) {\n \t\trte_flow_error_set(error, EINVAL,\n@@ -1167,10 +1170,20 @@ sfc_flow_parse_attr(const struct rte_flow_attr *attr,\n \t\tspec_filter->template.efs_rss_context = EFX_RSS_CONTEXT_DEFAULT;\n \t\tspec_filter->template.efs_priority = EFX_FILTER_PRI_MANUAL;\n \t} else {\n-\t\trte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER, attr,\n-\t\t\t\t \"Transfer is not supported\");\n-\t\treturn -rte_errno;\n+\t\tif (mae->status != SFC_MAE_STATUS_SUPPORTED) {\n+\t\t\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,\n+\t\t\t\t\t attr, \"Transfer is not supported\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t\tif (attr->priority > mae->nb_action_rule_prios_max) {\n+\t\t\trte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n+\t\t\t\t\t attr, \"Unsupported priority level\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t\tspec->type = SFC_FLOW_SPEC_MAE;\n+\t\tspec_mae->priority = attr->priority;\n \t}\n \n \treturn 0;\n@@ -2403,10 +2416,11 @@ sfc_flow_parse(struct rte_eth_dev *dev,\n \t struct rte_flow *flow,\n \t struct rte_flow_error *error)\n {\n+\tstruct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);\n \tconst struct sfc_flow_ops_by_spec *ops;\n \tint rc;\n \n-\trc = sfc_flow_parse_attr(attr, flow, error);\n+\trc = sfc_flow_parse_attr(sa, attr, flow, error);\n \tif (rc != 0)\n \t\treturn rc;\n \ndiff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h\nindex 433c7a31e9..1fbcb878d1 100644\n--- a/drivers/net/sfc/sfc_flow.h\n+++ b/drivers/net/sfc/sfc_flow.h\n@@ -38,6 +38,7 @@ struct sfc_flow_rss {\n /* Flow engines supported by the implementation */\n enum sfc_flow_spec_type {\n \tSFC_FLOW_SPEC_FILTER = 0,\n+\tSFC_FLOW_SPEC_MAE,\n \n \tSFC_FLOW_SPEC_NTYPES\n };\n@@ -58,6 +59,12 @@ struct sfc_flow_spec_filter {\n \tstruct sfc_flow_rss rss_conf;\n };\n \n+/* MAE-specific flow specification */\n+struct sfc_flow_spec_mae {\n+\t/* Desired priority level */\n+\tunsigned int\t\t\tpriority;\n+};\n+\n /* Flow specification */\n struct sfc_flow_spec {\n \t/* Flow specification type (engine-based) */\n@@ -67,6 +74,8 @@ struct sfc_flow_spec {\n \tunion {\n \t\t/* Filter-based (VNIC level flows) specification */\n \t\tstruct sfc_flow_spec_filter filter;\n+\t\t/* MAE-based (lower-level HW switch flows) specification */\n+\t\tstruct sfc_flow_spec_mae mae;\n \t};\n };\n \ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 2a7ed6377a..487bd61f76 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -21,6 +21,7 @@ sfc_mae_attach(struct sfc_adapter *sa)\n {\n \tconst efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);\n \tstruct sfc_mae *mae = &sa->mae;\n+\tefx_mae_limits_t limits;\n \tint rc;\n \n \tsfc_log_init(sa, \"entry\");\n@@ -35,12 +36,21 @@ sfc_mae_attach(struct sfc_adapter *sa)\n \tif (rc != 0)\n \t\tgoto fail_mae_init;\n \n+\tsfc_log_init(sa, \"get MAE limits\");\n+\trc = efx_mae_get_limits(sa->nic, &limits);\n+\tif (rc != 0)\n+\t\tgoto fail_mae_get_limits;\n+\n \tmae->status = SFC_MAE_STATUS_SUPPORTED;\n+\tmae->nb_action_rule_prios_max = limits.eml_max_n_action_prios;\n \n \tsfc_log_init(sa, \"done\");\n \n \treturn 0;\n \n+fail_mae_get_limits:\n+\tefx_mae_fini(sa->nic);\n+\n fail_mae_init:\n \tsfc_log_init(sa, \"failed %d\", rc);\n \n@@ -55,6 +65,7 @@ sfc_mae_detach(struct sfc_adapter *sa)\n \n \tsfc_log_init(sa, \"entry\");\n \n+\tmae->nb_action_rule_prios_max = 0;\n \tmae->status = SFC_MAE_STATUS_UNKNOWN;\n \n \tif (status_prev != SFC_MAE_STATUS_SUPPORTED)\ndiff --git a/drivers/net/sfc/sfc_mae.h b/drivers/net/sfc/sfc_mae.h\nindex d7821e71cc..dd9ca07d15 100644\n--- a/drivers/net/sfc/sfc_mae.h\n+++ b/drivers/net/sfc/sfc_mae.h\n@@ -28,6 +28,8 @@ enum sfc_mae_status {\n struct sfc_mae {\n \t/** NIC support for MAE status */\n \tenum sfc_mae_status\t\tstatus;\n+\t/** Priority level limit for MAE action rules */\n+\tunsigned int\t\t\tnb_action_rule_prios_max;\n };\n \n struct sfc_adapter;\n", "prefixes": [ "v2", "07/62" ] }