Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81455/?format=api
{ "id": 81455, "url": "http://patches.dpdk.org/api/patches/81455/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603183709-23420-24-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603183709-23420-24-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603183709-23420-24-git-send-email-arybchenko@solarflare.com", "date": "2020-10-20T08:47:50", "name": "[23/62] common/sfc_efx/base: add MAE action rule provisioning APIs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "212d567ad925d2b2ffeaa72d83aa845298af157c", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603183709-23420-24-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13132, "url": "http://patches.dpdk.org/api/series/13132/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13132", "date": "2020-10-20T08:47:30", "name": "net/sfc: support flow API transfer rules", "version": 1, "mbox": "http://patches.dpdk.org/series/13132/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81455/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/81455/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 00C9DA04DD;\n\tTue, 20 Oct 2020 10:53:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 46458BC4A;\n\tTue, 20 Oct 2020 10:49:23 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id B72EFAD3B\n for <dev@dpdk.org>; Tue, 20 Oct 2020 10:49:00 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.60])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 891D46007D for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:00 +0000 (UTC)", "from us4-mdac16-62.ut7.mdlocal (unknown [10.7.66.61])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 886982009A\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:00 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.66.33])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 14EDE1C0052\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:49:00 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n BF149A80061\n for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:59 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 20 Oct 2020 09:48:50 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 20 Oct 2020 09:48:50 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09K8mn1Q030804;\n Tue, 20 Oct 2020 09:48:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id E9E25161A2F;\n Tue, 20 Oct 2020 09:48:48 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<y@solarflare.com>", "CC": "<dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Tue, 20 Oct 2020 09:47:50 +0100", "Message-ID": "<1603183709-23420-24-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-TM-AS-Result": "No-0.765400-8.000000-10", "X-TMASE-MatchedRID": "qR7nF2Wf8maEQeXrAUW/pxIRh9wkXSlFE02Pr4CkNSNwkdIrVt8X1VDT\n Kayi2ZF6pVG0HeSt+ryWGRCs++FM0t1RkEnBFAu+nFVnNmvv47vr3E41VlKsfazG9MIKeG/GOvC\n 9T24J5iZONuFTUFBeosbWIXMKWGPD0rn1NhBG2mEJaVZHbbd1rlQhqd4OP4Y7R2YNIFh+clHT/p\n FzauZLmV963OSi68sDFYtQn4h9SJQE7MuQrZP2o8ewkPVzkoGNqb3/o5s+OcO1E+HbdRuHYHd7b\n ci/LVuNdR9IuTvvB94PtqKIlA3hYsP8NSaeQRaaF9p7X9UAWGXcVi8qZmJWcxyFieO3WgdPThZS\n O8+zLqri8zVgXoAltsIJ+4gwXrEtWBd6ltyXuvujVG9LmisBxiFPLfnXbHE3XVNNLRBUfo1NlL6\n BDHKPHE1HNRS7aAPNxQ+L0GDp1PKSsD7S3Gb632eM/fhCMOLfrJ/dTZLPtW69Tbikt9AWZ0CBSG\n S7bIBtA1B/p1SzcogrKiD/U8b7SaNbPJBuvLaLftwZ3X11IV0=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-0.765400-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-MDID": "1603183740-sFvHcfi11y70", "X-PPE-DISP": "1603183740;sFvHcfi11y70", "Subject": "[dpdk-dev] [PATCH 23/62] common/sfc_efx/base: add MAE action rule\n\tprovisioning APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nAdd APIs for action rule insert / remove operations.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx.h | 29 ++++\n drivers/common/sfc_efx/base/efx_mae.c | 150 ++++++++++++++++++\n .../sfc_efx/rte_common_sfc_efx_version.map | 2 +\n 3 files changed, 181 insertions(+)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex 3053da75f8..d37850eda6 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -4193,6 +4193,11 @@ efx_mae_match_specs_class_cmp(\n \n #define\tEFX_MAE_RSRC_ID_INVALID\tUINT32_MAX\n \n+/* Rule ID */\n+typedef struct efx_mae_rule_id_s {\n+\tuint32_t id;\n+} efx_mae_rule_id_t;\n+\n /* Action set ID */\n typedef struct efx_mae_aset_id_s {\n \tuint32_t id;\n@@ -4211,6 +4216,30 @@ efx_mae_action_set_free(\n \t__in\t\t\t\tefx_nic_t *enp,\n \t__in\t\t\t\tconst efx_mae_aset_id_t *aset_idp);\n \n+/* Action set list ID */\n+typedef struct efx_mae_aset_list_id_s {\n+\tuint32_t id;\n+} efx_mae_aset_list_id_t;\n+\n+/*\n+ * Either action set list ID or action set ID must be passed to this API,\n+ * but not both.\n+ */\n+LIBEFX_API\n+extern\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_action_rule_insert(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tconst efx_mae_match_spec_t *spec,\n+\t__in\t\t\t\tconst efx_mae_aset_list_id_t *asl_idp,\n+\t__in\t\t\t\tconst efx_mae_aset_id_t *as_idp,\n+\t__out\t\t\t\tefx_mae_rule_id_t *ar_idp);\n+\n+LIBEFX_API\n+extern\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_action_rule_remove(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tconst efx_mae_rule_id_t *ar_idp);\n+\n #endif /* EFSYS_OPT_MAE */\n \n #ifdef\t__cplusplus\ndiff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c\nindex 2626710216..1715cdc4fb 100644\n--- a/drivers/common/sfc_efx/base/efx_mae.c\n+++ b/drivers/common/sfc_efx/base/efx_mae.c\n@@ -1005,6 +1005,156 @@ efx_mae_action_set_free(\n \n \treturn (0);\n \n+fail3:\n+\tEFSYS_PROBE(fail3);\n+fail2:\n+\tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\treturn (rc);\n+}\n+\n+\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_action_rule_insert(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tconst efx_mae_match_spec_t *spec,\n+\t__in\t\t\t\tconst efx_mae_aset_list_id_t *asl_idp,\n+\t__in\t\t\t\tconst efx_mae_aset_id_t *as_idp,\n+\t__out\t\t\t\tefx_mae_rule_id_t *ar_idp)\n+{\n+\tconst efx_nic_cfg_t *encp = efx_nic_cfg_get(enp);\n+\tefx_mcdi_req_t req;\n+\tEFX_MCDI_DECLARE_BUF(payload,\n+\t MC_CMD_MAE_ACTION_RULE_INSERT_IN_LENMAX_MCDI2,\n+\t MC_CMD_MAE_ACTION_RULE_INSERT_OUT_LEN);\n+\tefx_oword_t *rule_response;\n+\tefx_mae_rule_id_t ar_id;\n+\tsize_t offset;\n+\tefx_rc_t rc;\n+\n+\tEFX_STATIC_ASSERT(sizeof (ar_idp->id) ==\n+\t MC_CMD_MAE_ACTION_RULE_INSERT_OUT_AR_ID_LEN);\n+\n+\tEFX_STATIC_ASSERT(EFX_MAE_RSRC_ID_INVALID ==\n+\t MC_CMD_MAE_ACTION_RULE_INSERT_OUT_ACTION_RULE_ID_NULL);\n+\n+\tif (encp->enc_mae_supported == B_FALSE) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail1;\n+\t}\n+\n+\tif (spec->emms_type != EFX_MAE_RULE_ACTION ||\n+\t (asl_idp != NULL && as_idp != NULL) ||\n+\t (asl_idp == NULL && as_idp == NULL)) {\n+\t\trc = EINVAL;\n+\t\tgoto fail2;\n+\t}\n+\n+\treq.emr_cmd = MC_CMD_MAE_ACTION_RULE_INSERT;\n+\treq.emr_in_buf = payload;\n+\treq.emr_in_length = MC_CMD_MAE_ACTION_RULE_INSERT_IN_LENMAX_MCDI2;\n+\treq.emr_out_buf = payload;\n+\treq.emr_out_length = MC_CMD_MAE_ACTION_RULE_INSERT_OUT_LEN;\n+\n+\tEFX_STATIC_ASSERT(sizeof (*rule_response) <=\n+\t MC_CMD_MAE_ACTION_RULE_INSERT_IN_RESPONSE_LEN);\n+\toffset = MC_CMD_MAE_ACTION_RULE_INSERT_IN_RESPONSE_OFST;\n+\trule_response = (efx_oword_t *)(payload + offset);\n+\tEFX_POPULATE_OWORD_3(*rule_response,\n+\t MAE_ACTION_RULE_RESPONSE_ASL_ID,\n+\t (asl_idp != NULL) ? asl_idp->id : EFX_MAE_RSRC_ID_INVALID,\n+\t MAE_ACTION_RULE_RESPONSE_AS_ID,\n+\t (as_idp != NULL) ? as_idp->id : EFX_MAE_RSRC_ID_INVALID,\n+\t MAE_ACTION_RULE_RESPONSE_COUNTER_ID, EFX_MAE_RSRC_ID_INVALID);\n+\n+\tMCDI_IN_SET_DWORD(req, MAE_ACTION_RULE_INSERT_IN_PRIO, spec->emms_prio);\n+\n+\t/*\n+\t * Mask-value pairs have been stored in the byte order needed for the\n+\t * MCDI request and are thus safe to be copied directly to the buffer.\n+\t */\n+\tEFX_STATIC_ASSERT(sizeof (spec->emms_mask_value_pairs.action) >=\n+\t MAE_FIELD_MASK_VALUE_PAIRS_LEN);\n+\toffset = MC_CMD_MAE_ACTION_RULE_INSERT_IN_MATCH_CRITERIA_OFST;\n+\tmemcpy(payload + offset, spec->emms_mask_value_pairs.action,\n+\t MAE_FIELD_MASK_VALUE_PAIRS_LEN);\n+\n+\tefx_mcdi_execute(enp, &req);\n+\n+\tif (req.emr_rc != 0) {\n+\t\trc = req.emr_rc;\n+\t\tgoto fail3;\n+\t}\n+\n+\tif (req.emr_out_length_used < MC_CMD_MAE_ACTION_RULE_INSERT_OUT_LEN) {\n+\t\trc = EMSGSIZE;\n+\t\tgoto fail4;\n+\t}\n+\n+\tar_id.id = MCDI_OUT_DWORD(req, MAE_ACTION_RULE_INSERT_OUT_AR_ID);\n+\tif (ar_id.id == EFX_MAE_RSRC_ID_INVALID) {\n+\t\trc = ENOENT;\n+\t\tgoto fail5;\n+\t}\n+\n+\tar_idp->id = ar_id.id;\n+\n+\treturn (0);\n+\n+fail5:\n+\tEFSYS_PROBE(fail5);\n+fail4:\n+\tEFSYS_PROBE(fail4);\n+fail3:\n+\tEFSYS_PROBE(fail3);\n+fail2:\n+\tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\treturn (rc);\n+}\n+\n+\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_action_rule_remove(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tconst efx_mae_rule_id_t *ar_idp)\n+{\n+\tconst efx_nic_cfg_t *encp = efx_nic_cfg_get(enp);\n+\tefx_mcdi_req_t req;\n+\tEFX_MCDI_DECLARE_BUF(payload,\n+\t MC_CMD_MAE_ACTION_RULE_DELETE_IN_LEN(1),\n+\t MC_CMD_MAE_ACTION_RULE_DELETE_OUT_LEN(1));\n+\tefx_rc_t rc;\n+\n+\tif (encp->enc_mae_supported == B_FALSE) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail1;\n+\t}\n+\n+\treq.emr_cmd = MC_CMD_MAE_ACTION_RULE_DELETE;\n+\treq.emr_in_buf = payload;\n+\treq.emr_in_length = MC_CMD_MAE_ACTION_RULE_DELETE_IN_LEN(1);\n+\treq.emr_out_buf = payload;\n+\treq.emr_out_length = MC_CMD_MAE_ACTION_RULE_DELETE_OUT_LEN(1);\n+\n+\tMCDI_IN_SET_DWORD(req, MAE_ACTION_RULE_DELETE_IN_AR_ID, ar_idp->id);\n+\n+\tefx_mcdi_execute(enp, &req);\n+\n+\tif (req.emr_rc != 0) {\n+\t\trc = req.emr_rc;\n+\t\tgoto fail2;\n+\t}\n+\n+\tif (MCDI_OUT_DWORD(req, MAE_ACTION_RULE_DELETE_OUT_DELETED_AR_ID) !=\n+\t ar_idp->id) {\n+\t\t/* Firmware failed to delete the action rule. */\n+\t\trc = EAGAIN;\n+\t\tgoto fail3;\n+\t}\n+\n+\treturn (0);\n+\n fail3:\n \tEFSYS_PROBE(fail3);\n fail2:\ndiff --git a/drivers/common/sfc_efx/rte_common_sfc_efx_version.map b/drivers/common/sfc_efx/rte_common_sfc_efx_version.map\nindex 643b3bab52..0e0d058c8f 100644\n--- a/drivers/common/sfc_efx/rte_common_sfc_efx_version.map\n+++ b/drivers/common/sfc_efx/rte_common_sfc_efx_version.map\n@@ -85,6 +85,8 @@ INTERNAL {\n \tefx_mac_stats_upload;\n \tefx_mac_up;\n \n+\tefx_mae_action_rule_insert;\n+\tefx_mae_action_rule_remove;\n \tefx_mae_action_set_alloc;\n \tefx_mae_action_set_free;\n \tefx_mae_action_set_populate_deliver;\n", "prefixes": [ "23/62" ] }