Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81180/?format=api
{ "id": 81180, "url": "http://patches.dpdk.org/api/patches/81180/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201017030701.16134-17-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201017030701.16134-17-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201017030701.16134-17-l.wojciechow@partner.samsung.com", "date": "2020-10-17T03:07:00", "name": "[v8,16/17] test/distributor: ensure all packets are delivered", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5eaf90f537dd4a6bad3e65e874c2eaff209a1bf9", "submitter": { "id": 1628, "url": "http://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201017030701.16134-17-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 13072, "url": "http://patches.dpdk.org/api/series/13072/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13072", "date": "2020-10-17T03:06:44", "name": "fix distributor synchronization issues", "version": 8, "mbox": "http://patches.dpdk.org/series/13072/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81180/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4566AA04DB;\n\tSat, 17 Oct 2020 05:13:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 987ABE36E;\n\tSat, 17 Oct 2020 05:08:22 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 29359E2C1\n for <dev@dpdk.org>; Sat, 17 Oct 2020 05:07:50 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20201017030729euoutp028113cadda7fee51dbcdcae752be7e81a~_qL2Km0Fm2304823048euoutp02h\n for <dev@dpdk.org>; Sat, 17 Oct 2020 03:07:29 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20201017030723eucas1p255a22a301b598139f6925f7dc2c71fcf~_qLxHkpcE2440824408eucas1p2y;\n Sat, 17 Oct 2020 03:07:23 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges3new.samsung.com (EUCPMTA) with SMTP id 49.D5.06318.BEF5A8F5; Sat, 17\n Oct 2020 04:07:23 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20201017030722eucas1p107dc8d3eb2d9ef620065deba31cf08ed~_qLvvqz_W2252822528eucas1p14;\n Sat, 17 Oct 2020 03:07:22 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20201017030722eusmtrp1dc64595bd7823bb07a0900ecec7a5559~_qLvvMamN3018830188eusmtrp1a;\n Sat, 17 Oct 2020 03:07:22 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 4F.DE.06017.AEF5A8F5; Sat, 17\n Oct 2020 04:07:22 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20201017030721eusmtip12450277e2202383d3ef9f3dbd74e8850~_qLvQPR9j0424404244eusmtip1S;\n Sat, 17 Oct 2020 03:07:21 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20201017030729euoutp028113cadda7fee51dbcdcae752be7e81a~_qL2Km0Fm2304823048euoutp02h", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1602904049;\n bh=Scuc5Yl7mnmC3/9oBm1I4cjSrTqf6Y6Dqa10WtinLUk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=L2BgyoswA/zlN8qMP3hk8Eza/+TYHdnAbyMYCfJlM7UgbMLaCM5nR+ZjT7zDFqJrl\n 0Ulz8W2/wykQAy8VMbiE1usB/dmAUrSNJ/0D3FvvWPJmAhL8zoD+usCe70asA0gt0V\n C8Qkg12BO+w136wEq66JLidAy3i3tsBVySrEFR7s=", "X-AuditID": "cbfec7f5-371ff700000018ae-9f-5f8a5febeac5", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "David Hunt <david.hunt@intel.com>", "Cc": "dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org", "Date": "Sat, 17 Oct 2020 05:07:00 +0200", "Message-Id": "<20201017030701.16134-17-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201017030701.16134-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWy7djP87qv47viDV50WFr0TfrIZPHu03Ym\n i2c96xgt/nX8YXdg8fi1YCmrx+I9L5k8Dr7bwxTAHMVlk5Kak1mWWqRvl8CVse/dTaaCI4oV\n pz4eZm1gnCLdxcjBISFgInHhE2MXIxeHkMAKRomrdzvYuhg5gZwvjBKvb2dAJD4zSvz48wAs\n AdKwad5/JojEckaJqV9OsMBVbVzbzw5SxSZgK3Fk5ldWEFtEQFXi3/5PTCDrmAWcJZ58BRsk\n LOAjsbV9BjOIzQJU0vm6B6yVV8BNonflPlaIZfISqzccYAZp5QSKNx53BVklIXCGTWLSuY8s\n EDUuEhfXfIKqF5Z4dXwLO4QtI3F6cg8LRMM2oNd+/2SEcPYzSlzvXQFVZS1x+N9vNojjNCXW\n 79KHCDtKfDnYxg4JIj6JG28FQcLMQOakbdOZIcK8Eh1tQhDVehJPe6Yywqz9s/YJC0SJh8SF\n 7gJI6FxllDg6aRLjBEb5WQi7FjAyrmIUTy0tzk1PLTbOSy3XK07MLS7NS9dLzs/dxAiM99P/\n jn/dwbjvT9IhRgEORiUeXo6lnfFCrIllxZW5hxglOJiVRHidzp6OE+JNSaysSi3Kjy8qzUkt\n PsQozcGiJM5rvOhlrJBAemJJanZqakFqEUyWiYNTqoFx66U/M1gjD5d5bdBYM1mr9eyKO6F/\n 7M+vlr5nITq9eMrLBVUb2VoUGL8oFP4OnvbjlpPPu2qZjXcZXlzbvr7B99vRjI27U45ph5e2\n 1s1n+Pv30gZTaz1VZY66DW+jjq7iOibSqhn2Mez/9KLi8KWflb7WfpW8yV+gkpRi6CZ3j5nb\n pfxdjWifEktxRqKhFnNRcSIAgzlJovMCAAA=", "\n H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t/xu7qv4rviDXZ3ylj0TfrIZPHu03Ym\n i2c96xgt/nX8YXdg8fi1YCmrx+I9L5k8Dr7bwxTAHKVnU5RfWpKqkJFfXGKrFG1oYaRnaGmh\n Z2RiqWdobB5rZWSqpG9nk5Kak1mWWqRvl6CXse/dTaaCI4oVpz4eZm1gnCLdxcjJISFgIrFp\n 3n8mEFtIYCmjxMdjYV2MHEBxGYkPlwQgSoQl/lzrYuti5AIq+cgoMX3TPDaQBJuArcSRmV9Z\n QWwRAVWJf/s/gc1hFnCX2LJ4KjOILSzgI7G1fQaYzQJU0/m6hx3E5hVwk+hduY8VYoG8xOoN\n B5hB9nICxRuPu0LsamSUODtrHcsERr4FjAyrGEVSS4tz03OLjfSKE3OLS/PS9ZLzczcxAgNw\n 27GfW3Ywdr0LPsQowMGoxMO7YVFnvBBrYllxZe4hRgkOZiURXqezp+OEeFMSK6tSi/Lji0pz\n UosPMZoCHTWRWUo0OR8YHXkl8YamhuYWlobmxubGZhZK4rwdAgdjhATSE0tSs1NTC1KLYPqY\n ODilGhg7HrG/dbu2kd3ywjLzTfq35OcIvL5wzdFofppgxzuTk4vW7ggvfvmKMXT/4a9fBIzP\n b05oWm4TxWDJ5X5zqoPCFNlyu1tfD7xR/3xoj47cJBuddmntNWHxBj7chxzc/3lcnWU+OU5I\n 7EqveGl/zbfdn3MV/Wc2O967FpG/L608wGVJc+iyRw+VWIozEg21mIuKEwGAtElwVgIAAA==" ], "X-CMS-MailID": "20201017030722eucas1p107dc8d3eb2d9ef620065deba31cf08ed", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20201017030722eucas1p107dc8d3eb2d9ef620065deba31cf08ed", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20201017030722eucas1p107dc8d3eb2d9ef620065deba31cf08ed", "References": "<20201010160508.19709-1-l.wojciechow@partner.samsung.com>\n <20201017030701.16134-1-l.wojciechow@partner.samsung.com>\n <CGME20201017030722eucas1p107dc8d3eb2d9ef620065deba31cf08ed@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v8 16/17] test/distributor: ensure all packets\n\tare delivered", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In all distributor tests there is a chance that tests\nwill send packets to distributor with rte_distributor_process()\nbefore workers are started and requested for packets.\n\nThis patch ensures that all packets are delivered to workers\nby calling rte_distributor_process() in loop until number\nof successfully processed packets reaches required by test.\nChange is applied to every first call in test case.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\nAcked-by: David Hunt <david.hunt@intel.com>\n---\n app/test/test_distributor.c | 32 +++++++++++++++++++++++++++-----\n 1 file changed, 27 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c\nindex cfae5a1ac..a4af0a39c 100644\n--- a/app/test/test_distributor.c\n+++ b/app/test/test_distributor.c\n@@ -103,6 +103,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p)\n \tstruct rte_mbuf *returns[BURST*2];\n \tunsigned int i, count;\n \tunsigned int retries;\n+\tunsigned int processed;\n \n \tprintf(\"=== Basic distributor sanity tests ===\\n\");\n \tclear_packet_count();\n@@ -116,7 +117,11 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p)\n \tfor (i = 0; i < BURST; i++)\n \t\tbufs[i]->hash.usr = 0;\n \n-\trte_distributor_process(db, bufs, BURST);\n+\tprocessed = 0;\n+\twhile (processed < BURST)\n+\t\tprocessed += rte_distributor_process(db, &bufs[processed],\n+\t\t\tBURST - processed);\n+\n \tcount = 0;\n \tdo {\n \n@@ -304,6 +309,7 @@ sanity_test_with_mbuf_alloc(struct worker_params *wp, struct rte_mempool *p)\n \tstruct rte_distributor *d = wp->dist;\n \tunsigned i;\n \tstruct rte_mbuf *bufs[BURST];\n+\tunsigned int processed;\n \n \tprintf(\"=== Sanity test with mbuf alloc/free (%s) ===\\n\", wp->name);\n \n@@ -316,7 +322,10 @@ sanity_test_with_mbuf_alloc(struct worker_params *wp, struct rte_mempool *p)\n \t\t\tbufs[j]->hash.usr = (i+j) << 1;\n \t\t}\n \n-\t\trte_distributor_process(d, bufs, BURST);\n+\t\tprocessed = 0;\n+\t\twhile (processed < BURST)\n+\t\t\tprocessed += rte_distributor_process(d,\n+\t\t\t\t&bufs[processed], BURST - processed);\n \t}\n \n \trte_distributor_flush(d);\n@@ -410,6 +419,7 @@ sanity_test_with_worker_shutdown(struct worker_params *wp,\n \tstruct rte_mbuf *bufs2[BURST];\n \tunsigned int i;\n \tunsigned int failed = 0;\n+\tunsigned int processed = 0;\n \n \tprintf(\"=== Sanity test of worker shutdown ===\\n\");\n \n@@ -427,7 +437,10 @@ sanity_test_with_worker_shutdown(struct worker_params *wp,\n \tfor (i = 0; i < BURST; i++)\n \t\tbufs[i]->hash.usr = 1;\n \n-\trte_distributor_process(d, bufs, BURST);\n+\tprocessed = 0;\n+\twhile (processed < BURST)\n+\t\tprocessed += rte_distributor_process(d, &bufs[processed],\n+\t\t\tBURST - processed);\n \trte_distributor_flush(d);\n \n \t/* at this point, we will have processed some packets and have a full\n@@ -489,6 +502,7 @@ test_flush_with_worker_shutdown(struct worker_params *wp,\n \tstruct rte_mbuf *bufs[BURST];\n \tunsigned int i;\n \tunsigned int failed = 0;\n+\tunsigned int processed;\n \n \tprintf(\"=== Test flush fn with worker shutdown (%s) ===\\n\", wp->name);\n \n@@ -503,7 +517,10 @@ test_flush_with_worker_shutdown(struct worker_params *wp,\n \tfor (i = 0; i < BURST; i++)\n \t\tbufs[i]->hash.usr = 0;\n \n-\trte_distributor_process(d, bufs, BURST);\n+\tprocessed = 0;\n+\twhile (processed < BURST)\n+\t\tprocessed += rte_distributor_process(d, &bufs[processed],\n+\t\t\tBURST - processed);\n \t/* at this point, we will have processed some packets and have a full\n \t * backlog for the other ones at worker 0.\n \t */\n@@ -585,6 +602,7 @@ sanity_mark_test(struct worker_params *wp, struct rte_mempool *p)\n \tunsigned int i, count, id;\n \tunsigned int sorted[buf_count], seq;\n \tunsigned int failed = 0;\n+\tunsigned int processed;\n \n \tprintf(\"=== Marked packets test ===\\n\");\n \tclear_packet_count();\n@@ -615,7 +633,11 @@ sanity_mark_test(struct worker_params *wp, struct rte_mempool *p)\n \n \tcount = 0;\n \tfor (i = 0; i < buf_count/burst; i++) {\n-\t\trte_distributor_process(db, &bufs[i * burst], burst);\n+\t\tprocessed = 0;\n+\t\twhile (processed < burst)\n+\t\t\tprocessed += rte_distributor_process(db,\n+\t\t\t\t&bufs[i * burst + processed],\n+\t\t\t\tburst - processed);\n \t\tcount += rte_distributor_returned_pkts(db, &returns[count],\n \t\t\tbuf_count - count);\n \t}\n", "prefixes": [ "v8", "16/17" ] }