Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81173/?format=api
{ "id": 81173, "url": "http://patches.dpdk.org/api/patches/81173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201017030701.16134-11-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201017030701.16134-11-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201017030701.16134-11-l.wojciechow@partner.samsung.com", "date": "2020-10-17T03:06:54", "name": "[v8,10/17] distributor: align API documentation with code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a889bf8bbf3c25dd9054fb604a8b1ba3d6cd04fc", "submitter": { "id": 1628, "url": "http://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201017030701.16134-11-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 13072, "url": "http://patches.dpdk.org/api/series/13072/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13072", "date": "2020-10-17T03:06:44", "name": "fix distributor synchronization issues", "version": 8, "mbox": "http://patches.dpdk.org/series/13072/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81173/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C66D0A04DB;\n\tSat, 17 Oct 2020 05:11:02 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5308CE2E8;\n\tSat, 17 Oct 2020 05:08:09 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 9C174E2A9\n for <dev@dpdk.org>; Sat, 17 Oct 2020 05:07:39 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20201017030722euoutp01b18b697bbb8656be7145c7956f0d4f0d~_qLvhNaDF1627716277euoutp01X\n for <dev@dpdk.org>; Sat, 17 Oct 2020 03:07:22 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20201017030719eucas1p2bab72f14313b7dcd3f72c5ed93981a21~_qLtP0J2V2441224412eucas1p2-;\n Sat, 17 Oct 2020 03:07:19 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 93.42.05997.7EF5A8F5; Sat, 17\n Oct 2020 04:07:19 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20201017030718eucas1p256e1f934af12af2a6b07640c9de7a766~_qLsHGb361942819428eucas1p2x;\n Sat, 17 Oct 2020 03:07:18 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20201017030718eusmtrp24668aa7eeb9aa84b6ee2e43bc351f107~_qLsGl_rK2572125721eusmtrp2j;\n Sat, 17 Oct 2020 03:07:18 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 8B.99.06314.6EF5A8F5; Sat, 17\n Oct 2020 04:07:18 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20201017030717eusmtip122abc76b9830dfab5f100f4375c7bf66~_qLrOMbnC0424404244eusmtip1P;\n Sat, 17 Oct 2020 03:07:17 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20201017030722euoutp01b18b697bbb8656be7145c7956f0d4f0d~_qLvhNaDF1627716277euoutp01X", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1602904042;\n bh=fynvMAAU6OLk1/+zR+LOvZdNO64pUieNLjkvDKcsip8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=nPhfBget/MI+k+k7sSQvtPyxcGo2txQiYjG2Saoirht+0UHXZUbdB9DixHiTXgl4J\n sPiPZ4TOdRsgmUsRnIk3Mq/iYbT1lXOD9+/pTXaK5aGPwjjPh1XqHfNfxx5oEyXaJG\n zDjPzq1Q2q18pZeIWEX7JcyZapWCwglWkbGV9odQ=", "X-AuditID": "cbfec7f4-677ff7000000176d-c3-5f8a5fe78366", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "David Hunt <david.hunt@intel.com>, Bruce Richardson\n <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org", "Date": "Sat, 17 Oct 2020 05:06:54 +0200", "Message-Id": "<20201017030701.16134-11-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201017030701.16134-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsWy7djP87rP47viDa4807W4screom/SRyaL\n d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoLpuU1JzMstQifbsEroxbl0oK\n PkhVXHzWxNzAeE+0i5GTQ0LARGLBvolMXYxcHEICKxglHr87zAiSEBL4wijRuIERIvGZUeLt\n nrPsMB03tl9lhihazijRPE8BwgYq+tErB2KzCdhKHJn5lRXEFhEIk2hu3svSxcjBwSzgLPHk\n KxtIWFjAQ6J3SxdYCYuAqsS1Q7fBxvMKuEkcXb2aBWKVvMTqDQeYQVo5geKNx11BzpEQuMwm\n cebkNSaIGheJaf8fQp0mLPHq+BYoW0bi/875TBAN2xglrv7+yQjh7GeUuN67AqrKWuLwv99s\n EMdpSqzfpQ8RdpR4ML+JESQsIcAnceOtIEiYGcictG06M0SYV6KjTQiiWk/iac9URpi1f9Y+\n gTrfQ+LK/rdskCC8yiixfutJtgmM8rMQli1gZFzFKJ5aWpybnlpslJdarlecmFtcmpeul5yf\n u4kRGPWn/x3/soNx15+kQ4wCHIxKPLwcSzvjhVgTy4orcw8xSnAwK4nwOp09HSfEm5JYWZVa\n lB9fVJqTWnyIUZqDRUmc13jRy1ghgfTEktTs1NSC1CKYLBMHp1QD49YKCbGGDRw33r94VHI4\n Nnr97tTFVvtKnKwYJix9bLbQLU5ky0M/w4RJm8snSbBoT/imJnXJWWXht/eHrxTm+vLHPNwQ\n uuD9m1fT1ZWbvD+cXurXKfr+ZxnzvioFqeoL6lfenWSOl2RlPLwqe/nLzof76peev7UkYaHf\n K0+tOutjZ2M2m/7cVafEUpyRaKjFXFScCACVcYaH9gIAAA==", "\n H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t/xu7rP4rviDT4elre4screom/SRyaL\n d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoPZui/NKSVIWM/OISW6VoQwsj\n PUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYxbl0oKPkhVXHzWxNzAeE+0i5GTQ0LA\n ROLG9qvMXYxcHEICSxklLnztBXI4gBIyEh8uCUDUCEv8udbFBlHzkVFiass6JpAEm4CtxJGZ\n X1lB6kUEwiROrPQHCTMLuEtsWTyVGcQWFvCQ6N3SxQpiswioSlw7dJsdxOYVcJM4uno1C8R8\n eYnVGw6AreUEijced4VY1cgocXbWOpYJjHwLGBlWMYqklhbnpucWG+oVJ+YWl+al6yXn525i\n BIbhtmM/N+9gvLQx+BCjAAejEg/vhkWd8UKsiWXFlbmHGCU4mJVEeJ3Ono4T4k1JrKxKLcqP\n LyrNSS0+xGgKdNREZinR5HxgjOSVxBuaGppbWBqaG5sbm1koifN2CByMERJITyxJzU5NLUgt\n gulj4uCUamCcWh99ZsmtOr9+lWWspTpN7K+CtJ+Url3KkLWOYfW9aWv+RJrH7tspGLRmuweL\n f9kVH9u8v0VHlu9cnKV3RCtKe1PAFIG129l8XTO+5c5l/jcj+dmmditmqWsh0hKNFj43LRw1\n YxmW3u2IfP39y06DkpM75wgLlpTqqPSc/Kgtx7xJUWLhumlKLMUZiYZazEXFiQAtfrCgWQIA\n AA==" ], "X-CMS-MailID": "20201017030718eucas1p256e1f934af12af2a6b07640c9de7a766", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20201017030718eucas1p256e1f934af12af2a6b07640c9de7a766", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20201017030718eucas1p256e1f934af12af2a6b07640c9de7a766", "References": "<20201010160508.19709-1-l.wojciechow@partner.samsung.com>\n <20201017030701.16134-1-l.wojciechow@partner.samsung.com>\n <CGME20201017030718eucas1p256e1f934af12af2a6b07640c9de7a766@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v8 10/17] distributor: align API documentation\n\twith code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "After introducing burst API there were some artefacts in the\nAPI documentation from legacy single API.\nAlso the rte_distributor_poll_pkt() function return values\nmismatched the implementation.\n\nFixes: c0de0eb82e40 (\"distributor: switch over to new API\")\nCc: david.hunt@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\nAcked-by: David Hunt <david.hunt@intel.com>\n---\n lib/librte_distributor/rte_distributor.h | 23 ++++++++++++-----------\n 1 file changed, 12 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/librte_distributor/rte_distributor.h b/lib/librte_distributor/rte_distributor.h\nindex 327c0c4ab..a073e6461 100644\n--- a/lib/librte_distributor/rte_distributor.h\n+++ b/lib/librte_distributor/rte_distributor.h\n@@ -155,7 +155,7 @@ rte_distributor_clear_returns(struct rte_distributor *d);\n * @param pkts\n * The mbufs pointer array to be filled in (up to 8 packets)\n * @param oldpkt\n- * The previous packet, if any, being processed by the worker\n+ * The previous packets, if any, being processed by the worker\n * @param retcount\n * The number of packets being returned\n *\n@@ -187,15 +187,15 @@ rte_distributor_return_pkt(struct rte_distributor *d,\n \n /**\n * API called by a worker to request a new packet to process.\n- * Any previous packet given to the worker is assumed to have completed\n+ * Any previous packets given to the worker are assumed to have completed\n * processing, and may be optionally returned to the distributor via\n * the oldpkt parameter.\n- * Unlike rte_distributor_get_pkt_burst(), this function does not wait for a\n- * new packet to be provided by the distributor.\n+ * Unlike rte_distributor_get_pkt(), this function does not wait for\n+ * new packets to be provided by the distributor.\n *\n- * NOTE: after calling this function, rte_distributor_poll_pkt_burst() should\n- * be used to poll for the packet requested. The rte_distributor_get_pkt_burst()\n- * API should *not* be used to try and retrieve the new packet.\n+ * NOTE: after calling this function, rte_distributor_poll_pkt() should\n+ * be used to poll for the packets requested. The rte_distributor_get_pkt()\n+ * API should *not* be used to try and retrieve the new packets.\n *\n * @param d\n * The distributor instance to be used\n@@ -213,9 +213,9 @@ rte_distributor_request_pkt(struct rte_distributor *d,\n \t\tunsigned int count);\n \n /**\n- * API called by a worker to check for a new packet that was previously\n+ * API called by a worker to check for new packets that were previously\n * requested by a call to rte_distributor_request_pkt(). It does not wait\n- * for the new packet to be available, but returns NULL if the request has\n+ * for the new packets to be available, but returns if the request has\n * not yet been fulfilled by the distributor.\n *\n * @param d\n@@ -227,8 +227,9 @@ rte_distributor_request_pkt(struct rte_distributor *d,\n * The array of mbufs being given to the worker\n *\n * @return\n- * The number of packets being given to the worker thread, zero if no\n- * packet is yet available.\n+ * The number of packets being given to the worker thread,\n+ * -1 if no packets are yet available (burst API - RTE_DIST_ALG_BURST)\n+ * 0 if no packets are yet available (legacy single API - RTE_DIST_ALG_SINGLE)\n */\n int\n rte_distributor_poll_pkt(struct rte_distributor *d,\n", "prefixes": [ "v8", "10/17" ] }