Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8112,
    "url": "http://patches.dpdk.org/api/patches/8112/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1445981935-3559-1-git-send-email-tim.shearer@overturenetworks.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1445981935-3559-1-git-send-email-tim.shearer@overturenetworks.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1445981935-3559-1-git-send-email-tim.shearer@overturenetworks.com",
    "date": "2015-10-27T21:38:55",
    "name": "[dpdk-dev] lib/librte_ether: Prevent link status race condition when LSI enabled",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a64c41e462c9e1273b34ce0e6b79f6305a78e74a",
    "submitter": {
        "id": 334,
        "url": "http://patches.dpdk.org/api/people/334/?format=api",
        "name": "Tim Shearer",
        "email": "tim.shearer@overturenetworks.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1445981935-3559-1-git-send-email-tim.shearer@overturenetworks.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/8112/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/8112/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1853A5A65;\n\tTue, 27 Oct 2015 22:39:39 +0100 (CET)",
            "from localhost.localdomain (unknown [50.58.84.238])\n\tby dpdk.org (Postfix) with ESMTP id B0BEC5A64\n\tfor <dev@dpdk.org>; Tue, 27 Oct 2015 22:39:37 +0100 (CET)",
            "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby localhost.localdomain (8.14.3/8.14.3) with ESMTP id t9RLdZ0R003634;\n\tTue, 27 Oct 2015 17:39:35 -0400",
            "(from tim.shearer@localhost)\n\tby localhost.localdomain (8.14.3/8.14.3/Submit) id t9RLdYSd003633;\n\tTue, 27 Oct 2015 17:39:34 -0400"
        ],
        "From": "Tim Shearer <tim.shearer@overturenetworks.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 27 Oct 2015 17:38:55 -0400",
        "Message-Id": "<1445981935-3559-1-git-send-email-tim.shearer@overturenetworks.com>",
        "X-Mailer": "git-send-email 1.7.2.3",
        "In-Reply-To": "<5406727.UN0rhZ0d4I@xps13>",
        "References": "<5406727.UN0rhZ0d4I@xps13>",
        "Cc": "Tim Shearer <tim.shearer@overturenetworks.com>",
        "Subject": "[dpdk-dev] [PATCH] lib/librte_ether: Prevent link status race\n\tcondition when LSI enabled",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Calling the Ethernet driver's link_update function from rte_eth_dev_start can result in a race condition if the NIC raises the link interrupt at the same time. Depending on the interrupt handler implementation, the race can cause the it to think that it received two consecutive link up interrupts, and it exits without calling the user callback. Appears to impact E1000/IGB and virtio drivers only.\n\nSigned-off-by: Tim Shearer <tim.shearer@overturenetworks.com>\n---\n lib/librte_ether/rte_ethdev.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)",
    "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex f593f6e..a821a1f 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1300,7 +1300,7 @@ rte_eth_dev_start(uint8_t port_id)\n \n \trte_eth_dev_config_restore(port_id);\n \n-\tif (dev->data->dev_conf.intr_conf.lsc != 0) {\n+\tif (dev->data->dev_conf.intr_conf.lsc == 0) {\n \t\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->link_update, -ENOTSUP);\n \t\t(*dev->dev_ops->link_update)(dev, 0);\n \t}\n",
    "prefixes": [
        "dpdk-dev"
    ]
}