Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81112/?format=api
{ "id": 81112, "url": "http://patches.dpdk.org/api/patches/81112/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201016133259.3061153-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201016133259.3061153-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201016133259.3061153-2-thomas@monjalon.net", "date": "2020-10-16T13:32:57", "name": "[v6,1/3] ethdev: remove forcing stopped state upon close", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cf21f871e3a75966c4a5015b3f700539de049b38", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201016133259.3061153-2-thomas@monjalon.net/mbox/", "series": [ { "id": 13064, "url": "http://patches.dpdk.org/api/series/13064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13064", "date": "2020-10-16T13:32:56", "name": "cleanup ethdev close operation", "version": 6, "mbox": "http://patches.dpdk.org/series/13064/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/81112/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/81112/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D565CA04DB;\n\tFri, 16 Oct 2020 15:33:38 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 819471EE27;\n\tFri, 16 Oct 2020 15:33:21 +0200 (CEST)", "from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com\n [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 32DDD1EE21\n for <dev@dpdk.org>; Fri, 16 Oct 2020 15:33:19 +0200 (CEST)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailnew.nyi.internal (Postfix) with ESMTP id 8680F5802AA;\n Fri, 16 Oct 2020 09:33:17 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Fri, 16 Oct 2020 09:33:17 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id C731F3064674;\n Fri, 16 Oct 2020 09:33:11 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=dRj/QsKvb2ASI\n w0BTy5n/N+9iEbV01vLiP/0RNGW5xc=; b=iwrlKUSEKcepFFoIFicuEOLHZeEIW\n OHNF/y822rW4gpYWahWtLSF2cVb4R3u5ITpccznA+x+XTkV47YoSP+M5JKwAkRXG\n AaFbRCZ5PqdHXMGjoJXb6z753behvMF/JmO7qXIEyR1XKh7Z0xJfq/87o7gjIWsl\n fv1M54G6NN8zV6eWhVb4g/ZI1uQDddHO13IeyFONTjVXxiGoz5OuDpJ1Hurqnovt\n h8fuPWLwz9fOv6xABdyuDxbvZ+PgqS0844wSzV6YPaBV5fyAKyFtc8NP3nw932VV\n 2bpay0rkHYKL8qh0/wSv6kPT+6jUqGyJXzJj+VKD0oQCKKn+it4803y3Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=dRj/QsKvb2ASIw0BTy5n/N+9iEbV01vLiP/0RNGW5xc=; b=aXC7ayaj\n ibjl2xi4C0Vx8mCidkdJFyo0ggT3Zn1tb3XAfFOkqZF74TA5tfD/Aqnpf1pWz+gv\n xE4YqFtwWaorL3HPccNrwrrVLPm8Cy2ZxabYNbye1Ci+AFTKGN4MEZ5CRWQ6CsnD\n 6uDdpRyRZOSnc0VBOtrwMUGwBY9LnCctq/bu19DsQ8XYbvbbl4rB9mk9xeEARbpC\n WbX2lC02tw+HyoYSUi1rblo/QFbPogb/6DZwNaBkWaoG5ELagThJ5tA6ng0FSwjA\n Xk7o99SdtbEoe9f3bMEDbcsCSf1pD6v2BdNdJZWfBA/W2RRD/mjyYPD/cF4FzAqM\n O4V5fQ3SEZPY8w==" ], "X-ME-Sender": "<xms:HKGJX9nFa1dC6uVP_NXWb8JC2_25RPr_oNpBZjVbUk8RuemUCEz_mw>\n <xme:HKGJX41Ppub-bpHjTaB-BdBkf4LwJfT34JEoUVzUStuBXuESfy5WfgekbodsMg_6m\n qWMoanomjBdwfXZNQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrieehgdeiiecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu\n tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho\n nhdrnhgvth", "X-ME-Proxy": "<xmx:HKGJXzrlpDOgQD7gowiOvXSZfi1ppP9hfA4z-AuCLW__nDqYf6kBng>\n <xmx:HKGJX9khgwUpdZzRUsDen3sCLbAnwiR_hfXyyM9ympWb2YE7Tm2DsA>\n <xmx:HKGJX70jjscyD_3cFIGm4mHAqactJGq0a-ebm_e-6_eVfmJqB1zwRA>\n <xmx:HaGJXzN55TFKyAR2mGqBlY62IeB6jAX8XE8cEUm6KPjckJt8_M-xzw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\tandrew.rybchenko@oktetlabs.ru,\n Stephen Hemminger <stephen@networkplumber.org>,\n Andrew Rybchenko <arybchenko@solarflare.com>,\n Shepard Siegel <shepard.siegel@atomicrules.com>,\n Ed Czeck <ed.czeck@atomicrules.com>,\n John Miller <john.miller@atomicrules.com>,\n Igor Russkikh <igor.russkikh@aquantia.com>,\n Pavel Belous <pavel.belous@aquantia.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@oss.nxp.com>,\tJeff Guo <jia.guo@intel.com>,\n Haiyue Wang <haiyue.wang@intel.com>,\tMarcin Wojtas <mw@semihalf.com>,\n Michal Krawczyk <mk@semihalf.com>,\tGuy Tzalik <gtzalik@amazon.com>,\n Evgeny Schemeilin <evgenys@amazon.com>,\n Igor Chauskin <igorch@amazon.com>,\tGagandeep Singh <g.singh@nxp.com>,\n Qi Zhang <qi.z.zhang@intel.com>,\tXiao Wang <xiao.w.wang@intel.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>,\n \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Beilei Xing <beilei.xing@intel.com>,\tJingjing Wu <jingjing.wu@intel.com>,\n Qiming Yang <qiming.yang@intel.com>,\n Shijith Thotton <sthotton@marvell.com>,\n Srisivasubramanian Srinivasan <srinivasan@marvell.com>,\n Zyta Szpak <zr@semihalf.com>,\tLiron Himi <lironh@marvell.com>,\n Stephen Hemminger <sthemmin@microsoft.com>,\n \"K. Y. Srinivasan\" <kys@microsoft.com>,\n Haiyang Zhang <haiyangz@microsoft.com>,\tLong Li <longli@microsoft.com>,\n Martin Spinler <spinler@cesnet.cz>,\tAkhil Goyal <akhil.goyal@nxp.com>,\n Rasesh Mody <rmody@marvell.com>,\tShahed Shaikh <shshaikh@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Jerin Jacob <jerinj@marvell.com>,\tMaciej Czekaj <mczekaj@marvell.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>,\tZhihong Wang <zhihong.wang@intel.com>,\n Yong Wang <yongwang@vmware.com>", "Date": "Fri, 16 Oct 2020 15:32:57 +0200", "Message-Id": "<20201016133259.3061153-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201016133259.3061153-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>\n <20201016133259.3061153-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 1/3] ethdev: remove forcing stopped state upon\n\tclose", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When closing a port, it is supposed to be already stopped,\nand marked as such with \"dev_started\" state zeroed by the stop API.\n\nResetting \"dev_started\" before calling the driver close operation\nwas hiding the case of not properly stopped port being closed.\nThe flag \"dev_started\" is not changed anymore in \"rte_eth_dev_close()\".\n\nIn case the \"dev_stop\" function is called from \"dev_close\",\nbypassing \"rte_eth_dev_stop()\" API,\nthe \"dev_started\" state must be explicitly reset in the PMD\nin order to keep the same behaviour.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/ark/ark_ethdev.c | 1 +\n drivers/net/atlantic/atl_ethdev.c | 1 +\n drivers/net/dpaa/dpaa_ethdev.c | 1 +\n drivers/net/e1000/em_ethdev.c | 2 ++\n drivers/net/e1000/igb_ethdev.c | 2 ++\n drivers/net/ena/ena_ethdev.c | 1 +\n drivers/net/enetc/enetc_ethdev.c | 1 +\n drivers/net/fm10k/fm10k_ethdev.c | 1 +\n drivers/net/hinic/hinic_pmd_ethdev.c | 2 ++\n drivers/net/hns3/hns3_ethdev.c | 1 +\n drivers/net/hns3/hns3_ethdev_vf.c | 1 +\n drivers/net/i40e/i40e_ethdev.c | 1 +\n drivers/net/i40e/i40e_ethdev_vf.c | 2 +-\n drivers/net/iavf/iavf_ethdev.c | 1 +\n drivers/net/ice/ice_ethdev.c | 1 +\n drivers/net/igc/igc_ethdev.c | 1 +\n drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++\n drivers/net/kni/rte_eth_kni.c | 1 +\n drivers/net/liquidio/lio_ethdev.c | 1 +\n drivers/net/mvneta/mvneta_ethdev.c | 2 ++\n drivers/net/netvsc/hn_ethdev.c | 1 +\n drivers/net/nfb/nfb_ethdev.c | 2 ++\n drivers/net/pfe/pfe_ethdev.c | 2 ++\n drivers/net/qede/qede_ethdev.c | 1 +\n drivers/net/ring/rte_eth_ring.c | 1 +\n drivers/net/szedata2/rte_eth_szedata2.c | 2 ++\n drivers/net/thunderx/nicvf_ethdev.c | 1 +\n drivers/net/vhost/rte_eth_vhost.c | 1 +\n drivers/net/virtio/virtio_ethdev.c | 1 +\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 +\n lib/librte_ethdev/rte_ethdev.c | 1 -\n 31 files changed, 38 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex e3b1347769..f1355581f1 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -595,6 +595,7 @@ eth_ark_dev_stop(struct rte_eth_dev *dev)\n \tif (ark->started == 0)\n \t\treturn;\n \tark->started = 0;\n+\tdev->data->dev_started = 0;\n \n \t/* Stop the extension first */\n \tif (ark->user_ext.dev_stop)\ndiff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\nindex 2217511ca0..f2e48e1c11 100644\n--- a/drivers/net/atlantic/atl_ethdev.c\n+++ b/drivers/net/atlantic/atl_ethdev.c\n@@ -609,6 +609,7 @@ atl_dev_stop(struct rte_eth_dev *dev)\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \n \tPMD_INIT_FUNC_TRACE();\n+\tdev->data->dev_started = 0;\n \n \t/* disable interrupts */\n \tatl_disable_intr(hw);\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex af47c196ae..952e8f72ad 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -420,6 +420,7 @@ static void dpaa_eth_dev_stop(struct rte_eth_dev *dev)\n \tstruct fman_if *fif = dev->process_private;\n \n \tPMD_INIT_FUNC_TRACE();\n+\tdev->data->dev_started = 0;\n \n \tif (!fif->is_shared_mac)\n \t\tfman_if_disable_rx(fif);\ndiff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex d050eb478a..dd9238a616 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -717,6 +717,8 @@ eth_em_stop(struct rte_eth_dev *dev)\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \n+\tdev->data->dev_started = 0;\n+\n \teth_em_rxtx_control(dev, false);\n \tem_rxq_intr_disable(hw);\n \tem_lsc_intr_disable(hw);\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex cb3d97e2a3..f697b0e52e 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -1497,6 +1497,7 @@ eth_igb_stop(struct rte_eth_dev *dev)\n \t}\n \n \tadapter->stopped = true;\n+\tdev->data->dev_started = 0;\n }\n \n static int\n@@ -3374,6 +3375,7 @@ igbvf_dev_stop(struct rte_eth_dev *dev)\n \t}\n \n \tadapter->stopped = true;\n+\tdev->data->dev_started = 0;\n }\n \n static int\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex d32fa43837..e02d340c33 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1118,6 +1118,7 @@ static void ena_stop(struct rte_eth_dev *dev)\n \n \t++adapter->dev_stats.dev_stop;\n \tadapter->state = ENA_ADAPTER_STATE_STOPPED;\n+\tdev->data->dev_started = 0;\n }\n \n static int ena_create_io_queue(struct ena_ring *ring)\ndiff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c\nindex b3dec7e64d..dddbc89939 100644\n--- a/drivers/net/enetc/enetc_ethdev.c\n+++ b/drivers/net/enetc/enetc_ethdev.c\n@@ -54,6 +54,7 @@ enetc_dev_stop(struct rte_eth_dev *dev)\n \tuint32_t val;\n \n \tPMD_INIT_FUNC_TRACE();\n+\tdev->data->dev_started = 0;\n \t/* Disable port */\n \tval = enetc_port_rd(enetc_hw, ENETC_PMR);\n \tenetc_port_wr(enetc_hw, ENETC_PMR, val & (~ENETC_PMR_EN));\ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex c4a6fdf7f0..0c13fd5c37 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -1161,6 +1161,7 @@ fm10k_dev_stop(struct rte_eth_dev *dev)\n \tint i;\n \n \tPMD_INIT_FUNC_TRACE();\n+\tdev->data->dev_started = 0;\n \n \tif (dev->data->tx_queues)\n \t\tfor (i = 0; i < dev->data->nb_tx_queues; i++)\ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex 466c8362b9..daf8f33cf3 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -1189,6 +1189,8 @@ static void hinic_dev_stop(struct rte_eth_dev *dev)\n \tname = dev->data->name;\n \tport_id = dev->data->port_id;\n \n+\tdev->data->dev_started = 0;\n+\n \tif (!rte_bit_relaxed_test_and_clear32(HINIC_DEV_START,\n \t\t\t\t\t &nic_dev->dev_status)) {\n \t\tPMD_DRV_LOG(INFO, \"Device %s already stopped\", name);\ndiff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex ce5bae538d..8fcc0f18c5 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -4997,6 +4997,7 @@ hns3_dev_stop(struct rte_eth_dev *dev)\n \tstruct hns3_hw *hw = &hns->hw;\n \n \tPMD_INIT_FUNC_TRACE();\n+\tdev->data->dev_started = 0;\n \n \thw->adapter_state = HNS3_NIC_STOPPING;\n \thns3_set_rxtx_function(dev);\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 1a19c0e6e6..b2038395a2 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -1952,6 +1952,7 @@ hns3vf_dev_stop(struct rte_eth_dev *dev)\n \tstruct hns3_hw *hw = &hns->hw;\n \n \tPMD_INIT_FUNC_TRACE();\n+\tdev->data->dev_started = 0;\n \n \thw->adapter_state = HNS3_NIC_STOPPING;\n \thns3_set_rxtx_function(dev);\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 943cfe71dc..825de51fbb 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -2599,6 +2599,7 @@ i40e_dev_stop(struct rte_eth_dev *dev)\n \tpf->tm_conf.committed = false;\n \n \thw->adapter_stopped = 1;\n+\tdev->data->dev_started = 0;\n \n \tpf->adapter->rss_reta_updated = 0;\n }\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 4d6510d1ff..40c9745433 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -2207,7 +2207,7 @@ i40evf_dev_stop(struct rte_eth_dev *dev)\n \ti40evf_add_del_mc_addr_list(dev, vf->mc_addrs, vf->mc_addrs_num,\n \t\t\t\tFALSE);\n \thw->adapter_stopped = 1;\n-\n+\tdev->data->dev_started = 0;\n }\n \n static int\ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex f5e6e852ae..8bd2c048a1 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -562,6 +562,7 @@ iavf_dev_stop(struct rte_eth_dev *dev)\n \t\t\t\t false);\n \n \tadapter->stopped = 1;\n+\tdev->data->dev_started = 0;\n }\n \n static int\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex d8ce09d28f..1db4015c23 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2376,6 +2376,7 @@ ice_dev_stop(struct rte_eth_dev *dev)\n \t}\n \n \tpf->adapter_stopped = true;\n+\tdev->data->dev_started = 0;\n }\n \n static int\ndiff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c\nindex 7f5066df4b..73b7d20ac2 100644\n--- a/drivers/net/igc/igc_ethdev.c\n+++ b/drivers/net/igc/igc_ethdev.c\n@@ -616,6 +616,7 @@ eth_igc_stop(struct rte_eth_dev *dev)\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tstruct rte_eth_link link;\n \n+\tdev->data->dev_started = 0;\n \tadapter->stopped = 1;\n \n \t/* disable receive and transmit */\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 0b98e210e7..a45c59644b 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2917,6 +2917,7 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)\n \tadapter->rss_reta_updated = 0;\n \n \thw->adapter_stopped = true;\n+\tdev->data->dev_started = 0;\n }\n \n /*\n@@ -5418,6 +5419,7 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev)\n \n \tixgbevf_intr_disable(dev);\n \n+\tdev->data->dev_started = 0;\n \thw->adapter_stopped = 1;\n \tixgbe_stop_adapter(hw);\n \ndiff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c\nindex be747adf86..329a55039f 100644\n--- a/drivers/net/kni/rte_eth_kni.c\n+++ b/drivers/net/kni/rte_eth_kni.c\n@@ -196,6 +196,7 @@ eth_kni_dev_stop(struct rte_eth_dev *dev)\n \t}\n \n \tdev->data->dev_link.link_status = 0;\n+\tdev->data->dev_started = 0;\n }\n \n static int\ndiff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c\nindex 1a41f27198..52bcefc819 100644\n--- a/drivers/net/liquidio/lio_ethdev.c\n+++ b/drivers/net/liquidio/lio_ethdev.c\n@@ -1471,6 +1471,7 @@ lio_dev_stop(struct rte_eth_dev *eth_dev)\n \tstruct lio_device *lio_dev = LIO_DEV(eth_dev);\n \n \tlio_dev_info(lio_dev, \"Stopping port %d\\n\", eth_dev->data->port_id);\n+\teth_dev->data->dev_started = 0;\n \tlio_dev->intf_open = 0;\n \trte_mb();\n \ndiff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c\nindex 607771149a..3c0332ab4d 100644\n--- a/drivers/net/mvneta/mvneta_ethdev.c\n+++ b/drivers/net/mvneta/mvneta_ethdev.c\n@@ -413,6 +413,8 @@ mvneta_dev_stop(struct rte_eth_dev *dev)\n {\n \tstruct mvneta_priv *priv = dev->data->dev_private;\n \n+\tdev->data->dev_started = 0;\n+\n \tif (!priv->ppio)\n \t\treturn;\n \ndiff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex 5ae2d469c8..be3713dfa0 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -833,6 +833,7 @@ hn_dev_stop(struct rte_eth_dev *dev)\n \tstruct hn_data *hv = dev->data->dev_private;\n \n \tPMD_INIT_FUNC_TRACE();\n+\tdev->data->dev_started = 0;\n \n \thn_rndis_set_rxfilter(hv, 0);\n \thn_vf_stop(dev);\ndiff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c\nindex a9a8bc878d..44e57ee6c8 100644\n--- a/drivers/net/nfb/nfb_ethdev.c\n+++ b/drivers/net/nfb/nfb_ethdev.c\n@@ -158,6 +158,8 @@ nfb_eth_dev_stop(struct rte_eth_dev *dev)\n \tuint16_t nb_rx = dev->data->nb_rx_queues;\n \tuint16_t nb_tx = dev->data->nb_tx_queues;\n \n+\tdev->data->dev_started = 0;\n+\n \tfor (i = 0; i < nb_tx; i++)\n \t\tnfb_eth_tx_queue_stop(dev, i);\n \ndiff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c\nindex f0de1c8a2e..c4dd0a5f69 100644\n--- a/drivers/net/pfe/pfe_ethdev.c\n+++ b/drivers/net/pfe/pfe_ethdev.c\n@@ -378,6 +378,8 @@ pfe_eth_stop(struct rte_eth_dev *dev/*, int wake*/)\n {\n \tstruct pfe_eth_priv_s *priv = dev->data->dev_private;\n \n+\tdev->data->dev_started = 0;\n+\n \tgemac_disable(priv->EMAC_baseaddr);\n \tgpi_disable(priv->GPI_baseaddr);\n \ndiff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex 548497f3ae..88389c9e4f 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -1169,6 +1169,7 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)\n \tstruct ecore_dev *edev = QEDE_INIT_EDEV(qdev);\n \n \tPMD_INIT_FUNC_TRACE(edev);\n+\teth_dev->data->dev_started = 0;\n \n \t/* Bring the link down */\n \tqede_dev_set_link_state(eth_dev, false);\ndiff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 83c5502123..6dceab0c59 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -108,6 +108,7 @@ eth_dev_start(struct rte_eth_dev *dev)\n static void\n eth_dev_stop(struct rte_eth_dev *dev)\n {\n+\tdev->data->dev_started = 0;\n \tdev->data->dev_link.link_status = ETH_LINK_DOWN;\n }\n \ndiff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c\nindex 0eecec1e8c..c89ff16fc1 100644\n--- a/drivers/net/szedata2/rte_eth_szedata2.c\n+++ b/drivers/net/szedata2/rte_eth_szedata2.c\n@@ -1020,6 +1020,8 @@ eth_dev_stop(struct rte_eth_dev *dev)\n \tuint16_t nb_rx = dev->data->nb_rx_queues;\n \tuint16_t nb_tx = dev->data->nb_tx_queues;\n \n+\tdev->data->dev_started = 0;\n+\n \tfor (i = 0; i < nb_tx; i++)\n \t\teth_tx_queue_stop(dev, i);\n \ndiff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c\nindex cc6eb4ba24..b87e1e5640 100644\n--- a/drivers/net/thunderx/nicvf_ethdev.c\n+++ b/drivers/net/thunderx/nicvf_ethdev.c\n@@ -1766,6 +1766,7 @@ nicvf_dev_stop_cleanup(struct rte_eth_dev *dev, bool cleanup)\n \tstruct nicvf *nic = nicvf_pmd_priv(dev);\n \n \tPMD_INIT_FUNC_TRACE();\n+\tdev->data->dev_started = 0;\n \n \t/* Teardown secondary vf first */\n \tfor (i = 0; i < nic->sqs_count; i++) {\ndiff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 66efecb320..5328cfcd02 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -1158,6 +1158,7 @@ eth_dev_stop(struct rte_eth_dev *dev)\n {\n \tstruct pmd_internal *internal = dev->data->dev_private;\n \n+\tdev->data->dev_started = 0;\n \trte_atomic32_set(&internal->started, 0);\n \tupdate_queuing_status(dev);\n }\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 65eefa2a31..aa8de55fe9 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -2523,6 +2523,7 @@ virtio_dev_stop(struct rte_eth_dev *dev)\n \tstruct rte_intr_conf *intr_conf = &dev->data->dev_conf.intr_conf;\n \n \tPMD_INIT_LOG(DEBUG, \"stop\");\n+\tdev->data->dev_started = 0;\n \n \trte_spinlock_lock(&hw->state_lock);\n \tif (!hw->started)\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex fa950e1ba0..828043a65a 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -858,6 +858,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)\n \trte_eth_linkstatus_set(dev, &link);\n \n \thw->adapter_stopped = 1;\n+\tdev->data->dev_started = 0;\n }\n \n static void\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex c8ed890686..bec12f6814 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -1718,7 +1718,6 @@ rte_eth_dev_close(uint16_t port_id)\n \tdev = &rte_eth_devices[port_id];\n \n \tRTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_close);\n-\tdev->data->dev_started = 0;\n \t(*dev->dev_ops->dev_close)(dev);\n \n \trte_ethdev_trace_close(port_id);\n", "prefixes": [ "v6", "1/3" ] }